Re: [PATCH] wined3d: Display state in state_undefined

2010-02-17 Thread Henri Verbeet
On 17 February 2010 00:28, Stefan Dösinger ste...@codeweavers.com wrote: No, the pipeline part that would implement this(vertex) should set a state handler that prints a WARN for each defined but unimplemented stage. Sure, but that doesn't mean you can't catch undefined states as well. E.g.

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 2]

2010-02-17 Thread Ilya Basin
Hi! Please comment on try 2 of the patch. Will you accept it? IB Hi! This should expose this bug: IB http://bugs.winehq.org/show_bug.cgi?id=19385 ( the 'wine start' IB launcher does not open MS Office documents that have spaces in their IB path ). Although the title is misleading, many other

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 2]

2010-02-17 Thread Paul Vriens
On 02/17/2010 09:51 AM, Ilya Basin wrote: Hi! Please comment on try 2 of the patch. Will you accept it? IB +/* ensure tmpdir is in %TEMP%: GetTempPath() can succeed even if TEMP is undefined */ IB +SetEnvironmentVariableA(TEMP, fileA); I'm still not convinced you need this but I

Re: [jscript]add korean translation(resend)

2010-02-17 Thread Paul Vriens
On 02/16/2010 01:25 AM, Hwang YunSong(황윤성) wrote: I append patch file http://www.dreamwiz.com/ http://www.dreamwiz.com/ http://dreamwiz.gmarket.co.kr/redirect2.dwz?http://www.gmarket.co.kr/challenge/neo_event/today_event/today_event_main.asp?jaehuid=20891

Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers

2010-02-17 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,COM1:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM2:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM3:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM4:,2,9600,n,8,1

Re: [PATCH] wined3d: Display state in state_undefined

2010-02-17 Thread Christian Costa
Henri Verbeet a écrit : On 17 February 2010 00:28, Stefan Dösinger ste...@codeweavers.com wrote: No, the pipeline part that would implement this(vertex) should set a state handler that prints a WARN for each defined but unimplemented stage. Sure, but that doesn't mean you can't catch

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

2010-02-17 Thread Henri Verbeet
On 17 February 2010 11:47, Christian Costa titan.co...@wanadoo.fr wrote: It should use debugstr_an() in the first place. You could have a go at splitting it into separate lines if needed after that, but I can't think of a whole lot of cases where the comments are really useful.

Re: [PATCH] d3d8: Display FIXME only once in ValidatePixelShader and ValidateVertexShader

2010-02-17 Thread Henri Verbeet
On 17 February 2010 11:47, Christian Costa titan.co...@wanadoo.fr wrote: I'm not much of a fan of the whole let's disable the scary debug output idea, especially since now the function becomes invisible after the first call for people doing actual debugging, unless you run with +relay.

Re: [PATCH] d3d8: Display FIXME only once in ValidatePixelShader and ValidateVertexShader

2010-02-17 Thread Christian Costa
There are not scary but uselessly noisy. Having to much redondant messages doesn't help unless traces are enabled. I can always display the fixme when traces are enable if it suits you. Henri Verbeet a écrit : On 17 February 2010 11:47, Christian Costa titan.co...@wanadoo.fr wrote: I'm not

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

2010-02-17 Thread Christian Costa
Henri Verbeet a écrit : On 17 February 2010 11:47, Christian Costa titan.co...@wanadoo.fr wrote: It should use debugstr_an() in the first place. You could have a go at splitting it into separate lines if needed after that, but I can't think of a whole lot of cases where the comments are

Re[2]: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 2]

2010-02-17 Thread Ilya Basin
PV On 02/17/2010 09:51 AM, Ilya Basin wrote: Hi! Please comment on try 2 of the patch. Will you accept it? IB +/* ensure tmpdir is in %TEMP%: GetTempPath() can succeed even if TEMP is undefined */ IB +SetEnvironmentVariableA(TEMP, fileA); PV I'm still not convinced you need this

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

2010-02-17 Thread Henri Verbeet
On 17 February 2010 13:22, Christian Costa titan.co...@wanadoo.fr wrote: I don't see your point using debugstr_an. My code does all the needed job. It's unvalidated external data, special characters should be escaped. Wrt comments, having displayed the comments that explain the assembly code

compiling for 64bit: types and format strings

2010-02-17 Thread Joerg-Cyril.Hoehle
Hi, While I have no 64bit system, I recently submitted a compilation job to WTB and saw dozens of warnings unknown to me so far, mostly about printf format strings. The reason for the warnings is that WTB compiles in 64 bit mode, while I only know 32bit systems. Is there anything us 32bit users

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled

2010-02-17 Thread Stefan Dösinger
Wrt comments, having displayed the comments that explain the assembly code is not uninteresting at all imo. I'm tempted to keep then displayed. I have *never* used the comments to fixed a bug, or seen particularly interesting ones, for that matter. Regardless, if it works for you that's

Re: compiling for 64bit: types and format strings

2010-02-17 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: More specifically, regarding format strings, I'm unsure whether it's actually possible to find %d/%ld formats that work on both systems for all types one comes across (UINT, MMRESULT etc.) What's the receipe? All Win32 types are the same across

Re: compiling for 64bit: types and format strings

2010-02-17 Thread Michael Stefaniuc
On 02/17/2010 05:06 PM, Alexandre Julliard wrote: joerg-cyril.hoe...@t-systems.com writes: More specifically, regarding format strings, I'm unsure whether it's actually possible to find %d/%ld formats that work on both systems for all types one comes across (UINT, MMRESULT etc.) What's the

Re: Status of Patchwatcher

2010-02-17 Thread Seth Shelnutt
2010/2/16 André Hentschel n...@dawncrow.de Just some ideas by me: Dan Kegel schrieb: Seth Shelnutt wrote: I am wondering what that status of patchwatcher is? It's waiting around for somebody to have time to start it up again. It's ugly code, written in shell and perl, which

Re: Status of Patchwatcher

2010-02-17 Thread Nikolay Sivov
On 2/17/2010 23:32, Seth Shelnutt wrote: 2010/2/16 André Hentschel n...@dawncrow.de mailto:n...@dawncrow.de Just some ideas by me: Dan Kegel schrieb: Seth Shelnutt wrote: I am wondering what that status of patchwatcher is? It's waiting around for somebody to

Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers

2010-02-17 Thread Detlef Riekenberg
On Mi, 2010-02-17 at 11:15 +0100, Alexandre Julliard wrote: Detlef Riekenberg wine@web.de writes: @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,COM1:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM2:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM3:,2,9600,n,8,1

Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers

2010-02-17 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: On Mi, 2010-02-17 at 11:15 +0100, Alexandre Julliard wrote: Detlef Riekenberg wine@web.de writes: @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,COM1:,2,9600,n,8,1 HKLM,%CurrentVersionNT%\Ports,COM2:,2,9600,n,8,1