Re: msvcrt: Implement _mbctombb.

2010-02-24 Thread David Hedberg
Hi again, On Wed, Feb 24, 2010 at 8:27 AM, Maarten Lankhorst m.b.lankho...@gmail.com wrote: Hi David, David Hedberg wrote: On Wed, Feb 24, 2010 at 7:12 AM, Maarten Lankhorst m.b.lankho...@gmail.com wrote: Hi David, Hi Maarten, David Hedberg wrote: +/* Maps multibyte cp932

Re: msvcrt: Implement _mbctombb.

2010-02-24 Thread Reece Dunn
On 24 February 2010 08:51, David Hedberg david.hedb...@gmail.com wrote: Well, I should add that it only makes sense for cp 932 as far as I know, but then I'm only familiar with Japanese. More important perhaps is that I also ran some tests on Win XP and Win 7 trying to get it to return

Re: PeekMsg/MsgWaitForMultipleObjects question

2010-02-24 Thread Joerg-Cyril.Hoehle
Hi, Alexandre wrote: Message waiting functions only return for new input. You need to make sure the queue is empty before waiting. Actually, now that I believe I understand the issue, I'd rephrase it differently: The queue need not be empty (a message might have arrived 1 microsecond before the

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Alexandre Julliard
Reece Dunn mscl...@googlemail.com writes: NOTE: A check for integer overflow would be `position.low + move.low position.low`, but there are no current tests to say if integer overflow is handled (and how it is handled) here in the tests. Therefore, the simplest implementation is just to

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Reece Dunn
On 24 February 2010 11:06, Alexandre Julliard julli...@winehq.org wrote: Reece Dunn mscl...@googlemail.com writes: NOTE: A check for integer overflow would be `position.low + move.low position.low`, but there are no current tests to say if integer overflow is handled (and how it is handled)

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Reece Dunn
On 24 February 2010 11:41, Alexandre Julliard julli...@winehq.org wrote: Reece Dunn mscl...@googlemail.com writes: On 24 February 2010 11:06, Alexandre Julliard julli...@winehq.org wrote: It may be the simplest, but the right way is to add such a test and figure out the appropriate behavior.

Re: user32: Windows allows to delete a busy DC, add a test case.

2010-02-24 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@codeweavers.com writes: The test passes under XP SP3. --- dlls/gdi32/tests/dc.c | 43 ++- dlls/user32/painting.c | 17 - 2 files changed, 46 insertions(+), 14 deletions(-) You'd want to verify this with

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Alexandre Julliard
Reece Dunn mscl...@googlemail.com writes: On 24 February 2010 11:06, Alexandre Julliard julli...@winehq.org wrote: It may be the simplest, but the right way is to add such a test and figure out the appropriate behavior. Will do -- that was next on my things to do. Do I need to do that

Re: tests: WINETEST_STRICT=1 disables broken().

2010-02-24 Thread Alexandre Julliard
joerg-cyril.hoe...@t-systems.com writes: It would be valuable if, from time to time, WTB on test.winehq would run the XP/7/Vista tests with WINETEST_STRICT to assess how close Wine really is to native behaviour. I'm not 100% satisfied with WINETEST_STRICT. Beside WINETEST_INTERACTIVE, I'm

Re: user32: Use whole window rectangle for UpdateLayeredWindow

2010-02-24 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: @@ -3398,14 +3398,14 @@ BOOL WINAPI UpdateLayeredWindowIndirect( HWND hwnd, const UPDATELAYEREDWINDOWINF if (info-hdcSrc) { -HDC hdc = GetDCEx( hwnd, 0, DCX_CACHE ); +HDC hdc = GetWindowDC( hwnd ); if

Re: user32: DeleteDC() should allow to delete a DC returned by GetDC(). Take 2.

2010-02-24 Thread Alexandre Julliard
Dmitry Timoshkov dmi...@codeweavers.com writes: The test passes under XP SP3. --- dlls/gdi32/dc.c|2 +- dlls/gdi32/tests/dc.c | 107 +++- dlls/user32/painting.c |2 +- 3 files changed, 108 insertions(+), 3 deletions(-) You

Re: ntdll/tests: Add more tests for registry symlinks.

2010-02-24 Thread Paul Vriens
Hi Alexandre, This one made my Vista (Ultimate SP2) box starting to crash (the box itself not just the test). Another Vista Ultimate SP2 system doesn't show this issue. Both boxes are VMware guests btw though on different hosts. The attached patch shows the culprit but I'm not sure if the

Using assert() in wine dll code

2010-02-24 Thread Paul Chitescu
Hi! Recently I've run into excessive use of assertions in some code after a regression was caused by one of my commits. A parameter that came from the application was validated this way. The code in question is in quartz.dll but there are asserts in many other places, a short grep in the dlls

Re: [2/2] wordpad: Number of preview pages to show when unzoomed is persistent.

2010-02-24 Thread James Mckenzie
Either one or two pages may be shown in print preview when zoomed out. This value is stored in the registry in native wordpad, and preserved while opening and closing the print preview. Zooming in will only show one page, but the pages shown value must be saved because it will return to the

Re: ntdll/tests: Add more tests for registry symlinks.

2010-02-24 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: Hi Alexandre, This one made my Vista (Ultimate SP2) box starting to crash (the box itself not just the test). Another Vista Ultimate SP2 system doesn't show this issue. Both boxes are VMware guests btw though on different hosts. The attached

Bad usage of ok() macro in tests

2010-02-24 Thread Yann Droneaud
Hi, While trying to manage to fix warning about unused values, I've found a problem about some usages of ok() macro. ok() macros is defined in include/wine/test.h as: #define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok #define ok ok_(__FILE__,

Re: user32: Use whole window rectangle for UpdateLayeredWindow

2010-02-24 Thread Nikolay Sivov
On 2/24/2010 15:57, Alexandre Julliard wrote: Shouldn't you map prcDirty to window coordinates before intersecting? Of course, see try3.

Re: Bad usage of ok() macro in tests

2010-02-24 Thread Yann Droneaud
Le mercredi 24 février 2010 à 15:47 +0100, Yann Droneaud a écrit : Hi, While trying to manage to fix warning about unused values, I've found a problem about some usages of ok() macro. ok() macros is defined in include/wine/test.h as: #define ok_(file, line)

Regression? in first-run of Dragon NaturallySpeaking

2010-02-24 Thread Susan Cragin
I haven't been installing Dragon NaturallySpeaking every day for over a week, but I did try it today, and noticed that a bug has apparently crept in. Here's what happens: Installation runs fine. Then I try running the program for the first time. The microphone level test is fine, and the test

Re: [2/2] wordpad: Number of preview pages to show when unzoomed is persistent.

2010-02-24 Thread Dylan Smith
On Wed, Feb 24, 2010 at 9:04 AM, James Mckenzie jjmckenzi...@earthlink.netwrote: Either one or two pages may be shown in print preview when zoomed out. This value is stored in the registry in native wordpad, and preserved while opening and closing the print preview. Zooming in will only show

Re: shell32[2/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try4]

2010-02-24 Thread Juan Lang
Hi Mikolaj, this one was rejected due to formatting, I imagine because of C++ comments in the tests: +// Setting the same value will not set IsDirty... Would you mind fixing and resending? Thanks, --Juan

Re: Bad usage of ok() macro in tests

2010-02-24 Thread Austin English
On Wed, Feb 24, 2010 at 9:25 AM, Yann Droneaud y...@droneaud.fr wrote: Le mercredi 24 février 2010 à 15:47 +0100, Yann Droneaud a écrit : Hi, While trying to manage to fix warning about unused values, I've found a problem about some usages of ok() macro. ok() macros is defined in

Re: Regression? in first-run of Dragon NaturallySpeaking

2010-02-24 Thread Austin English
On Wed, Feb 24, 2010 at 9:48 AM, Susan Cragin susancra...@earthlink.net wrote: I haven't been installing Dragon NaturallySpeaking every day for over a week, but I did try it today, and noticed that a bug has apparently crept in. Here's what happens: Installation runs fine. Then I try running

Re: shell32[2/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try4]

2010-02-24 Thread Mikołaj Zalewski
Juan Lang pisze: Hi Mikolaj, this one was rejected due to formatting, I imagine because of C++ comments in the tests: +// Setting the same value will not set IsDirty... Would you mind fixing and resending? Thanks, --Juan Yes, I've sent the old patch with C++ comments (and a

grr. america's army 3 downloader requires .net 3.5...

2010-02-24 Thread Dan Kegel
http://www.americasarmy.com/downloads/ lists two ways to download: 1) steam, which works, after some tweaking. 2) deploy client (see http://www.aadeploy.com ), which uses .net 3.5. Bleah.

Preferred way of dll registration

2010-02-24 Thread Paul Vriens
Hi, We seem to have 2 different approaches for dll registration: 1) a regsvr.c file with all the necessary functions and registry information. 2) an inf file and some code to register/unregister the dll. The first one is the most common in our source but I can remember a comment from AJ

Re: Preferred way of dll registration

2010-02-24 Thread Jacek Caban
Hi Paul, On 2/24/10 8:59 PM, Paul Vriens wrote: Hi, We seem to have 2 different approaches for dll registration: 1) a regsvr.c file with all the necessary functions and registry information. 2) an inf file and some code to register/unregister the dll. 3) IRegistrar from atl.dll The first

Re: dns-sd dll implementation -- Needs work

2010-02-24 Thread C.W. Betts
On Feb 23, 2010, at 12:31 PM, Gert van den Berg wrote:Just a note: According to Wikipedia, Photoshop CS3 is among theapplications using Bonjour under Windows:http://blogs.adobe.com/jnack/2007/01/cs3_doesnt_inst.htmlGertAnd I read a bugzilla report that CS3 was having issues because of it.From what

Re: Preferred way of dll registration

2010-02-24 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: I think both 2) and 3) are way better than regsvr.c. It avoids code duplication and you can add much more custom registries without a single line of C (I'd call it more flexible, but it's more a better flexibility/efforts factor). IRegistrar is much

Re: gdiplus: Implement GdipImageRotateFlip.

2010-02-24 Thread Vincent Povirk
Sorry, this is wrong. It'll clobber the bitmap's palette if it originally has one. On Wed, Feb 24, 2010 at 5:10 PM, Vincent Povirk vinc...@codeweavers.com wrote:

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
Thanks for reviewing the patch Vincent! I'm reworking the test to use bitmaps but I've run into a problem. I'm using GdipGetImageGraphicsContext to convert from a bitmap to a graphic, this works fine at 16bpp and higher, but below that it returns OutOfMemory on Window (seems that this function

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Vincent Povirk
Well, that's interesting. It would be worth trying your test on Windows 7, as some other problems with paletted images were fixed in that version. You could also try creating an 8-bit device-independent bitmap using gdi32 and selecting it into a compatible DC. On Wed, Feb 24, 2010 at 6:29 PM,

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
I tried creating a DIB, then converting it to a GpBitmap via: GdipCreateBitmapFromHBITMAP and piping that into GdipGetImageGraphicsContext with the same result. I also tried selecting the DIB and sending the DC into GdipCreateFromHDC, same deal. Maybe you're talking about doing something else

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Vincent Povirk
If you send me a patch for the test, I'll run it on Windows 7. Also, there's https://winetestbot.geldorp.nl/ On Wed, Feb 24, 2010 at 8:48 PM, Justin Chevrier jchevr...@gmail.com wrote: I tried creating a DIB, then converting it to a GpBitmap via: GdipCreateBitmapFromHBITMAP and piping that

Unable to Compile Wine on MacOSX

2010-02-24 Thread James McKenzie
Interestingly enough, I have run into the 'Unable to compile' problem building the latest git on MacOSX. Maybe there is corruption in my git pull, but this started yesterday It appears that configure never fully finishes and config.status loops. James McKenzie

Re: Unable to Compile Wine on MacOSX

2010-02-24 Thread Charles Davis
James McKenzie wrote: Interestingly enough, I have run into the 'Unable to compile' problem building the latest git on MacOSX. Maybe there is corruption in my git pull, but this started yesterday It appears that configure never fully finishes and config.status loops. I don't have that