Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

2010-02-26 Thread Paul Vriens
On 02/26/2010 10:19 AM, Reece Dunn wrote: Hi, This fixes the test failures in msxml3:domdoc when IE7 or later is installed. - Reece Hi Reece, It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:

Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

2010-02-26 Thread Reece Dunn
On 26 February 2010 09:31, Paul Vriens paul.vriens.w...@gmail.com wrote: On 02/26/2010 10:19 AM, Reece Dunn wrote: Hi, This fixes the test failures in msxml3:domdoc when IE7 or later is installed. - Reece Hi Reece, It's definitely not IE7+ only. All W2K3 boxes for the latest winetest:

Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

2010-02-26 Thread Paul Vriens
On 02/26/2010 10:37 AM, Reece Dunn wrote: On 26 February 2010 09:31, Paul Vrienspaul.vriens.w...@gmail.com wrote: On 02/26/2010 10:19 AM, Reece Dunn wrote: Hi, This fixes the test failures in msxml3:domdoc when IE7 or later is installed. - Reece Hi Reece, It's definitely not IE7+ only.

Re: [PATCH 2/5] wined3d: refactoring and add Mesa AMD/ATI driver support

2010-02-26 Thread Henri Verbeet
On 26 February 2010 06:38, Paul-Andre Panon ppa...@shaw.ca wrote: +enum wined3d_gl_vendor +{ +GL_VENDOR_WINE = 0x, +GL_VENDOR_MESA = 0x0001, +GL_VENDOR_APPLE= 0x0002, +GL_VENDOR_ATI = 0x1002,

Re: [PATCH 4/5] wined3d: refactoring and add Mesa AMD/ATI driver support

2010-02-26 Thread Henri Verbeet
On 26 February 2010 06:39, Paul-Andre Panon ppa...@shaw.ca wrote: +enum wined3d_pci_device (select_card_nvidia_binary)(const struct wined3d_gl_info *gl_info, const char *gl_renderer, +unsigned int *vidmem ) +{ /* Both the GeforceFX, 6xxx and 7xxx series support

Re: [PATCH 3/5] wined3d: refactoring and add Mesa AMD/ATI driver support

2010-02-26 Thread Henri Verbeet
On 26 February 2010 06:39, Paul-Andre Panon ppa...@shaw.ca wrote: +if (gl_vendor == GL_VENDOR_ATI) return TRUE; +return FALSE; Just return gl_vendor == GL_VENDOR_ATI; should probably do. - * varyings and we subtract one in dx9 shaders its not going to hurt us because the dx9

Re: [PATCH] Implement IPersistStream

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 13:35, denver stalk wrote: --- dlls/msxml3/domdoc.c| 193 ++- dlls/msxml3/msxml_private.h |2 + dlls/msxml3/xmldoc.c|9 +- 3 files changed, 199 insertions(+), 5 deletions(-) It's

Re: [PATCH] msxml3\tests: Fix the domdoc IObjectSafety tests for IE7+.

2010-02-26 Thread Reece Dunn
On 26 February 2010 09:54, Paul Vriens paul.vriens.w...@gmail.com wrote: On 02/26/2010 10:37 AM, Reece Dunn wrote: On 26 February 2010 09:31, Paul Vrienspaul.vriens.w...@gmail.com  wrote: On 02/26/2010 10:19 AM, Reece Dunn wrote: Hi, This fixes the test failures in msxml3:domdoc when IE7

Re: msi: Remove empty directories as part of the RemoveFiles action.

2010-02-26 Thread Paul Vriens
On 02/26/2010 01:38 PM, Hans Leidekker wrote: +'`','C','e','a','t','e','F','o','l','d','e','r','`',0}; Doesn't that one miss an 'r' ? -- Cheers, Paul.

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov nsi...@codeweavers.com writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void) trace(test_query_value_ex: type set to: 0x%08x\n, type); ok(size == 0, size should have been set to 0 instead of %d\n, size); } +todo_wine ok(GetLastError()

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 16:38, Alexandre Julliard wrote: Nikolay Sivovnsi...@codeweavers.com writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void) trace(test_query_value_ex: type set to: 0x%08x\n, type); ok(size == 0, size should have been set to 0 instead of %d\n,

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov bungleh...@gmail.com writes: On 2/26/2010 16:38, Alexandre Julliard wrote: Nikolay Sivovnsi...@codeweavers.com writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void) trace(test_query_value_ex: type set to: 0x%08x\n, type); ok(size == 0,

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 19:00, Alexandre Julliard wrote: Nikolay Sivovbungleh...@gmail.com writes: On 2/26/2010 16:38, Alexandre Julliard wrote: Nikolay Sivovnsi...@codeweavers.com writes: @@ -626,15 +627,22 @@ static void test_query_value_ex(void)

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Alexandre Julliard
Nikolay Sivov bungleh...@gmail.com writes: On 2/26/2010 19:00, Alexandre Julliard wrote: I'm not saying that you should remove it, but that you should set last error to 0xdeadbeef to make it clear whether you are expecting it to be unchanged or set to 0. Right now your test could mean either.

Re: advapi32/tests: Test for last error after RegQueryValueEx

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 19:17, Alexandre Julliard wrote: Nikolay Sivovbungleh...@gmail.com writes: On 2/26/2010 19:00, Alexandre Julliard wrote: I'm not saying that you should remove it, but that you should set last error to 0xdeadbeef to make it clear whether you are expecting it to be

Re: [PATCH 1/5] wined3d: refactoring and add Mesa AMD/ATI driver support

2010-02-26 Thread James Mckenzie
Paul-Andre Panon ppa...@shaw.ca wrote: Sent: Feb 25, 2010 10:37 PM Is there any difference between the two sets of files? If so, you should mark the second set as [Try 2] If this was just a resend then it should be marked [resend] Thank you. James McKenzie

Significant performance regression

2010-02-26 Thread Erich Hoover
I was looking into updating the AppDB with more recent results for PCB Artist* and discovered that on a fresh Wine install that the application opens and creates new files incredibly slowly (it now takes 23 minutes vs. old performance of ~5 seconds). I ran a regression test and discovered that an

Re: [PATCH] msxml3/tests: Fix the domdoc IObjectSafety tests for msxml3 SP8+.

2010-02-26 Thread Nikolay Sivov
On 2/26/2010 23:20, Reece Dunn wrote: Hi, As the following table shows, the msxml3 behaviour for IObjectSafety changed from SP7 (8.70.*) to SP8 (8.80.*): fail? Windows MSXML MSXML Service Pack == NO Win2003 SP1

Re: [PATCH] msxml3/tests: Fix the domdoc IObjectSafety tests for msxml3 SP8+.

2010-02-26 Thread Reece Dunn
On 26 February 2010 20:36, Nikolay Sivov bungleh...@gmail.com wrote: On 2/26/2010 23:20, Reece Dunn wrote: Hi, As the following table shows, the msxml3 behaviour for IObjectSafety changed from SP7 (8.70.*) to SP8 (8.80.*): fail?   Windows         MSXML           MSXML Service Pack

Re: [spam-high] RE: Significant performance regression

2010-02-26 Thread Erich Hoover
On Fri, Feb 26, 2010 at 11:35 AM, Vincent Povirk vinc...@codeweavers.comwrote: Any storage-related fixme's? ... On the most recent git all I see is a single instance of: fixme:storage:StgCreateDocfile Storage share mode not implemented. Testing right after the patch in question is applied