Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name.

2010-07-19 Thread David Hedberg
On Sat, Jul 17, 2010 at 5:26 PM, Marvin test...@testbot.winehq.org wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be

Re: user32: Make sure that main window state is consistent during the tests. (Resend)

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3509 Your paranoid

Re: [PATCH 02/10] d3dx9: Add tests for D3DXCreateSphere vertex buffer description. (try 2)

2010-07-19 Thread Henri Verbeet
On 17 July 2010 21:13, Misha Koshelev misha...@gmail.com wrote: +            if (hr == D3D_OK) +            { +                todo_wine ok( vertex_buffer_description.Format == D3DFMT_VERTEXDATA, Got result %x, expected %x

Re: [PATCH 03/10] d3dx9: Test raw vertex data for D3DXCreateSphere. (try 2)

2010-07-19 Thread Henri Verbeet
On 17 July 2010 21:13, Misha Koshelev misha...@gmail.com wrote: +#include assert.h You don't use that in this patch. +    D3DXVECTOR3 test_vertex_data[8]; I think it makes sense to use the same kind of structure you're using in your implementation of D3DXCreateSphere() here. +            if

Re: [PATCH 04/10] d3dx9: Add tests for D3DXCreateBox. (try 2)

2010-07-19 Thread Henri Verbeet
Same comments apply as for the previous patches. With this being a larger dataset it makes even more sense to calculate the vertices instead of hardcoding them.

Re: [PATCH 05/10] d3dx9: Add comment to delineate vertex buffer and index buffer tests. (try 2)

2010-07-19 Thread Henri Verbeet
On 17 July 2010 21:13, Misha Koshelev misha...@gmail.com wrote: ---  dlls/d3dx9_36/tests/mesh.c |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c index cac515e..401e61e 100644 --- a/dlls/d3dx9_36/tests/mesh.c

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)

2010-07-19 Thread Henri Verbeet
On 17 July 2010 21:14, Misha Koshelev misha...@gmail.com wrote: @@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void)             IDirect3DVertexBuffer9_Release(vertex_buffer);         } +        /* Index buffer */ +        number_of_faces = box-lpVtbl-GetNumFaces(box); +        

Re: user32: Add a test showing that SetForegroundWindow() on a visible child of invisible parent does activate the parent an

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3510 Your paranoid

Re: [1/2] shlwapi/ordinal: Partially implement SHGetShellKey

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3514 Your paranoid

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (resent)

2010-07-19 Thread Alexandre Julliard
Paul Chitescu pa...@voip.null.ro writes: @@ -3323,6 +3323,26 @@ HANDLE WINAPI GetCurrentProcess(void) } /*** + * GetLogicalProcessorInformation (KERNEL32.@) + */ +BOOL WINAPI

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name.

2010-07-19 Thread Alexandre Julliard
David Hedberg david.hedb...@gmail.com writes: --- dlls/shell32/shell32.spec |2 +- dlls/shell32/shell32_main.h|5 - dlls/shell32/shlmenu.c |2 +- dlls/shell32/tests/shlfileop.c | 14 +++--- dlls/shell32/undocshell.h |4

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (resent)

2010-07-19 Thread Paul Chitescu
On Monday 19 July 2010 03:25:15 pm Alexandre Julliard wrote: Paul Chitescu pa...@voip.null.ro writes: @@ -3323,6 +3323,26 @@ HANDLE WINAPI GetCurrentProcess(void) } /*** + *

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (resent)

2010-07-19 Thread Alexandre Julliard
Paul Chitescu pa...@voip.null.ro writes: The buffer argument is not to void but the corresponding structures and constants are missing in wine includes. Would you want first to have that structures copied from MSDN? Yes, of course you need to define them. You also need to add the function

Re: [1/5] gameux: Add initial implementation of gameux.dll

2010-07-19 Thread Henri Verbeet
2010/7/18 Mariusz Pluciński vsha...@gmail.com: +static HINSTANCE hInstance; This is unused. You're mixing tabs and spaces, and have a couple of trailing spaces. Also: + * DllRegisterServer (OLEAUT32.@)

Re: [2/5] gameux: Add IClassFactory implementation

2010-07-19 Thread Henri Verbeet
2010/7/18 Mariusz Pluciński vsha...@gmail.com: +static HRESULT WINAPI gameuxcf_QueryInterface( +IClassFactory *iface, +REFIID riid, +LPVOID *ppobj ) +{ +if (IsEqualGUID(riid, IID_IUnknown) || +IsEqualGUID(riid, IID_IClassFactory)) +{ +

Re: misc: remove references to wineprefixcreate

2010-07-19 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: diff --git a/dlls/dinput8/dinput8_main.c b/dlls/dinput8/dinput8_main.c index 87dd07b..416e355 100644 --- a/dlls/dinput8/dinput8_main.c +++ b/dlls/dinput8/dinput8_main.c @@ -66,7 +66,7 @@ HRESULT WINAPI DECLSPEC_HOTPATCH

MS compatible interface to xulrunner?

2010-07-19 Thread Thomas Kaltenbrunner
Hello, I am interested to port the wine interface to the xulrunner back to mswindows to access the xulrunner via a IE compatible interface. So it would be easy to replace an embedded IE with the gecko-engine. After some code browsing I thing it will be some of the DLLs, especially mshtml and

Re: MS compatible interface to xulrunner?

2010-07-19 Thread Steven Edwards
Hi Thomas, On Mon, Jul 19, 2010 at 9:29 AM, Thomas Kaltenbrunner tkaltenbrun...@opc.de wrote: Hello, I am interested to port the wine interface to the xulrunner back to mswindows to access the xulrunner via a IE compatible interface. So it would be easy to replace an embedded IE with the

Re: MS compatible interface to xulrunner?

2010-07-19 Thread Jacek Caban
Hi Thomas, On 7/19/10 3:29 PM, Thomas Kaltenbrunner wrote: Hello, I am interested to port the wine interface to the xulrunner back to mswindows to access the xulrunner via a IE compatible interface. So it would be easy to replace an embedded IE with the gecko-engine. After some code

Re: ole32: Implement cross-process drag and drop.

2010-07-19 Thread Huw Davies
On Mon, Jul 19, 2010 at 01:58:07PM +0100, Huw Davies wrote: --- dlls/ole32/ole2.c | 199 1 files changed, 168 insertions(+), 31 deletions(-) Please use the updated version which has fixed a typo in a comment (spotted by Detlef).

Re: [2/7] shlwapi/tests: Add tests for StrStrA.

2010-07-19 Thread Detlef Riekenberg
Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in

Re: WineD3D: Only perform sRGB write correction on formats that advertise it

2010-07-19 Thread Henri Verbeet
On 19 July 2010 17:51, Stefan Dösinger ste...@codeweavers.com wrote: -if (((IWineD3DDeviceImpl *)shader-baseShader.device)-strided_streams.position_transformed) +if (device-strided_streams.position_transformed) You might as well replace both instances.

Re: [2/7] shlwapi/tests: Add tests for StrStrA.

2010-07-19 Thread Andrew Nguyen
On 07/19/2010 11:01 AM, Detlef Riekenberg wrote: Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to

Re: MS compatible interface to xulrunner?

2010-07-19 Thread Thomas Kaltenbrunner
Hello Jacek, first of all, thank you for this detailed explanation. Am 19.07.2010 17:11, schrieb Jacek Caban: Hi Thomas, On 7/19/10 3:29 PM, Thomas Kaltenbrunner wrote: Hello, I am interested to port the wine interface to the xulrunner back to mswindows to access the xulrunner via a IE

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Henri Verbeet
2010/7/19 Oldřich Jedlička oldium@seznam.cz: This fixes bug #9008. Please provide a more descriptive log message, and consider writing a test. I'm also pretty sure this will conflict with http://source.winehq.org/patches/data/63676.

Quick license question for teapot

2010-07-19 Thread Misha Koshelev
Dear All: Sorry to bother - apparently Owen Rudge has done quite a bit of basic texture work, so I will await his patches to start my texture work. As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Freeglut is freeglut is released under

Re: Quick license question for teapot

2010-07-19 Thread Henri Verbeet
On 19 July 2010 20:33, Misha Koshelev misha...@gmail.com wrote: As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Well, Wine is LGPL 2.1 or later. I didn't say you *should* look at freeglut, just that freeglut is probably safer to look

Re: Quick license question for teapot

2010-07-19 Thread Stefan Dösinger
Am 19.07.2010 um 20:33 schrieb Misha Koshelev: As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Actually, it is LGPL 2.1. I don't know the definite answer to your real question though, and I'll abstain from spreading suspicions :-)

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Stefan Dösinger
Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after it has been created. Specifically, when the app attaches the backbuffer to the frontbuffer(assuming this works, needs a test) wined3d has to be made aware of the change - there's a

Re: Quick license question for teapot

2010-07-19 Thread Misha Koshelev
On Mon, 2010-07-19 at 20:49 +0200, Stefan Dösinger wrote: Am 19.07.2010 um 20:33 schrieb Misha Koshelev: As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Actually, it is LGPL 2.1. I don't know the definite answer to your real

Re: Quick license question for teapot

2010-07-19 Thread Austin English
On Mon, Jul 19, 2010 at 1:33 PM, Misha Koshelev misha...@gmail.com wrote: Dear All: Sorry to bother - apparently Owen Rudge has done quite a bit of basic texture work, so I will await his patches to start my texture work. As for teapot, Henri recommends looking at freeglut. I know wine is:

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
Hi Henri, On Monday 19 July 2010 20:07:08 Henri Verbeet wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: This fixes bug #9008. Please provide a more descriptive log message, and consider writing a test. I'm also pretty sure this will conflict with

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Austin English
2010/7/19 Oldřich Jedlička oldium@seznam.cz: The tests will be a problem, because I don't have the Windows machine as a reference. Also `make test` fails on DirectX tests for me because of r600 driver bug... When I write CreateSurface tests (for various interfaces), is there a way for me

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
Hi Stefan, On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after it has been created. Specifically, when the app attaches the backbuffer to the frontbuffer(assuming this works, needs a

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Henri Verbeet
2010/7/19 Oldřich Jedlička oldium@seznam.cz: I will enhance the log message, no problem here. Should I consider the referenced patch as being applied (so that I should base my patch on it)? Yeah. The tests will be a problem, because I don't have the Windows machine as a reference. Also

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Oldřich Jedlička
On Monday 19 July 2010 21:41:26 Henri Verbeet wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: I will enhance the log message, no problem here. Should I consider the referenced patch as being applied (so that I should base my patch on it)? Yeah. Ok, I will update it according to

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread Stefan Dösinger
Am 19.07.2010 um 21:24 schrieb Oldřich Jedlička: Hi Stefan, On Monday 19 July 2010 20:56:35 Stefan Dösinger wrote: Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after it has been created. Specifically, when the app attaches the backbuffer

Re: ntdll: also parse asmv1 assemblies (with test)

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3533 Your paranoid

D3DXCreateTeapot

2010-07-19 Thread Ian Macfarlane
Following the question as to how to implement D3DXCreateTeapot, might I suggest making it in the form of a wine glass? Given that is unlikely to negatively affect anything (indeed the entire method does border on the ridiculous) I think it would make a nice hidden touch. Regards Ian

Re: shlwapi/tests: Fix GLE for SHFormatDateTimeA

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3535 Your paranoid

Re: [PATCH 2/2] d3dx9: Test raw vertex data for D3DXCreateSphere.

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3542 Your paranoid

Re: [PATCH 2/2] d3dx9: Test raw vertex data for D3DXCreateSphere.

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3542 Your paranoid

Re: [2/2] fusion: Implement IAssemblyNameImpl_GetDisplayName more completely

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3538 Your paranoid

Re: [PATCH 1/2] d3dx9: Add tests for D3DXCreateSphere vertex buffer description.

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3541 Your paranoid

My sincerest sincerest apologies

2010-07-19 Thread Misha Koshelev
Dear All: I am very very sorry for the spam I have created via my testbot failures. I have struggled quite a bit merging my git repository with upstream Wine today. In fact, when I generated individual patches using git-format-patch from my GitHub repository and then used git-am on the

Re: [PATCH 7/7] msvcp90/tests: Added char_traitschar::_Copy_s tests

2010-07-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3549 Your paranoid

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.

2010-07-19 Thread James McKenzie
Austin English wrote: 2010/7/19 Oldřich Jedlička oldium@seznam.cz: The tests will be a problem, because I don't have the Windows machine as a reference. Also `make test` fails on DirectX tests for me because of r600 driver bug... When I write CreateSurface tests (for various

Fyi patch submission information on wiki updated for GitHub

2010-07-19 Thread Misha Koshelev
My apologies, but it seems that only such a convoluted shell script seems to achieve the correct results for different remotes: http://wiki.winehq.org/GitWine#head-3fe70b8c0310e61d94ba30fe7edf19bd0630e1ef If anyone has a simpler solution, I can definitely update. Unfortunately, the more

Fwd: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]

2010-07-19 Thread Dan Kegel
Quoth Linus: Ask the Wine people what strange open-function-from-hell they are interested in. Full message follows. Discussion archived at e.g. http://marc.info/?l=linux-kernelm=127955270231189w=2 -- Forwarded message -- From: Linus Torvalds torva...@linux-foundation.org Date:

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-19 Thread Vitaliy Margolen
On 07/19/2010 08:59 PM, Misha Koshelev wrote: Unfortunately, the more intuitive git format-patch -k --stdout HEAD~79..HEAD~78 /tmp/patch.old does not seem to result in patches that can be properly applied onto a different (upstream) remote (see below). Works fine here. You must have had some