Re: RFC: Resolving a full screen bug

2010-08-26 Thread Alexandre Julliard
Erich Hoover ehoo...@mines.edu writes: I've been periodically revisiting a patch I've been using to fix a bug with running Borderlands under Wine at the same resolution as the desktop ( original message: http://www.winehq.org/pipermail/wine-devel/2010-May/083339.html ). Attached is an

Re: winetrick mono dot net 3.5 emmulation.

2010-08-26 Thread Hin-Tak Leung
apologies - for laziness, I picked one message with Dan Kegel and did a reply and emptied subject/body. I guess that messes up e-mail software that actually uses the invisible headers for threads. Original Message Subject: Re: winetrick mono dot net 3.5 emmulation. Date:

[PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.

2010-08-26 Thread Joerg-Cyril.Hoehle
Octavian, are you aware of bug http://bugs.winehq.org/show_bug.cgi?id=22146 and the partial patch and additional test cases there? winmm: Add MCI_INTEGER_PTR return type for DWORD_PTR return values. +#define MCI_INTEGER_PTR 13 What kind of testing did you perform on native systems to

Re: mpr: Fix Czech translation.

2010-08-26 Thread Alexandre Julliard
Amine Khaldi amine.kha...@reactos.org writes: Regards, Amine. There's no need to send a separate patch for each language, it's the same change for all. Also make sure your mailer doesn't mangle the high bit chars. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH 4/5] shell32: Add INameSpaceTreeControlEvents stub to the ExplorerBrowser control.

2010-08-26 Thread Nikolay Sivov
On 8/26/2010 14:53, David Hedberg wrote: +*ppvObject = NULL; +if(IsEqualIID(riid,IID_INameSpaceTreeControlEvents)) +{ +*ppvObject = iface; +} + Why don't you allow IUnknown here?

Re: [PATCH 1/5] shell32: Check for ICommDlgBrowser from Site and use it in the IExplorerBrowser control.

2010-08-26 Thread Nikolay Sivov
On 8/26/2010 14:53, David Hedberg wrote: --- dlls/shell32/ebrowser.c | 98 +++ dlls/shell32/tests/ebrowser.c | 174 - 2 files changed, 251 insertions(+), 21 deletions(-) diff --git a/dlls/shell32/ebrowser.c

Re: [PATCH 1/5] shell32: Check for ICommDlgBrowser from Site and use it in the IExplorerBrowser control.

2010-08-26 Thread David Hedberg
On Thu, Aug 26, 2010 at 13:15, Nikolay Sivov nsi...@codeweavers.com wrote:  On 8/26/2010 14:53, David Hedberg wrote: ---  dlls/shell32/ebrowser.c       |   98 +++  dlls/shell32/tests/ebrowser.c |  174 -  2 files changed, 251

Re: [PATCH 4/5] shell32: Add INameSpaceTreeControlEvents stub to the ExplorerBrowser control.

2010-08-26 Thread David Hedberg
On Thu, Aug 26, 2010 at 13:03, Nikolay Sivov nsi...@codeweavers.com wrote:  On 8/26/2010 14:53, David Hedberg wrote: +    *ppvObject = NULL; +    if(IsEqualIID(riid,IID_INameSpaceTreeControlEvents)) +    { +        *ppvObject = iface; +    } + Why don't you allow IUnknown here? An

Re: gameux: Use SUBLANG_NEUTRAL for language-independent resources.

2010-08-26 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4787 Your paranoid

Re: Use SUBLANG_NEUTRAL for the Gaelic resources?

2010-08-26 Thread Francois Gouget
On Tue, 24 Aug 2010, Huw Davies wrote: [...] If not it would be better to use SUBLANG_NEUTRAL instead of SUBLANG_GAELIC. For instance: I think they're different enough to warrant falling back to English rather than Irish (which is essentially what you're asking). Works for me. --

Re: gameux: Use SUBLANG_NEUTRAL for language-independent resources.

2010-08-26 Thread Francois Gouget
On Thu, 26 Aug 2010, test...@testbot.winehq.org wrote: [...] http://testbot.winehq.org/JobDetails.pl?Key=4787 Your paranoid android. === W98SE (32 bit) === === W2KPROSP4 (32 bit) === === WXPPROSP3 (32 bit) === === W2K3R2SESP2 (32 bit) === === W2K8SE (32 bit) === No test summary line

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread Stefan Dösinger
Am 25.08.2010 um 04:34 schrieb James McKenzie: Dan Kegel wrote: Would it be appropriate and useful to invite someone from Mono and Pulseaudio to attend Wineconf this year? We do have to work well with those projects, maybe that would help solve a couple current or future problems. Dan:

Re: ddraw/tests: New visual back buffer flipping tests. (try 3)

2010-08-26 Thread Stefan Dösinger
+hr = IDirectDrawSurface_AddAttachedSurface(Primary, Backbuffer); +todo_wine ok(hr == DD_OK || broken(hr == DDERR_CANNOTATTACHSURFACE), + Attaching a back buffer to a front buffer returned %08x\n, hr); The patch looks OK. Out of curiosity, which windows system returns

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread Dan Kegel
On Wed, Aug 25, 2010 at 9:51 AM, Stefan Dösinger stefandoesin...@gmx.at wrote: Would it be appropriate and useful to invite someone from Mono and Pulseaudio to attend Wineconf this year? I guess it never hurts to have people around, but we should have a set of issues to discuss with them.

Re: ddraw: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-26 Thread Stefan Dösinger
Hi, Your CreateSurface tests are missing in this patch(assuming that paulo lesgaz is your alter ego) There's a comment above the SetCooperativeLevel implementation that needs adjustments. if(cooplevel DDSCL_NORMAL) { -/* Can't coexist with fullscreen or exclusive */ -

Re: user32: Make GetMessage and PeekMessage patchable

2010-08-26 Thread Henri Verbeet
On 26 August 2010 15:51, Stefan Dösinger ste...@codeweavers.com wrote: From: =?UTF-8?q?Stefan=20D=C3=B6singer?= ste...@macbook.local Please configure git properly?

Re: [2/5] d3dcompiler: Stub D3DCompile implementation.

2010-08-26 Thread Henri Verbeet
On 26 August 2010 17:26, Matteo Bruni matteo.myst...@gmail.com wrote: Please stick to the coding style used in the rest of the d3d10 dlls (see e.g. blob.c for reference). This applies to patches 4 and 5 as well.

Re: [5/5] d3d10: Implement D3D10CompileShader, forward to d3dcompiler.

2010-08-26 Thread Henri Verbeet
On 26 August 2010 17:26, Matteo Bruni matteo.myst...@gmail.com wrote: +#define COBJMACROS #include config.h #include wine/port.h - +#include objbase.h +#include d3dcompiler.h #include d3d10_private.h You should probably just include d3dcompiler.h from d3d10_private.h.

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread Vincent Povirk
Mono: Vincent, what do you think?  Probably they're not holding us up, but maybe they'd like to see a presentation from you about status of Mono integration? Oh geez. Um. Well, they are indeed not holding us up. In all my communication with them, they've been very helpful. I don't know that

Re: : Use SUBLANG_NEUTRAL for language-independent resources

2010-08-26 Thread Greg Geldorp
From: Francois Gouget fgou...@free.fr According to past Winetest results these platforms could (should?) have it though. A full log is strange but I don't how it could be cause by my patch: gameux: start - - Usage: C:\winetest\gameux_test64.exe test_name Valid test names:

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread James Mckenzie
Vincent Povirk madewokh...@gmail.com wrote: Sent: Aug 26, 2010 9:03 AM To: Dan Kegel d...@kegel.com Cc: wine-devel@winehq.org, Stefan Dösinger stefandoesin...@gmx.at Subject: Re: Inviting Mono and pulseaudio to wineconf? Mono: Vincent, what do you think?  Probably they're not holding us up,

Re: ddraw/tests: New visual back buffer flipping tests. (try 3)

2010-08-26 Thread Oldřich Jedlička
On Wednesday 25 August 2010 12:03:50 Stefan Dösinger wrote: +hr = IDirectDrawSurface_AddAttachedSurface(Primary, Backbuffer); +todo_wine ok(hr == DD_OK || broken(hr == DDERR_CANNOTATTACHSURFACE), + Attaching a back buffer to a front buffer returned %08x\n, hr); The patch

Re: [PATCH 1/1] gameux/tests: verifying registry values created by GameExplorer (try 4)

2010-08-26 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4793 Your paranoid

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Juan Lang
Hi David, I know this was committed already, but something caught my eye that I didn't understand: +if(This-navpane.show ^ show_navpane) Is this a cute way to write if(This-navpane.show show_navpane) ? If so, why ^ rather than ? Thanks, --Juan

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Octavian Voicu
On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang juan.l...@gmail.com wrote: Hi David, I know this was committed already, but something caught my eye that I didn't understand: +    if(This-navpane.show ^ show_navpane) Is this a cute way to write if(This-navpane.show show_navpane) ? If so, why ^

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread David Hedberg
On Thu, Aug 26, 2010 at 19:32, Octavian Voicu octavian.vo...@gmail.com wrote: On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang juan.l...@gmail.com wrote: Hi David, I know this was committed already, but something caught my eye that I didn't understand: +    if(This-navpane.show ^ show_navpane) Is

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Juan Lang
^ is bitwise-XOR, so it is more like if(This-navpane.show != show_navpane), which looks to be what he intended. Ah, yes 'tis. Perhaps it's a deficiency of my brain, but when reading bit-twiddling code, I remember the bitwise operators, but when reading logical code, I tend to stick to the

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread Vincent Povirk
Also, half of the cross-compiling dependencies are available (and more up to date) on fedora under the ming32-* packages. I don't use fedora, but you're welcome to add that information for the benefit of fedora users. (Or even a reference for yourself; that's pretty much what I use the wiki

Re: [PATCH] inetcpl: Add initial applet

2010-08-26 Thread Detlef Riekenberg
Am Dienstag, den 24.08.2010, 17:56 -0700 schrieb Juan Lang: Hi Detlef, were you planning to resubmit this patch? [1] Yes, after the next release but as a more complete Patchset. Using our own inetcpl.cpl would allow us to avoid that, by exposing cryptui.CryptUICertMgr without using any

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-26 Thread Hin-Tak Leung
Vincent Povirk wrote: snipped http://wiki.winehq.org/Mono is looking good. (Think there's a Summer of Code 2011 project or two in there?) Judging by bugzilla, there don't seem to be any large projects that would help compatibility enough to be worthwhile. All the mscoree bugs only affect one

Re: user32: Make GetMessage and PeekMessage patchable

2010-08-26 Thread Stefan Dösinger
Am 26.08.2010 um 07:08 schrieb Henri Verbeet: On 26 August 2010 15:51, Stefan Dösinger ste...@codeweavers.com wrote: From: =?UTF-8?q?Stefan=20D=C3=B6singer?= ste...@macbook.local Please configure git properly? Oops, sorry. I am surprised I never sent a patch from this machine since I set it

Re: mpr: Fix translations

2010-08-26 Thread James McKenzie
Amine Khaldi wrote: [nothing] Can you please put some sort of tracking information when resubmitting a patch like [try2]. This will keep those of us who are manually tracking and applying your fixes in sync. Thank you. James McKenzie

Re: windowscodecs: support ICO files with embedded PNGs

2010-08-26 Thread Vincent Povirk
You mean you're not going to implement IWICStream::InitializeFromIStreamRegion? That's no fun. Also, that read loop is a bit silly. You might as well just lock the HGLOBAL and read into it directly. On Fri, Aug 27, 2010 at 12:30 AM, Damjan Jovanovic damjan@gmail.com wrote: Changelog: *