Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5234
Your paranoid
Vladimir Panteleev thecybersha...@gmail.com wrote:
diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c
index aac8a4d..ee99710 100644
--- a/dlls/user32/dialog.c
+++ b/dlls/user32/dialog.c
@@ -1221,6 +1221,11 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg )
Vladimir Panteleev thecybersha...@gmail.com wrote:
How does this look? I took the opportunity to remove the duplicate
GetDlgItem(hwndDlg, LOWORD(dw)).
It's better, but since BN_CLICKED is 0, there is no need to introduce wParam.
--
Dmitry.
Vladimir Panteleev thecybersha...@gmail.com wrote:
I reduced the patch to two lines (it's not visible from the context,
but there's a return TRUE lower to make up for the removed one).
Hopefully it's not too cryptic now. Thanks for the feedback.
Looks good to me.
--
Dmitry.
On 15 September 2010 01:55, Misha Koshelev misha...@gmail.com wrote:
+while (count MAX_FVF_DECL_SIZE (count == 0 ||
declaration[count-1].Stream != 0xFF))
+{
+count++;
+}
...and similarly you'd want to use D3DXGetDeclLength() here, though I
wonder if implementing
On 15 September 2010 12:22, Henri Verbeet hverb...@gmail.com wrote:
On 14 September 2010 15:44, Mike Frysinger vap...@gentoo.org wrote:
note: i couldnt find a statement of what C standard wine aims for. if
it is attempting pre-c99, then this will have to be done differently.
Marcus Meissner mar...@jet.franken.de wrote:
+ if (!unk) {
+ FIXME(hr was %d, but unk is NULL?\n, hr);
+ return E_FAIL;
+ }
IDropTarget_QueryInterface() should be fixed instead.
--
Dmitry.
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote:
Marcus Meissner mar...@jet.franken.de wrote:
+ if (!unk) {
+ FIXME(hr was %d, but unk is NULL?\n, hr);
+ return E_FAIL;
+ }
IDropTarget_QueryInterface() should be fixed instead.
The implementation is in
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote:
Marcus Meissner mar...@jet.franken.de wrote:
+ if (!unk) {
+ FIXME(hr was %d, but unk is NULL?\n, hr);
+ return E_FAIL;
+ }
IDropTarget_QueryInterface() should be fixed instead.
I am not sure where where
On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote:
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote:
Marcus Meissner mar...@jet.franken.de wrote:
+ if (!unk) {
+ FIXME(hr was %d, but unk is NULL?\n, hr);
+ return E_FAIL;
+ }
On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote:
On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote:
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote:
Marcus Meissner mar...@jet.franken.de wrote:
+ if (!unk) {
+ FIXME(hr was %d, but
On Wed, Sep 15, 2010 at 12:40:46PM +0100, Huw Davies wrote:
On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote:
On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote:
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote:
Marcus Meissner mar...@jet.franken.de
The previous version ended up as a reply to something inappropriate.
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository with
classifications of the directory content. Please take a look at it and
tell me if you think the
Hello Dmitry,
Wednesday, September 15, 2010, 10:35:20 AM, you wrote:
It would be cleaner to use an existing SendMessage() instead of
introducing a duplicate.
How does this look? I took the opportunity to remove the duplicate
GetDlgItem(hwndDlg, LOWORD(dw)).
--
Best regards,
Vladimir
Hello Dmitry,
Wednesday, September 15, 2010, 11:30:38 AM, you wrote:
It's better, but since BN_CLICKED is 0, there is no need to introduce wParam.
I reduced the patch to two lines (it's not visible from the context,
but there's a return TRUE lower to make up for the removed one).
Hopefully
Henri Verbeet wrote:
On 14 September 2010 15:44, Mike Frysinger vap...@gentoo.org wrote:
note: i couldnt find a statement of what C standard wine aims for. if
it is attempting pre-c99, then this will have to be done differently.
perhaps introducing a project-wide define like VARARRAY which
On 09/14/2010 07:20 AM, Nikolay Sivov wrote:
Properly set default value for SelectionLanguage property
Hi Nikolay,
I wondered why there were only a few testbot reports on test.winehq.org.
Looking at the reports on test.winehq.org (I have an account) shows that
the reports are filled
A STFW for wine faq gives as first result this page
http://www.winehq.org/site/docs/wine-faq/index (old version of the FAQ)
instead of
http://wiki.winehq.org/FAQ (linked from home support)
The former contains some outdated information. Shouldn't it be
suppressed (after a check to see if does
On 09/15/2010 04:11 PM, Paul Vriens wrote:
On 09/14/2010 07:20 AM, Nikolay Sivov wrote:
Properly set default value for SelectionLanguage property
Hi Nikolay,
I wondered why there were only a few testbot reports on test.winehq.org.
Looking at the reports on test.winehq.org (I have an
On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote:
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository with
classifications of the directory content.
Well, to be frank, I don't like the structure.
Doxygen is able to
On 15 September 2010 15:25, GOUJON Alexandre ale.gou...@gmail.com wrote:
On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote:
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository with
classifications of the directory
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5243
Your paranoid
On Wed, 15 Sep 2010, Max TenEyck Woodbury wrote:
The previous version ended up as a reply to something inappropriate.
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository with
classifications of the directory content.
2010/9/15 Frédéric Delanoy frederic.dela...@gmail.com:
A STFW for wine faq gives as first result this page
http://www.winehq.org/site/docs/wine-faq/index (old version of the FAQ)
instead of
http://wiki.winehq.org/FAQ (linked from home support)
The former contains some outdated
Hi all,
I used to think the arch flag is only used to say this function is only
available on win32 or
to say the same for win64.
We do that e.g. in msvcp* dlls.
So i am not sure why those stubs like
@ stub -arch=win32 function
differ so heavy from stubs like
@ stub function
The last
André Hentschel n...@dawncrow.de writes:
The last one silently gets ignored, but the one with the arch flag causes
winebuild
to put some extra assembler code into the dll.
So is this intented?
No. Try something like this:
diff --git a/tools/winebuild/parser.c b/tools/winebuild/parser.c
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5246
Your paranoid
Am 15.09.2010 19:44, schrieb Alexandre Julliard:
André Hentschel n...@dawncrow.de writes:
The last one silently gets ignored, but the one with the arch flag causes
winebuild
to put some extra assembler code into the dll.
So is this intented?
No. Try something like this:
diff --git
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5247
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5248
Your paranoid
Eric Pouech eric.pou...@orange.fr writes:
(would hang for example server_get_unix_fd when an improper handle was
passed, as no error
was returned from server call)
Fix for #24394.
The individual get_fd() functions are supposed to set the appropriate
error when returning NULL.
--
Alexandre
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5250
Your paranoid
Henri Verbeet wrote:
On 15 September 2010 01:55, Misha Koshelev misha...@gmail.com wrote:
+while (count MAX_FVF_DECL_SIZE (count == 0 ||
declaration[count-1].Stream != 0xFF))
+{
+count++;
+}
...and similarly you'd want to use D3DXGetDeclLength() here, though I
On 09/15/2010 10:25 AM, GOUJON Alexandre wrote:
On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote:
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository with
classifications of the directory content.
Well, to be frank, I
On 09/15/2010 10:56 AM, Francois Gouget wrote:
On Wed, 15 Sep 2010, Max TenEyck Woodbury wrote:
The previous version ended up as a reply to something inappropriate.
The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php
now has pages for the directories in the Wine Repository
On 09/15/2010 10:47 PM, Max TenEyck Woodbury wrote:
Actually, that was a mistake on my part. If you use:
https://sourceforge.net/apps/mediawiki/wineapi/index.php you can skip
the login.
ARGH! Make that: http://sourceforge.net/apps/mediawiki/wineapi/index.php
- Max
On 9/16/2010 02:27, Nikolay Sivov wrote:
This is supposed to fix test bot failures.
Please ignore this one.
37 matches
Mail list logo
