On 01/11/2011 02:26 AM, MP wrote:
+case PixelFormat8bppIndexed:
+setpixel_8bppIndexed(r,g,b,a,row,x,bitmap);
+break;
+case PixelFormat4bppIndexed:
+setpixel_8bppIndexed(r,g,b,a,row,x,bitmap);
+break;
+case
The 256x256 pixel icons are designed to be viewed in that size. They
can, and often do, contain a different picture to the smaller icons.
When you scale them down to a smaller size, they look bad. On MacOS
that may not matter since multiple icon sizes are written and the best
is chosen, but on
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8223
Your paranoid
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 10.01.2011 um 22:03 schrieb Emanuele Oriani:
2) Stefan, do you have any hint on where we should start optimizing the calls
of D3D - OpenGL functions?
Where do we waste time/CPU cycles?
A few bugs that are probably easier to fix(there's no
Frédéric Delanoy frederic.dela...@gmail.com writes:
---
po/fr.po |8
1 files changed, 4 insertions(+), 4 deletions(-)
There are many more issues to fix. One of the motivations for po files
is to reduce the patch churn caused by translations, so please don't
send a separate patch
2011/1/11 Alexandre Julliard julli...@winehq.org:
Frédéric Delanoy frederic.dela...@gmail.com writes:
---
po/fr.po | 8
1 files changed, 4 insertions(+), 4 deletions(-)
There are many more issues to fix. One of the motivations for po files
is to reduce the patch churn caused
Hi Andrew,
I think the test should be enhanced by checking the information about mouse
position
it seems that windows coalesce two mouse messages, but does it also occur
when the position is different (a cursory look seems to indicate that you
resend the same coordinate for mouse move)
I'd expect
Frédéric Delanoy frederic.dela...@gmail.com writes:
Actually I based on the Wine translation statistics page, which most
probably will need a overhaul since it didn't find other non
translated/correctly converted strings.
BTW while reviewing the po file, I stumbled upon a potential problem:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8233
Your paranoid
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8232
Your paranoid
On 01/11/2011 05:39 AM, Eric Pouech wrote:
Hi Andrew,
I think the test should be enhanced by checking the information about
mouse position
it seems that windows coalesce two mouse messages, but does it also
occur when the position is different (a cursory look seems to indicate
that you
On 01/11/2011 05:32 AM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
Hello,
In this patch, in function REBAR_HandleUDDrag:
+if(yOff 0)
+{
+/* Place the band above the current top row */
+DPA_DeletePtr(infoPtr-bands, iHitBand);
+hitBand-fStyle = RBBS_BREAK;
+REBAR_GetBand(infoPtr, 0)-fStyle |= RBBS_BREAK;
+
Hi Christian,
-static BYTE bin1[] = { 0x55, 0x53 };
-static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74,
+static BYTE bin1[] = { 0x55, 0x53 };
+static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74,
0x61 };
Please don't introduce whitespace-only changes,
Andrew Nguyen angu...@codeweavers.com writes:
---
dlls/advapi32/security.c | 19 ---
1 files changed, 12 insertions(+), 7 deletions(-)
It doesn't work here:
../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p
advapi32_test.exe.so security.c touch security.ok
Am 2011-01-11 16:18, schrieb Juan Lang:
Please don't introduce whitespace-only changes, it's harder to see
what your patch is doing.
Sorry, that wasn't intended.
Since these changes pass on unpatched wine, they don't demonstrate the
necessity for your patch. We need tests that show what the
I don't know, what you've doing, but for me it show errors. (on
unpatched crypt32/str.c (and patched crypt32/tests/str.c ;) ))
Ah, right. Sorry, I wasn't thinking clearly. In that case, you need
to number the patches as a series to show the dependency between them.
--Juan
Am 2011-01-11 16:58, schrieb Juan Lang:
Ah, right. Sorry, I wasn't thinking clearly. In that case, you need
to number the patches as a series to show the dependency between them.
--Juan
First the normal then the test, or reverse?
--Christian
First the normal then the test, or reverse?
Tests must pass with every commit. In general, I prefer to see tests
first, with failing tests marked todo_wine. Then the second patch,
with implementation, removes the todo_wines. In this case adding
todo_wine might be more trouble than it's worth,
Am 2011-01-11 17:03, schrieb Juan Lang:
Tests must pass with every commit. In general, I prefer to see tests
first, with failing tests marked todo_wine. Then the second patch,
with implementation, removes the todo_wines. In this case adding
todo_wine might be more trouble than it's worth,
Hi Christian,
on second thought I don't have too much to say about this, other than
style comments: take them or leave them.
+/* Only use this function internally. */
This comment isn't all that useful. You might indicate that quotes
are only needed by CertNameToStr when the string type is
Am 2011-01-11 17:11, schrieb Juan Lang:
Also, since CertRDNValueToStr doesn't need quote_string, you should
probably invert the order in which they appear in the file.
The calls or the definitions?
If the definition, should I move is_quotable_char too?
--Christian
The calls or the definitions?
If the definition, should I move is_quotable_char too?
The definitions. Yes, please.
--Juan
Hi,
the AppDB screenshot submission pages mentions this rule
- Do not upload screenshots of error messages, installers, game menus
yet it is continuously violated and e.g. screenshots of game
menus are accepted, including recently.
Is it still a useful rule?
If yes, should matching screenshots
On Tue, 11 Jan 2011 18:07:48 +0100
joerg-cyril.hoe...@t-systems.com wrote:
Hi,
the AppDB screenshot submission pages mentions this rule
- Do not upload screenshots of error messages, installers, game menus
yet it is continuously violated and e.g. screenshots of game
menus are accepted,
Am 11.01.2011 18:54, schrieb Rosanne DiMesio:
On Tue, 11 Jan 2011 18:07:48 +0100
joerg-cyril.hoe...@t-systems.com wrote:
Hi,
the AppDB screenshot submission pages mentions this rule
- Do not upload screenshots of error messages, installers, game menus
yet it is continuously violated and
Hi,
I'm quite green wrt PO files and was reviewing French PO file after
recent rc - po migration.
So I read somewhat about PO format and Wine's PO support code.
I wonder how to add message contexts, and thought it might be this way:
1. Add msgctxt myContext next to the associated msgid myMsgid
On Tue, 11 Jan 2011 19:18:17 +0100
André Hentschel n...@dawncrow.de wrote:
AppDB should represent the actual state of an App, so game menus, installer
screenshots and graphical glitches are ok IMO.
Of course the graphical glitch should have a bug filed and should not only
lay around in
Hi all,
i get
err:process:start_wineboot failed to start wineboot, err 1359
which of course leads to major problems, i tracked it down to server/process.c
in function process_poll_event it hits the line
if (event (POLLERR | POLLHUP)) kill_process( process, 0 )
because event is 0x19
what can
2011/1/11 André Hentschel n...@dawncrow.de:
Hi all,
i get
err:process:start_wineboot failed to start wineboot, err 1359
which of course leads to major problems, i tracked it down to server/process.c
in function process_poll_event it hits the line
if (event (POLLERR | POLLHUP))
André Hentschel n...@dawncrow.de writes:
Hi all,
i get
err:process:start_wineboot failed to start wineboot, err 1359
which of course leads to major problems, i tracked it down to server/process.c
in function process_poll_event it hits the line
if (event (POLLERR | POLLHUP))
Hi Stefan,
thanks very much.
Do we think any of the below points will be prioritized by wine devs?
Btw, I don't have windows (moral choice) so can't test it (I have a
virtualized winxp but can't run the game in VirtualBox).
Cheers,
On 11/01/11 10:38, Stefan Dösinger wrote:
-BEGIN PGP
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8249
Your paranoid
2011/1/11 Austin English austinengl...@gmail.com:
2011/1/11 André Hentschel n...@dawncrow.de:
Hi all,
i get
err:process:start_wineboot failed to start wineboot, err 1359
which of course leads to major problems, i tracked it down to
server/process.c
in function process_poll_event it hits
On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote:
Date: Wed, 12 Jan 2011 00:46:26 +0300
Subject: [PATCH 1/1] Partially implement _set_abort_behavior
Please search the patches queue first.
try 2: http://source.winehq.org/patches/data/70231
try 1: http://source.winehq.org/patches/data/70136
On Jan 11, 2011, at 2:41 AM, Damjan Jovanovic wrote:
The 256x256 pixel icons are designed to be viewed in that size. They
can, and often do, contain a different picture to the smaller icons.
When you scale them down to a smaller size, they look bad. On MacOS
that may not matter since multiple
36 matches
Mail list logo
