Re: [3/8] msi: Handle escaped double quotes in command line parsing.

2011-06-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12111 Your paranoid

Re: [PATCH 1/3] d3dx9/line: Implemented ID3DXLine's Draw method.

2011-06-30 Thread Matteo Bruni
2011/6/30 Charles Welton charles...@gmail.com: --- +memcpy(buffer_mem, vertices, size); There is no need to allocate and write into your own buffer then copy the content, you can directly write into the vertex buffer. A more important issue: MSDN says The ID3DXLine interface

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Michael Mc Donnell
I've implemented ConvertPointRepsToAdjacency, but would like some help to make it's worst case performance bearable. In init_edge_face_map I initialize an array of edge_face structs, and in find_adjacent_face I do a linear search through that array. I would like to replace the array with a hash

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Henri Verbeet
On 30 June 2011 14:49, Michael Mc Donnell mich...@mcdonnell.dk wrote: In init_edge_face_map I initialize an array of edge_face structs, and in find_adjacent_face I do a linear search through that array. I would like to replace the array with a hash table, so that the search time becomes

Re: GSoC: dinput8 Action Mapping

2011-06-30 Thread Marcus Meissner
On Thu, Jun 30, 2011 at 02:56:08AM -0300, Lucas Zawacki wrote: Hey guys, how are you doing? I've got some patches for you. The first is a refactoring of the BuildActionMap implementations for keyboard and mouse. I think with 'semantic_to_obj_id' the mapping is pretty much correct for

Re: wine bug 27600

2011-06-30 Thread wylda
Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was covered by several other

Re: wine bug 27600

2011-06-30 Thread Vincas Miliūnas
On 06/30/2011 05:31 PM, wy...@volny.cz wrote: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit

Re: wine bug 27600

2011-06-30 Thread Austin English
2011/6/30 wy...@volny.cz: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many regression tests, reverse reg.testing, found faulty commit even though it was

Re: wine bug 27600

2011-06-30 Thread Matijn Woudt
On Thu, Jun 30, 2011 at 4:52 PM, Austin English austinengl...@gmail.com wrote: 2011/6/30  wy...@volny.cz: Ok, try with a modified header: OK no problem, i will try later today. But i don't think it's a bug in applicability of those patches. I began with wine testing 2 years ago and did many

Re: wine bug 27600

2011-06-30 Thread Vincas Miliūnas
On 06/30/2011 05:57 PM, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is already modified and works for me too. I would

Re: wine bug 27600

2011-06-30 Thread Vincas Miliūnas
On 06/30/2011 06:07 PM, Vincas Miliūnas wrote: On 06/30/2011 05:57 PM, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is

Re: dxgi.idl: Added DXGI_SWAP_CHAIN_FLAG enum declaration and DXGI_MWA_* flags

2011-06-30 Thread Henri Verbeet
On 30 June 2011 17:34, Jacek Caban ja...@codeweavers.com wrote: +cpp_quote(#define DXGI_MWA_NO_WINDOW_CHANGES 0x1) +cpp_quote(#define DXGI_MWA_NO_ALT_ENTER 0x2) +cpp_quote(#define DXGI_MWA_NO_PRINT_SCREEN0x4) +cpp_quote(#define DXGI_MWA_VALID 0x7) Aren't those usually

Re: GSoC: dinput8 Action Mapping

2011-06-30 Thread Lucas Zawacki
Ouch, that is a leftover from an older try at this code. So much for double checking the patches... 2011/6/30 Marcus Meissner meiss...@suse.de: On Thu, Jun 30, 2011 at 02:56:08AM -0300, Lucas Zawacki wrote: Hey guys, how are you doing? I've got some patches for you. The first is a refactoring

Re: dxgi.idl: Added DXGI_SWAP_CHAIN_FLAG enum declaration and DXGI_MWA_* flags

2011-06-30 Thread Jacek Caban
On 06/30/11 17:44, Henri Verbeet wrote: On 30 June 2011 17:34, Jacek Caban ja...@codeweavers.com wrote: +cpp_quote(#define DXGI_MWA_NO_WINDOW_CHANGES 0x1) +cpp_quote(#define DXGI_MWA_NO_ALT_ENTER 0x2) +cpp_quote(#define DXGI_MWA_NO_PRINT_SCREEN0x4) +cpp_quote(#define DXGI_MWA_VALID

Re: [PATCH 1/4] shell32: Implement erasing and restoring items from the trash

2011-06-30 Thread Juan Lang
Hi Jay, +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){ Nit: the brace should be on its own line. +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; +HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; These two functions are never called in this patch, so you're

Re: gcc 4.6 warning report

2011-06-30 Thread Juan Lang
David is right, the address is not stored as a pointer but as a DWORD in place of the chars. Like this: gethostbyname(winehq.org): wrong: (DWORD) host-h_addr_list[i] = 0x00cbd1c8 = 200.209.203.0 right: *(DWORD*) host-h_addr_list[i] = 0x86192ed1 = 209.46.25.134 Patch welcome ;) --Juan

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Michael Mc Donnell
On Thu, Jun 30, 2011 at 4:10 PM, Henri Verbeet hverb...@gmail.com wrote: On 30 June 2011 14:49, Michael Mc Donnell mich...@mcdonnell.dk wrote: In init_edge_face_map I initialize an array of edge_face structs, and in find_adjacent_face I do a linear search through that array. I would like to

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

2011-06-30 Thread Detlef Riekenberg
On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote: How can we force tests to use VT_UI4? It's not JScript builtin type, you need to extend tests host object for that. Sorry, no clue. Which host object? +/* 0x7fff is 2147483647 is INT_MAX */ +tmp = 2147483647*-1; 0x... is

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

2011-06-30 Thread Jacek Caban
On 06/28/11 15:47, Detlef Riekenberg wrote: On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote: How can we force tests to use VT_UI4? It's not JScript builtin type, you need to extend tests host object for that. Sorry, no clue. Which host object Global host object for tests. See how

Re: wine bug 27600

2011-06-30 Thread Austin English
On Thu, Jun 30, 2011 at 07:57, wy...@volny.cz wrote: $ cd wine-git $ wget http://dl.dropbox.com/u/6901628/raw.patch $ patch -p1 raw.patch $ ./tools/make_requests $ ./configure $ make works here: Thanks Austin for testing, but this raw.patch is already modified and works for me too.

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Michael Mc Donnell
On Thu, Jun 30, 2011 at 6:42 PM, Michael Mc Donnell mich...@mcdonnell.dk wrote: On Thu, Jun 30, 2011 at 4:10 PM, Henri Verbeet hverb...@gmail.com wrote: On 30 June 2011 14:49, Michael Mc Donnell mich...@mcdonnell.dk wrote: In init_edge_face_map I initialize an array of edge_face structs, and

Re: wine bug 27600

2011-06-30 Thread wylda
Otherwise WINE compilation with 32bit gcc gets broken (not yet 100% confirmed, see the discussion with Wylda on wine-devel mailing list). Small patch to test for the issue - http://dl.dropbox.com/u/6901628/bug_test.patch Now i can confirm for sure, that simple testcase bug_test.patch

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Stefan Dösinger
On Thursday 30 June 2011 21:50:45 Michael Mc Donnell wrote: I have another question about my test. I've basically copied all the test data from my ConvertAdjacencyToPointReps test, and then just inverted the conditions. Should I merge the two tests, put the test data in a separate function, or

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-06-30 Thread Dylan Smith
On Thu, Jun 30, 2011 at 3:50 PM, Michael Mc Donnell mich...@mcdonnell.dk wrote: I've implemented the look-up scheme that you described. +if (!point_reps) /* Indentity point reps */ +{ +memset(adjacency, -1, 3 * num_faces * sizeof(*adjacency)); +return D3D_OK; +}