Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling

2012-05-16 Thread Nikolay Sivov
On 5/15/2012 22:53, Daniel Jelinski wrote: +PostMessageA(hTree, WM_RBUTTONUP, 0, (LPARAM)0x10001); +/* this sequence should NOT send WM_CONTEXTMENU */ +SendMessageA(hTree, WM_RBUTTONDOWN, 2, (LPARAM)0x10001); Please use defined names for wParam and a MAKELPARAM macro to make a

Re: mstask/tests: Add missing call to the tested function.

2012-05-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18417 Your paranoid

Re: mstask: Actually run a test and fix the expected behaviour.

2012-05-16 Thread Michael Stefaniuc
On 05/16/2012 11:32 AM, Marvin wrote: While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: mstask: Actually run a test and fix the expected behaviour.

2012-05-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid

Re: mstask: Actually run a test and fix the expected behaviour.

2012-05-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18419 Your paranoid

AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Good day to all subscribers of this list, I've got a small decision trouble I have to deal with as an AppDB maintainer. I know that years ago there had been discussion on this topic, but I want to bring this once on a surface once again so we would

Re: [PATCH 2/2] ieframe: Added GetExternal tests

2012-05-16 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18421 Your paranoid

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Rosanne DiMesio
On Wed, 16 May 2012 14:14:30 +0400 Alexey Loukianov mooro...@mail.ru wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 How should we treat situations like that? From user PoV it's Platinum - app is working out of the box. From real side of things - it is Gold, as native dll override

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 16.05.2012 17:34, Rosanne DiMesio wrote: If the user didn't have to manually do anything, it should be rated platinum. Is it the official position that have been agreed throughout Wine devteam and AppDB maintainers? Because years ago I've been at

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.

2012-05-16 Thread Vincent Povirk
Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data.

re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Dan Kegel
16.05.2012 17:34, Rosanne DiMesio wrote: If the user didn't have to manually do anything, it should be rated platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required,

Re: [2/2] gdiplus: Implement GdipImageGetFrameCount and GdipImageSelectActiveFrame.

2012-05-16 Thread Dmitry Timoshkov
Vincent Povirk madewokh...@gmail.com wrote: Er, you removed the FIXME, but GdipImageSelectActiveFrame is still a stub? You're not changing the image data. GdipImageSelectActiveFrame is now implemented, the bug is elsewhere. Anyway, I'm working on that area on both sides of the problem. --

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 16.05.2012 17:56, Dan Kegel wrote: 16.05.2012 17:34, Rosanne DiMesio wrote: If the user didn't have to manually do anything, it should be rated platinum. Agreed. OK then, it would simplify my work significantly - now it wouldn't be required

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Rosanne DiMesio
On Wed, 16 May 2012 17:48:28 +0400 Alexey Loukianov mooro...@mail.ru wrote: Is it the official position that have been agreed throughout Wine devteam and AppDB maintainers? It's the way I've been handling things as an admin. It's really the only way I can handle it, because as an admin, I

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 16.05.2012 18:08, Rosanne DiMesio wrote: Is it the official position that have been agreed throughout Wine devteam and AppDB maintainers? It's the way I've been handling things as an admin. It's really the only way I can handle it... Thanks

RE: localspl: Only store the file part of the filenames in the registry

2012-05-16 Thread Detlef Riekenberg
Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and

Re: localspl: Only store the file part of the filenames in the registry

2012-05-16 Thread Huw Davies
On 16/05/2012 17:22, Detlef Riekenberg wrote: We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. No, the current code copies the entire contents of the DRIVER_INFO struct's filename entries - this

Re: [1/2] wmvcore: Add stub for WMCreateSyncReader (try 2) (resend)

2012-05-16 Thread Nikolay Sivov
On 5/16/2012 19:46, André Hentschel wrote: + wmsdkidl.idl \ + wmsbuffer.idl \ This is supposed to be sorted. Also I think you need to add .gitignore changes as well.

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Austin English
On Wed, May 16, 2012 at 5:14 AM, Alexey Loukianov mooro...@mail.ru wrote: With the recent release of Diablo III we're are at the same spot: game installer auto-installs vcrun2008 redist as a part of installation process, so end-user experience is like this game works out of a box. Problem is

Re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Rosanne DiMesio
On Wed, 16 May 2012 12:56:00 -0500 Austin English austinengl...@gmail.com wrote: Copying an install form windows is unsupported and should be treated as such. The AppDB form has the option No, but has a workaround on the dropdown list for Installs? IMO, copying a Windows install is a valid

kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions

2012-05-16 Thread Alex Henrie
Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it. -Alex

re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Dan Kegel
Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or third party software. Really? IMHO they should still be silver. Patches are very

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions

2012-05-16 Thread Alexandre Julliard
Alex Henrie alexhenri...@gmail.com writes: Hello, This patch was marked committed yesterday--thank you for accepting it!--but it still isn't showing up in Git. Maybe it was accidentally skipped? It needs to be committed before I can submit the UTF-7 implementation I wrote that builds on it.

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Rosanne DiMesio
On Wed, 16 May 2012 13:16:11 -0700 Dan Kegel d...@kegel.com wrote: Really? IMHO they should still be silver. Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. AppDB test reports are supposed to reflect the

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Alexey Loukianov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 17.05.2012 00:16, Dan Kegel wrote: Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Dan Kegel
On Wed, May 16, 2012 at 1:50 PM, Alexey Loukianov mooro...@mail.ru wrote: Really?  IMHO they should still be silver.  Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. - Dan I thinks that using silver won't be correct

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Rosanne DiMesio
On Wed, 16 May 2012 15:55:37 -0500 Austin English austinengl...@gmail.com wrote: Some of the more popular patches are available in PPA's, and I'd be willing to bet that many of the less tech savvy users are running Ubuntu and can figure out how to add a PPA. They're also available through

Installing 64 bit visual c++ 2010 runtime?

2012-05-16 Thread Dan Kegel
I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650EFEBA5/vcredist_x64.exe wine vcredist_x64 and that installs fine... but