Re: [1/4] msi/tests: Use only uppercase characters for the PID_REVNUMBER property.

2012-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18972 Your paranoid

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).

2012-06-12 Thread Jacek Caban
Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: Real Name: Erich Hoover Description: This patch adds the ability in HTML Help to convert HTML encoded characters (e.g. ecirc;) into the Unicode character equivalent. This feature is needed by the table of contents and the index

Re: [PATCH] ntprint: Do not fail when the spooler service was stopped

2012-06-12 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: @@ -88,22 +92,25 @@ static void test_PSetupDestroyMonitorInfo(VOID) { HANDLE mi; - SetLastError(0xdeadbeef); pPSetupDestroyMonitorInfo(NULL); -/* lasterror is returned */ -trace(returned with %u\n, GetLastError()); +

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Nikolay Sivov
On 6/12/2012 11:52, Ulrik Dickow wrote: Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . +static void test_namespaces_change(int doc_version) +{ +IXMLDOMDocument *doc; +IXMLDOMElement *elem; +IXMLDOMNode *node; + +VARIANT var; +HRESULT hr; +BSTR str;

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-06-12 Thread Nikolay Sivov
On 6/12/2012 11:55, Ulrik Dickow wrote: Patch 2 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . +/* Emit appropriate fixme or warning in case of unsupported or invalid namespace. + * The W3C spec would like us to exit earlier for attempts to redefine the namespace for +

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Nikolay Sivov
On 6/12/2012 13:33, Ulrik Dickow wrote: Den 12-06-2012 13:11, Nikolay Sivov skrev: On 6/12/2012 11:52, Ulrik Dickow wrote: +/* create on element and try to alter namespace after that */ +doc = (doc_version == 0 ? + create_document(IID_IXMLDOMDocument) : +

Re: configure.ac: Get the needed libs from cups-config (for OpenBSD)

2012-06-12 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: Inspired by Matias Colli, see bug 17896. I made sure it doesn't hurt on other OS and send it because it doesn't seem he will do it and it's a oneliner. It doesn't work for me on Debian testing, not without manually creating symlinks for the libs that

Re: Command line parameters

2012-06-12 Thread John Emmas
On 7 Jun 2012, at 21:43, Hin-Tak Leung wrote: --- On Thu, 7/6/12, Dan Kegel d...@kegel.com wrote: Example: wine notepad /home/dank/foo.txt This fails because notepad treats / as the beginning of an option (see http://source.winehq.org/source/programs/notepad/main.c#L616 ). So, no,

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-06-12 Thread Ulrik Dickow
Den 12-06-2012 13:21, Nikolay Sivov skrev: On 6/12/2012 11:55, Ulrik Dickow wrote: Patch 2 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . +/* Emit appropriate fixme or warning in case of unsupported or invalid namespace. + * The W3C spec would like us to exit earlier

Re: [PATCH 4/5] wined3d: Set undefined vertex attributes to 0.0.

2012-06-12 Thread Stefan Dösinger
Am Dienstag, 12. Juni 2012, 17:03:49 schrieb Henri Verbeet: +if (state-vertex_shader-reg_maps.input_registers (1 i)) +GL_EXTCALL(glVertexAttrib4fARB(i, 0.0f, 0.0f, 0.0f, 0.0f)); Does an application need this? Afair Windows drivers have implementation- specific

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).

2012-06-12 Thread Erich E. Hoover
On Tue, Jun 12, 2012 at 2:07 AM, Jacek Caban ja...@codeweavers.com wrote: ... You didn't address most of my comments. Feel free to ask for clarifications if something was not clear enough. I'm really sorry about that, for some reason gmail hid them as a quote. Erich

Re: Command line parameters

2012-06-12 Thread Hin-Tak Leung
--- On Tue, 12/6/12, John Emmas john...@tiscali.co.uk wrote: snipped Thanks Hin-Tak and Dan but I think we're at crossed purposes now.  Remember that my original question had nothing to do with paths.  I simply used paths as a convenient example.  My question is about command-line parameters

Re: Command line parameters

2012-06-12 Thread Ben Peddell
On 12/06/2012 8:59 PM, John Emmas wrote: Thanks Hin-Tak and Dan but I think we're at crossed purposes now. Remember that my original question had nothing to do with paths. I simply used paths as a convenient example. My question is about command-line parameters and (more specifically) about

Re: d3dx9_36: D3DXQuaternionLn computes as if the norm of the input is 1

2012-06-12 Thread Matteo Bruni
2012/6/12 Nozomi Kodama nozomi.kod...@yahoo.com: +if ( (pq-w = 1.0f) || (pq-w == -1.0f) ) I think the second comparison should be '=', if you want to avoid getting NaNs.

Re: po: Update Russian translation (try 3) (resend)

2012-06-12 Thread Francois Gouget
msgid KeyID= -msgstr Код ключа= +msgstr Код ключа: [...] msgid Other Name= -msgstr Другое имя= +msgstr Альтернативное имя: and many more like this. Why did you not fix this? Replacing the equal sign with a colon looks wrong to me but then I don't speak Russian. Still I have not seen

Misspelt Portuguese in msvcrt

2012-06-12 Thread Francois Gouget
Is there a reason why Portuguese is misspelt in these two places? diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 97b82ec..b26a9c8 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -85,7 +85,7 @@ static const char * const _country_synonyms[] = german-swiss,

Re: [08/11] windowscodecs: Add tests for more types of IFD fields.

2012-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18986 Your paranoid

Re: [09/11] windowscodecs: Add support for IFD_UNDEFINED field type.

2012-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18987 Your paranoid

Re: [11/11] windowscodecs: Implement GetMetadataFormat.

2012-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18989 Your paranoid