Re: [PATCH 1/4] wined3d: 1x1 texures have a power of two size

2013-04-14 Thread Henri Verbeet
On 13 April 2013 16:37, Stefan Dösinger ste...@codeweavers.com wrote: @@ -965,8 +965,6 @@ static HRESULT texture_init(struct wined3d_texture *texture, UINT width, UINT he !(format-id == WINED3DFMT_P8_UINT gl_info-supported[EXT_PALETTED_TEXTURE]

RE: request.h: size of unnamed array is negative

2013-04-14 Thread Hugh McMaster
On Apr 13, 2013, Charles Davis wrote: STOP! You should modify server/protocol.def instead. The file you changed is automatically generated from protocol.def, along with a bunch of other files needed to make the server interface magic work. On Apr 13, 2013, at 7:39 AM, Hugh McMaster wrote:

Re: d3dx9: Implement D3DXSHMultilpy5

2013-04-14 Thread Rico Schüller
On 13.04.2013 01:55, Nozomi Kodama wrote: Is there a problem with this patch? http://source.winehq.org/patches/data/9 Nozomi Looks pretty much ok, but isn't there a way to reduce the size a bit? Just see the dirty hack which is attached. D3DXSHMultiply6 will add a lot of lines too...

zlib's gzseek return gabbage and fails intermittently under wine.

2013-04-14 Thread Hin-Tak Leung
I am porting an application which uses zlib's gzseek quite extensively to do pseudo- random access of the content of large gz'ed files, in the same manner of some's use of posix's lseek. On small test data, it works correctly on wine. (identical result as linux). On production data - a large

Re: zlib's gzseek return gabbage and fails intermittently under wine.

2013-04-14 Thread Vincent Povirk
considering how old zlib is and the vast number of windows application which uses zlib Given how many people duplicate the effort to package zlib, the fact that they're rarely updated, and the sort of problems gnulib exists to work around, it would not surprise me if your particular zlib

Re: zlib's gzseek return gabbage and fails intermittently under wine.

2013-04-14 Thread Hin-Tak Leung
-- On Sun, Apr 14, 2013 22:34 BST Vincent Povirk wrote: considering how old zlib is and the vast number of windows application which uses zlib Given how many people duplicate the effort to package zlib, the fact that they're rarely updated, and the sort of

Re: zlib's gzseek return gabbage and fails intermittently under wine.

2013-04-14 Thread Vincent Povirk
Well, here's a simple thing you can check: Does your zlib dll link to _lseek or _lseeki64? The first one uses a 32-bit offset. Wine's implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) expands that to 64-bit and later truncates the file offset to 32-bit. For a file larger

Re: zlib's gzseek return gabbage and fails intermittently under wine.

2013-04-14 Thread Hin-Tak Leung
--- On Sun, 14/4/13, Vincent Povirk madewokh...@gmail.com wrote: Well, here's a simple thing you can check: Does your zlib dll link to _lseek or _lseeki64? The first one uses a 32-bit offset. Wine's implementation (http://source.winehq.org/source/dlls/msvcrt/file.c#L1090) expands that to

Re: d3dx9: Implement D3DXSHMultilpy5

2013-04-14 Thread Nozomi Kodama
Hello thanks for the review. I don't think that calling defines is the way to go. Indeed, I tested my patch and yours. Yours is about 12% slower than mine in my computer. And now, we try to take care of efficiency of this dll. So, it is not the time  to increase latency. I used 10 digits

RE: request.h: size of unnamed array is negative

2013-04-14 Thread Hugh McMaster
On Apr 14, 7:20 PM, Hugh McMaster wrote: Is there something special/different that needs to be done for the server to accept input? I can answer this myself now. SERVER_START_REQ { req-spi_workarea.right = workarea.right; req-spi_workarea.bottom = workarea.bottom; wine_server_call(