[PATCH 1/2] Added test to show EnableWindow cause wrong ReleaseCapture (try 3)

2013-05-09 Thread Guo Jian
Hello everyone, This is my first patch to wine, which has been submitting since the last day. Please help that what is the safe way sending patches that makes sure the patch is not corrupt by my mail client? Is it the most correct way to attach a path with .txt suffix rather than past

Re: [PATCH] user32: initialize just the members we need (Coverity)

2013-05-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25499 Your paranoid

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow

2013-05-09 Thread Qian Hong
Hello Guo Jian, On Fri, May 10, 2013 at 1:36 AM, Guo Jian orz...@gmail.com wrote: A window should not lose mouse capture even when it's parent window is disabled. Did you forget to remove the todo_wine introduced in [patch 1/2]? Thanks for your work on it. -- Regards, Qian Hong

Re: [PATCH 2/2] Fixing ReleaseCapture of child window bug in EnableWindow

2013-05-09 Thread Guo Jian
Did you forget to remove the todo_wine introduced in [patch 1/2]? I forgot it. I'll have more check and resend once latter. And I get a little more to understand what todo_wine means this time. Thank you. -- Regards, Guo Jian

Re: [PATCH 2/3] oleaut32: COM cleanup for ITypeInfo object

2013-05-09 Thread Andrew Eikum
Looks like I missed replacing the ITypeInfo casts with impl_from calls, e.g.: static HRESULT WINAPI ITypeInfo_fnGetTypeComp( ITypeInfo2 *iface, ITypeComp * *ppTComp) { ITypeInfoImpl *This = (ITypeInfoImpl *)iface; You can apply these, or wait until I amend them to fix that,

Re: [PATCH] mscms: Use lcms2, when available

2013-05-09 Thread wine . dev
Hi Hans. lcms2 was released on 8. May 2010 lcms v1 is on the way to be phased out in the newest distribution versions. Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for replacing lcms v1. There is no reason, that Wine is the last app, which

Re: [1/3] winex11: Select for XRandR screen change events and implement an event handler.

2013-05-09 Thread Ken Thomases
On May 9, 2013, at 1:36 PM, Alexandre Julliard wrote: Handling external resizes should be done in the desktop process, and most likely involves the wineserver too. It certainly won't be an easy task. Hmm. Then that probably means I messed it up in the Mac driver, since what I did didn't

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.

2013-05-09 Thread Alexandre Julliard
Christian Costa titan.co...@gmail.com writes: @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) { ID3DXFileImpl *object; HRESULT ret; +const char expand_string[] = expand_string; TRACE((%p)\n, d3dxfile); @@ -701,6 +702,11 @@ HRESULT WINAPI

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.

2013-05-09 Thread Christian Costa
Le 09/05/2013 22:05, Alexandre Julliard a écrit : Christian Costa titan.co...@gmail.com writes: @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) { ID3DXFileImpl *object; HRESULT ret; +const char expand_string[] = expand_string; TRACE((%p)\n,

d3dx9: Avoid useless computations in D3DXMatrixTransformation2D

2013-05-09 Thread Nozomi Kodama
Hello What happens for this patch? Nozomi

Re: [PATCH] mscms: Use lcms2, when available

2013-05-09 Thread Hans Leidekker
On Thu, 2013-05-09 at 18:56 +0200, wine@web.de wrote: Hi Hans. lcms2 was released on 8. May 2010 lcms v1 is on the way to be phased out in the newest distribution versions. Are there any distributions that have released without v1? I don't know, but Ubuntu has a bug for

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.

2013-05-09 Thread Christian Costa
Le 09/05/2013 22:15, Christian Costa a écrit : Le 09/05/2013 22:05, Alexandre Julliard a écrit : Christian Costa titan.co...@gmail.com writes: @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) { ID3DXFileImpl *object; HRESULT ret; +const char

Patches 96113 96114

2013-05-09 Thread Christian Costa
Hi, Is there anything wrong with these patches? http://source.winehq.org/patches/data/96113 http://source.winehq.org/patches/data/96114 Christian

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.

2013-05-09 Thread Alexandre Julliard
Christian Costa titan.co...@gmail.com writes: Le 09/05/2013 22:05, Alexandre Julliard a écrit : Christian Costa titan.co...@gmail.com writes: @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) { ID3DXFileImpl *object; HRESULT ret; +const char

Re: [PATCH] d3dxof: Add string expansion extension to d3dxof and make d3dx9_36 use it.

2013-05-09 Thread Christian Costa
Le 09/05/2013 23:01, Alexandre Julliard a écrit : Christian Costa titan.co...@gmail.com writes: Le 09/05/2013 22:05, Alexandre Julliard a écrit : Christian Costa titan.co...@gmail.com writes: @@ -677,6 +677,7 @@ HRESULT WINAPI D3DXFileCreate(ID3DXFile **d3dxfile) { ID3DXFileImpl

winemac.drv: add fullscreen mode support for Mac OS X 10.7+

2013-05-09 Thread Kevin Eaves
Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. The fullscreen button appears if a main window is resizable. Basically this feature is the zoom button on crack. It doesn't actually

Re: [PATCH] mscms: Use lcms2, when available

2013-05-09 Thread Detlef Riekenberg
Hi Hans. For most apps it will be a matter of adding a configure check for lcms2 and then recompiling. This is not the case for Wine as you have pointed out. - cmsCreateLabProfile was renamed to cmsCreateLab2Profile cmsvirt.c (1.19: 570) / (2.4: 458 and 497) - cmsSetLogErrorHandler can be

Ask for mentor - Improve Bcrypt

2013-05-09 Thread Kaiyi Zhang
Hello everyone: I am Kaiyi Zhang,A Computer Science and Engineering student from china, my major is information security. My nickname in #winehackers is KaiyiZhang. I heard the GSOC and I'm very interested in this, wine is tempting to me.I have submitted my wine application before the deadline of

Re: Ask for mentor - Improve Bcrypt

2013-05-09 Thread Juan Lang
Hi Kaiyi Zhang, (or is Zhang Kaiyi?) I think there's a little misconception in your proposal. Bcrypt the algorithm is not the same as the BCrypt functions in crypt32. I believe that Microsoft redesigned their CryptoAPI and more or less renamed their functions BCrypt*. I don't believe they have

Re: Re: Ask for mentor - Improve Bcrypt

2013-05-09 Thread Marek Chmiel
Hey Kaiyi Zhang, Welcome to wine dev! If you decide to move forward with this(DH and DSS), I wish to share with you all that I have finished up to now. Using a few things from RSAENH I have all the related algorithms functioning. Also using LibTomCrypt I have partially implemented DSA but you

Re: winemac.drv: add fullscreen mode support for Mac OS X 10.7+

2013-05-09 Thread Ken Thomases
Hi, On May 9, 2013, at 5:48 PM, Kevin Eaves wrote: Attached patch is a proof-of-concept for the fullscreen APIs provided in OS X 10.7+, which allows applications to enter fullscreen in a separate desktop space. Thanks for this. It's quite interesting. The fullscreen button appears if a

Re: Ask for mentor - Improve Bcrypt

2013-05-09 Thread Kaiyi Zhang
Hi Juan Lang, Thank you for your suggestion, I accept that there is a misconception with my Bcrypt proposal. There are more things i need to learn, So I expect to join the wine project. people here are very enthusiastic, your suggestion and Markek Chmiel's generous. the DH and DSS is strange to