Seems reasonable, but could you put together some tests to show this?
Andrew
On Sat, Sep 28, 2013 at 10:41:15AM +0200, Maarten Lankhorst wrote:
diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c
index 40f1702..0fe300c 100644
--- a/dlls/dsound/capture.c
+++ b/dlls/dsound/capture.c
@@
Looks good for the most part. Some thoughts below...
On Sat, Aug 17, 2013 at 01:25:00PM +0200, Frédéric Delanoy wrote:
+ The implementation can be found in a number of directories:
+ itemizedlist
+listitem
+ para
+filename
On Tue, Aug 20, 2013 at 05:57:34AM +0200, Fabrice Bauzac wrote:
Hello,
This patch intends to fix the bug:
http://bugs.winehq.org/show_bug.cgi?id=34305
The bug: basically, when there is no sound device and the user tries
to WOD_Open() the WAVE_MAPPER pseudodevice, the code calls read_map()
On Tue, Aug 20, 2013 at 07:06:13PM +0200, Fabrice Bauzac wrote:
+if (g_inmmdevices_count == 0) {
+return MMSYSERR_BADDEVICEID;
+}
Looks like the indentation is bad here.
Also please submit the patch to wine-patches. Patches aren't picked up
from wine-devel.
Thanks for the
On Wed, Jul 10, 2013 at 10:42:05AM +0200, Francois Gouget wrote:
We don't have a MIDI Mapper configuration applet so don't tell the user to
use it.
---
Or if we do, how does one get to it? I did not find anything in
winecfg.exe, nor in control.exe (the Control Panel).
It comes basically from the ERole enumeration in MMDevAPI:
http://msdn.microsoft.com/en-us/library/windows/desktop/dd370842%28v=vs.85%29.aspx
The Input device maps to eConsole (and eMultimedia, which is
identical to eConsole in modern Windows). The Voice input device
maps to eCommunications.
So,
On Wed, May 29, 2013 at 01:10:56PM +0200, Maarten Lankhorst wrote:
NAK.
+ HeapFree(GetProcessHeap(), 0, device-primary_pwfx);
+ device-primary_pwfx = DSOUND_CopyFormat(passed_fmt);
Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning
On Tue, May 21, 2013 at 02:52:55PM -0600, Charles Davis wrote:
You can't return the straight HRESULT from ForceFeedback here. That's because
the codes in the FACILITY_NULL range on Mac get their values from the 16-bit
COM runtime (cf. CoreFoundation/CFPlugInCOM.h). You must turn them into
that, too.
Whichever.
Andrew
On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote:
---
dlls/oleaut32/typelib.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
index e62fa84..c6d2189 100644
-dwFlags WHDR_PREPARED))
+return MMSYSERR_NOERROR;
Note the subtle difference in behaviour between wave and midi headers...
IMHO calling named winmm:xyz functions should be equivalent to dispatching
MM* messages
I forgot to add that I'm still surprised that Andrew Eikum could
On Mon, Feb 11, 2013 at 02:06:42PM +0100, Maarten Lankhorst wrote:
Fixes bug #32312, apparently some programs depend on the format it specifies
being returned.
Just set wBitsPerSample, nSamplesPerSec and nChannels to make those
applications happy.
The patch seems fine, but can you add
On Tue, Jan 22, 2013 at 11:15:59AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Andrew Eikum was in favour of this too and since implemented winmm
device notification upon change. Remember the December thread:
http://www.winehq.org/pipermail/wine-devel/2012-December/098114.html
Yeah, I
On Tue, Jan 15, 2013 at 06:51:59PM +0100, Maarten Lankhorst wrote:
Op 07-01-13 16:58, Andrew Eikum schreef:
This patch breaks the sound on Zaxxon[1] on both CoreAudio and ALSA
without PulseAudio. I didn't test OSS. It skips around on the ship's
shooting noises. I've attached good and bad
On Mon, Jan 14, 2013 at 03:32:40PM -0500, Dimi Paun wrote:
OK, we might be onto something. I've wrote a script
to determine the deleted pages: 20162.
Should I just go ahead and nuke those?
Probably, yes.
One common way for spammers to abuse wikis is to intentionally get the
pages deleted,
On Tue, Jan 08, 2013 at 05:40:44PM +0400, Nikolay Sivov wrote:
On 1/8/2013 16:34, Tatyana Fokina wrote:
+
+memset(a, 'a', sizeof(a));
+SetLastError(NO_ERROR);
+ret = CompareStringA(lcid, 0, a, sizeof(a), a, sizeof(a));
+error = GetLastError();
+ok(!error ret ==
On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote:
+ if(!maxq){
+ /* nothing to do! */
+ LeaveCriticalSection(device-mixlock);
+ return;
}
This was removed in 8ba4090fc304993. It breaks starting the device in
some situations
On Mon, Dec 31, 2012 at 07:03:31PM +0100, Maarten Lankhorst wrote:
Op 31-12-12 17:59, Andrew Eikum schreef:
On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote:
+ if(!maxq){
+ /* nothing to do! */
+ LeaveCriticalSection(device-mixlock);
+ return
On Thu, Dec 20, 2012 at 02:03:06PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
what's up with this patch?
I wrote:
SetEvent is one of those calls with a high probability that the
Linux scheduler will switch to another thread, e.g. the one receiving
the event. As the critical section is
Looks good to me, no problems with any of the drivers. I think it'd be
good to get it in on Monday, as release day is tomorrow, but that's
not my call.
Andrew
On Wed, Dec 19, 2012 at 10:30:04AM +0100, Maarten Lankhorst wrote:
Use a thread instead of a timer for greater precision.
Changes
On Sun, Dec 16, 2012 at 11:56:46AM +0100, sebastien chev wrote:
It seems that no matter what the Windows side program choose for
DirectSoundCreate, the DSound subsystem initialize itself with the higher
spec sound available (for example 48Khz Float32, or 48kHz Int16 if no
Float32 available).
On Mon, Dec 17, 2012 at 05:01:29PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Furthermore, this patch eases integration of my lock-less code, which
I'll not release for now, by cleanly separating read and write
pointers during playback and capture. No more adding of two volatile
entities
On Tue, Dec 18, 2012 at 08:08:03PM +0100, sebastien chev wrote:
Thank you for the tips. I will look at these.
I guess you're probably also thinking about the mix buffer in dsound
itself. That does always mix to float, and there isn't a way to change
it right now.
What are you planning to use
On Tue, Dec 11, 2012 at 04:46:34PM +0100, Henri Verbeet wrote:
On 11 December 2012 16:05, joerg-cyril.hoe...@t-systems.com wrote:
My first reaction is that this is a good idea. We've had some
discussion about device enumeration before. The final conclusion was
it's basically impossible to do
On Wed, Dec 12, 2012 at 04:23:52PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Max TenEyck Woodbury objected:
Replacing the ability to use a drop box in the app to select the audio
device with a 'regedit' session is not an improvement.
My proposal intentionaly was silent about GUI changes,
On Wed, Dec 12, 2012 at 03:57:40PM +0100, Henri Verbeet wrote:
On 12 December 2012 15:28, Andrew Eikum aei...@codeweavers.com wrote:
It's tricky because ALSA and PulseAudio have different theories about
where device selection should occur -- in the application or in the
audio mixer
On Wed, Dec 12, 2012 at 04:45:11PM +0100, Henri Verbeet wrote:
On 12 December 2012 16:31, Andrew Eikum aei...@codeweavers.com wrote:
Even ignoring the Pulse case, we don't have an acceptable enumeration
API.
Yes, I know. I just don't think it would be unreasonable to try to
work with ALSA
On Wed, Dec 05, 2012 at 11:59:01AM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
+br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
SND_ALIAS_ID|SND_SYNC);
+ok(br == TRUE || br == FALSE, sndPlaySound gave strange return:
%u\n, br);
This kind
On Wed, Dec 05, 2012 at 11:06:48PM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
+br = sndPlaySoundA((LPCSTR)SND_ALIAS_SYSTEMASTERISK,
SND_ALIAS_ID|SND_SYNC);
+ok(br == TRUE || br == FALSE, sndPlaySound gave strange return:
%u\n, br
On Wed, Dec 05, 2012 at 11:21:39PM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
The call is only supposed to return TRUE or FALSE, so I guess it's
checking that the return value isn't 3 or something. Not very useful,
sure, but it looked odd to just have a series
On Thu, Dec 06, 2012 at 12:14:53AM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
The call is only supposed to return TRUE or FALSE, so I guess it's
checking that the return value isn't 3 or something. Not very useful,
sure, but it looked odd to just have
On Mon, Dec 03, 2012 at 02:59:07PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
BTW, I still believe that mixing and resampling would find their best place
in mmdevapi, not DSound.
Perhaps, but that's provably not what Windows does. Given a format with:
dwChannelMask =
On Thu, Nov 29, 2012 at 12:50:20PM +0100, Maarten Lankhorst wrote:
Op 21-11-12 19:16, Maarten Lankhorst schreef:
Signed-off-by: Maarten Lankhorst maarten.lankho...@ubuntu.com
Bump, anything wrong with this patch?
Been spending my Wine time on Bug 32297 this week. I'll take a look
at this
Yeah, that fixes the problem. This patch looks good to me now.
Andrew
On Fri, Nov 16, 2012 at 08:35:51PM +0100, Maarten Lankhorst wrote:
I promised I would never touch it, but then I wanted to play skyrim
V2: Limit channels to 2 in primary if not in writeprimary mode
V3: Split off
Seems reasonable to me. Thanks for working on this old code.
On Thu, Nov 08, 2012 at 10:51:08AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Ran tests on all four backends and everything seems okay.
On Fri, Oct 26, 2012 at 10:31:33AM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
Hi,
With the previous code in place, we can derive sane values for
WAVE_FORMAT_QUERY.
Given the amount of work and side-effects that the audio
On Fri, Oct 19, 2012 at 11:33:22PM +0200, Maarten Lankhorst wrote:
Op 19-10-12 15:40, Andrew Eikum schreef:
I'm a big fan of error checking (or at least reporting), so these
unchecked calls make me nervous. They'll probably never fail, but if
they do, I think they should fail loudly.
Erm
On Sat, Oct 20, 2012 at 12:03:55AM +0200, Maarten Lankhorst wrote:
Op 19-10-12 15:54, Andrew Eikum schreef:
Mostly good cleanup in this one. Some thoughts below...
On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound
On Sat, Oct 20, 2012 at 12:13:08AM +0200, Maarten Lankhorst wrote:
Hey,
Op 19-10-12 15:29, Andrew Eikum schreef:
Patches 1 and 2 in this series look fine.
I have a series of patches similar to this one in my dsound
multichannel branch. This patch seems to do too much at once.
When
Patches 1 and 2 in this series look fine.
I have a series of patches similar to this one in my dsound
multichannel branch. This patch seems to do too much at once.
When I did this cleanup, I split it up into four patches:
1) Allocate the device format in the Device struct
2) Load the default
I like it. Before I can give a sign-off, I need to run it through my
usual battery of tests on all the platforms. I'll do that after patch
3 gets figured out.
Some thoughts below...
On Tue, Oct 16, 2012 at 02:06:28PM +0200, Maarten Lankhorst wrote:
+ /* ALSA is retarded, add a
Mostly good cleanup in this one. Some thoughts below...
On Tue, Oct 16, 2012 at 02:06:29PM +0200, Maarten Lankhorst wrote:
diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h
index feef787..7817b88 100644
--- a/dlls/dsound/dsound_private.h
+++
Be nice if you could split this up and squash it into the previous
patches.
Andrew
On Tue, Oct 16, 2012 at 02:06:30PM +0200, Maarten Lankhorst wrote:
From: Maarten Lankhorst maarten.lankho...@canonical.com
No longer influence anything, so zap them.
---
dlls/dsound/dsound_main.c| 17
That's a lot of patches! In the future, please try to send no more
than about 5 at a time, until each batch is committed. That's much
easier to review.
I reviewed the first 12, and will do the rest after those are
committed. Just reading the patches, I didn't notice any
show-stoppers. Overall
On Sun, Sep 23, 2012 at 08:44:59PM +0200, Christian Costa wrote:
@@ -66,6 +68,11 @@ static void test_dmusic(void)
return;
}
+hr = IDirectMusic_GetMasterClock(dmusic, guid_clock, clock);
+ok(hr == S_OK, IDirectMusic_GetMasterClock returned: %x\n, hr);
+ok(clock !=
On Thu, Jul 26, 2012 at 07:32:10PM +0100, Joel Holdsworth wrote:
Does anyone have any suggestions for how I can better investigate
these issues? And what is the status of ActiveX in wine - is it
likely to work at all?
I've done only a little work with ActiveX in Wine, but I think it
works in
be sure to test your
changes before sending :)
Thanks,
Andrew
On Fri, Jul 13, 2012 at 11:10 PM, Andrew Eikum aei...@codeweavers.com wrote:
Thanks, Donny. Nice work overall. Some comments below.
On Fri, Jul 13, 2012 at 05:57:48PM +1000, Donny Yang wrote:
This patch makes dsound
Thanks, Donny. Nice work overall. Some comments below.
On Fri, Jul 13, 2012 at 05:57:48PM +1000, Donny Yang wrote:
This patch makes dsound automatically get the output format when a
output device is initialised and also allows up to 8 output channels
to be used for ALSA and PulseAudio. Using
On Fri, Jul 13, 2012 at 05:59:03PM +1000, Donny Yang wrote:
- if (channels != 1 channels != 2)
- {
- FIXME(There is no support for %u channels\n, channels);
+ if (dsb-device-pwfx-wFormatTag == WAVE_FORMAT_EXTENSIBLE)
+ channelMask =
On Fri, Jun 15, 2012 at 06:23:57PM -0700, Chris Robinson wrote:
The update_size is only relevant if mmdevapi updates in period-sized chunks.
If it doesn't, you can just remove it and the rounding. The tlength should be
kept updated using pa_stream_set_buffer_attr_callback, in case the server
On Mon, Jun 18, 2012 at 08:49:55AM -0700, Chris Robinson wrote:
On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote:
Yeah, I experimented with ADJUST_LATENCY, as it seems to be the trick
to getting lower latencies. Then we have to maintain our own buffer,
which is why I switched to using
On Thu, Jun 14, 2012 at 02:46:37PM -0500, Rosanne DiMesio wrote:
A forum user reported this behavior with the Ubuntu 12.04 wine1.5 packages,
which are apparently only available with the winepulse patch.
http://forum.winehq.org/viewtopic.php?t=15747
Thanks. I was able to reproduce it on a
On Wed, Jun 13, 2012 at 09:02:33PM +0200, Alexandre Julliard wrote:
Andrew Eikum aei...@codeweavers.com writes:
The configure.ac changes and parts of the driver itself were written by
Maarten Lankhorst.
It doesn't work here, it's apparently using the driver even though
PulseAudio
Thanks Alexander. Thoughts below...
On Sat, May 19, 2012 at 09:09:35PM +0600, Alexander E. Patrakov wrote:
There are two ways to implement a high-performance resampler, and I
have prepared (conflicting, pick no more than one) patches for both:
1 (this patch): Use a shorter FIR with the
On Tue, May 15, 2012 at 12:33:25PM +0600, Alexander E. Patrakov wrote:
Andrew Eikum wrote:
-
- TRACE(Mixed at least %d from all buffers\n, minlen);
- return minlen;
Hi. You have removed the message that could say Mixed at least 0 from
all buffers (as seen, e.g., for Armored Fist 3
On Thu, May 10, 2012 at 07:52:58AM +0200, Christian Costa wrote:
static HRESULT read_from_stream(IStream *stream, void *data, ULONG size)
{
-ULONG readed;
+ULONG read;
HRESULT hr;
-hr = IStream_Read(stream, data, size, readed);
+hr = IStream_Read(stream, data,
On Thu, May 10, 2012 at 08:29:25AM +0200, Alexandre Julliard wrote:
Andrew Eikum aei...@codeweavers.com writes:
---
This fixes bug 30631, introduced by
31291cdc6ccc4c172ccf86f383c6a90f31a50ba1.
In addition to safely exiting on process exit, we do much more
thorough cleanup
Hi Adam,
On Sun, Apr 15, 2012 at 12:06:14AM +0100, adam smith wrote:
I've been trying to get WASAPI audio output working for our app as
Directsound output was very glitchy post the new audio stack.
Sorry to hear that. We do have a large sequence of patches just about
ready to go into Wine
On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote:
Also initialize a may be uninitialized value the compiler sees.
Not sure what this means. *num is initialized at the beginning of
alsa_enum_devices, which is always called from GetEndpointIDs. Seems
like a Coverity oversight. I'd
On Mon, Apr 16, 2012 at 11:53:00AM -0500, Andrew Eikum wrote:
On Mon, Apr 16, 2012 at 09:09:58AM +0200, Marcus Meissner wrote:
Also initialize a may be uninitialized value the compiler sees.
Of course I quoted the wrong section of your mail :)
Not sure what this means. *num
Thanks. GCC 4.7 must be smart enough to detect the same if-conditions,
and doesn't issue a warning for me. Kind of impressive, actually.
Andrew
On Fri, Apr 06, 2012 at 02:49:38AM +0200, Józef Kucia wrote:
---
dlls/winealsa.drv/mmdevdrv.c |2 +-
1 files changed, 1 insertions(+), 1
On Fri, Mar 30, 2012 at 12:33:51PM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
Andrew Eikum asked Christian Costa:
Just to be clear, which native do you mean? Does this match Windows
7's dmusic behavior, or something else? I've been trying to target
Windows 7's behavior in the new audio
It would be nice to see some tests for this. For example, how does
this IDirectSound reference relate to the one created by
IDirectMusicPerformance::InitAudio()?
On Thu, Mar 29, 2012 at 08:53:10AM +0200, Christian Costa wrote:
---
dlls/dmusic/dmusic.c | 27
On Thu, Mar 29, 2012 at 08:52:45AM +0200, Christian Costa wrote:
+midiOutGetDevCapsW(index - 1, caps, sizeof(caps));
...
+CoCreateInstance(CLSID_DirectMusicSynth, NULL,
CLSCTX_INPROC_SERVER, IID_IDirectMusicSynth8, (void**)synth);
+
Just to be clear, which native do you mean? Does this match Windows
7's dmusic behavior, or something else? I've been trying to target
Windows 7's behavior in the new audio design.
Also...
On Thu, Mar 29, 2012 at 08:53:52AM +0200, Christian Costa wrote:
- obj-pCaps.dwEffectFlags =
On Thu, Mar 29, 2012 at 04:18:20PM +0200, Christian Costa wrote:
It's the original code. I decided to keep it in this patch and add error
checking in the patch that comes just after.
I can merge them but I prefer to do things incrementally as much as
possible.
Ah, sure enough. I missed that
I'm working on Bug 14559 and have run into an interesting UI problem.
In WinMM, there are three classes of devices: waveIn, waveOut, and
mixer. Windows 7's WinMM implementation provides one mixer for each
waveIn and waveOut device. The WCHAR caps.szPname[32] field for the
matching mixer and
Vitaliy,
On Sun, Mar 11, 2012 at 10:15:40AM -0600, Vitaliy Margolen wrote:
That information simply does not belong on Wine wiki. It talks about
making Jack work as Alsa sound device. This has nothing to do with
Wine in particular. Especially that he posted the link to an
external wiki which
On Mon, Mar 12, 2012 at 07:18:39AM -0600, Vitaliy Margolen wrote:
On 03/12/2012 06:11 AM, Andrew Eikum wrote:
On Sun, Mar 11, 2012 at 10:15:40AM -0600, Vitaliy Margolen wrote:
That information simply does not belong on Wine wiki. It talks about
making Jack work as Alsa sound device. This has
On Mon, Feb 27, 2012 at 11:41:56PM +0100, Maarten Lankhorst wrote:
W.r.t. to 1.4.0, I believe the following path should be taken:
- Write CreateTimerQueue tests to verify whether native behaves like:
a) sleep(Xms) /* what Wine does now */ or
b) sleep(Xms - elapsed) /* what
On Tue, Feb 28, 2012 at 08:24:37AM -0600, Andrew Eikum wrote:
I'm investigating native TimerQueue's operation now. If it turns out
that TimerQueue isn't sufficient, we'll probably just switch over to
using poll() like winmm's timer stuff does.
And, not too surprisingly, TimerQueue isn't
This patch looks sane and fixes the tests on my machine, but causes no
changes to dsound capture behavior in Audacity. I don't have much of
an opinion on if it should go in for 1.4.
On Tue, Feb 21, 2012 at 05:33:35PM +0100, Maarten Lankhorst wrote:
---
I suspect a lot more AUDCLNT_E_* calls
On Thu, Feb 16, 2012 at 10:10:09AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Hi,
this fixes bug #28413.
Thanks Jörg, looks sane to me and I can confirm it fixes the problem.
Andrew
:00:00 2001
From: Andrew Eikum aei...@codeweavers.com
Date: Mon, 13 Feb 2012 09:47:03 -0600
Subject: winealsa.drv: Optionally load extra ALSA device names from the
registry
To: wine-patches wine-patc...@winehq.org
Reply-To: wine-devel wine-devel@winehq.org,Andrew Eikum aei...@codeweavers.com
MIME
On Sat, Feb 11, 2012 at 06:24:08AM -0800, Chris Robinson wrote:
On Saturday, February 11, 2012 2:05:18 PM Нискородов Серёжа wrote:
Here is another trouble with snd_ctl_open. Not all devices in alsa
configuration files have a predefined ctl. Especially defined by user,
for example I don't
3fca39549abc2606c7e51420d69dd241a9877a12 Mon Sep 17 00:00:00 2001
From: Andrew Eikum aei...@codeweavers.com
Date: Mon, 13 Feb 2012 09:47:03 -0600
Subject: winealsa.drv: Optionally load default ALSA device names from the
registry
To: wine-patches wine-patc...@winehq.org
Reply-To: wine-devel wine-devel@winehq.org
On Tue, Feb 07, 2012 at 11:32:34PM +0200, Нискородов Серёжа wrote:
I'm not so good at programming. I just was looking for a way to
make possible play sound from WINE to ALSA software device other than
default.
I wrote a patch that allows you to select the ALSA software device
from control
On Tue, Feb 07, 2012 at 11:32:34PM +0200, Нискородов Серёжа wrote:
Perhaps the code is not so clear and beautiful, but it works for me,
and maybe someone wants to send it to the repository, or to correct
and send a corrected.
One more thing, this messes up the default device selection, which
On Thu, Feb 09, 2012 at 10:08:39PM +0200, Нискородов Серёжа wrote:
Thanks, I've been wanting to do this for a while. I've been hesitating
because ALSA doesn't document the format of their device names. If a
device name contains a colon, is it _always_ a hardware device that
will be
On Wed, Feb 08, 2012 at 11:22:42AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Your rewrite no more maps WOD_XYZ* messages to waveOut functions.
I believe that it is possible that an old app entirely uses the generic
SendDriverMessage function
(esp. in the mciavi/msvfw area, cf.
On Mon, Jan 30, 2012 at 11:37:17AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Fixes bug #29657
While I like the idea of this patch and how you implemented it, I
wonder if it's appropriate for code freeze.
The main problem in that bug is that the CA driver can deadlock, or
release memory
On Mon, Jan 30, 2012 at 11:03:52AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
+sc = AudioQueueEnqueueBufferWithParameters(This-aqueue,
+This-public_buffer, 0, NULL, 0, 0, 0, NULL, req_time,
start_time);
I advise against setting req_time. This can only fragilize
On Mon, Jan 30, 2012 at 06:52:36PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Andre Eikum wrote:
+sc = AudioQueueEnqueueBufferWithParameters(This-aqueue,
+This-public_buffer, 0, NULL, 0, 0, 0, NULL,
+ req_time, start_time);
NULL=ASAP is exactly what we want.
On Fri, Jan 27, 2012 at 02:02:22PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
+case S_FALSE: /* as in IsFormatSupported */
+case AUDCLNT_E_UNSUPPORTED_FORMAT:
+return WAVERR_BADFORMAT;
I think I'd rather special-case how we handle IsFormatSupported,
rather than put
On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote:
The code looks like it would do what was intended to me. The problem I
have with it, and I'm pretty sure I've mentioned this before, is that
reducing debug output shouldn't be a goal on its own. If you're a
user, and the messages
On Fri, Jan 20, 2012 at 07:23:42PM +0800, Dmitry Timoshkov wrote:
joerg-cyril.hoe...@t-systems.com wrote:
Austin English wrote:
If no one opposes in the next few days I'll add it/start tagging bugs.
I'm no more opposed to adding a pseudo-component. I simply
suggest naming it
On Fri, Jan 20, 2012 at 10:40:53PM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
Austin English wrote:
If no one opposes in the next few days I'll add it/start tagging bugs.
I'm no more opposed to adding a pseudo-component. I simply
suggest naming
On Fri, Jan 20, 2012 at 05:43:15PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
#29294 no sound with ALSA loopback
#28781 loopback to Jack
It is not acceptable for winealsa to solely know default and hw:x,y.
The user can define and use any other name in the asound.conf files.
The old
On Thu, Jan 19, 2012 at 08:22:11PM +, The Edmeades wrote:
I'll resend, and thanks for working this through with me!
Before you resend, please fix your mail client to put your real name
in the From: header, as I believe you are named Jason and not The :)
Andrew
On Wed, Jan 18, 2012 at 07:03:24PM +, Jerome Leclanche wrote:
Any comments?
Seems like a useful idea to me, though I'd defer to the heavier
Bugzilla users' opinions.
Andrew
On Tue, Jan 17, 2012 at 1:09 AM, Jerome Leclanche adys...@gmail.com wrote:
Hi,
Joerg and I exchanged a
On Tue, Jan 17, 2012 at 01:53:10AM +0100, Michael Stefaniuc wrote:
@@ -901,10 +895,11 @@ HRESULT IDirectSoundBufferImpl_Create(
TRACE(Created buffer at %p\n, dsb);
dsb-ref = 0;
+dsb-refiks = 0;
dsb-numIfaces = 0;
dsb-device = device;
Actually, don't commit this one.
On Mon, Jan 16, 2012 at 02:02:49PM -0600, Andrew Eikum wrote:
---
dlls/dsound/mixer.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c
index 23af6ce..b35a888 100644
--- a/dlls/dsound
This mail is about bugs 28042[1] and 28677[2]. In short, what I'm
trying to deal with is buggy applications that make calls to DSound
and WinMM from within DllMain(), causing deadlocks.
On almost any entry into DSound or WinMM's wave functions, the modules
launch a thread to communicate with
On Tue, Jan 10, 2012 at 04:57:58PM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
Andrew Eikum wrote:
I think the GetPosition and GetCurrentPadding failures are caused by
using GETOSPACE instead of GETODELAY in GetPosition().
Please write that patch too. It needs good testing to get
On Wed, Jan 11, 2012 at 01:03:56AM +0800, Dmitry Timoshkov wrote:
Andrew Eikum aei...@codeweavers.com wrote:
So, I'm asking for insights. Should I try hard to avoid launching
threads unless absolutely necessary? Is this a known deficiency in the
loader, and I should do nothing
On Tue, Jan 10, 2012 at 09:10:15PM +0100, Henri Verbeet wrote:
On 10 January 2012 20:55, Andrew Eikum aei...@codeweavers.com wrote:
So it appears we should be able to launch threads in DllMain() without
deadlocking.
Thoughts, anyone?
That should be easy enough to test. Is the issue
On Thu, Nov 03, 2011 at 09:41:46AM +0100, joerg-cyril.hoe...@t-systems.com
wrote:
perhaps I shouldn't send this one day before release...
I argue that Wine has no business setting ALSA's period size,
esp. not to a completely random value like duration/10.
Better leave it complete freedom,
On Sun, Oct 23, 2011 at 05:57:04PM -0700, Chris Robinson wrote:
On Sunday, October 23, 2011 8:28:45 PM Jonathan McCrohan wrote:
Would someone with a better knowledge of Wine and/or ALSA be able to
assist me in tracking down the source of this bug?
Part of the problem is the way Wine
On Mon, Oct 24, 2011 at 06:26:18AM -0700, Chris Robinson wrote:
On Monday, October 24, 2011 8:08:58 AM Andrew Eikum wrote:
On Sun, Oct 23, 2011 at 05:57:04PM -0700, Chris Robinson wrote:
A configuration option (in
winecfg/control panel) would be needed to set
Hi J�rg,
Thanks for adding these tests. It would have been nicer to split the
patch up into discrete chunks. That would make the patch much easier
to review. Overall it looks pretty good. Some remarks follow...
BTW, I've not touched
render.c:223: Test failed: IsFormatSupported(0x) call
On Mon, Sep 26, 2011 at 04:50:22PM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
I'm not satisfied with the removal of the audio tree from winecfg.
Beside allowing to switch or disable drivers, one key feature was to
allow inspecting the devices that winmm found on this system.
The goal of
1 - 100 of 198 matches
Mail list logo
