Re: Virus spread via wine

2013-09-23 Thread Dan Kegel
/index.php?title=VirusDB */ On Mon, Sep 23, 2013 at 1:20 PM, Dan Kegel d...@kegel.com wrote: Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

Virus spread via wine

2013-09-22 Thread Dan Kegel
Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

re: open bugs / multi thread / recommendation on new system

2013-08-19 Thread Dan Kegel
Damian wrote: 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? Don't know. I just use nvidia cards I find in the trash :-) But then I don't actually play games, so I don't care about 3d performance. 2) FX 8320 or intel same price class CPU? As the AMD has far inferior single

Re: Could you update/rerun that report on bugs without AppDB links?

2013-08-18 Thread Dan Kegel
I don't seem to have saved the (crappy) script. There is something similar at https://code.google.com/p/winezeug/source/browse/#svn%2Ftrunk%2Fappdb-mashup and it wouldn't be too hard to whip something up again for somebody who is motivated. Please do throttle the scraping script to avoid

re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Dan Kegel
Minor problem: +static void test_strncpy(void) +{ +size_t len = 10; +char *ret; +char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems

re: Main sources of Wine complexity

2013-06-10 Thread Dan Kegel
I need to port fairly large WinAPI-heavy application to Linux. After some googling it becomes clear that there's nothing except for Wine/Winelib which is *huge*. However for at least most basic WinAPI functions it looks fairly easy to just re-implement it via Boost/STL/libc/Linux syscalls. Why

Re: How to stop gecko and mono popups while git bisecting?

2013-06-03 Thread Dan Kegel
Or run https://winezeug.googlecode.com/svn/trunk/install-addons.sh

re: Increment, Decrement, and Assignment Operators

2013-05-28 Thread Dan Kegel
Watch http://source.winehq.org/patches/ for your patch's status (see legend at bottom). It might be rejected since it doesn't actually fix any behavioral problem in Wine. IIRC trivial cleanups in code are frowned upon, especially if they cross many modules. Better to pick some small real problem

Making SetThreadPriorityBoost claim success

2013-05-26 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=22280 just got another dup. How awful would it be to make SetThreadPriorityBoost just return success, as in the patch attached to http://bugs.winehq.org/show_bug.cgi?id=22280#c1

Re: user32: add assembly wrapper for calling hook procedures.

2013-04-22 Thread Dan Kegel
Thanks. I saw the 'doesn't apply' status at source.winehq.org/patches, so was going to take another look tonight. On Mon, Apr 22, 2013 at 4:40 PM, James Eder jimpor...@gmail.com wrote: Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

re: Willing to work on CMD - implement more robust parser

2013-04-20 Thread Dan Kegel
Hi Gaurab! Glad to hear you're interested in wine, and in cmd. You might start by reading previous discussion on the topic, e.g. the full thread following http://www.winehq.org/pipermail/wine-devel/2009-December/080643.html and http://kegel.com/wine/sweng/2010/ Two tips that might help smooth

re: Google Summer of Code 2013

2013-04-20 Thread Dan Kegel
Hi Anulesh, improving wine's support of cygwin is a toughie. ( I gave http://bugs.winehq.org/show_bug.cgi?id=15679 the old college try, but failed. ) You should probably be more specific about what you have in mind. - Dan

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()

2013-04-19 Thread Dan Kegel
I suspect this is a real fix, and there is no gcc bug. On Fri, Apr 19, 2013 at 9:47 AM, Qian Hong fract...@gmail.com wrote: Hi Dan, Thanks for working on it! It is really an annoying bug, however, is adding DECLSPEC_NOINLINE a workaround or a real fix? If it is only a workaround, would that

Re: [user32] Add DECLSPEC_NOINLINE, use it on call_hook_proc()

2013-04-19 Thread Dan Kegel
On Fri, Apr 19, 2013 at 10:38 AM, Dan Kegel d...@kegel.com wrote: Hooking is a fragile business. Somebody somewhere is probably making assumptions about how hooking works (like, how many stack frames are pushed), and inlining call_hook_proc probably violates one of those assumptions

Re: Portability - Port Wine to Wayland

2013-04-05 Thread Dan Kegel
OK, thanks. On Fri, Apr 5, 2013 at 7:45 AM, André Hentschel n...@dawncrow.de wrote: Hi Dan, i just removed your gsoc idea and i want to let you know why. There was a quite short discussion on IRC: Andre_H_laptop: austin_laptop: Dan added a quite controversal gsoc idea... afaik ken needed

re: Clang static analyzer results / wine-1.5.19-186-g1cd0c4a

2012-12-21 Thread Dan Kegel
I had a look at a couple warnings, e.g. file:///home/dank/Downloads/scan-build-2012-12-18-1/report-z07lcL.html#EndPath file:///home/dank/Downloads/scan-build-2012-12-18-1/report-9D2p5I.html#EndPath They're hard to follow, but mostly look like garbage :-( Too bad there's no web interface for

re: [PATCH 5/5] winex11: Detect broken NVIDIA RandR setups.

2012-11-24 Thread Dan Kegel
Henri wrote: +/* Recent (304.64, possibly earlier) versions of the nvidia driver only + * report a DFP's native mode through RandR 1.2 / 1.3. Standard DMT modes + * are only listed through RandR 1.0 / 1.1. This is completely useless, + * but NVIDIA considers this a feature, so it's

certificate problem accessing https://source.winehq.org ?

2012-11-17 Thread Dan Kegel
$ git clone https://source.winehq.org/git/wine.git newwine-git Cloning into 'newwine-git'... error: server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none while accessing https://source.winehq.org/git/wine.git/info/refs Maybe that's related to the big fat

Re: certificate problem accessing https://source.winehq.org ?

2012-11-17 Thread Dan Kegel
On Sat, Nov 17, 2012 at 1:34 PM, Dan Kegel d...@kegel.com wrote: $ git clone https://source.winehq.org/git/wine.git newwine-git Cloning into 'newwine-git'... error: server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none while accessing https

Fwd: Bug#566351: libgcrypt11: should not change user id as a side effect

2012-11-07 Thread Dan Kegel
After gstreamer, gcrypt is also dropping support for alternative thread libraries. Good thing secur32/schannel_gnutls.c doesn't use it. (Right?) - Dan -- Forwarded message -- From: Werner Koch w...@gnupg.org Date: Wed, Nov 7, 2012 at 1:31 AM Subject: Re: Bug#566351: libgcrypt11:

re: Call for papers - FOSDEM 2013

2012-11-02 Thread Dan Kegel
Francois wrote: (*) A particularly interesting one to me is testing untrusted code on real hardware (with possible approaches being direct access to a graphics card from within a VM I had some fun googling your wishlist. Presumably you've seen some of these links already:

re: ntdll: Fixed some heap allocation stalls

2012-11-02 Thread Dan Kegel
Which game were you testing?

Re: vcomp: single-threaded implementation of _vcomp_fork (try 6)

2012-10-24 Thread Dan Kegel
On Wed, Oct 24, 2012 at 3:26 AM, joerg-cyril.hoe...@t-systems.com wrote: Alexandre Julliard wrote: +void WINAPIV _vcomp_fork(BOOL ifval, int nargs, void *wrapper, ...) +__ms_va_list valist; it's ugly to use varargs only as a hack to get a pointer to the first argument. Would taking the

Re: vcomp: single-threaded implementation of _vcomp_fork (try 6)

2012-10-24 Thread Dan Kegel
On Wed, Oct 24, 2012 at 5:38 AM, Alexandre Julliard julli...@winehq.org wrote: What I'm actually saying is that you should stop playing games with the compiler and implement this in assembler... Thanks for the cleartext.

re: [PATCH] services: Fix some weird sizeof usages.

2012-10-21 Thread Dan Kegel
Christian Costa wrote: ... --- a/programs/services/rpc.c +++ b/programs/services/rpc.c ... @@ -952,7 +952,7 @@ BOOL service_send_command( struct service_entry *service, HANDLE pipe, } r = GetOverlappedResult( pipe, overlapped, count, FALSE ); } -if (!r || count != sizeof

re: [PATCH 4/6] [cmd] Add for /f parsingkeyword parsing, add support for skip=

2012-10-17 Thread Dan Kegel
Jason wrote: It's clearly time to start splitting WCMD_for into several helper functions. I completely agree, and it was definitely on my radar to do... its really ugly code in there (I take responsibility for a lot of that!) as it has been a slow incremental increase in what we actually

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-14 Thread Dan Kegel
On Sat, Oct 13, 2012 at 4:40 PM, Max TenEyck Woodbury m...@mtew.isa-geek.net wrote: ... There are criteria beyond the two you mentioned, but it is rare to see them come into play. Few people know enough to even recognize such problems. While far from an expert on such matters, I have enough

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-13 Thread Dan Kegel
In general, patches to wine should have some demonstrated benefit, either by increasing the number of passing conformance tests, or by making some app work better, or both. Your current patch doesn't seem to do either of these things. Getting into a pissing match with AJ about patent and

Re: Help getting amd64 assembly patch into wine?

2012-10-06 Thread Dan Kegel
New draft at https://testbot.winehq.org/JobDetails.pl?Key=22035 (the testbot seems stuck... Maarten, does it need a kick?) Thanks to Maarten for getting me to try C varargs again; the first assembly function is now gone. I've also added comments that explain the vcomp execution model, I hope

Re: Help getting amd64 assembly patch into wine?

2012-10-05 Thread Dan Kegel
On Fri, Oct 5, 2012 at 7:27 AM, joerg-cyril.hoe...@t-systems.com wrote: I found your message very unclear. The patch adds support for OpenMP programs like this: And then you start talking about vcomp_fork without telling us where it comes from and what it should do. Good point - it's unfair

Re: Help getting amd64 assembly patch into wine?

2012-10-04 Thread Dan Kegel
On Thu, Oct 4, 2012 at 1:52 PM, Kyle Auble randomidma...@yahoo.com wrote: I'm just wondering is assembly definitely needed? This is just based on some googling and skimming through StackOverflow, but it sounds like you can still use va_list on amd64. It just takes some tweaking:

Help getting amd64 assembly patch into wine?

2012-10-03 Thread Dan Kegel
As you might know from watching too many of my patches scroll by, I've been working on adding support for OpenMP to wine. (A handful of games, and a lot of serious apps, seem to use that api.) After getting it nicely organized and cleaned up to the point where it passed all the tests I could

re: Question from new developer

2012-09-23 Thread Dan Kegel
Chris wrote: 1. I discovered later that I don't think this is the root of my original bug - and in fact doesn't seem to affect behavior of my program. Is it still worth submitting? Generally, fixes are more likely to get committed when they don't break anything (did you run all the

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

2012-09-07 Thread Dan Kegel
As I mentioned earlier, the testbot can't handle vcomp.dll tests until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 is deployed. It can handle vcomp100.dll tests, though (no manifest). I guess I can submit the series again with the vcomp100 forwarding and tests in a sixth patch, that

Re: [2/5] vcomp: add better stub for _vcomp_fork (resend)

2012-09-07 Thread Dan Kegel
On Fri, Sep 7, 2012 at 7:21 AM, Dan Kegel d...@kegel.com wrote: As I mentioned earlier, the testbot can't handle vcomp.dll tests until a fix for http://bugs.winehq.org/show_bug.cgi?id=31609 is deployed. It can handle vcomp100.dll tests, though (no manifest). I guess I can submit the series

Re: Building winetest-latest.exe?

2012-09-04 Thread Dan Kegel
On Tue, Sep 4, 2012 at 3:18 PM, Francois Gouget fgou...@codeweavers.com wrote: (But as it turns out, the code I needed to fix was in buildbot, not winetest.) Maybe the WineTestBot code needs a similar fix? In testbot/src/TestLauncher/TestLauncher.c? Yeah, um, ^buildbot^testbot I have a patch

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-09-03 Thread Dan Kegel
On Sun, Sep 2, 2012 at 1:14 PM, Dan Kegel d...@kegel.com wrote: On Wed, Aug 8, 2012 at 7:27 AM, Dan Kegel d...@kegel.com wrote: Testing vcomp100 does work, but I shouldn't need to do that until there's some vcomp100-specific code. msvcr90/tests just adds a manifest, and that works. Heh

Re: Building winetest-latest.exe?

2012-09-03 Thread Dan Kegel
On Mon, Sep 3, 2012 at 2:28 PM, Austin English austinengl...@gmail.com wrote: On Sun, Sep 2, 2012 at 9:52 PM, Vincent Povirk madewokh...@gmail.com wrote: As I understand it, you need to set up a mingw build as in http://wiki.winehq.org/CompilingDLLsUsingMingw Sort of. You don't need a

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-09-02 Thread Dan Kegel
On Wed, Aug 8, 2012 at 7:27 AM, Dan Kegel d...@kegel.com wrote: Testing vcomp100 does work, but I shouldn't need to do that until there's some vcomp100-specific code. msvcr90/tests just adds a manifest, and that works. Heh. It does add a manifest, but I don't think it works. See http

Building winetest-latest.exe?

2012-09-02 Thread Dan Kegel
Hi folks, how does one build the native version of winetest.exe? I looked around a bit, and didn't see any obvious instructions. http://www.winehq.org/pipermail/wine-devel/2011-July/091144.html touches on it, but doesn't say much. I ask because I'm interested in tracking down why testbot doesn't

re: xmllite: Store DTD processing mode in reader

2012-08-27 Thread Dan Kegel
Alexandre Julliard wrote: Explicit ok() calls are better than hiding them inside a macro. Uh-oh. Want me to get rid of this macro +#define CHECK_RET_ERRNO(ret, ex) \ +do { \ +ok(ret == ex, ret is %d, expected %d\n, ret, ex); \ +ok(errno == ex, errno is %d, expected %d\n,

Re: msvcr100: Add wmemmove_s and wmemcpy_s

2012-08-26 Thread Dan Kegel
On Sun, Aug 26, 2012 at 1:29 AM, Alexandre Julliard julli...@winehq.org wrote: But msvcr100's wmemmove_s/wmemcpy_s are different; they do not change errno. Tests in my patch confirm this. They do set errno, the tests are broken. Aw, foo. Thanks, resent with fixes.

re: msvcr100: Add wmemmove_s and wmemcpy_s

2012-08-25 Thread Dan Kegel
I asked Alexandre what http://source.winehq.org/patches/data/88732 needed before it could be reviewed. He said it needed to adapt to the recent parameter checking changes. I see that when he took my patch http://www.winehq.org/pipermail/wine-patches/attachments/20120728/bea2581d/attachment.obj

Re: _vcomp_fork stack frame puzzle

2012-08-12 Thread Dan Kegel
Using varargs like Andre tried doesn't work because pushing a va_list isn't the same as pushing a list of arguments. So I think we need assembly. The assembly I gave earlier is wrong because it cleans up the stack, which it's not allowed to do. I've attached an updated patch to

Re: _vcomp_fork stack frame puzzle

2012-08-10 Thread Dan Kegel
Yeah, it might be as simple as _vcomp_vfork proc add sp,4 ; skip parallel flag and arg count ret ; jump to helper function, leaving its args on stack or something like that.

Re: _vcomp_fork stack frame puzzle

2012-08-10 Thread Dan Kegel
Yes indeed, this works: extern void WINAPIV VCOMP__vcomp_fork(DWORD parallel, int ncount, void (__cdecl *helper)(__ms_va_list), ...); __ASM_GLOBAL_FUNC( VCOMP__vcomp_fork, pop %eax\n\t /* save return address */ add $8,%esp\n\t/* skip

Re: _vcomp_fork stack frame puzzle

2012-08-10 Thread Dan Kegel
On Fri, Aug 10, 2012 at 7:37 PM, Dan Kegel d...@kegel.com wrote: Yes indeed, this works: extern void WINAPIV VCOMP__vcomp_fork(DWORD parallel, int ncount, void (__cdecl *helper)(__ms_va_list), ...); __ASM_GLOBAL_FUNC( VCOMP__vcomp_fork, pop %eax\n\t /* save

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-08 Thread Dan Kegel
Testing vcomp100 does work, but I shouldn't need to do that until there's some vcomp100-specific code. msvcr90/tests just adds a manifest, and that works.

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-08 Thread Dan Kegel
Andre wrote: i'd something like in my attachment Sorry, I should have linked to http://testbot.winehq.org/JobDetails.pl?Key=20684 where I verified that testing vcomp100 did indeed work around the problem. I guess that's where I'll put the tests until somebody hits me with a cluestick.

_vcomp_fork stack frame puzzle

2012-08-08 Thread Dan Kegel
Having fun trying to figure out what's in the black box of _vcomp_fork(), the helper function that spawns threads in Visual C's OpenMP support library. The C source code #include stdio.h #include omp.h int main(int argc, char **argv) { double d; double e; int i; printf(d is %p, e

vcomp.dll, vcomp90.dll missing on testbot?

2012-08-06 Thread Dan Kegel
I'm trying to test a better set of stubs for vcomp.dll and its ilk, but those dlls don't seem to be installed on testbot. Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs?

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-06 Thread Dan Kegel
On Mon, Aug 6, 2012 at 8:28 AM, Dan Kegel d...@kegel.com wrote: Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs? Nevermind for the moment, I probably have a manifest problem.

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-06 Thread Dan Kegel
On Mon, Aug 6, 2012 at 8:47 AM, Dan Kegel d...@kegel.com wrote: On Mon, Aug 6, 2012 at 8:28 AM, Dan Kegel d...@kegel.com wrote: Is vcomp{,90,100}.dll not installed by default on Windows? If not, should we install it on a few of the VMs? Nevermind for the moment, I probably have a manifest

A milestone of sorts...

2012-07-30 Thread Dan Kegel
I just ran into a CAD app whose 64 bit version runs better than its 32 bit version on Wine (the 32 bit version hangs with http://bugs.winehq.org/show_bug.cgi?id=31358 but the 64 bit version gets past that and seems to actually do something). Not very important, but kind of cool.

Re: Rethinking WineConf

2012-07-26 Thread Dan Kegel
On Tue, Jan 10, 2012 at 2:58 PM, Pau Garcia i Quiles pgqui...@elpauer.org wrote: In that regard, let me say: this year I am coorganizing the CrossDesktop DevRoom at FOSDEM and I am truly disappointed we have not received a single talk proposal about Wine, even though I sent the call for talks

Re: Rethinking WineConf

2012-07-26 Thread Dan Kegel
On Thu, Jul 26, 2012 at 5:54 AM, Dan Kegel d...@kegel.com wrote: On Tue, Jan 10, 2012 at 2:58 PM, Pau Garcia i Quiles pgqui...@elpauer.org wrote: D'oh! Looks like I was fooled by a long-delayed message delivery. The message I replied to is from *six months* ago. I've gotten several of those

re: Investigating iexplore/activex issues

2012-07-26 Thread Dan Kegel
I'm running into a similar problem, http://bugs.winehq.org/show_bug.cgi?id=23058 If you're using a different activex control, please file a new bug, with a way for others to reproduce the problem. Any chance you could add an HTML5 mode? http://praegnanz.de/html5video/ shows a bunch of HTML5 video

Re: [rfc msvcp100] add Container_base::_Orphan_all

2012-07-25 Thread Dan Kegel
On Tue, Jul 24, 2012 at 2:07 AM, Piotr Caban piotr.ca...@gmail.com wrote: The calling convention is correct. The class name is _Container_base0 (not _Container_base). I can't say anything about the implementation. I don't know what this class is supposed to do. Can you have a look at

Re: [1/2] msvcrt: added wmemcpy_s and wmemmove_s

2012-07-23 Thread Dan Kegel
On Mon, Jul 23, 2012 at 5:56 AM, Alexandre Julliard julli...@winehq.org wrote: You shouldn't need to put that in msvcrt. OK, I'll put it in msvcr90. Also please check the parameters correctly like every other _s function does. The wmemmove_s/wmemcpy_s I posted are exact copies of the existing

Re: [1/2] msvcrt: added wmemcpy_s and wmemmove_s

2012-07-23 Thread Dan Kegel
On Mon, Jul 23, 2012 at 8:33 AM, Alexandre Julliard julli...@winehq.org wrote: You shouldn't need to put that in msvcrt. OK, I'll put it in msvcr90. It's not supposed to be there either. Maybe I was grepping without the w prefix by accident, sorry. I see now it's only in msvcr100. - Dan

re: Have there been any problems with Wine on GCC 4.7?

2012-07-23 Thread Dan Kegel
Groveling around, I found a few possibilities: backtraces broken on gcc 4.7 http://bugs.winehq.org/show_bug.cgi?id=26791 ICE when compiling: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641056 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640864

Noticed openwatcom.org's afxapi

2012-07-22 Thread Dan Kegel
Initial checkin of afxapi, a class library aiming to provide source-level compatibility with MFC. http://www.openwatcom.org:4000/@md=dcd=//depot/openwatcom/bld/afxapi/include/cdf=//depot/openwatcom/bld/afxapi/include/afxcmn4.mnlra=src=sc=3Z1@/36051?ac=10 Wonder how that's going.

[rfc msvcp100] add Container_base::_Orphan_all

2012-07-20 Thread Dan Kegel
Piotr, can you review this, please? I've only tested this with two apps on 32 bits, I have not tested at all on 64 bits, and am only guessing on the calling convention stuff. Seems to fix http://bugs.winehq.org/show_bug.cgi?id=27698 for Harvest and one other app (I can't reproduce the problem

re: msvcp90: handle npos as a len in basic_string::replace

2012-07-16 Thread Dan Kegel
Daniel Lehman wrote: @@ -1949,7 +1949,7 @@ basic_string_char* __thiscall basic_string_char_replace_cstr_len(basic_string_ch -if(off+len this-size) +if(off+len off || off+len this-size) len = this-size-off; Wouldn't this be more elegant: if(num this-size-pos)

Re: Suppressing My Computer in File Open dialog box?

2012-07-14 Thread Dan Kegel
On Sat, Jul 14, 2012 at 2:03 AM, GOUJON Alexandre ale.gou...@gmail.com wrote: Does anyone know how to keep the Save File dialog box from listing My Computer in the LookIn pulldown? Have you read

re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-14 Thread Dan Kegel
Is it worth for working on patches for these issues, or is this completely impossible with the current architecture? Do you know yet why no symlink is made in dosdevices for /media/-? I haven't heard any rumblings about the current architecture being hopelessly broken.

Suppressing My Computer in File Open dialog box?

2012-07-13 Thread Dan Kegel
I'm creating a page of tips at http://wiki.winehq.org/DisplayingUnixFilenames for vendors shipping Windows apps on Linux with Wine who want their apps to use Windows paths throughout internally, but display Linux paths in the GUI This is something I've been meaning to do ever since I helped port

Re: winetricks dotnet40 fails verifier because System.EnterpriseServices.Wrapper.dll missing?

2012-07-09 Thread Dan Kegel
On Mon, Jul 9, 2012 at 1:42 PM, Hans Leidekker h...@codeweavers.com wrote: That file does seem to be on disc, but somewhere else: c:/windows/Microsoft.NET/Framework/v4.0.30319/System.EnterpriseServices.Wrapper.dll Not sure how serious it is that that's misplaced. Have other folks seen

re: Re-enable editing on the forum?

2012-07-08 Thread Dan Kegel
No objection here. Seems like an obvious thing to do. I'll do it later today if nobody objects.

Re: League of Legends patches

2012-07-04 Thread Dan Kegel
On Wed, Jul 4, 2012 at 12:15 AM, Andrea Canciani ranm...@gmail.com wrote: Do you think you could write a test that (semi-)reliably causes the deadlock you're fixing? Yes, I guess it should be possible. Could you point me to a test which triggers a deadlock (in particular, how should the

winetricks dotnet40 fails verifier because System.EnterpriseServices.Wrapper.dll missing?

2012-07-04 Thread Dan Kegel
With current git, when I try rm -rf .wine sh winetricks -q dotnet40 sh winetricks -q dotnet_verifier wine netfx_setupverifier.exe the verifier reports failure: ... [07/04/12,21:45:13] ERROR File

Re: League of Legends patches

2012-07-03 Thread Dan Kegel
. On an administrivial note, you should send one patch per email to wine-patches. Do you think you could write a test that (semi-)reliably causes the deadlock you're fixing? The patches have been tested by Dan Kegel (in CC) and are currently being used by many MacOSX and Linux users to run LoL. Our

Re: Integer overflow problem in string::compare()

2012-07-02 Thread Dan Kegel
On Mon, Jul 2, 2012 at 2:51 AM, Piotr Caban piotr.ca...@gmail.com wrote: This patch looks correct. It's also good to fix other functions with similar bug. Great, I'll have a bigger patchset for review in a few days. Thanks, Dan

Integer overflow problem in string::compare()

2012-07-01 Thread Dan Kegel
Hi Piotr, could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ? If you like it, I'll submit it to wine-patches. It passes winetestbot and gets pulsen and stepmania past the splash screen abort. Why are there no tests for msvcp60? If you think it's appropriate, I can add

re: [PATCH 2/5] ddraw: Use wined3d_get_adapter_display_mode() in CreateSurface().

2012-06-21 Thread Dan Kegel
Henri wrote: -hr = wined3d_device_get_display_mode(ddraw-wined3d_device, 0, mode); -if (FAILED(hr)) +if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw-wined3d, WINED3DADAPTER_DEFAULT, mode))) Seems like a step back in readability to combine setting and testing hr. - Dan

Examples of AJ silently improving patches?

2012-06-20 Thread Dan Kegel
AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at

'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)

2012-06-19 Thread Dan Kegel
Nozomi wrote: +for (i = 0; i order * order; i++) I might have written int n = order * order; for (i=0; i n; i++) to avoid repeating the multiplication every time around the loop, even though multiplication is cheap nowadays, and -O1 will optimize it out anyway. Staying in the

comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't also ask the

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
On Mon, Jun 18, 2012 at 11:41 AM, Dmitry Timoshkov dmi...@baikal.ru wrote: +     /* In some apps, the hotkey doesn't draw unless we invalidate it here */ +     InvalidateRect(infoPtr-hwndSelf, NULL, FALSE); It doesn't make sense to invalidate before painting in the paint handler. Looking

re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
-#elif defined(HAVE_SYS_SYSCTL_H) defined(IPCTL_STATS) (HAVE_STRUCT_IPSTAT_IPS_TOTAL || HAVE_STRUCT_IP_STATS_IPS_TOTAL) +#elif defined(HAVE_SYS_SYSCTL_H) defined(IPCTL_STATS) (defined(HAVE_STRUCT_IPSTAT_IPS_TOTAL) || defined(HAVE_STRUCT_IP_STATS_IPS_TOTAL)) Isn't this a no-op? I thought that

Re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
On Fri, Jun 8, 2012 at 11:51 AM, Francois Gouget fgou...@free.fr wrote: On Fri, 8 Jun 2012, Dan Kegel wrote: Isn't this a no-op?  I thought that an undefined symbol was treated as false by the preprocessor. Actually you may be right. But then this is the only place in Wine where we rely

Re: iphlpapi: Don't rely on the HAVE_XXX macros having a numeric values.

2012-06-08 Thread Dan Kegel
Alexandre wrote: It's common practice to avoid it, to make things like -Wundef more useful. Good point. Reading http://ozlabs.org/~rusty/index.cgi/tech/2008-01-04.html makes me sad. -Wundef would be a lot more useful if autoconf defined symbols to zero instead of undefining them; then we could

re: Command line parameters

2012-06-07 Thread Dan Kegel
John asked [ How do I launch Windows apps from Unix apps and pass filenames to them?] execl (the_path_to_wine, wine, path_to_the_windows_program, command_line_parameter_for_windows_app, NULL); Relative unix paths will often work with Windows apps, but in general, you will have to translate

Re: Command line parameters

2012-06-07 Thread Dan Kegel
John wrote: from what Hin-Tak said earlier, it sounds like Wine itself will translate any paths that I pass as a command line parameter (or did I misunderstand that?) Example: wine notepad /home/dank/foo.txt This fails because notepad treats / as the beginning of an option (see

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

2012-06-04 Thread Dan Kegel
On Mon, Jun 4, 2012 at 12:05 AM, Frédéric Delanoy frederic.dela...@gmail.com wrote: Wouldn't it be better (and more acceptable for people disliking/wanting to avoid mono) to - keep install-gecko.sh as is - create install-mono.sh - create wine-install-addons.sh calling the former ? The

re: comctl: allow label edit only if treeview style allows editing

2012-06-04 Thread Dan Kegel
I stopped doing make test on my machine some time ago Bad developer, no donut :-) , when I found out that some tests do consistently fail on my machine (clean prefix or not), and others consistently hang, thus preventing make test -k. I had the same problem, and wrote a little script to

Wine in Humble Indie Bundle

2012-06-03 Thread Dan Kegel
I see the Humble Indie Bundle includes a game ported via wine, http://zcint.co.uk/article/limbo-on-linux-incites-humble-bundle-petition That's pretty cool, but not everyone agrees, and somebody has started circulating an anti-wine petition. So I put together a pro-wine petition:

Re: Wine in Humble Indie Bundle

2012-06-03 Thread Dan Kegel
Berillions wrote: the other petition does have a point about Wine not doing as well with sound as it should. Yes, there are some issues. For the record, here are a couple links to people talking about their problems with the game: http://askubuntu.com/questions/144915/limbo-game-has-no-sound

Re: Wine in Humble Indie Bundle

2012-06-03 Thread Dan Kegel
On Sun, Jun 3, 2012 at 5:16 PM, Jerome Leclanche adys...@gmail.com wrote: This comes up in one form or the other very often, though, doesn't it? Company x releases software y with a Wine wrapper advertising native linux support and users get upset. Personally, I'm glad they're thinking about

Re: Installing 64 bit visual c++ 2010 runtime?

2012-05-17 Thread Dan Kegel
On Wed, May 16, 2012 at 3:24 PM, Dan Kegel d...@kegel.com wrote:  wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650EFEBA5/vcredist_x64.exe  wine vcredist_x64 installs fine... but only puts anything in c:\windows\syswow64, And the things it puts there are 64 bit

re: AppDB, ratings and native vs. builtin trouble

2012-05-16 Thread Dan Kegel
16.05.2012 17:34, Rosanne DiMesio wrote: If the user didn't have to manually do anything, it should be rated platinum. Agreed. appdb ratings are from the point of view of someone who simply uses their linux distro to install wine, and then tries to install a game. If no fiddling is required,

re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Dan Kegel
Frédéric Delanoy wrote: -Application works flawlessly with some DLL overrides, other settings or third party software. +Application works flawlessly with some DLL overrides, some patches applied, other settings or third party software. Really? IMHO they should still be silver. Patches are very

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-16 Thread Dan Kegel
On Wed, May 16, 2012 at 1:50 PM, Alexey Loukianov mooro...@mail.ru wrote: Really?  IMHO they should still be silver.  Patches are very hard for the average user to deploy without a third party front end like POL, and appdb is not about POL. - Dan I thinks that using silver won't be correct

Installing 64 bit visual c++ 2010 runtime?

2012-05-16 Thread Dan Kegel
I'd like to try a real 64 bit app, so on a 64 bit Ubuntu 12.04, I tried sudo apt-get install wine rm -rf ~/.wine export WINEARCH=win64 wget http://download.microsoft.com/download/3/2/2/3224B87F-CFA0-4E70-BDA3-3DE650EFEBA5/vcredist_x64.exe wine vcredist_x64 and that installs fine... but

re: Using an IDE on Wine?

2012-05-12 Thread Dan Kegel
I suspect most people don't use IDEs with wine. Someone recently posted how to use eclipse during debugging, though: http://www.winehq.org/pipermail/wine-devel/2012-April/095162.html

Re: winetricks DLL overrides

2012-05-10 Thread Dan Kegel
On Sat, May 5, 2012 at 9:26 PM, wy...@volny.cz wrote: winetricks settings alldlls=builtin further checking revealed, that winetricks(20120308) has several no longer available dll override compared to winecfg and some are missing, thus application uses them as native. So i add/del dlls from

Building 64 32 bit wine on Ubuntu 12.10?

2012-05-02 Thread Dan Kegel
What's the standard procedure for building both 32 and 64 bit wine together on Ubuntu 12.10? Sadly, it seems you can't install both 32 and 64 bit development files at the same time. And trying to use a 32 bit chroot is awkward because wine's build system tries to use the 64 bit makedep from

Wine developer example sessions?

2012-04-27 Thread Dan Kegel
I'm bringing a new intern up to speed, and while I was showing him how to diagnose one particular wine bug, I recorded the session on a web page, http://kegel.com/wine/bug30486.html It occurred to me that recorded sessions like that might be useful to other beginners (above and beyond the more

Re: Wine developer example sessions?

2012-04-27 Thread Dan Kegel
On Fri, Apr 27, 2012 at 1:35 PM, Lucas Zawacki lfzawa...@gmail.com wrote: When I first started to learn about wine development I stumbled across some examples exactly like these in the wine wiki. A quick search reveals them (the first 3)

qemu still can't run x86 wine

2012-04-05 Thread Dan Kegel
http://wiki.winehq.org/ARM says commands like $ qemu-i386 /usr/local/qemu-i386/wine/bin/wine /usr/local/qemu-i386/wine/c/Program\ Files/putty.exe used to work, but doesn't anymore. I gave it a shot anyway, just trying to run x86 apps inside wine inside qemu: wget

  1   2   3   4   5   6   7   8   9   10   >