Re: Ecco Pro hangs when accessing 2nd level dialogs

2006-06-04 Thread Detlef Riekenberg
Hi Don. I'm a long-time programmer with good (if rusty) knowledge of C/C++ and Unix, just getting up to speed on Linux. I'm at the point where I might be willing to tackle this myself, if the learning curve isn't too steep. Great, that you want to help wine. Did you already got some

Re: winspool: [3/3] Add GetPrintProcessorDirectoryA

2006-06-02 Thread Detlef Riekenberg
Am Freitag, den 02.06.2006, 11:30 +0200 schrieb Alexandre Julliard: Detlef Riekenberg [EMAIL PROTECTED] writes: +if (ret) { +needed = WideCharToMultiByte( CP_ACP, 0, InfoW, -1, (LPSTR)Info, cbBuf, NULL, NULL); +if (pcbNeeded) *pcbNeeded = needed; +ret

Re: How are we doing? (documentation + regression tests)

2006-06-02 Thread Detlef Riekenberg
Am Freitag, den 02.06.2006, 08:03 -0500 schrieb Jeremy White: But there are plenty of places in Wine where the code does something screwball or out of the ordinary (hell, the API itself is screwball), and those places deserve more comments. IMHO, more comment's help to teach someone, who read

Re: How are we doing?

2006-06-01 Thread Detlef Riekenberg
Am Donnerstag, den 01.06.2006, 11:45 +0200 schrieb Alexandre Julliard: During the Time, things changed and I get confused more and more times about special Developers and other Developers, as well as special Patches and other Patches. (It's also Possible, that i did not see the big

Re: winspool/tests: [1/3] Tests for GetPrintProcessorDirectory

2006-06-01 Thread Detlef Riekenberg
Am Donnerstag, den 01.06.2006, 11:15 +0200 schrieb Alexandre Julliard: Detlef Riekenberg [EMAIL PROTECTED] writes: +SetLastError(0xdeadbeef); +res = GetPrintProcessorDirectoryA(NULL, NULL, 1, NULL, 0, cbBuf); +if(!res ( (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED

Re: Text input box with scrollbar

2006-06-01 Thread Detlef Riekenberg
Am Dienstag, den 30.05.2006, 11:06 -0300 schrieb Augusto Arcoverde da Rocha: Hi all, Where I can find the inputbox drawing code? Some of these box appear with scrollbar when testing Action Request System application under Wine, but not under MS Windows. Might be: dlls/user/edit.c (edit

Re: winspool/tests: Use 0xdeadbeef as magic Value

2006-06-01 Thread Detlef Riekenberg
Am Montag, den 29.05.2006, 21:28 +1000 schrieb Jeff Latimer: A minor spelling mistake, deaddeef instread of deadbeef. Thanks for validating my Patch. And updated Check is already in the Tree :-) -- By By ... ... Detlef

Re: crypt32: implement CryptBinaryToStringA and CryptStringToBinaryA

2006-05-31 Thread Detlef Riekenberg
Hi Juan Lang. ChangeLog: implement CryptBinaryToStringA and CryptStringToBinaryA based on Kai Blin's base64 encoder/decoder The Functions are not Present in every crypt_32.dll. The test will crash on win9x. (The Results from GetProcAddress are not tested) -- By By ... ... Detlef

Re: How are we doing?

2006-05-31 Thread Detlef Riekenberg
Am Dienstag, den 30.05.2006, 00:17 +0100 schrieb Mike Hearn: Thanks a lot for starting this. As I'm connected with wine about a Year now, I give my comments / feeling here. (It's large, but i'm unable to Split ...) Questions to consider: * Is Wine improving or is the regression rate

Re: wineconsole: Store the font as a DWORD_PTR.

2006-05-31 Thread Detlef Riekenberg
Am Mittwoch, den 31.05.2006, 16:28 +0900 schrieb Mike McCormack: index 169f4e1..73a0987 100644 --- a/programs/wineconsole/dialog.c +++ b/programs/wineconsole/dialog.c +return GetWindowLongPtr(hWnd, 0); +HFONT hFont = (HFONT)GetWindowLongPtr(hWnd, 0L); Are 0 and 0L

writing 0xdeadbeef directly is the worst case we did

2006-05-27 Thread Detlef Riekenberg
Am Samstag, den 27.05.2006, 01:01 +0200 schrieb Andreas Mohr: I was using 0x00dead00 before, but Dmitry suggested 0xdeadbeef, as this is used in most Places in wine. First, then you should really write it as such... Second, why does it *ALWAYS* have to be 0xdeadbeef? It was 0x00dead00

Re: Picasa for Linux available!

2006-05-26 Thread Detlef Riekenberg
Am Donnerstag, den 25.05.2006, 18:50 -0700 schrieb Dan Kegel: Google has indeed been working on Picasa, and it's finally available for download at http://labs.google.com/ Great! On the Labs-Page, the first Entry is: New! Picasa for Linux Google's photo organizer now available for

Re: WRT failed to Build

2006-05-26 Thread Detlef Riekenberg
Am Mittwoch, den 24.05.2006, 20:24 +0200 schrieb Stefan Leichter: The cross-compiled WRT failed since 17. May. I have already send a patch to Paul, to fix the cross compiling, Many Thanks. but it looks like Paul is not at home. Let's wait for him together. -- By By ... ...

Re: Mac OS X Audio driver = wineaudio.drv

2006-05-25 Thread Detlef Riekenberg
Am Mittwoch, den 24.05.2006, 19:51 +0200 schrieb Emmanuel Maillard: This patch is the initial Audio Driver for Mac OS X, quiet big (contain all winecoreaudio dir) tell me if you want i split this in separated patches. The Flatten DLL Directories project (

WRT failed to Build

2006-05-23 Thread Detlef Riekenberg
Hi. The cross-compiled WRT failed since 17. May. The native WRT failed even longer. And Ideas? -- By By ... ... Detlef

Re: wininet: Space for current directory allocated from the heap

2006-05-22 Thread Detlef Riekenberg
Am Montag, den 22.05.2006, 16:02 -0500 schrieb Phil Lodwick: @@ -746,16 +746,21 @@ lend: BOOL WINAPI FtpGetCurrentDirectoryA(HINTERNET hFtpSession, LPSTR lpszCurrentDirectory, LPDWORD lpdwCurrentDirectory) Your mailer destroyed the Layout (Line-Wrap). I suggest to attach the File.

Re: widl: Added an option to set importlib search path.

2006-05-14 Thread Detlef Riekenberg
Hi Jacek: + -L path Set importlib searcg dir to path (multiple -L Small typo in tools/widl/widl.c: search -- By By ... ... Detlef

Might be useful for wine (DIB): 3D software renderer (LGPL)

2006-05-10 Thread Detlef Riekenberg
Hi Just found this on Freshmeat: -- cut -- VortexGE is a software 3D renderer for the X environment that was created without using OpenGL/MesaGL. It also supports 2D image manipulations and audio access and is intended for creating Linux games without needing 3D card acceleration. -- cut --

Re: winspool/tests: fix broken test for GetPrinterDriver (updated)

2006-05-01 Thread Detlef Riekenberg
Dmitry Timoshkov wrote: In the other cases, the value depends on the Default Printer. I have seen 213, 257, 294, 297, 319, 401 There is no Documentation, what the OS does with this Parameter when the Function failed. An absent documentation should not stop us from testing such

Re: winspool/tests: fix broken test for GetPrinterDriver (updated)

2006-04-30 Thread Detlef Riekenberg
Am Sonntag, den 30.04.2006, 11:57 +0900 schrieb Dmitry Timoshkov: +/* needed is modified in win9x. testing for needed == (DWORD)-1 will fail */ That's interesting, is there a pattern how win9x modifies it? + trace((%d) returned %d with 0x%08lx/%ld and 0x%08lx/%ld\n, level, +

Re: setupapi: Fix parsing of UCS-16 files

2006-04-26 Thread Detlef Riekenberg
Am Mittwoch, den 26.04.2006, 15:42 +0100 schrieb Robert Shearman: +if (*new_buff == 0xfeff) +new_buff++; .. new_buff, (WCHAR *)((char*)new_buff +size), error_line ); This points behind the End of the File-Mapping, when you skip the BOM. The Pointer to the End of the

Re: Fixing cross-compilation 1/2

2006-04-23 Thread Detlef Riekenberg
Am Sonntag, den 23.04.2006, 17:23 +0100 schrieb Paul Millar: The patch fixes an existing test within the autoconf configure.ac. Great to see, that WRT-Native is on the way to run again. This is a resubmission (no comment from previous submission) so please comment if its wrong! This Patch

Re: KERNEL: [2/2] changed test for FindFirstFileEx

2006-04-23 Thread Detlef Riekenberg
Am Samstag, den 22.04.2006, 18:05 +0400 schrieb Konstantin Petrov: patch for test No Patch attached. btw, the indention looks strange in your other Patch. -- By By ... ... Detlef

SOC: More Ideas

2006-04-20 Thread Detlef Riekenberg
Hi Some more Ideas for SOC: Printer-Dialogs: PrintDlgEx* is the Default Printing-Dialog since w2k, but we have only a stub. Some Apps fail to Print for that reason. A usable Implementation need to Support the Properties from the Application (Example from IE: Print actual Frame /

Re: RFC/PATCH: Twain + Gphoto

2006-04-18 Thread Detlef Riekenberg
Am Sonntag, den 09.04.2006, 21:16 +0200 schrieb Marcus Meissner: +EXTRALIBS = @SANELIBS@ @GPHOTO2LIBS@ It was ok for twain to fail, when sane was not installed. IMHO, when get more alternatives, then all backends must be usable independent (linked dynamic). We do not want to force libsane and

Re: Dmitry Timoshkov : winspool: Add a test for GetPrinterDriver, make it pass under Wine.

2006-04-14 Thread Detlef Riekenberg
Am Freitag, den 14.04.2006, 12:46 -0500 schrieb Alexandre Julliard: Author: Dmitry Timoshkov [EMAIL PROTECTED] Date: Fri Apr 14 22:34:57 2006 +0900 winspool: Add a test for GetPrinterDriver, make it pass under Wine. Thanks for working on winspool.drv, but i'm Sorry that I had not enough

Re: Comctl32: fix listview column resize [2/2] (resend)

2006-04-12 Thread Detlef Riekenberg
Mikołaj Zalewski wrote: When resizing the columns of a listview by dragging the header columns divider, the list columns resizes after every mouse move while the header only draws a tracking line and resizes when the mouse button goes up. These patches tries to fix it. The

setupapi.dll updated by reactos

2006-04-11 Thread Detlef Riekenberg
Hi. Hervé Poussineau (hpoussin) anounced today on #winehackers, that he did some updates (LGPL) on our setupapi.dll - codebase for reactos. So when you have an Installer / Application, that needs more from setupapi.dll, this hint my help. -- By By ... ... Detlef

Re: Makefile.in: Fix broken ctags/etags-targets

2006-04-08 Thread Detlef Riekenberg
Am Freitag, den 07.04.2006, 12:02 +0200 schrieb Alexandre Julliard: [EMAIL PROTECTED]:~/wine.cvs/bin$ etags --version Exuberant Ctags 5.5.4, Copyright (C) 1996-2003 Darren Hiebert Compiled: Aug 13 2004, 05:14:24 Addresses: [EMAIL PROTECTED], http://ctags.sourceforge.net Optional

Re: Makefile.in: Fix broken ctags/etags-targets

2006-04-07 Thread Detlef Riekenberg
Am Donnerstag, den 06.04.2006, 21:41 +0200 schrieb Alexandre Julliard: make etags and make ctags are broken. What's broken about them? - [EMAIL PROTECTED]:~/wine.cvs/bin$ make ctags find /home/detlef/wine.cvs/src -name '*.[ch]' -print | ctags --c-types= +px -L - - The file tags is

Re: Makefile.in: Fix broken ctags/etags-targets

2006-04-07 Thread Detlef Riekenberg
Am Freitag, den 07.04.2006, 10:38 +0200 schrieb Alexandre Julliard: [EMAIL PROTECTED]:~/wine.cvs/bin$ make etags find /home/detlef/wine.cvs/src -name '*.[ch]' -print | etags - etags: Unknown option: - make: *** [etags] Fehler 1 What's not broken about them? Well, it works fine here,

winspool: [1/2] implement EnumMonitorsW

2006-03-31 Thread Detlef Riekenberg
Our Tests will work, when both Patches are in the Tree Changelog: - winspool: implement EnumMonitorsW -- By By ... ... Detlef diff --git a/dlls/winspool/info.c b/dlls/winspool/info.c index 83ae8f7..3c70825 100644 --- a/dlls/winspool/info.c +++ b/dlls/winspool/info.c @@ -126,6 +126,14

Need Help for IniFileMapping

2006-03-30 Thread Detlef Riekenberg
Hi all. I need your Help to see, how IniFileMapping works on different NT-Versions. An updated kernel32_crosstest.exe, that prints a lot of informations and a detailed description is here: http://bugs.winehq.org/show_bug.cgi?id=4096 Thanks for your Help (IniFile is the redirection from

Re: advpack: Add initial tests for RunSetupCommand

2006-03-27 Thread Detlef Riekenberg
Am Donnerstag, den 23.03.2006, 23:12 -0600 schrieb James Hawkins: * Add initial tests for RunSetupCommand. dlls/advpack/tests/install.c | 106 Hi. Your tests used a fixed Path, resulting to failure on: - win95, win98 and winme (c:\windows\system)

Bugzilla: Duplicates (was: Known issues area on main wiki page)

2006-03-22 Thread Detlef Riekenberg
Tony Lambregts wrote: Tom Spear wrote: On 3/21/06, *Vitaliy Margolen* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: I sure hope all users will go look at this page first. But some how I don't think they will. When we getting _exact_ duplicates with the Keeping them around for a

wine dev packages (was: Can't run DirectX games on x86_64 Linux)

2006-03-12 Thread Detlef Riekenberg
Jason Green wrote: Correct, wine will compile and run without a lot of features and never warn you that they don't exist. See this wiki page for an example of what your include/config.h file should probably look like: http://wiki.winehq.org/Recommended_Packages I just added the Fedora Core

Re: [wininet] More wininet tests InternetQueryOption and InternetSetOption - 2

2006-03-03 Thread Detlef Riekenberg
Am Freitag, den 03.03.2006, 20:50 +0530 schrieb Vijay Kiran Kamuju: Changes made according to some suggestions Detlef, waiting for more - It took me a really long time to write the review, but you ignored almost everything I suggest, that you do what i did before sending patches to wine:

WRT: winetest-latest is outdated

2006-03-03 Thread Detlef Riekenberg
Hi. The latest Winetest-Binaries are outdated ( http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/?N=D ). Winetest (ELF) compiled again recently ( http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php ), but the crossbuilds are still missing. Is there anything that we can do for help? --

Re: [wininet] More wininet tests InternetQueryOption and InternetSetOption - Corrected

2006-02-26 Thread Detlef Riekenberg
Am Mittwoch, den 22.02.2006, 23:13 +0530 schrieb Vijay Kiran Kamuju: Any thing wrong with this patch. Any Comments (expecting a lot) As you asked me, i took a look on this Patch. For my winspool-Patches, i was told to check the documented behavior and only check undocumented behavior, when

Re: [PATCH] please commit this FCI work

2006-02-24 Thread Detlef Riekenberg
Am Freitag, den 24.02.2006, 14:28 +0100 schrieb Gerold J. Wucherpfennig: Please commit. I have no knowledge about fci, but some code is strange: +#define fci_set_error(A,B,C) \ +p_fci_internal-perf-erfOper = A; \ +p_fci_internal-perf-erfType = B; \ +p_fci_internal-perf-fError = C;

Want fun? Try qemu.exe on wine

2006-02-23 Thread Detlef Riekenberg
Hi. SDLVIDEODRIVER=windib wine qemu.exe -L . -hda reactos_0.2.8.img winefile starts inside reactos :-) -- By By ... ... Detlef

Re: Want fun? Run Windows XP on wine

2006-02-23 Thread Detlef Riekenberg
Am Donnerstag, den 23.02.2006, 17:34 +0100 schrieb Detlef Riekenberg: SDLVIDEODRIVER=windib wine qemu.exe -L . -hda reactos_0.2.8.img winefile starts inside reactos :-) Want more fun? Windows XP works also on wine (with qemu.exe) -- By By ... ... Detlef

Re: WineFile: [PATCH] Implement part of Save Settings to registry

2006-02-22 Thread Detlef Riekenberg
Am Montag, den 20.02.2006, 12:57 -0500 schrieb Jason Green: This patch adds the ability to save your window position to the registry when using winefile. +static const WCHAR registry_key[] = { 'S','o','f','t','w','a','r','e','\\', +

ntdll: Avoid commpile - Error, caused by a single Quote

2006-02-20 Thread Detlef Riekenberg
Am Dienstag, den 21.02.2006, 00:25 +0100 schrieb Stefan Leichter: current cvs does not build for me on SuSE 9.0 gcc -c -I../../../wine/dlls/ntdll -I. -I../../../wine/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+

ntdll: Avoid commpile - Error, caused by a single Quote

2006-02-20 Thread Detlef Riekenberg
Am Dienstag, den 21.02.2006, 00:25 +0100 schrieb Stefan Leichter: current cvs does not build for me on SuSE 9.0 gcc -c -I../../../wine/dlls/ntdll -I. -I../../../wine/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+

Re: Appdb thoughts

2006-02-15 Thread Detlef Riekenberg
Am Montag, den 13.02.2006, 21:48 -0800 schrieb Dan Kegel: 2) I often do quick testing of apps for obvious bugs (like crashes) without really getting to know the app, and I don't feel qualified to say much about the app; I just want to link a bug to it. I picked up your Dogfood-Challenge

riched20_crosstest.exe does not build (-lriched20)

2006-02-15 Thread Detlef Riekenberg
Hi. While testing for bug #4567 ( http://bugs.winehq.org/show_bug.cgi?id=4567 ): riched20_crosstest.exe does not Build: /usr/lib/gcc/i586-mingw32msvc/3.4.2/../../../../i586-mingw32msvc/bin/ld: cannot find -lriched20 Is this the same Problem for winetest-latest.* still dated 10.Feb ? -- By By

winspool/tests: Add tests for EnumMonitors()

2006-02-15 Thread Detlef Riekenberg
Am Mittwoch, den 08.02.2006, 22:36 +0100 schrieb Detlef Riekenberg: Changelog: - Add tests for EnumMonitors() http://www.winehq.org/pipermail/wine-patches/2006-February/024171.html Anything wrong with this? (Still apply and works on wine-0.9.8) -- By By ... ... Detlef

winspool: EnumMonitorsA/W implemented

2006-02-15 Thread Detlef Riekenberg
Am Mittwoch, den 08.02.2006, 23:33 +0100 schrieb Detlef Riekenberg: Changelog: - EnumMonitorsA/W implemented - Registry-Entry for Local Port added (NT) Return the Monitor-Entry for Local Port also, when the dll failed to load (we do the work of localspl.dll in our winspool.drv) http

Re: Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

2006-02-15 Thread Detlef Riekenberg
Hi all * Vijay Kiran Kamuju [EMAIL PROTECTED] [15/02/06, 09:06:42]: Im not the one who actually designed secur32 ;) :P I know. If i did anything worng please correct me. nothing wrong. You do a great job for wine, as all Developer do. I think this was more like a general rant against the

Re: Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

2006-02-15 Thread Detlef Riekenberg
Hi all static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG, PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp) We all should thank the People who did such a Design :-) However, this only

Re: DSOUND bugs

2006-02-14 Thread Detlef Riekenberg
Am Montag, den 13.02.2006, 10:44 -0700 schrieb Jesse Allen: I'm really wondering why nobody has fixed the DSOUND buffer underrun bugs.. err:dsound:DSOUND_MixOne underrun on sound buffer 0x7fda2038 The problem is known. It has to do with wine, increasing thread priority, and linux kernel.

Small and Fast (was: Re: Add InitializeSecurityContext for schannel)

2006-02-14 Thread Detlef Riekenberg
Am Dienstag, den 14.02.2006, 17:34 +0530 schrieb Vijay Kiran Kamuju: Add InitializeSecurityContext for schannel in secur32.dll +static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( + PCredHandle phCredential, PCtxtHandle phContext, SEC_WCHAR *pszTargetName, + ULONG fContextReq,

Re: gethostbyname call with 0 length arg

2006-02-08 Thread Detlef Riekenberg
Am Freitag, den 03.02.2006, 19:23 +0100 schrieb Christer Palm: if((!name) (name[0])) { Do you really mean that? if name is 0, then dereference name? No. the code is: if name is not NULL, then dereference name -- By By ... ... Detlef

Re: gethostbyname call with 0 length arg

2006-02-08 Thread Detlef Riekenberg
Am Samstag, den 04.02.2006, 00:59 +0100 schrieb Phil Goss: This is what seems to have worked for me if(!name || !strlen(name)) { strlen() is overkill here, because you do not need the real length of the string. So !name[0] (or !*name) instead of !strlen(name) is more efficient, when you want

Re: VC++ demangling tool

2006-02-08 Thread Detlef Riekenberg
Am Dienstag, den 07.02.2006, 22:48 +0100 schrieb Michael Stefaniuc: Why not make winedump a Wine app Please do not do that. winedump now works on windows without an wine-specific dll. -- By By ... ... Detlef

Re: Implement DVD_ReadStructure

2006-02-08 Thread Detlef Riekenberg
Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: ChangeLog: Implement DVD_ReadStructure --- /dev/null 2006-02-03 18:20:42.451563144 +1100 +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.0 +1100 Please use include/ddk/ -- By By ... ... Detlef

Re: gethostbyname call with 0 length arg

2006-02-01 Thread Detlef Riekenberg
Am Sonntag, den 29.01.2006, 14:46 +0100 schrieb Phil Goss: There seems to be a check in the gethostbyname for a NULL arg name ... if(!name) ... But no check for ... if(!strlen(name)) Alexandre changed strlen(xxx) 0 in my first Patch to xxx[0] So for your code above, simple change:

Re: Repackaging Mozilla ActiveX control to include MSVCP60.DLL? [FIXED]

2006-02-01 Thread Detlef Riekenberg
Am Sonntag, den 29.01.2006, 14:08 +0100 schrieb Jonathan Ernst: Jonathan, what software do you use, if you don't mind revealing? :-) It's Evolution 2.4.2.1, pretty good e-mail client if you ask me. Evolution 2.2.1.1 here and i had a similar problem with my Patches: I used UTF-8 in as the

Re: advpack/tests: fixed failure, when ProgramFilesDir is != C:\Program Files [resend]

2006-02-01 Thread Detlef Riekenberg
Am Sonntag, den 29.01.2006, 10:25 +0100 schrieb Stefan Leichter: anything wrong with this patch ? Already in the tree: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=c824e8bc5b5c2bfcf56a04fe92f7f7bfe8ac1379 -- By By ... ... Detlef

DLL Help Database on microsoft.com

2006-01-29 Thread Detlef Riekenberg
Just found the DLL Help Database (with Details on Product, Version, Exports, Dependencies) on microsoft.com. General Search: http://support.microsoft.com/dllhelp/ Search a dll by Filename (Language is en_US): http://support.microsoft.com/dllhelp/?dlltype=filel=55S=1alpha= You can add the

Re: advpack tests

2006-01-19 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 23:42 +0100 schrieb Stefan Leichter: this patch should fix http://test.winehq.org/data/200601171000/xp_dr.ie6/advpack:advpack.txt and http://test.winehq.org/data/200601171000/xp_alx-winxp-17-jan-2k6/ advpack:advpack.txt but i can not test it myself because

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. Why do you need to output the version tested? I have a partial implemented

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Mittwoch, den 18.01.2006, 13:28 -0600 schrieb James Hawkins: There is one case where I think it's leaning towards the OK side, though it still bugs me, and that is the advpack:GetVersionFromFile tests. This test is in the wrong File (file.c and tests/advpack.c). There's really no way

winspool/tests: a Space before the printername is invalid

2006-01-17 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 13:08 -0600 schrieb Wine Bugs: --- Additional Comments From [EMAIL PROTECTED] 2006-17-01 13:08 --- And to make it complete, space before printer name in customized printing dialog is still present. (mayby small bug in ISS?) This Patch validates, that

winspool: What can I do to get my Patches into CVS?

2006-01-16 Thread Detlef Riekenberg
Hi. What can I do to get my Patches into CVS? 2006.01.07: http://www.winehq.org/pipermail/wine-patches/2006-January/023276.html Changelog: - winspool/tests: filter more results 2006.01.08: http://www.winehq.org/pipermail/wine-patches/2006-January/023284.html Changelog: - kernel/tests: report

Re: Starter projects for new Wine contributors?

2006-01-10 Thread Detlef Riekenberg
Am Montag, den 09.01.2006, 21:02 -0500 schrieb Al Tobey: I'm looking for suggestions for starter projects for new contributors that would take something like a week to do, and wouldn't require much knowledge of Wine ahead of time. Tests! Another way is: Fixing Tests, that currently fail

Re: ntdll/tests: Load test on win95 again

2006-01-10 Thread Detlef Riekenberg
Am Dienstag, den 10.01.2006, 20:14 +0100 schrieb Alexandre Julliard: - ntdll/tests: Load test on win95 again (kernel32,CreateWaitableTimerA not present) A better fix would be to avoid the call completely, the ntdll tests shouldn't need to use kernel32 functions. I asked the Author of

Re: winspool: Printing-Environment-Support for GetPrinterDriverDirectory

2006-01-06 Thread Detlef Riekenberg
Am Dienstag, den 03.01.2006, 00:51 +0100 schrieb Detlef Riekenberg: What can I do with this Patch ? Changelog: - Add Function validate_envW to validate the user-supplied Printing Environment (respect Windows Version - Setting) - Change GetPrinterDriverDirectoryW on top of validate_envW

Re: commit 15667b36e43a571f6bb8726b9dec4f1099d2b4f9 (_fullpath)

2006-01-06 Thread Detlef Riekenberg
Am Freitag, den 06.01.2006, 10:01 -0600 schrieb Aric Stewart: ChangeLog: Additional add a regression test for _fullpath dlls/msvcrt/tests/dir.c | 58 + +SetCurrentDirectory(C:\\Windows\\System\\); + Please do not use a fixed Path. This will not work on many Systems: nt351:

Re: winecfg: Problems with audio configuration

2006-01-06 Thread Detlef Riekenberg
Am Mittwoch, den 04.01.2006, 08:19 +0100 schrieb Michael Jung: It fixes the problem for me. Would be nice if this could go into CVS, even if it is just a hack. I guess it crashes on any Debian Sarge setup? Your patch is missing an ntdll import. I've attached an updated version. While

Re: PATCH: winspool.spec adjustments

2006-01-04 Thread Detlef Riekenberg
Am Mittwoch, den 04.01.2006, 18:40 +0100 schrieb Marcus Meissner: -noname is wrong here: +202 stub -noname [EMAIL PROTECTED] +204 stub -noname [EMAIL PROTECTED] winspool.drv from w2k export this Functions by name. (The Ordinal-Numbers are correct) -- By By ... ... Detlef

Switching from INI-Files (win9x) to Registry (NT)?

2005-12-18 Thread Detlef Riekenberg
Hi. With NT, Windows did a Switch from INI-Files to the Registry and use IniFileMapping for compatibility with win9x-Apps. (see http://bugs.winehq.org/show_bug.cgi?id=4096) Wine is using both Methods when settings are changed (more code), and this introduce bugs if a Setting-Target is missing:

Re: WinAPI testing inside a machine emulator

2005-12-11 Thread Detlef Riekenberg
Am Freitag, den 25.11.2005, 01:11 +0200 schrieb Saulius Krasuckas: BTW, how do you all folks think -- is it reliable approach to test WinAPI inside a machine emulator, like a QEmu? IMHO, only using Real Hardware for Regression-Test give us much less Results. machine emulators cannot

Re: [NDR] Implement NdrClientCall2 and NdrServerCall2

2005-12-11 Thread Detlef Riekenberg
Am Donnerstag, den 01.12.2005, 00:39 -0600 schrieb Robert Shearman: [NDR] Implement NdrClientCall2 and NdrServerCall2 [NDR] Fix handle support for stubless objects [NDR] Fix Accessing Arguments in NdrClientCall2 Hi Rob. I tested your Patches with printui.dll and winspool.drv (from w2k) and

Re: CVSROOT/. loginfo

2005-12-03 Thread Detlef Riekenberg
Am Freitag, den 02.12.2005, 21:00 +0100 schrieb Alexandre Julliard: Can we get the Module name and/or modified files added back to the subject line for CVS? IHMO, this is much more useful than knowing who submitted the patch. Well, I think having some description of what the patch is

Re: CVSROOT/. loginfo

2005-12-03 Thread Detlef Riekenberg
Am Samstag, den 03.12.2005, 13:43 +0100 schrieb Martin Fuchs: What about all three informations: a.) author b.) affected directory, like [dlls/ole32] c.) beginning of the changelog IMHO, best of all is starting with the affected directory and use the subject for c. Benefit: Simple sort by

winspool: GetPrinterDriverDirectory updated to NT/win9x (resend)

2005-12-01 Thread Detlef Riekenberg
Resend with suggestions from Alexandre: GetVersion() was used to often. - We do not Check for WIN32S. - For Win9x, we use the same Path as NT is using for Windows 4.0 (%winsysdir%\spool\drivers\win40) Changelog: - Add Function validate_envW to validate the user-supplied Printing

x11drv/winpos: Remove unused include (bug 3228)

2005-11-30 Thread Detlef Riekenberg
Fix for Bug 3228 (make failed with: X11/Intrinsic.h not found) Changelog: Remove unused include (X11/IntrinsicP.h) -- By By ... ... Detlef Index: dlls/x11drv/winpos.c === RCS file: /home/wine/wine/dlls/x11drv/winpos.c,v

winspool: comments for GetPrinterDriverDirectory updated please

2005-11-22 Thread Detlef Riekenberg
Hi. I ask for comments before sending this as 2 or 3 patches. - Correct 2 failing tests on win9x - Add Documentation for GetPrinterDriverDirectoryW/A (c2man) - Add Function validate_envW to validate the user-supplied Printing Environment (respect Windows Version - Setting) - Change

Re: ADVPACK/tests: exit after 0x8007007e

2005-11-22 Thread Detlef Riekenberg
Am Donnerstag, den 17.11.2005, 18:38 + schrieb James Hawkins: I have NT3.51sp5 with ie5.00 here. (qemu) Tell me, what you want to be tested. Can you run the advpack test after applying and compiling the following patch? Just send back the output. advpack.dll is not present on NT 3.51

Re: Visual changes after running tests

2005-11-21 Thread Detlef Riekenberg
Am Sonntag, den 20.11.2005, 17:02 +0100 schrieb Paul Vriens: with the latest winetest suite I've noticed the following changes: Thanks for writing this first. - On win98 my taskbar get's twice the size it used to be. Same here on win98se - On win98/winxp the window border is a lot thicker.

Re: Thread tests failure on Windows

2005-11-18 Thread Detlef Riekenberg
Am Freitag, den 18.11.2005, 02:51 +0200 schrieb Saulius Krasuckas: strange enough is the fact, that some win98s don't crash. [2] maybe that are those which runs under Qemu emulator? (w98.ie50.dx61 and w98.ie6.dx81) qemu is correct. -- By By ... ... Detlef

Re: ADVPACK/tests: exit after 0x8007007e

2005-11-17 Thread Detlef Riekenberg
Am Mittwoch, den 16.11.2005, 23:31 + schrieb James Hawkins: same way later. I guess, this is because of NT3.51 unability to parse usual INF-files. Log message: Saulius Krasuckas [EMAIL PROTECTED] Exit test after first TranslateInfString() failure, which seems to

Compilerflags for Bogus code

2005-11-16 Thread Detlef Riekenberg
Hi GCC did not warn us on this bogus code (dlls/user/tests/monitor.c): ret = EnumDisplayDevicesA(NULL, num, dd, 0), EnumDisplayDevices fails \n; This Line is in CVS since 28 Sep.2005 Should we have stronger Compiler-Flags? Patch already send.

RE: Question about ~/.wine/dosdevices/

2005-11-13 Thread Detlef Riekenberg
Am Sonntag, den 13.11.2005, 23:53 +0100 schrieb Peter Berg Larsen: Ah, ah. This is where I complete fail in my understanding. I had the idea that wine was able to run any window program (modulo registry etc.) no matter how I did the install. This is TRUE, but that depends on the Program!

Re: Measuring Wine's API completeness

2005-11-12 Thread Detlef Riekenberg
Am Samstag, den 12.11.2005, 01:52 + schrieb James Hawkins: need to change c2man to parse the FIXMEs at the beginning for the word 'stub' or 'semi-stub'. They are already in most functions, and it would be beneficial to add them to the rest. I have seen most stubs at the end of the

Re: Needs some guidance (aclui/netapi32)

2005-11-12 Thread Detlef Riekenberg
Am Freitag, den 11.11.2005, 14:02 -0600 schrieb Robert Shearman: How critical is fixme:ole:RPCRT4_NdrClientCall2? Probably quite critical in this case and in most cases. At some point in the future I will send a patch to implement that function. Great Idea!

Re: comctl32: doc update

2005-11-12 Thread Detlef Riekenberg
Am Samstag, den 12.11.2005, 07:39 +0100 schrieb Markus Amsler: Documented Total count is now 100%! Changelog: Markus Amsler [EMAIL PROTECTED] Reformate see section, to match c2man requirements. No Patch present :-) -- By By ... ... Detlef

tools/wine.inf (was: wine/programs/winecfg)

2005-10-28 Thread Detlef Riekenberg
Am Freitag, den 28.10.2005, 04:38 -0500 schrieb Alexandre Julliard: ChangeSet ID: 20901 CVSROOT: /opt/cvs-commit Module name: wine Changes by: [EMAIL PROTECTED] 2005/10/28 04:38:11 Modified files: programs/winecfg: appdefaults.c Log message: Vitaliy Margolen

Re: [TRY5] printer dialog fixes part1 + french + other rcs

2005-10-27 Thread Detlef Riekenberg
Am Donnerstag, den 27.10.2005, 15:22 +0200 schrieb Jonathan Ernst: Try4:Of printer dialog patch, with changes suggested by detlef Try5:Update RCs for other languages that are not two old (the remaining rcs are way too old to be updated with this patch) Sorry, same failure again. In Try 4

Re: bugzilla mass mods

2005-10-27 Thread Detlef Riekenberg
Am Donnerstag, den 27.10.2005, 11:23 +0200 schrieb Jonathan Ernst: I don't think that having ~800 bugs marked as fixed since years was useful. Just for your Info: My account was flooded, because my free Mail-Account has a Limit for the number of Mail's and the total Size. Not very nice.

Re: Shell32 File Property dialog

2005-10-23 Thread Detlef Riekenberg
Am Freitag, den 14.10.2005, 13:28 +0200 schrieb Johannes Anderwald: I have a patch which adds file property dialogs to shell32 Welcome to wine. Your Idea is nice and many Thanks for your Wine-Support, but since wine is different from ReactOS, your Patch will not work here. I started half a

Re: Final call for bug fixes (insert , after DEL)

2005-10-22 Thread Detlef Riekenberg
Am Freitag, den 21.10.2005, 15:09 +0200 schrieb Alexandre Julliard: So if you have bugs that you feel must be fixed for 0.9 (and that can be fixed with minimal changes), now is the time to speak up... Has someone a fix for the DEL-Key while NumLock is active - Problem? (inserting a , after

Re: wine / Linux kernel interaction

2005-10-21 Thread Detlef Riekenberg
Am Freitag, den 21.10.2005, 10:47 +1000 schrieb Troy Rollo: On Thu, 20 Oct 2005 17:15, Damjan Jovanovic wrote: Because the scanner, like too many others, is unsupported by SANE. Which scanner? Lexmark x5130 http://www.sane-project.org/unsupported/lexmark-x5130.html -- By By ...

version: updated trace for VERSIONED_PRINTER (v3)

2005-10-21 Thread Detlef Riekenberg
Changelog: - updated trace to support VERSIONED_PRINTER This time without deleting the TRACE for the flags. Informations on the Web: Specifying Printer Driver Version Numbers

Re: [TRY3] printer dialog fixes part1 + french

2005-10-11 Thread Detlef Riekenberg
Am Dienstag, den 11.10.2005, 10:36 +0200 schrieb Jonathan Ernst: -- cut -- + +EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 2, NULL, 0, needed, num); +if(num == 0) +{ + -- cut -- Sorry that didn't work. You receive in num the Number of returned PRINTER_INFO_2 Entries in buffer Since

Re: Bugzilla administration policies

2005-10-11 Thread Detlef Riekenberg
Am Dienstag, den 11.10.2005, 12:48 +0200 schrieb Francois Gouget: And since components might be a better match than keywords for some tasks, I will just mention that like keywords they are not freetext, they are clearly displayed in the GUI, and have a page describing them

wineprefixcreate - localization (Re: Office97 Install issue)

2005-10-09 Thread Detlef Riekenberg
Am Montag, den 12.09.2005, 19:32 +0200 schrieb Detlef Riekenberg: Am Montag, den 12.09.2005, 02:38 -0400 schrieb Steven Edwards: See Also: wineprefixcreate is fixed to c:\windows and english Names: http://bugs.winehq.org/show_bug.cgi?id=2844 If you still have your modified

Re: wcmd unusable when DISPLAY not set. Again.

2005-10-07 Thread Detlef Riekenberg
Am Montag, den 03.10.2005, 17:40 +0200 schrieb Alexandre Julliard: So I think we just should switch defaults to a nulldrv, but let the ttydrv lives here and waits for a better times. Please. Why? It's really an empty skeleton at this point, all it does is mess up the screen and dump

<    1   2   3   4   5   6   >