On Sun, Sep 29, 2013 at 11:10 PM, Daniel Jeliński djelins...@gmail.comwrote:
2013/9/30 Nikolay Sivov bungleh...@gmail.com
On 9/30/2013 00:51, Daniel Jeliński wrote:
+struct progress_list {
+const DWORD progress_retval_init; /* value to return from progress
routine */
+const
Hi Ben, thanks for having a whack at this.
Some tests would be nice.
-static HCERTCHAINENGINE CRYPT_defaultChainEngine;
+/* There are two default chain engines which correspond to
HCCE_CURRENT_USER and
+ * HCCE_LOCAL_MACHINE.
+*/
+static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL,
Hi George,
On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos
gaf.stepha...@gmail.comwrote:
I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel
free to comment.
So far, I've written code for all functions except for the RegEnum family.
General description:
HKCR
On Fri, Sep 6, 2013 at 9:17 PM, Charles Davis cdavi...@gmail.com wrote:
On Sep 6, 2013, at 5:01 PM, Juan Lang wrote:
On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis cdavi...@gmail.com wrote:
Maybe then the real fix is to make Wine accept either a constructor SET
or the custom tag
: PRINTABLESTRING :Juan Lang
31:d=2 hl=2 l= 1 prim: INTEGER :01
34:d=1 hl=2 l= 6 cons: SEQUENCE
36:d=2 hl=2 l= 2 prim: OBJECT:1.2.3
40:d=2 hl=2 l= 0 prim: NULL
42:d=1 hl=2 l= 96 cons: SET
44:d=2 hl=2 l= 0 prim: EOC
(a bunch
On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis cdavi...@gmail.com wrote:
Maybe then the real fix is to make Wine accept either a constructor SET or
the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for
either attribute set. I should come up with a test case first, though, to
[+wine-devel]
Hi Jacek,
I've added the list so the discussion can take place in public.
On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban ja...@codeweavers.com wrote:
I have a patch for crypt32. I'd appreciate your review before I submit
it to Wine. It has high potential to be insecure... This
Hi Andre,
-/* this is a io heavy test, do it at the end so the kernel doesn't
start dropping packets */
+/* this is a heavy io test, do it at the end so the kernel doesn't
start dropping packets */
To my eyes, this isn't an improvement. A slight improvement might be this
is a io-heavy
Hi Vincent, Pavel,
On Tue, Jul 2, 2013 at 8:44 AM, Vincent Povirk madewokh...@gmail.comwrote:
Since you're not prepared to spend a lot of time improving Wine's
driver support, it sounds like modifying core parts of Wine
specifically to support your application is the best approach.
An
On Fri, Jun 28, 2013 at 9:16 AM, Qian Hong fract...@gmail.com wrote:
Dear Juan,
Thanks for reviewing!
On Fri, Jun 28, 2013 at 11:31 PM, Juan Lang juan.l...@gmail.com wrote:
It's more in line with most C code to use !memcmp(...) instead of
memcmp(...)==0. I find it easier to scan, anyway
Hi George,
static void test_classesroot(void)
{
+static const WCHAR reg_user[] = {
'\\','R','E','G','I','S','T','R','Y','\\','U','S','E','R' };
+static const WCHAR reg_machine[] = {
'\\','R','E','G','I','S','T','R','Y','\\','M','A','C','H','I','N','E' };
Almost, but these have to
Hi George,
(consider subscribing to wine-devel so your emails don't get stuck in
moderation.)
On Sat, May 11, 2013 at 7:43 AM, George Stephanos
gaf.stepha...@gmail.comwrote:
As instructed, I added a few lines to the already written tests that
confirm my claim.
Part of the research of the
(consider subscribing to wine-devel so your emails don't get stuck in
moderation.)
Hmm but I am already!
Ok, that's strange. Maybe I just got it late.
I think Alexandre will object to using msvcrt functions (wcsncmp in this
case), but I don't have a straightforward alternative yet.
Hi Guo,
On Tue, May 14, 2013 at 1:32 PM, Guo Jian orz...@gmail.com wrote:
I just found that the REG_OPTION_VOLATILE of create_key in hkcr may
have some tricks. Not surprisingly found a strange situation when
testing on windows. See my test here please :
Hi Kaiyi Zhang,
(or is Zhang Kaiyi?)
I think there's a little misconception in your proposal. Bcrypt the
algorithm is not the same as the BCrypt functions in crypt32. I believe
that Microsoft redesigned their CryptoAPI and more or less renamed their
functions BCrypt*. I don't believe they have
In general, I think you want to send this to wine-patches, not here.
On Mon, May 6, 2013 at 12:26 PM, Max Kellermann m...@duempel.org wrote:
The first memcpy() call in puts_clbk_str_w() confuses character count
and byte count. It uses the number of characters (out-len) as number
of bytes.
On Tue, May 7, 2013 at 9:10 AM, Piotr Caban piotr.ca...@gmail.com wrote:
On 05/07/13 17:46, Juan Lang wrote:
In general, I think you want to send this to wine-patches, not here.
This patch was also sent to wine-patches.
On Mon, May 6, 2013 at 12:26 PM, Max Kellermann m...@duempel.org
Hi Guo Jian,
just so you know, there's another application for the same project. This
doesn't mean that yours can't be accepted, but it does impact your chances.
Thank you for your interest.
Good luck,
--Juan
On Fri, May 3, 2013 at 1:05 AM, orzhvs orz...@gmail.com wrote:
Hi.
I'm applying
Type it yourself. Refer to MSDN, public descriptions, and publicly
available headers, but don't copy/paste from any of them.
--Juan
On Wed, May 1, 2013 at 3:56 AM, Daniel Jeliński djelins...@gmail.comwrote:
It probably is, I downloaded it somewhere. Had to remove some stuff to get
it to
Hi George,
On Wed, May 1, 2013 at 8:14 AM, George Stephanos gaf.stepha...@gmail.comwrote:
Hello wine-devel!
This is my proposal as a student for Google Summer of Code 2013.
I'm George Stephanos from the Arab Academy for Science and Technology
situated in Egypt. gsteph on #winehackers
I'm
Hi Jacek,
On Sat, Mar 30, 2013 at 8:36 AM, Jacek Caban ja...@codeweavers.com wrote:
Most of the argument could be used against enabling TLS 1.1 and TLS 1.2,
because it's not present on older Macs (nor enabled by default on Windows),
so we'll have different behaviour. That's sadly something
Hi Jacek,
thanks for the detailed reply.
On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban ja...@codeweavers.com wrote:
Each protocol has two kinds of enable/disable flags: enabled and
disabled by default. Those have different default values for each
protocol and there are registry setting
On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases k...@codeweavers.com wrote:
On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote:
--- a/dlls/secur32/schannel_macosx.c
+++ b/dlls/secur32/schannel_macosx.c
@@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef
transport, const
On Fri, Mar 8, 2013 at 6:11 AM, Graham Knap graham.k...@gmail.com wrote:
Michael Stefaniuc wrote:
i.e. commit 8099c2b9. JW says ... to more closely resemble Windows
behavior. The key is to yield in a Sleep...
JW is Jeremy White so us old timers chuckle now ;)
I know the name, but
Hi Michael, this isn't actually a problem with your patch, just something I
spotted:
On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc mstef...@redhat.comwrote:
On 02/06/2013 11:16 PM, Austin English wrote:
On Feb 6, 2013 11:13 PM, Michael Stefaniuc mstef...@redhat.de
On Sat, Feb 2, 2013 at 5:05 AM, Marcus Meissner mar...@jet.franken.dewrote:
On Fri, Feb 01, 2013 at 03:48:27PM -0800, Juan Lang wrote:
On Fri, Feb 1, 2013 at 3:45 PM, Juan Lang juan.l...@gmail.com wrote:
Hi Marcus,
-add_oid_to_usage(usage, ptr);
+usage
Hi Marcus,
-add_oid_to_usage(usage, ptr);
+usage = add_oid_to_usage(usage, ptr);
This looks fine, but would you mind making the same change on line 337?
Thanks,
--Juan
On Fri, Feb 1, 2013 at 3:45 PM, Juan Lang juan.l...@gmail.com wrote:
Hi Marcus,
-add_oid_to_usage(usage, ptr);
+usage = add_oid_to_usage(usage, ptr);
This looks fine, but would you mind making the same change on line 337?
Actually, perhaps I hit sent too early
Hi Jacek,
just wanted to say these series of patches make me happy :)
lpfnHungarianNotationDieDieDie ;)
--Juan
Hi Kyle,
On Tue, Jan 15, 2013 at 8:10 AM, Kyle Auble randomidma...@yahoo.com wrote:
The one thing that would probably help a lot is if there was a regularly
updated tarball of the wiki content either at WineHQ or Lattica's FTP
again. I
haven't messed with cron itself much, but my
In case this was awaiting an ACK from me, this looks good. Thanks.
--Juan
Hi André,
On Wed, Jan 2, 2013 at 8:08 AM, André Hentschel n...@dawncrow.de wrote:
Hi,
FWIW i have just seen:
https://www.ssllabs.com/ssltest/analyze.html?d=testbot.winehq.orghideResults=on
https://www.ssllabs.com/ssltest/analyze.html?d=test.winehq.orghideResults=on
On Wed, Dec 12, 2012 at 12:32 AM, Hans Leidekker h...@codeweavers.comwrote:
On Tue, 2012-12-11 at 12:59 -0800, Juan Lang wrote:
Getting the client to trust the server cert can be as easy as ignoring
untrusted
root errors, if you don't think this impacts the revocation results.
Returning
On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker h...@codeweavers.comwrote:
On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote:
On 12/11/12 09:45, Hans Leidekker wrote:
https://testbot.winehq.org/JobDetails.pl?Key=23300 is a test which
shows that
revocation checks fail for the
On Tue, Dec 11, 2012 at 12:37 PM, Hans Leidekker h...@codeweavers.comwrote:
On Tue, 2012-12-11 at 11:52 -0800, Juan Lang wrote:
On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker h...@codeweavers.com
wrote:
On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote:
On 12/11/12 09
On Wed, Nov 7, 2012 at 3:22 AM, Dan Kegel d...@kegel.com wrote:
After gstreamer, gcrypt is also dropping support for alternative
thread libraries.
Good thing secur32/schannel_gnutls.c doesn't use it. (Right?)
Right.
If someone were motivated, we could begin to transition winhttp and
Hi Frédéric,
thanks for the patch. Allow me to elaborate:
On Tue, Nov 6, 2012 at 6:05 AM, Alexandre Julliard julli...@winehq.orgwrote:
Frédéric Delanoy frederic.dela...@gmail.com writes:
@@ -1520,8 +1521,8 @@ DWORD WINAPI GetIpAddrTable(PMIB_IPADDRTABLE
pIpAddrTable, PULONG pdwSize, BOOL
Hi Qian,
There is a winpcap based network authentication client which check for the
DhcpEnabled value, this patch make the app happy and then the app works with
André's pcap wrapper [1].
Please let me know if this is acceptable, or we have to correctly implement
DhcpEnabled status?
I
Hi Francois,
pretty sure you didn't mean to leave this hunk in:
@@ -2296,9 +2406,13 @@ START_TEST(shlexec)
init_test();
+#if 0
test_argify();
test_lpFile_parsed();
test_filename();
+#endif
+test_fileurl();
+#if 0
test_find_executable();
test_lnks();
Hi Jacek,
+ * that NaN value representation has 52 (almost) free bytes.
You mean bits, yes?
While you're at it,
+ * jsval_t structure is used to represent JavaScript dynamicaly-typed values.
dynamically is spelled with two l's.
Thanks,
--Juan
Hi Marek,
On Wed, Sep 12, 2012 at 2:57 PM, Marek Chmiel kcm...@gmail.com wrote:
Hello all,
over the summer I had a chance to complete the regression test suite
for the DSSENH cryptographic provider; thank you to those that helped
along the way. I am currently researching how to implement the
On Mon, Jun 4, 2012 at 2:19 AM, Piotr Caban piotr.ca...@gmail.com wrote:
On 06/02/12 13:35, m...@mtew.isa-geek.net wrote:
@@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal(
goto cleanup;
}
- FIXME(entry already in cache - don't know what to do!\n);
Hi André,
+#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT
+struct tcpstat tcp_stat;
+#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT
+struct tcp_stats tcp_stat;
+#endif
struct tcpstat tcp_stat;
I think you meant to remove the declaration outside of the #if.
--Juan
--Juan
From 728b013f2ca52de878dc65633a9c6cbcb1a9002c Mon Sep 17 00:00:00 2001
From: Juan Lang juan.l...@gmail.com
Date: Thu, 17 May 2012 15:55:16 -0700
Subject: [PATCH 2/7] Don't shadow a variable with a variable of a different
type
---
dlls/crypt32/tests/cert.c | 36
Hi Alexandre,
On Sun, May 27, 2012 at 6:22 AM, GOUJON Alexandre ale.gou...@gmail.com wrote:
Some tests call directly the function by its name (i.e. GetWindowsDirectory,
CreateFileA, CloseHandle...) while others declare a pointer to the function
(prefixing its name by 'p' and followed by a
Hi Alex,
first, thanks for taking the time to respond to feedback. Showing
responsiveness helps a great deal.
Next, on your patch: I'm trying to help you get this committed, so
this is meant to be constructive feedback.
+static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR
Hi Morten and Piotr,
I notice both of you are working on wininet's url cache. That's
great: it's largely bitrot, and has been for years. My question is,
what are you planning to fix? It seems like you're both running into
some of the same issues right now, and it would be nice if you could
Hi Roger,
On Mon, Apr 2, 2012 at 10:41 AM, Roger Cruz roger_r_c...@yahoo.com wrote:
I'm looking for a way to determine programmatically what the arguments to a
Win32 API implemented in Wine are. I'm trying to implement an API
redirection stub that I can use to trace calls into all of the
Hi Marek,
On Tue, Mar 27, 2012 at 9:13 AM, M C kcm...@gmail.com wrote:
Hi everyone,
My name is Marek Chmiel, I am a student a NEIU. I am studying computer
science and network security related topics. This semester I had spent
a fair amount of time writing crypt related functions with java,
Hi Andrew,
one small contribution:
Winmm's timer functions use poll() with a timeout value, subtracting
the time elapsed curing the callback. This works quite well in dsound.
The Win32 API also provides the SetTimer API. But that depends on a
message queue, which is a hassle I don't know if
Hi Aidin,
On Mon, Feb 6, 2012 at 11:01 AM, Aidin Gharibnavaz ai...@aidinhut.com wrote:
SourceForge blocked download for some countries by default, such as Iran.
(More detail can be found here)
So, if it's not illegal to you to let Iranians download your software,
please go to the
Hi Hans,
hr = IXMLDOMNode_get_text( node, s );
IXMLDOMNode_Release( node );
-if (!strcmpW( s, product_code )) r = ERROR_SUCCESS;
-SysFreeString(s);
+if (hr == S_OK !strcmpW( s, product_code )) r = ERROR_SUCCESS;
+SysFreeString( s );
Is it really
Hi Erich,
On Tue, Jan 31, 2012 at 9:34 AM, Erich E. Hoover ehoo...@mines.edu wrote:
On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover ehoo...@mines.edu wrote:
On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang juan.l...@gmail.com wrote:
Sorry I didn't spot this earlier. Without this, someone who
Wow, I clearly didn't read that you moved the code over to
match_common_name. Apparently I'm not quite conscious today, my
apologies!
Clearly I wasn't quite conscious when I reviewed your patch in the
first place :) No worries, for security fixes lots of checking is
always worthwhile!
--Juan
Hi Erich,
On Fri, Jan 27, 2012 at 10:33 AM, Erich E. Hoover ehoo...@mines.edu wrote:
On Fri, Jan 27, 2012 at 11:16 AM, Austin English
austinengl...@gmail.com wrote:
...
Forgot the patch.
Thanks! I don't know how I missed that, apparently I'm blind today.
surely this needs a test. Ping me
Hi Daniel,
On Mon, Jan 23, 2012 at 3:15 AM, Alexandre Julliard julli...@winehq.org wrote:
Daniel Santos danielfsan...@att.net writes:
I've updated my in-process wineserver hack, cleaned it up a bit more and
fixed a few problems. So, at least in Star Wars Battlefront II, the
sound and HID
Hi Jason,
+ ME_InsertTextFromCursor(editor, 0, endlv10[0], 2, style);
you want to use endlv10 instead, i.e.:
+ ME_InsertTextFromCursor(editor, 0, endlv10, 2, style);
--Juan
This was deliberate - I did that originally and I got a compile warning as
one is const WCHAR * and one is const WCHAR[2] (Not sure if that error was
from a MSVC windows or Linux compile, but I was trying to avoid it, and a
typecast was a bit pointless as the above is accurate as well, isnt
Whats the difference between a typecast and var[0]?
I wasn't advocating for a typecast, merely admitting that we use them
from time to time.
What's the compile warning you're actually seeing on gcc? I don't
think we care what warnings are produced in MSVC.
--Juan
Hi Roland,
On Sun, Dec 18, 2011 at 6:46 AM, Roland Baudin rolan...@free.fr wrote:
Yes, I suspected such a mechanism. Now if I understand well I have to find
which one is the builtin mechanism and which one is the fallback
mechanism.
Is there some documentation around about the differences
On second thought, coverity would still complain even with the
TRACEs adapted, so I'll mark these defects as Ignored in Coverity
Does the attached patch address one of the Coverity complaints?
--Juan
From 13115c8ab68550b38f992eba04c9a05e88696f73 Mon Sep 17 00:00:00 2001
From: Juan Lang juan.l
Should the TRACE (e.g. on crypt32:2435) be adapted so it conditionally
prints the value instead? Or be removed altogether?
I'd prefer a conditional print if it's not too ugly. There haven't
been too many decoding bugs in a while, but the trace can sometimes
help identify them.
Thanks,
--Juan
can you be more specific please?
Yes:
+#ifndef __HTTP_H__
+#define __HTTP_H__
Don't do that, it's already #ifdef protected.
+/*#if _WIN32_WINNT = 0x0501*/
Dead code, just leave it out.
+typedef struct _HTTP_REQUEST_V2
+{
+/* TODO : anonymous structure is not supported by C standard */
+
Hi Arash,
I'm also concerned whether this was the product of copy/paste, which
isn't allowed. Was it?
about that copy/paste stuff,
well I guess we eventually produce an almost identical header file with one
in the SDK
I mean everything in the header file is already exposed to the user and
Hi Erich,
+ * Bind the given socket exclusively to a specific interface.
I know the style around here is to comment minimally, but I didn't
find it clear what the behavior of this function is. For one thing,
+static int interface_bind( int fd, struct sockaddr *addr )
(snip)
+int ret =
That's a lot of stuff. What needs it?
It's also obviously incorrect in places.
--Juan
Hi all,
in the tidy up I've been doing to iphlpapi, I notice that on Solaris
it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got
a patch written that does that, but I have no way to test it myself.
If anyone here has some version of Solaris with a machine with IPv6
addresses,
Hi folks,
right now iphlpapi uses autoconf to detect if getifaddrs is available,
and only uses it to enumerate IPv6 addresses.
I'm thinking of replacing the current IPv4 enumeration code, which
uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning
toward replacing, rather than adding
I'm thinking of replacing the current IPv4 enumeration code, which
uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning
toward replacing, rather than adding side-by-side with the current
code, is that getifaddrs is commonly available: it's available on all
recent versions of
Why? AFAIK getifaddr was added to at least openSolaris Last year and you
still can use the old Code as fallback
Yes, by keeping the current code I meant alongside a
getifaddrs-based implementation.
--Juan
Hi Bernhard,
nit:
-todo_wine
-ok(!ret GetLastError() == ERROR_INVALID_PARAMETER,
+todo_wine ok(!ret GetLastError() == ERROR_INVALID_PARAMETER,
This change is a no-op.
--Juan
Hi Joerg,
hr = IAudioClient_GetService(ac, IID_IAudioStreamVolume, (void**)out);
ok(hr == AUDCLNT_E_NOT_INITIALIZED, ... call returns %08x\n, hr);
todo_wine ok(broken(out != NULL), GetService %08x out pointer %p\n, hr,
out);
1. broken() documents that I consider native's observable
Hi Michael,
Not that I have any problems with our benevolent overlords, and not
that I would likely achieve franchise with a scant 2 patches under my
belt, but I can't help wondering how such a revolt would succeed
seeing as the only method to achieve franchise-hood is controlled by
the same
As I said, our overlords are kind and benevolent and I'm sure that the
mention of evil plans was simply a joke as such wise and noble
developers could need harbor a malevolent thought. But, unless I've
been misreading this mailing list, all patches have to go through our
current enlightened
OK but the purpose is to avoid checking the handle type for every line
read. Granted, one could use '((DWORD_PTR)h) 3 == 3' instead of
GetConsoleMode or similar function.
(there's currently code like BOOL is_console = GetConsoleMode(...);
...; while WCMD_fgets(..., is_console) and the handle
--Juan
From 544fb76b6da191c8e5c665be11357706acae9be0 Mon Sep 17 00:00:00 2001
From: Juan Lang juan.l...@gmail.com
Date: Thu, 22 Sep 2011 05:20:50 -0700
Subject: [PATCH 17/18] Test CertCreateCertificateContext, and fix an error code in a failure case
---
dlls/crypt32/cert.c |6
Hi Thomas,
wrong mailing list. You wanted wine-devel instead (now cc'ed.)
I don't know about wine development, but are these patches still likely to
work? What would need to happen for them to be merged in?
To your first question, try them and see! To your second question, a
lot. They're
Fix for bug 23287.
--Juan
From 1114085290c2ada360a02bae154b7167a0f2b0ca Mon Sep 17 00:00:00 2001
From: Juan Lang juan.l...@gmail.com
Date: Thu, 8 Sep 2011 11:10:08 -0700
Subject: [PATCH 2/2] Test/correct CertGetNameString with NULL pvTypePara
---
dlls/crypt32/str.c | 18 -
dlls
Hi Bruno,
The SIO_KEEPALIVE_VALS message on windows takes parameters as
miliseconds, on some other systems there are the equivalent
TCP_KEEPIDLE/TCP_KEEPINTVL which takes the parameters as seconds. To
solve this there is a division by 1000 on wine source code but the
problem is that values
just sent a patch doing that.
Looks good to me, thanks!
--Juan
Is the ProxyServer specified as an URL? If yes then use the proper API
to dissect the URL instead of cobbling something together.
Just to follow up in this idea, you could use InternetCrackUrl.
mshtml delay loads wininet, but it also loads urlmon, which also loads
wininet, so in effect wininet
Hi André,
http://domain\user:passw...@server.com:8080 makes it visible that it's
intended to get the last colon
What about http://domain\user:passw...@server.com? password isn't the
port number.
--Juan
I need to get the user configured path to Program Files/Common Files
to save the dinput action mapping settings.
What are the my options for doing this?
One way I found is the SHGetSpecialFolderPath function, but it
requires me to link to shell32 and I suspect there's a better way.
I
Hi William,
trace:chain:match_common_name CN = L*.battle.net\
warn:chain:match_domain_component domain component Lnet too short for
Lnet\
That CN is coming from the certificate.
Any thoughts or ideas on whether this is actually a bug and if so, how to
fix it?
It's partly a bug in
This Reserved1[0] is the DPC Time but I'm wondering what values from
/proc/stat to use here (remainder[0] is I/O wait). We could always make up
something of course but being accurate would be nicer.
DPC Time has no equivalent in /proc/stat. It's an NT thing. Making
something up is the only
I'd be interested if there's a space going free. We just get to send 2
mentors though as I understand it?
Yes. I'd be interested as well, that's why I started this thread. I've been
there already in 2009, so if anyone else wants to go I'd be happy to yield.
Whoever does go, I'll be happy to
Hi Michal,
please combine this with patch 3, it doesn't make sense on its own.
--Juan
Hi Jacek,
These are functions that I missed when revieweing Gecko headers. I will
probably change their calling convention in the next Gecko release.
In that case, why not change the calling convention now? The matrix
of possible configurations is much simpler that way.
Right now, we have:
BTW, the current plan is to do the new Gecko release together with Firefox 6
release, which is about 6 weeks from now. The first beta version should be
out in a week or two, depending on how Firefox beta will behave.
Then shouldn't the beta have the calling convention change anyway? In
this
Hi Christian,
this isn't quite what Alexandre meant. *What* did you fix? Saying
you did so isn't enough.
Thanks,
--Juan
Hi Keith,
WINE in general does many things, and you've got a big team now. Your
contributor list shows 1250 and you've got 2M lines of code.
Few of these contributors remain active. Most had small
contributions. The total number of contributors obviously can only
increase over time, but the
Hi Jay,
+HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){
Nit: the brace should be on its own line.
+HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN;
+HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN;
These two functions are never called in this patch, so you're
David is right, the address is not stored as a pointer but as a DWORD in
place of the chars. Like this:
gethostbyname(winehq.org):
wrong: (DWORD) host-h_addr_list[i] = 0x00cbd1c8 = 200.209.203.0
right: *(DWORD*) host-h_addr_list[i] = 0x86192ed1 = 209.46.25.134
Patch welcome ;)
--Juan
../../../dlls/netapi32/nbt.c:580:30: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
This is a false positive. h_addr_list is declared as a char **, and
technically it is, but gethostbyname only returns IPv4 addresses, i.e.
ones that can fit in a DWORD.
--Juan
This is a false positive. h_addr_list is declared as a char **, and
technically it is, but gethostbyname only returns IPv4 addresses, i.e.
ones that can fit in a DWORD.
That doesn't sound like a problem that would give that warning.
Why not? A cast of a pointer to a DWORD with 64-bit
Hi Lauri,
ok(pdst != NULL, inet_ntoa failed %s\n, dst);
-ok(!strcmp(pdst, addr0_Str),Address %s != %s\n, pdst, addr0_Str);
+ok(pdst !strcmp(pdst, addr0_Str),Address %s != %s\n, pdst, addr0_Str);
This change doesn't accomplish anything. In the first place, the
previous ok which you
It would be a lot easier to find and fix real things if there weren't a
thousand false ones hanging around. But if you feel it's better to have a
lot of warnings and some possible bugs than a lot of checks and no bugs,
then maybe I'll not waste any more time fixing them.
This is a false
Hi Patrick,
As this is quite a big amount of work, I would like to have some
guidance (what must I do to be sure it is accepted) so that I do not end
up doing all that for nothing - starting by knowing why my patch from
yesterday was not accepted (what did I do wrong).
The patch was marked
What's wrong with 'if (MachineName *MachineName)' ?
Nothing, it's my brain that's lacking. Thanks.
--Juan
Hi Adam,
perhaps I'm just being obtuse, but I don't see how Dmitry's comment
has been addressed for this patch. I'm confused by the commit comment
(Emulate Win9x if appropriate) and the change itself:
/* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile,
WinXP
1 - 100 of 1074 matches
Mail list logo
