On 09/11/2013 02:11 PM, Henri Verbeet wrote:
On 11 September 2013 12:09, Jacek Caban ja...@codeweavers.com wrote:
+typedef enum D3D11_RESOURCE_MISC_FLAG
+{
+D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001,
+D3D11_RESOURCE_MISC_SHARED =
On 08/30/2013 02:33 PM, matyapiro31 wrote:
I found many wine sources use not a pointer,but a sequence .
for example:
krnl386.exe16/dma.c:
for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];iret*size;i++)
msdaps/usrmarshal.c: for(prop = 0; prop
rgPropertySets[prop_set].cProperties; prop++)
I
Hello Nikolay,
On 08/27/2013 12:16 PM, Nikolay Sivov wrote:
+static OLEMISC get_olemisc_value(const WCHAR *str, int len)
+{
+int min, max;
+
+min = 0;
+max = sizeof(olemisc_values)/sizeof(struct olemisc_entry) - 1;
+
+while (min = max)
+{
+int n, c;
+
+
On 08/23/2013 03:39 PM, Rosanne DiMesio wrote:
I'm getting an Unable to connect message from Firefox and Connection
closed by remote server from Opera.
CC'ing Dimi as he might not read wine-devel so often.
bye
michael
On 08/16/2013 03:32 PM, Frédéric Delanoy wrote:
---
templates/en/cvs.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/templates/en/cvs.template b/templates/en/cvs.template
index 202cf60..300b9e4 100644
--- a/templates/en/cvs.template
+++
On 08/16/2013 04:42 PM, Tae Wong wrote:
Julliard said that it should feel free to provide a script that sorts
by last name.
You want to do this.
Careful. It is a trap. He is fine with it if it is done *right*.
Figuring out what the last name is is a hard problem.
bye
michael
On 08/16/2013 05:40 PM, Tae Wong wrote:
In the GIT tree, the AUTHORS file is sorted on first names.
Wrong.
It is sorted by the text line. The first word on the line can be the
first or lastname, depending what the author used.
bye
michael
On 08/16/2013 09:33 PM, Tae Wong wrote:
You have to manually update it by adding all authors from the GIT log.
The attachment is here at first message.
That one you did is not correct either:
- I see some Spanish double last names sorted by the 2nd one instead
of the first.
- In Dutch the
On 07/19/2013 01:40 PM, Marcus Meissner wrote:
On Thu, Jul 18, 2013 at 04:55:42PM -0500, Jeremy White wrote:
Alright folks, I have to confess that the 1.6 release came and I didn't
immediately get up and dance.
In fact, a new Wine release was almost...boring.
I think we have to consider
Original Message
Subject: Re: RFC: Three dots or Unicode ellipsis character
Date: Wed, 03 Jul 2013 19:32:15 +0200
From: Michael Stefaniuc mstef...@redhat.com
To: Francois Gouget fgou...@free.fr
On 07/03/2013 04:45 PM, Francois Gouget wrote:
Wine uses three dots
On 06/30/2013 11:29 PM, Ričardas Barkauskas wrote:
---
dlls/winex11.drv/opengl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
0001-winex11.drv-When-skipping-unknown-attribute-also-skip-.txt
diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c
index
On 06/26/2013 10:06 PM, Thomas Faber wrote:
On 2013-06-26 21:47, André Hentschel wrote:
The whitespace changes are bad, please don't do that.
Ok, I can take them out no problem.
Why's it bad though? I thought the rule was fix it while you're
working on it anyway.
Sure, fix the lines you
On 06/03/2013 10:36 PM, André Hentschel wrote:
On 03.06.2013 22:22, Alexandre Julliard wrote:
André Hentschel n...@dawncrow.de writes:
I haven't heard about NT4 been taking out of the requirement. I guess
the NT4 machines are offline due to the transition to the new testbot
On 05/16/2013 03:34 PM, Hugh McMaster wrote:
On Thursday, 16 May 2013
Rosanne DiMesio wrote:
On Thu, 16 May 2013 08:04:07 -0400
Hugh McMaster wrote:
My concern is with scenario (3). Wine is designed to be used with an X
server, but wineconsole can be used in non-X-based environment.
On 04/26/2013 05:54 AM, Sam Edwards wrote:
On 04/25/2013 12:28 PM, Alexandre Julliard wrote:
It doesn't work here:
../../../../wine/tools/runtest -q -P wine -M comctl32.dll -T ../../..
-p comctl32_test.exe.so
../../../../wine/dlls/comctl32/tests/listview.c touch listview.ok
wine: Unhandled
On 04/19/2013 12:43 AM, Austin English wrote:
With wine-1.5.20 and clang 3.2, the test suite is in the same state on
my Fedora 18 machine as gcc-4.7.2
llvm version: git-svn-id:
https://llvm.org/svn/llvm-project/llvm/trunk@179768
91177308-0d34-0410-b5e6-96231b3b80d8
clang version:
Hey Dimi,
the wiki is down:
puk is the wiki down?
puk it pings
puk but with high latency
puk and while port 80 connects a GET / doesn't returns
thanks
bye
michael
On 03/06/2013 07:10 PM, Graham wrote:
Alexandre wrote:
That's what the existing code already does.
Indeed. I don't know what I was thinking...
2. If you're about to block on select(), then I don't see any point in
preceding that with a call to sched_yield().
This was added for a reason;
Hello Joerg,
On 03/01/2013 10:22 AM, joerg-cyril.hoe...@t-systems.com wrote:
The idea to replace X * numerator / denominator
by X / den * mul + remainder from euclidian division
came from
http://blog.airsource.co.uk/index.php/2010/03/15/quelle-heure-est-il/
M. Stefaniuc suggested an inline
Hello Joerg,
On 02/27/2013 02:46 PM, joerg-cyril.hoe...@t-systems.com wrote:
The idea to replace X * numerator / denominator
by X / den * mul + remainder from euclidian division
came from
can you please use an inline function for that?
Thanks Juan,
On 02/07/2013 12:54 AM, Juan Lang wrote:
Hi Michael, this isn't actually a problem with your patch, just
something I spotted:
On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc mstef...@redhat.com
mailto:mstef...@redhat.com wrote:
On 02/06/2013 11:16 PM, Austin English
On 02/06/2013 11:16 PM, Austin English wrote:
On Feb 6, 2013 11:13 PM, Michael Stefaniuc mstef...@redhat.de
mailto:mstef...@redhat.de wrote:
---
dlls/iphlpapi/ipstats.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dlls/iphlpapi/ipstats.c b/dlls/iphlpapi
Forgot to add the credit for this patch series as I didn't wrote this
coccinelle script:
Found using the memcpy-assign.cocci script submitted for inclusion into
the Linux kernel:
https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html
bye
michael
On 01/24/2013 02:21 PM, Michael
On 12/11/2012 10:20 AM, Dmitry Timoshkov wrote:
Michael Stefaniuc mstef...@redhat.com wrote:
On 12/10/2012 07:37 PM, Amine Khaldi wrote:
This prevents the undefined behavior (null pointer dereference)
diagnostics (clang with ubsan checks for example).
This is a bug in clang
On 12/10/2012 07:37 PM, Amine Khaldi wrote:
This prevents the undefined behavior (null pointer dereference)
diagnostics (clang with ubsan checks for example).
This is a bug in clang. There is no null pointer dereference.
Afair gcc tried to pull this trick too but got educated about their error.
Hello Christian,
On 11/15/2012 09:43 AM, Christian Costa wrote:
Fixes bug 32185.
---
dlls/amstream/mediastreamfilter.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/dlls/amstream/mediastreamfilter.c
b/dlls/amstream/mediastreamfilter.c
index 9b2bd8e..d5388e5 100644
---
On 11/11/2012 03:00 AM, Max TenEyck Woodbury wrote:
I mentioned this a few days ago. It would have helped if you had
raised this point then.
I tried, but your email made no sense. You didn't even mention that
you're talking about COM interfaces.
As it stands, it is simply a way to adding data
On 11/11/2012 07:12 AM, Max TenEyck Woodbury wrote:
On 11/11/2012 01:01 AM, Nikolay Sivov wrote:
On 11/11/2012 05:00, Max TenEyck Woodbury wrote:
I mentioned this a few days ago. It would have helped if you had
raised this point then.
As it stands, it is simply a way to adding data members
You can't do that as the COM standard specifies also the ABI.
A COM interface is a pointer to a virtual table; it is *not* a struct.
That's just an implementation detail in C.
On 11/10/2012 08:48 PM, m...@mtew.isa-geek.net wrote:
From: Max TenEyck Woodbury max+...@mtew.isa-geek.net
---
On 11/08/2012 01:13 PM, Christian Costa wrote:
2012/11/8 Henri Verbeet hverb...@gmail.com mailto:hverb...@gmail.com
On 8 November 2012 00:22, Michael Stefaniuc mstef...@redhat.com
mailto:mstef...@redhat.com wrote:
But using just the capitalized letters from the name
On 11/08/2012 02:50 PM, Nikolay Sivov wrote:
On 11/8/2012 15:41, Michael Stefaniuc wrote:
On 11/08/2012 01:13 PM, Christian Costa wrote:
2012/11/8 Henri Verbeet hverb...@gmail.com mailto:hverb...@gmail.com
On 8 November 2012 00:22, Michael Stefaniuc mstef...@redhat.com
On 11/08/2012 03:44 PM, Christian Costa wrote:
2012/11/8 Michael Stefaniuc mstef...@redhat.com
mailto:mstef...@redhat.com
On 11/08/2012 01:13 PM, Christian Costa wrote:
2012/11/8 Henri Verbeet hverb...@gmail.com
mailto:hverb...@gmail.com mailto:hverb
On 11/07/2012 02:50 PM, Christian Costa wrote:
2012/11/7 Nikolay Sivov bungleh...@gmail.com mailto:bungleh...@gmail.com
On 11/7/2012 01:05, Christian Costa wrote:
Le 06/11/2012 22:38, Michael Stefaniuc a écrit :
On 11/06/2012 08:51 PM, Christian Costa wrote
On 11/06/2012 11:05 PM, Christian Costa wrote:
Sure, separate patch to remove the duplicate name is fine. Just start
with that as it makes the subsequent COM cleanup patch shorter as it
cleans up the function header (whitespace and LPJUNK).
That's what I try to do altough I don't clearly
On 11/07/2012 06:40 PM, Christian Costa wrote:
2012/11/7 Michael Stefaniuc mstef...@redhat.com
mailto:mstef...@redhat.com
On 11/07/2012 02:50 PM, Christian Costa wrote:
I didn't write this code and I don't like the current name either
but a
method name does not mean
On 11/06/2012 08:51 PM, Christian Costa wrote:
Le 06/11/2012 20:26, Nikolay Sivov a écrit :
On 11/6/2012 20:47, Christian Costa wrote:
What I also meant is these names are redundant, something like
directmusicloader_AddRef() is enough, of course you could use mixed
casing in names if you
On 10/24/2012 11:04 AM, Ken Thomases wrote:
On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote:
@@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename,
}
dir = (const CURSORICONFILEDIR*) bits;
-if ( filesize sizeof(*dir) )
-goto end
Hello Jörg,
On 10/24/2012 12:36 PM, joerg-cyril.hoe...@t-systems.com wrote:
I'm not happy with Wine's DSound+WinMM-mmdevapi. That may be a good
move for MS, but it's a bad move for Wine. Wine's audio drivers don't
what would you do instead? Go back to the old way and have dsound and
winmm
On 10/22/2012 11:21 AM, Henri Verbeet wrote:
On 22 October 2012 09:06, Rico Schüller kgbric...@web.de wrote:
On 19.10.2012 13:15, Nozomi Kodama wrote:
This patch adds tests for the patch sent by Rico for D3DXSHRotateZ.
Moreover, I changed const in CONST in the declaration of the function in
On 10/10/2012 10:42 AM, joerg-cyril.hoe...@t-systems.com wrote:
Hi,
David Laight wrote:
Better to code as:
status = wmm-dwStatus;
if (...)
Incidentally, that's what I did tonight in patch 20/25 try 2.
but even then I think the compiler is allowed to perform extra reads.
Hello Jörg,
as always it depends.
On 09/27/2012 09:37 AM, joerg-cyril.hoe...@t-systems.com wrote:
+#include assert.h
your patch is already committed, yet I believe that the least that dsound
needs is new asserts.
Asserts in dsound have been a PITA in Wine for the last decade.
It's ok
Hallo Alistair,
---
dlls/ole32/compobj.c |9 +
dlls/ole32/ole32.spec |1 +
2 files changed, 10 insertions(+)
diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c
index 0055d15..2ea1dc9 100644
--- a/dlls/ole32/compobj.c
+++ b/dlls/ole32/compobj.c
@@ -4279,6
Hello Charles,
On 09/18/2012 07:51 AM, Charles Davis wrote:
From: Charles Davis cda...@mymail.mines.edu
Contrary to what a novice C programmer might expect, when you declare an
array parameter to a function, what you actually get is a pointer.
Therefore, using sizeof() on the parameter will
After talking to Henri on irc, please ignore this patch. There are
patches out there to enumerate more devices than the primary one and
then the flags do play a role.
On 09/12/2012 11:08 PM, Michael Stefaniuc wrote:
---
dlls/ddraw/main.c |5 +
1 files changed, 1 insertions(+), 4
On 08/30/2012 06:05 PM, Jeremy Newman wrote:
On 08/29/2012 09:32 PM, Kyle Auble wrote:
just checked http://cvs.winehq.org and sure enough, there is still a
very outdated CVS repository there, but I can't find a template or a PHP
applet for it, just the same links you found (most in WWN
Hello Dmitry,
On 07/24/2012 08:01 AM, Dmitry Timoshkov wrote:
The patches in this series do not depend on each other, numeration is just
for a convenience. Patches do basically the same job for different objects,
so I decided to not invent a new subject for every separate kind of object.
---
On 07/02/2012 01:32 AM, Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
On 07/01/2012 12:12 AM, Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
Dmitry,
afair the fix is to disable the int truncation warnings in MSVC. For
whatever reason they seem to enable those bogus warnings.
bye
michael
On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote:
---
include/basetsd.h | 16
1 file changed, 8 insertions(+), 8
On 06/28/2012 01:00 PM, Dmitry Timoshkov wrote:
Michael Stefaniuc mstef...@redhat.com wrote:
afair the fix is to disable the int truncation warnings in MSVC. For
whatever reason they seem to enable those bogus warnings.
The warnings are not bogus, the PSDK compiler also emits a warning
On 06/28/2012 01:50 PM, Dmitry Timoshkov wrote:
Michael Stefaniuc mstef...@redhat.com wrote:
truncating from double to float while gcc keeps silence for instance.
I never looked at that but I assume the same holds true as above.
The following thread has some interesting details:
http
Argh!
Please skip this patch, it is incomplete and just skips the rest of the
tests on Wine. I'll resubmit it when I implement COM aggregation for
MediaDet. Patch 4/4 can be still applied as it doesn't depends on this.
bye
michael
On 06/26/2012 11:53 PM, Michael Stefaniuc wrote
On 06/27/2012 12:02 AM, Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
No qedit.dll on those two boxes.
Full results can be found at
Francois,
On 06/21/2012 04:21 PM, Francois Gouget wrote:
--- Network trouble
I'm having trouble getting the network to work fine in the QEmu VMs.
Eventually I discovered that if I bridged to eth0 then it's just the
communication between the host and the VM that does not work.
On 06/19/2012 10:47 AM, Dan Kegel wrote:
Nozomi wrote:
+for (i = 0; i order * order; i++)
I might have written
int n = order * order;
for (i=0; i n; i++)
to avoid repeating the multiplication every time around the loop,
even though multiplication is cheap nowadays, and -O1
Hello John!
On 06/15/2012 06:22 AM, John Emmas wrote:
Firstly, I'm not a Linux user. I'm a Windows programmer but I have a
passing knowledge of Linux (and several friends who are Linux
programmers). I write a Windows application which gets launched as a
child process by a popular Linux DAW.
On 06/13/2012 12:56 PM, Henri Verbeet wrote:
On 13 June 2012 10:41, Michael Stefaniuc mstef...@redhat.de wrote:
-object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object));
+object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
FIELD_OFFSET(struct wined3d, adapters[1
Hello!
On 06/11/2012 10:54 AM, Christophe-Marie Duquesne wrote:
To my understanding, wine is a reimplementation of the MS system. As
far as I understand, you take MS public headers and reimplement their
functions. If that is how it works, then how do you deal with
copyright? The MS headers
On 06/05/2012 08:53 AM, Max TenEyck Woodbury wrote:
The issue is access from linux native code to the .net
framework. That should require a specific decision on the
part of the system administrator to make it available. It is
that package that I believe is called 'mono'. I have taken
steps
Hello Aric,
On 05/18/2012 04:27 PM, Aric Stewart wrote:
diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c
index 5027e90..bac1b24 100644
--- a/dlls/quartz/avisplit.c
+++ b/dlls/quartz/avisplit.c
@@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl
*This,
On 05/16/2012 11:32 AM, Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
Hello Austin,
On 05/14/2012 08:01 AM, Austin English wrote:
diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index 6805c75..14fd01b 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML(
/* skip
On 05/14/2012 11:47 AM, Eric Pouech wrote:
while (*ptr)
if (isspaceW(*ptr)) ptr++; else break;
I do not mind terse code but that kinda overdoes it. I would put the
else on a separate line.
trafic on wine-devel is rather low those days
what about
On 04/17/2012 09:46 PM, Marcus Meissner wrote:
On Tue, Apr 17, 2012 at 09:10:45PM +0200, Christian Costa wrote:
Patch http://source.winehq.org/patches/data/85420 is marked as
pending. I've taken a look but I still don't understand what's
wrong.
Is there anything I've missed ?
I stopped
Hello Detlef,
On 04/15/2012 10:08 PM, Detlef Riekenberg wrote:
Used by apps to adjust the dialog position
or remove the cancel button before vista
--
By by ... Detlef
---
dlls/browseui/progressdlg.c | 69
++-
1 files changed, 68 insertions(+),
On 04/15/2012 10:04 PM, Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Yupp, test is incorrect. Stefan is looking at it.
bye
michael
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please
Hello Christian,
On 04/03/2012 07:53 AM, Christian Costa wrote:
+/*** IUnknown methods ***/
+static HRESULT WINAPI IAudioDataImpl_QueryInterface(IAudioData *iface,
REFIID riid, void **ppv)
+{
+AMAudioDataImpl *This = impl_from_IAudioData(iface);
+
+TRACE((%p/%p)-(%s,%p)\n, iface,
michael
--
Michael Stefaniuc Tel.: +49-711-96437-199
Consulting Communications Engineer Fax.: +49-711-96437-111
Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 Grasbrunn
Hello Christian,
On 03/29/2012 11:57 PM, Christian Costa wrote:
+HRESULT Direct3DRMMesh_create(REFIID riid, IUnknown** ppObj)
+{
+IDirect3DRMMeshImpl* object;
+
+TRACE((%p)\n, ppObj);
+
+object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(IDirect3DRMMeshImpl));
+
Alexandre,
On 03/28/2012 10:17 AM, Alexandre Julliard wrote:
Dmitry Timoshkov dmi...@baikal.ru writes:
It's very confusing, and absolutely not clear what is required from the
patch submitter, especially since *there is no any feedback on the patch*.
'Rejected' at least requies some sort of
Now that Alexandre is back and Jacek didn't want to beat me to it it is
time to finish my reply...
On 03/22/2012 01:06 AM, Henri Verbeet wrote:
On 22 March 2012 00:50, Michael Stefaniuc mstef...@redhat.de wrote:
-static HRESULT STDMETHODCALLTYPE d3d10_device_inner_QueryInterface(IUnknown
On 03/23/2012 07:50 PM, Lauri Kenttä wrote:
On 2012-03-22 00:36, Michael Stefaniuc wrote:
HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR
pVersion, DWORD cchBuffer, DWORD *dwlength)
{
- TRACE((%s, %p, %d, %p)\n, debugstr_w(pExe), debugstr_w(pExe),
cchBuffer, dwlength);
+ TRACE((%s
Hello Alex,
On 03/20/2012 05:17 PM, HolyCause wrote:
On 3/20/12 07:22, Maarten Lankhorst wrote:
Agreed, would like to add cmd parser to that list too.
~Maarten
Why is this? Does cmd sound like a bad project?
FWIW I was planning on improving cmd as my GSoC project, and I've talked
to Dan
On 03/19/2012 01:40 PM, prateek papriwal wrote:
http://wiki.winehq.org/FAQ#head-f566a12c806a1eacaeefb7cb6419a513a773c571 as
mentioned wine does not provide sandboxing at all but there can be some
wine users would like to prevent Windows apps from accessing unix system
so there is need for a
On 03/13/2012 12:42 AM, Christian Costa wrote:
Le 12/03/2012 20:32, Christian Costa a écrit :
Le 12/03/2012 21:02, Nikolay Sivov a écrit :
On 3/12/2012 21:52, Christian Costa wrote:
They are displayed as a single space in a text editor but visible
with an hex editor.
I guess this is a
Hello Joerg,
On 03/13/2012 03:05 PM, joerg-cyril.hoe...@t-systems.com wrote:
Maarten's wine-pulse contains several instances of assert()
I've been thinking about adding a bit of protection against
inconcsistencies within mmdevapi code too.
There are two variants that could be applicable
On 03/08/2012 05:40 PM, André Hentschel wrote:
Hi,
I cross-compiled a simple Application with the preview of MSVC 11 to ARM.
After some minor changes to Wine i was able to run it on my Pandaboard using
the native msvcr110.dll.
One thing i noticed in the cross-compile environment is that
On 03/08/2012 05:54 PM, André Hentschel wrote:
Am 08.03.2012 17:52, schrieb Michael Stefaniuc:
On 03/08/2012 05:40 PM, André Hentschel wrote:
Hi,
I cross-compiled a simple Application with the preview of MSVC 11 to ARM.
After some minor changes to Wine i was able to run it on my Pandaboard
Hello Francois,
On 03/01/2012 03:07 AM, Francois Gouget wrote:
---
A real Mac OS X implementation would be nice but barring that it seems
better to do nothing than to create .desktop files and directories that
make no sense on Mac OS X.
programs/winemenubuilder/winemenubuilder.c |
joerg-cyril.hoe...@t-systems.com wrote:
Alexandre Julliard wrote:
Please stop abusing goto, write a proper loop instead.
No problem. The idea was to minimize the patch and show what really changed.
Adding a while loop will indent all 120 lines of code in between { }.
See that as an opportunity
joerg-cyril.hoe...@t-systems.com wrote:
Michael Stefaniuc wrote:
See that as an opportunity to clean up the whitespace issues in those 120
lines ;)
Hmm, what was the latest word on reformatting, if any?
Until now I've been careful to preserve the surrounding formatting, even
Though winmmmci
Vitaliy Margolen wrote:
Please don't! I want my window manager decide based on how I configured
it where to position new windows. And not every program open in the
middle of the screen just because it things it's the most important
thing on my screen.
Uh? At the moment it always opens in the
Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=16849
Your
Hello Frédéric,
the patch is wrong.
Frédéric Delanoy wrote:
---
po/ro.po |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/po/ro.po b/po/ro.po
index a0912c2..c9375c4 100644
--- a/po/ro.po
+++ b/po/ro.po
@@ -11803,11 +11803,11 @@ msgstr Bază
#:
Francois Gouget wrote:
On Tue, 7 Feb 2012, Michael Stefaniuc wrote:
[...]
#: regedit.rc:282
msgid Hexadecimal
-msgstr Hexadecimal
+msgstr
#: regedit.rc:283
msgid Decimal
-msgstr Decimal
+msgstr
Those aren't untranslated but the Romanian words match the English ones.
Are you
: Michael Stefaniuc mstef...@redhat.de
Date: Wed, 1 Feb 2012 14:45:25 +0100
Subject: winealsa.drv: Clean up the sound card name retrieval code.
Fixes a memleak found by Valgrind.
---
dlls/winealsa.drv/mmdevdrv.c | 28
1 files changed, 16 insertions(+), 12 deletions
this strdup solution
ugly in his previous try. Luckily Michael Stefaniuc sent a finer patch
#83376.
Still not good enough. But at least we forced Alexandre to fix it himself ;)
bye
michael
Hello Joerg,
On 01/30/2012 09:46 AM, joerg-cyril.hoe...@t-systems.com wrote:
thank you very much for finding a bug in my code.
I'll have to meditate signed/unsigned conversions for the next months.
Perhaps it's my lack of familiarity with the MS-Windows API that had
me not find a signed
Frédéric Delanoy wrote:
2012/1/18 Francois Gouget fgou...@free.fr:
On Wed, 18 Jan 2012, Frédéric Delanoy wrote:
On Wed, Jan 18, 2012 at 10:12, Francois Gouget fgou...@free.fr wrote:
The sample text does not depend on the dialog language but on the scripts
supported by the font. As such
On 01/17/2012 05:44 PM, Andrew Eikum wrote:
On Tue, Jan 17, 2012 at 01:53:10AM +0100, Michael Stefaniuc wrote:
@@ -901,10 +895,11 @@ HRESULT IDirectSoundBufferImpl_Create(
TRACE(Created buffer at %p\n, dsb);
dsb-ref = 0;
+dsb-refiks = 0;
dsb-numIfaces = 0;
dsb
joerg-cyril.hoe...@t-systems.com wrote:
Hi,
Michael Stefaniuc wrote:
static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer
+if (pUnk) {
+WARN(invalid parameter: pUnk != NULL\n);
+/* *lplpDSCaptureBuffer = NULL; Not done by native dsound */
+return
Hello Joerg,
and addendum inline
Michael Stefaniuc wrote:
joerg-cyril.hoe...@t-systems.com wrote:
Michael Stefaniuc wrote:
static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer
+if (pUnk) {
+WARN(invalid parameter: pUnk != NULL\n);
+/* *lplpDSCaptureBuffer
On 01/09/2012 09:42 PM, André Hentschel wrote:
Am 08.01.2012 20:02, schrieb Nikolay Sivov:
On 1/8/2012 20:47, André Hentschel wrote:
---
dlls/d3drm/frame.c | 11 +++
dlls/d3drm/tests/d3drm.c | 16
2 files changed, 15 insertions(+), 12 deletions(-)
On 12/08/2011 01:16 PM, Dmitry Timoshkov wrote:
André Hentscheln...@dawncrow.de wrote:
Yes, i just recently modified it to test a bug, please don't remove it
You can always get through git when needed it.
That or we split it out into a separate git tree.
But we can keep it if it is still
Hello Vitaliy,
On 11/24/2011 06:28 PM, Vitaliy Margolen wrote:
---
dlls/dinput/dinput_main.c|7 ++
dlls/dinput/dinput_private.h |2 +
dlls/dinput/joystick.c | 195 +
include/dinputd.h| 243
On 11/24/2011 08:46 PM, Vitaliy Margolen wrote:
On 11/24/2011 12:27 PM, Michael Stefaniuc wrote:
Hello Vitaliy,
On 11/24/2011 06:28 PM, Vitaliy Margolen wrote:
---
dlls/dinput/dinput_main.c|7 ++
dlls/dinput/dinput_private.h |2 +
dlls/dinput/joystick.c | 195
Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=15553
Your
Marvin wrote:
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=15558
Your
Hello Juan,
Juan Lang wrote:
right now iphlpapi uses autoconf to detect if getifaddrs is available,
and only uses it to enumerate IPv6 addresses.
I'm thinking of replacing the current IPv4 enumeration code, which
uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning
toward
On 10/27/2011 02:09 PM, Frédéric Delanoy wrote:
On Thu, Oct 27, 2011 at 08:38, Eric Pouech eric.pou...@orange.fr wrote:
why do we check for ptr being null or not, when we deref ptr one line above?
if (*ptr == '\n') ptr++;
- WCMD_output_asis_len(message, (ptr) ? ptr - message :
1 - 100 of 683 matches
Mail list logo
