Re: Wine menu creation questions

2009-01-25 Thread Reece Dunn
Frank Richter wrote: Also, Windows and Linux desktops have a bit of different views on what the desktop menu should contain: most of the time, the Windows start menu contains one folder per application, with that folder containing not only the application but also a link to the README or web

Re: cmd.exe.manifest

2009-01-22 Thread Reece Dunn
2009/1/22 Luke Kenneth Casson Leighton l...@lkcl.net: 0010:trace:file:RtlGetFullPathName_U (LC:\\windows\\system32\\cmd.exe.manifest 520 0xff9aaaf4 (nil)) attr= sharing=0001 disp=1 options=0010 ea=(nil).0x 0009:trace:seh:start_debugger Starting debugger winedbg --auto 8

Re: How to distinct different behavior of IE versions

2009-01-20 Thread Reece Dunn
2009/1/20 Thomas Heckel thomas.hec...@gmx.net: Hi, I'm new to the wine development and interested in some bug hunting to gain better compatibility on windows. Just for starts I looked a little bit onto test.winehq.org and there especially why wininet:http was passing on some windows systems

Re: RFC: fd.o file type association integration

2009-01-15 Thread Reece Dunn
2009/1/15 Damjan Jovanovic damjan@gmail.com: Hi I've hacked together a little program (attached) that creates freedesktop file type associations (eg. open .dev files with Dev-C++ when you double-click them in a file manager) from what Windows programs do in the registry (#13597).

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2009-01-14 Thread Reece Dunn
2009/1/14 Dan Kegel d...@kegel.com: On Sat, Nov 15, 2008 at 8:37 AM, Reece Dunn mscl...@googlemail.com wrote: 2008/11/15 Dan Kegel d...@kegel.com: BTW, has anybody noticed a speed problem with our theme support? Yes. If you use some themes (e.g. the Zune theme from Microsoft

Re: Comctl32 tests on version 6.0

2009-01-12 Thread Reece Dunn
2009/1/12 Nikolay Sivov bungleh...@gmail.com: Running crossbuilt tests for comctl32 showed some failures when version 6.0 used: 27 - imagelist 25 - rebar 130 - toolbar (version 6.0 module used through external manifest xml in my test) Toolbar and rebar failures show different rectangle

Re: wcmd: Fix redirecting a pipe to another pipe

2009-01-11 Thread Reece Dunn
2009/1/11 Erich Hoover ehoo...@mines.edu: +/* If a redirect is immediately followed by '' (ie. 21) then +do nor process that ampersand as an AND operator */ Shouldn't that be do *not* process that ampersand? - Reece

Re: [1/8] widl: fix handling of [local] functions without [call_as] (try 3)

2009-01-10 Thread Reece Dunn
2009/1/10 Michael Karcher w...@mkarcher.dialup.fu-berlin.de: Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into stub tables if a local function has no call_as function associated, just as MIDL does. Shouldn't these go to wine-patches? - Reece

Re: [shell32/tests 6/6] Skip a test on Vista

2009-01-08 Thread Reece Dunn
2009/1/8 Paul Vriens paul.vriens.w...@gmail.com: Hi, With this last patch all shlfileop tests succeed on all my boxes (Win95, Win98, NT4, W2K, W2K3 and Vista). Changelog Skip a test on Vista +static BOOL on_vista = FALSE; + I don't see where this is used. Kudos for fixing the

Re: winecfg: Add dll override on return key press in combobox [resend]

2008-12-27 Thread Reece Dunn
2008/12/27 Andre Wisplinghoff andre.wisplingh...@gmail.com: 2008/12/27 Dmitry Timoshkov dmi...@codeweavers.com: Andre Wisplinghoff andre.wisplingh...@gmail.com wrote: +INT_PTR CALLBACK +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value

Re: Windows version autodetection

2008-12-22 Thread Reece Dunn
2008/12/22 Markus Hitter m...@jump-ing.de: Am 22.12.2008 um 05:16 schrieb Chris Robinson: Should that matter? Plenty of Win95 apps will work in WinXP. ... because WinXP has such a version heuristic already in place? I think it's perfectly possible to do an heuristic which is sometimes

Re: Windows version autodetection

2008-12-21 Thread Reece Dunn
2008/12/21 Damjan Jovanovic damjan@gmail.com: There are some older applications out there, which don't install or run correctly unless Wine is emulating the correct Windows version (eg. Windows 9x). At least Windows XP has the ability to use certain heuristics to make an educated guess

Re: Windows version autodetection

2008-12-21 Thread Reece Dunn
2008/12/21 Damjan Jovanovic damjan@gmail.com: On Sun, Dec 21, 2008 at 11:49 AM, Reece Dunn mscl...@googlemail.com wrote: 2008/12/21 Damjan Jovanovic damjan@gmail.com: You can change the version of Windows reported for different applications, and the default version using winecfg

Re: Windows version autodetection

2008-12-21 Thread Reece Dunn
2008/12/21 Scott Ritchie sc...@open-vote.org: Reece Dunn wrote: Sure. But what if an application was shipped after Vista or Windows Server 2008, but only worked on XP and earlier. Your detection would not work here. In that case the user is no worse off - they'd still need to look up AppDB

Re: Better user feedback and better user experience (idea)

2008-12-17 Thread Reece Dunn
2008/12/17 Austin English austinengl...@gmail.com: On Wed, Dec 17, 2008 at 2:10 PM, Sander Devrieze s.devri...@linux.be wrote: 2008/12/17 Scott Ritchie sc...@open-vote.org: snip If it's that users blame the distro when it's a Wine problem, then we can present them with some sort of

Re: wine-1.2 release criteria?

2008-12-15 Thread Reece Dunn
2008/12/15 Dan Kegel d...@kegel.com: - DIB Engine As mentioned in http://www.winehq.org/wwn/354#Another%20shot%20at%20a%20DIB%20Engine Massimo picked up Jesse's DIB engine code and has been trying to use it with Autocad. He says he's starting to get fonts working. (It's surprising that he

Re: Canonical and wine

2008-12-11 Thread Reece Dunn
2008/12/11 Steven Edwards sedwa...@bordeauxgroup.com: On Wed, Dec 10, 2008 at 3:42 PM, Zachary Goldberg zg...@bluesata.com wrote: I believe it has been proposed before to have .debs for things like Adobe Photoshop which first install Wine (or create a new prefix etc.) and then ask for the

Re: WineHQ redesign

2008-12-09 Thread Reece Dunn
Some issues: 1. The wiki is not using the new layout. 2. In the forums top-level page, the navigation is displayed in one big list that pushes the forum content to the bottom of the screen. 3. The WineHQ link on the forums page links back to the forums page and not the main website. Looking

Re: WineHQ redesign

2008-12-09 Thread Reece Dunn
2008/12/9 Reece Dunn [EMAIL PROTECTED]: Some issues: 1. The wiki is not using the new layout. 2. In the forums top-level page, the navigation is displayed in one big list that pushes the forum content to the bottom of the screen. 3. The WineHQ link on the forums page links back

Re: Sound regression (in Warcraft III)

2008-11-30 Thread Reece Dunn
2008/11/30 Adam Petaccia [EMAIL PROTECTED]: Maarten, could you look at http://bugs.winehq.org/show_bug.cgi?id=16297 as you're the author of 717df5b2972b3cb998ca5a43279ae2283b117eaa? I tried adding you as CC but bugzilla complained. Hi, You may be interested in

Re: RFC: Proposed new web site design

2008-11-24 Thread Reece Dunn
2008/11/24 Jeremy White [EMAIL PROTECTED]: At Wineconf, we made the decision to change the entry page to the Wine web site. The hope was to simplify and stream line it, and to put in place the infrastructure to start moving more content to the Wiki. Jeremy Newman and Jon Parshall have put a

Re: RFC: Proposed new web site design

2008-11-24 Thread Reece Dunn
2008/11/24 Jeremy White [EMAIL PROTECTED]: At Wineconf, we made the decision to change the entry page to the Wine web site. The hope was to simplify and stream line it, and to put in place the infrastructure to start moving more content to the Wiki. Another comment: on the wiki page revamp

Re: RFC: Proposed new web site design

2008-11-24 Thread Reece Dunn
2008/11/25 Brian Vincent [EMAIL PROTECTED]: Random thoughts: - Currently if you go to the wiki, you can navigate back to WineHQ, AppDB, Forums, etc on the left. The sample doesn't have that. Those links have been moved to the top. As such, they are (or will/should be) consistent throughout

Re: RFC: Proposed new web site design

2008-11-24 Thread Reece Dunn
2008/11/25 Scott Ritchie [EMAIL PROTECTED]: Cesar Izurieta wrote: Here's a quick relayout with some of the ideas posted in this thread: http://caih.org/wine/WineHQ.html Ewww. The vertical alignment is much better, and the news dragging to the bottom is just tacky. I agree. For the news,

Re: Revert mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag.

2008-11-23 Thread Reece Dunn
2008/11/24 Vitaliy Margolen [EMAIL PROTECTED]: Since Jacek did not comment on the bug 14311, revert patch in question. It restores 100% functionality of the scrollbars in Steam. This is not the correct fix. Simply reverting a patch because it broke an application without understanding why is

Re: LPD3DXMESH

2008-11-22 Thread Reece Dunn
2008/11/22 Stefan Dösinger [EMAIL PROTECTED]: LPD3DXMESH supposed to be declared in? http://letmegooglethatforyou.com/?q=LPD3DXMESH That doesn't necessarily work for Wine. Many DirectX searches are spammed with archived Wine-devel or wine-patches mails. The best way to find out is to

[RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]

2008-11-21 Thread Reece Dunn
Hi, Looking at the history of that test (http://test.winehq.org/data/tests/winmm:wave.html) I see a lot of timeout errors on the Wine builds, even after this fix went in. The fix itself has caused a regression of playback in many applications and games that play audio

Re: [RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]

2008-11-21 Thread Reece Dunn
2008/11/21 Chris Robinson [EMAIL PROTECTED]: On Friday 21 November 2008 10:26:19 am Reece Dunn wrote: I want to submit the following patch to revert the part of the patch that caused the regression and fix some of the tracing. I have been using this patch on Cepstral SwiftTalker without issue

Re: implement OleLoadPictureFile

2008-11-17 Thread Reece Dunn
2008/11/17 Michael Karcher [EMAIL PROTECTED]: Am Montag, den 17.11.2008, 13:09 -0800 schrieb Jeremy Drake: As far as the standard OLE file stream object, if you know of one please let me know. AFAIK, it is a pretty major oversight in the OLE IStream APIs that there is not a function to create

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-15 Thread Reece Dunn
2008/11/15 Dan Kegel [EMAIL PROTECTED]: On Sun, Nov 2, 2008 at 10:58 PM, Reece Dunn [EMAIL PROTECTED] wrote: .. the first step for Wine is making the uxtheme/msstyles support work well so that it can be used by distributions to theme Wine. BTW, has anybody noticed a speed problem with our

[RFC] winecfg -- approach to making the theme names colours lists sortable

2008-11-07 Thread Reece Dunn
Hi, At the moment, if you have several themes installed on your system (e.g. by installing StyleXP) winecfg will list those themes in a random (read not sorted) order. If I just add the CBS_SORT flag, the wrong theme is chosen because the order in the combo boxes are assumed to be the same order

Re: Wine theming (follow up)

2008-11-05 Thread Reece Dunn
2008/11/4 Roderick Colenbrander [EMAIL PROTECTED]: Hi, The way to go for Wine theming is to use Windows XP themes. Unfortunately the file format itself is not documented. Based on Wine its uxtheme code (BTW our uxtheme is quite complete) and an analysis of some 'free' XP themes like

Re: Wine support for win64

2008-11-04 Thread Reece Dunn
2008/11/4 Francois Gouget [EMAIL PROTECTED]: On Tue, 4 Nov 2008, Stefan Dösinger wrote: [...] I think we still have the problem that gcc doesn't support the calling convention Win64 uses, so we can't compile a Wine that is compatible with Win64 apps. In the meantime we can work on the long

Re: [PATCH] comctl32: support drawing themed push buttons. [try 4] [resend]

2008-11-04 Thread Reece Dunn
2008/11/5 Roderick Colenbrander [EMAIL PROTECTED]: Hi, I have the feeling that some of the drawing code is not correct and should use information which is buried inside the theme file. Things like content margins, text positions and things like that. I think it also requires test cases on

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-02 Thread Reece Dunn
2008/11/2 Dan Kegel [EMAIL PROTECTED]: FWIW, my opinion is that any deep integration is going to be hard, and that for the moment we should go with something much simpler: simply support mstheme files well, and provide themes that look like the default themes on Ubuntu / OpenSuse / Fedora.

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-02 Thread Reece Dunn
2008/11/3 Dan Kegel [EMAIL PROTECTED]: On Sun, Nov 2, 2008 at 2:52 PM, Roderick Colenbrander [EMAIL PROTECTED] wrote: Anyway desktops will never move to this microsoft format. I think both gtk and qt are now moving to xml based formats. We could define our own spec for that but I doubt they

Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
Hi, There is a discussion going on over at https://bugs.launchpad.net/ubuntu/+source/wine/+bug/111061 about improving Wine's look and feel to better match the system that it is running on. The situation is as follows: == Colour Schemes Wine supports these by reading the settings from the

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
2008/11/1 Roderick Colenbrander [EMAIL PROTECTED]: In the end we need to support a bunch of different theme engines GTK, QT, Cocoa and perhaps later on more. In theory it would be possible to create a different uxtheme backend for each different toolkit. One major issue is the language

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
2008/11/1 Frank Richter [EMAIL PROTECTED]: On 01.11.2008 14:04, Reece Dunn wrote: we could have the msstyles DLL expose the uxtheme API and have uxtheme call msstyles to do the rendering. That way, we could have a gtk.msstyles, qt3.msstyles, qt4.msstyles and an carbon.msstyles That sounds

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
2008/11/1 Tomasz Sałaciński [EMAIL PROTECTED]: IMHO WINE developers should first focus on applications, not their look. I believe most users would like to see Visual Studio running in gray instead of not running as native. Application functionality is important. Applications should run as well

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
2008/11/1 Roderick Colenbrander [EMAIL PROTECTED]: My whole point is maintenance and distribution. Sure you could create different plugins for uxtheme but the language limitation won't allow such plugins to enter Wine. They would need to be maintained outside of Wine which would be bad. It

Re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes

2008-11-01 Thread Reece Dunn
2008/11/1 Steven Edwards [EMAIL PROTECTED]: On Sat, Nov 1, 2008 at 1:10 PM, Frank Richter [EMAIL PROTECTED] wrote: So winetheme would have plugins - that seems to make the whole thing an additional complication over straight uxtheme plugins, since you have the application as an extra layer in

patchwatcher: the winehttp:notification tests are failing for some reason

2008-10-28 Thread Reece Dunn
Hi, Does anyone have any ideas why these tests are failing (e.g. http://kegel.com/wine/patchwatcher/results/3644.log)? The patches in question don't touch that code at all. Looking at http://test.winehq.org (e.g.

Re: [PATCH] uxtheme: fixed the todo blocks in the SetWindowTheme tests. [try 2]

2008-10-28 Thread Reece Dunn
2008/10/28 James Hawkins [EMAIL PROTECTED]: On Tue, Oct 28, 2008 at 10:17 AM, Rob Shearman [EMAIL PROTECTED] wrote: 2008/10/28 James Hawkins [EMAIL PROTECTED]: This code is screaming for a goto. I disagree. Yes, it was late and my mind stopped after the next thought. There's nothing to

Experience with msvcmaker and building wine core and test dlls with VC9

2008-10-24 Thread Reece Dunn
Hi, I have been using msvcmaker to generate project files to build the various wine test programs with VC9 and have since started to look at getting code dlls to work. I have successfully built cabinet.dll locally on VC9, doing the following: 1. add the following to dlls/cabinet/Makefile.in:

Re: [PATCH] msvcmaker: added COM_NO_WINDOWS_H to support midl-generated headers for __WINESRC__ components.

2008-10-23 Thread Reece Dunn
2008/10/23 Alexandre Julliard [EMAIL PROTECTED]: Rob Shearman [EMAIL PROTECTED] writes: 2008/10/18 Reece Dunn [EMAIL PROTECTED]: The midl generated code allows you to define COM_NO_WINDOWS_H to prevent the inclusion of windows.h. That define is thus added to those provided by msvcmaker

Re: [PATCH] cabinet: support building with midl-generated headers.

2008-10-23 Thread Reece Dunn
Please ignore this patch. The correct solution is to add EXTRADEFS = -DCOM_NO_WINDOWS_H to Makefile.in (e.g. see dlls/browseui/Makefile.in) - Reece

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Reece Dunn
2008/10/18 Vitaly Perov [EMAIL PROTECTED]: The program is Garant 7 F1 (Russian legal system database). I don't think you know this program. It is not a real world bug, but there are some significant bugs in SHFileOperationW. I don't think a lot of programs use SHFileOperationW to move a

setupapi tests question

2008-10-15 Thread Reece Dunn
When building the setupapi tests with VC9 and the MSVC headers (Vista version) after using msvcmaker, I get the following output: 2-- Build started: Project: setupapi_test, Configuration: Debug MSVC Headers Win32 -- 2Linking... 2misc.obj : error LNK2019: unresolved external symbol _MyFree

Re: setupapi tests question

2008-10-15 Thread Reece Dunn
2008/10/15 Dmitry Timoshkov [EMAIL PROTECTED]: Reece Dunn [EMAIL PROTECTED] wrote: When building the setupapi tests with VC9 and the MSVC headers (Vista version) after using msvcmaker, I get the following output: 2-- Build started: Project: setupapi_test, Configuration: Debug MSVC

Re: Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-08 Thread Reece Dunn
2008/10/8 Owen Rudge [EMAIL PROTECTED]: Hi all, Reading up on the wineconf WWN issue, I noticed that it mentions usability and winecfg. Therefore, I decided to dig up my RFC relating to some ideas I had about winecfg that I sent to the list. Ah, lovely. This is something I'm planning on

Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-07 Thread Reece Dunn
Hi, Reading up on the wineconf WWN issue, I noticed that it mentions usability and winecfg. Therefore, I decided to dig up my RFC relating to some ideas I had about winecfg that I sent to the list. I have attached a mockup of my ideas, which I have added to since my original mail. == APPEARANCE

Re: Usability: WineCfg Part 1 -- Desktop Integration tab

2008-10-07 Thread Reece Dunn
2008/10/8 James McKenzie [EMAIL PROTECTED]: Reece Dunn wrote: Hi, Reading up on the wineconf WWN issue, I noticed that it mentions usability and winecfg. Therefore, I decided to dig up my RFC relating to some ideas I had about winecfg that I sent to the list. 1. We may want to provide

Re: Wine PulseAudio Driver

2008-09-29 Thread Reece Dunn
2008/9/29 Scott Ritchie [EMAIL PROTECTED]: Arthur Taylor wrote: Also, in the patch, configure checks for pulseaudio = 0.9.7. I have since noticed that it uses parts of the api from 0.9.11 and compilation will fail against previous versions. Thanks As an aside, 0.9.11 is newer than most

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Reece Dunn
2008/9/28 Maarten Lankhorst [EMAIL PROTECTED]: Hi Juan, 2008/9/28, Juan Lang [EMAIL PROTECTED]: Hi Reece, I'm not nak'ing your patch. I just wanted to point out a simpler way: -static const char *printGUID(const GUID *guid) +static char *printGUID(const GUID *guid) { -static char

Re: RFC: Adding annotations to function declarations to improve static analysis

2008-09-27 Thread Reece Dunn
2008/9/28 Rob Shearman [EMAIL PROTECTED]: Hi all, This will be talked about in more detail at WineConf tomorrow, but I just thought I'd throw this out there as a bit of background to any discussions. Adding annotations to function declarations allows Prefast to pick up certain classes of

Re: coverity ... new run finally

2008-09-09 Thread Reece Dunn
2008/9/9 Dan Kegel [EMAIL PROTECTED]: Marcus wrote: A new Coverity run (274) was done finally, so we can restart looking at issues ;) Still a lot of NULL ptr migration issues which suck to fix, but well. Sure would be nice if Coverity could identify the cl which introduced each problem

Re: [1/2] hlink/tests: display the expected data, as well as the actual data.

2008-09-07 Thread Reece Dunn
2008/9/7 James Hawkins [EMAIL PROTECTED]: On Sun, Sep 7, 2008 at 4:56 AM, Reece Dunn [EMAIL PROTECTED] wrote: This improves the error reporting for the hlink tests. I think you need to think this one over. Why would we care to display the expected data, when the expected data is in the tests

Re: Adding Flawfinder to Patchwatcher

2008-09-01 Thread Reece Dunn
2008/8/28 Austin English [EMAIL PROTECTED]: I had a discussion with Dan about adding Flawfinder to the patchwatcher. Currently, it's got some pretty generic errors, but it seems able to test only patches, so we wouldn't be flooded with old nonbugs (or we could set up a blacklist of safe

Re: New kernel development guide might be good model for Wine...

2008-08-21 Thread Reece Dunn
2008/8/19 Markus Hitter [EMAIL PROTECTED]: Am 19.08.2008 um 00:41 schrieb James Hawkins: when the patch doesn't get committed, you should look back at it and really think outside the box about what could possibly be wrong with the patch. Essentially, you ask to change code on unfounded

Re: .NET program crashes involving stubbed functions

2008-08-15 Thread Reece Dunn
2008/8/13 Adam Petaccia [EMAIL PROTECTED]: Its customary to make a function return NotImplemented in Gdiplus, if its just a dummy function that does nothing and returns. But .NET seems to check for this and throw an exception, crashing the program anyway. See bug

Re: patchwatcher online

2008-08-12 Thread Reece Dunn
2008/8/12 Dan Kegel [EMAIL PROTECTED]: On Tue, Aug 12, 2008 at 6:47 AM, [EMAIL PROTECTED] wrote: couldn't you instead when the patchwatcher takes the patch it assigns it a patch # and require if there is a patch dependency that the person put into a comment REQ_PATCH: 123456,15456, etc.. ?

Re: Is Wine portable to ARM arch?

2008-08-10 Thread Reece Dunn
2008/8/8 Timothy Normand Miller [EMAIL PROTECTED]: On Fri, Aug 8, 2008 at 1:39 PM, James Mckenzie [EMAIL PROTECTED] wrote: If no then are there any plans for multiplatform code in Wine? NO! Even MacOSX specific code is not allowed Is there an FAQ that explains why this is so?

Re: problem loading wine test projects windows vista

2008-08-04 Thread Reece Dunn
2008/8/4 Hongbo Ni [EMAIL PROTECTED]: Reece wrote I really need to compile and run existing tests on window before I can write any test case for wine. What is git's core.autocrlf setting configured to? I had this issue (some of the detected filenames are '\r' - which is caused by perl

Re: What to do with tests that run for ages (examples dplayx and msi/install)

2008-08-04 Thread Reece Dunn
2008/8/4 James Hawkins [EMAIL PROTECTED]: On Mon, Aug 4, 2008 at 1:03 PM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, The recent additions to the dplayx tests make these tests run very slow (or there is just a lot tested?). Is there a way to either split up these tests so they don't timeout or

Re: problem loading wine test projects windows vista

2008-08-03 Thread Reece Dunn
2008/8/3 Hongbo Ni [EMAIL PROTECTED]: Hi, I want to build and test wine test suite on window, I did ./tools/winapi/msvcmaker --no-wine that is ok, but when I try to open the fille winetest.dsw, 1. with Developer Studio 6.0, it compaints that all *.dsp files (such as

Re: ole32: don't crash when running the marshal tests on Vista.

2008-08-01 Thread Reece Dunn
2008/7/31 Rob Shearman [EMAIL PROTECTED]: 2008/7/30 Reece Dunn [EMAIL PROTECTED]: When running the ole32:marshal tests on Vista, the call to CoUnmarshalInterface fails. This results in pProxy being NULL which then causes the crash on the QueryInterface call. This patch makes sure

Re: Bizarre idea: creating our own extension to msi for cross-platform installers

2008-07-27 Thread Reece Dunn
2008/7/27 Scott Ritchie [EMAIL PROTECTED]: Just a crazy thought, but... What if we created a standard for passing some sort of wine-specific metadata in an MSI file? Windows would ignore it, but application developers could use it to include some helpful Linux-specific Wine instructions

Request For Testing: Can you check this crypt32/protectdata test fix on Win2000.

2008-07-25 Thread Reece Dunn
Hi, I want to verify that the if (!protected) ... are correct. That is, on non-Win2000 platforms, we can't verify LastError == ERROR_SUCCESS, so I have removed those as per Juan's request. However, there are two places where Win2000 is returning a different error code. So the question is, is

Re: [RFC] crypt32: fixed the base64 tests on Vista.

2008-07-23 Thread Reece Dunn
2008/7/21 Juan Lang [EMAIL PROTECTED]: Hi Reece, thanks for looking into failures on Vista. To me, without understanding this in any more detail, it looks as if Vista is broken here (and thus the Vista return parts should be marked as broken()). However, Vista may be doing the right thing,

Re: crypt32/tests: check Vista error codes for the msg tests.

2008-07-23 Thread Reece Dunn
2008/7/23 Markus Hitter [EMAIL PROTECTED]: Am 23.07.2008 um 02:25 schrieb Reece Dunn: +/* last error -- NT: E_INVALIDARG, 9x/Vista: unchanged */ +/* ret is FALSE on XP and earlier but TRUE on Vista, therefore it cannot be tested for */ +ok((GetLastError() == E_INVALIDARG

Re: rasapi32: the tests need raserror.h to build using MS headers.

2008-07-22 Thread Reece Dunn
2008/7/21 Stefan Leichter [EMAIL PROTECTED]: Am Monday 21 July 2008 21:44 schrieb Reece Dunn: The error constants (e.g. ERROR_BUFFER_TOO_SMALL) are defined in raserror.h, which is needed for the tests to build using the Microsoft headers (checked against the Vista SDK headers). - Reece my

Re: [RFC] crypt32: fixed the base64 tests on Vista.

2008-07-21 Thread Reece Dunn
2008/7/21 Juan Lang [EMAIL PROTECTED]: Hi Reece, thanks for looking into failures on Vista. No problem. To me, without understanding this in any more detail, it looks as if Vista is broken here (and thus the Vista return parts should be marked as broken()). However, Vista may be doing the

[RFC] crypt32: fixed the base64 tests on Vista.

2008-07-20 Thread Reece Dunn
? - Reece From 2208d18bef5497e7b431a2b7f1cfe3be7abb0def Mon Sep 17 00:00:00 2001 From: Reece Dunn [EMAIL PROTECTED] Date: Sun, 20 Jul 2008 15:23:07 +0100 Subject: [PATCH] crypt32: fixed the base64 tests on Vista. --- dlls/crypt32/tests/base64.c |9 + 1 files changed, 5 insertions(+), 4

Problem compiling wine tests with msvc in standalone mode.

2008-07-19 Thread Reece Dunn
Hi, I am using VS 2008 (9.0) Express in conjunction with the Vista SDK. When compiling the tests, I get: c:\Users\reece\wine\dlls\comctl32\testscl -D_X86_ -DSTANDALONE -I../../../inclu de listview.c Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.21022.08 for 80x86 Copyright (C)

Re: Problem compiling wine tests with msvc in standalone mode.

2008-07-19 Thread Reece Dunn
2008/7/19 Mikołaj Zalewski [EMAIL PROTECTED]: Where does the ../../../include\rpc.h file come from? If you are mixing Wine and Windows headers then conflicts are quite possible. I copy only wine/test.h from the Wine headers. Often, I also need a #include windows.h at the top of the file for

Re: comctl32: initial support for drawing themed push buttons.

2008-07-16 Thread Reece Dunn
2008/7/15 Reece Dunn [EMAIL PROTECTED]: This adds basic support for drawing themed push buttons. Please ignore this patch, as it breaks the drawing of some dialogs (e.g. Cepstral SwiftTalker options). - Reece

Re: [3/3] gdiplus: Make GdipInvertMatrix test pass on native

2008-07-13 Thread Reece Dunn
2008/7/12 Michael Karcher [EMAIL PROTECTED]: Am Samstag, den 12.07.2008, 16:55 -0500 schrieb James Hawkins: GDI+ uses floating point values for matrix elements so don't you think the result could be slightly different due different calculation algorithms? As they say: Never compare

Re: [2/3] gdiplus: fix GdipPathIterNextMarker behaviour on path without markers. fix tests.

2008-07-13 Thread Reece Dunn
2008/7/13 Nikolay Sivov [EMAIL PROTECTED]: What do you think about matrix comparison or in general float comparison implementation? What is the best way to implement this. We have two cases now: 1. GdipIsMatrixEqual which compares two matrices (with simple bitwise operation now) Is this

Re: [PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Reece Dunn
2008/7/10 Hongbo Ni [EMAIL PROTECTED]: I have write a patch for the problem, please comment. +if( unicode class-winproc == EDIT_winproc_handle ) Is it just the EDIT window procedure that is affected? I suspect that this will apply to all classes that have A and W variants. I also

Re: winecfg.cpl: Add new control panel applet for winecfg

2008-07-02 Thread Reece Dunn
2008/7/2 Owen Rudge [EMAIL PROTECTED]: Well, the first part of the project was to get the shell namespace implementation of Control Panel working properly, which is now effectively complete. Hi, I just tested Cepstral SwiftTalker with latest git (see bug:

Re: user32: Add additional tests for scroll state, make them pass under Wine

2008-07-01 Thread Reece Dunn
2008/6/30 James Hawkins [EMAIL PROTECTED]: On Mon, Jun 30, 2008 at 3:34 PM, Alex Villací­s Lasso [EMAIL PROTECTED] wrote: ... +ok(si.nMin == 0xdeadbeef, si.nMin == 0x%x, expected 0xdeadbeef\n, si.nMin); +ok(si.nMax == 0xdeadbeef, si.nMax == 0x%x, expected 0xdeadbeef\n,

Re: netapi32: Set the buffer to NULL in NetApiBufferFree

2008-06-27 Thread Reece Dunn
2008/6/26 Kai Blin [EMAIL PROTECTED]: On Thursday 26 June 2008 16:34:51 you wrote: @@ -52,6 +52,7 @@ NET_API_STATUS WINAPI NetApiBufferFree(LPVOID Buffer) { TRACE((%p)\n, Buffer); HeapFree(GetProcessHeap(), 0, Buffer); +Buffer = NULL; return NERR_Success; } I don't

Re: Ok guys...

2008-06-27 Thread Reece Dunn
2008/6/26 Dan Kegel [EMAIL PROTECTED]: Your subject line was confusing; what's this about? Your patches seem malformed, they come across with question marks for tabs, e.g. They look fine on my googlemail account :), and it looks like they are spaces, not tabs. --- context.c??? 2008-06-26

Re: [legal] eligibility for contributing code to wine for students / graduates of a course derived from the Microsoft Windows Acadamic Program

2008-06-16 Thread Reece Dunn
2008/6/14 Steven Edwards [EMAIL PROTECTED]: On Fri, Jun 13, 2008 at 7:54 PM, Mark Farnell [EMAIL PROTECTED] wrote: If a student is currently taking, or has previously taken a course derived from the Microsoft Windows Academic Program ... will they become *ineligible* to contribute code to the

Re: Wine-1.0 release notes

2008-06-13 Thread Reece Dunn
2008/6/12 Vitaliy Margolen [EMAIL PROTECTED]: Reece Dunn wrote: 2008/6/11 Vitaliy Margolen [EMAIL PROTECTED]: In short - that after everyone's hard work and 15 years of development wine-1.0 is just a release tag nothing more. I think that this is overly harsh. It's like saying that you

Re: Wine-1.0 release notes

2008-06-11 Thread Reece Dunn
2008/6/11 Vitaliy Margolen [EMAIL PROTECTED]: In short - that after everyone's hard work and 15 years of development wine-1.0 is just a release tag nothing more. I think that this is overly harsh. It's like saying that you should not celebrate a birthday, as that is just you aging just a day,

Re: gdi32: Use 0xffff as a default character as Vista does

2008-06-10 Thread Reece Dunn
2008/6/10 Dmitry Timoshkov [EMAIL PROTECTED]: Hello, this patch fixes the problem reported in the bug 12305. In Wine Tahoma character ':' is mapped to glyph index 0x1f, and that seems to be confusing Firefox. +TM.tmDefaultChar = pOS2-usDefaultChar ? pOS2-usDefaultChar : 0x;

Re: How long does it take you to compile wine?

2008-06-01 Thread Reece Dunn
2008/6/1 Dan Kegel [EMAIL PROTECTED]: Way back five years ago, we all compared notes on how long it took to build Wine on our systems. http://www.winehq.org/site/?issue=149#Compile%20Time%20Comparisons%20/%20Tips Today I measured it on a new computer (with a spiffy new Intel dual core e7200

Re: Fixing crashes in Tests (OS version check)

2008-05-31 Thread Reece Dunn
2008/5/31 Jeff Latimer [EMAIL PROTECTED]: James Hawkins wrote: On Fri, May 30, 2008 at 11:18 PM, Alistair Leslie-Hughes [EMAIL PROTECTED] wrote: Hi, I've being investigating crashes that occur on Win98 when the tests run. I have fixed a couple already which where trivial. When I attempted

Re: AppDB: More information about the test environment needed

2008-05-29 Thread Reece Dunn
2008/5/29 Groeschel, Volker [EMAIL PROTECTED]: I just found two conflicting reports for Age of empires: http://appdb.winehq.org/objectManager.php?sClass=versioniId=10326 Both are on Ubuntu 8.04 and 1.0-rc1. One is Silver, one is Garbage. But it is just one example. Going with AoE, I have

Re: WOW! Look at test.winehq.org now!

2008-05-27 Thread Reece Dunn
2008/5/27 Dimi Paun [EMAIL PROTECTED]: On Tue, 2008-05-27 at 07:20 -0700, Dan Kegel wrote: Alexandre did an awesome job of improving the index page. It's very polished and useful now. http://test.winehq.org/data/ This is indeed very cool! I think we should link this from somewhere on the

Re: Winetest broken on Win98

2008-05-27 Thread Reece Dunn
2008/5/27 Paul Vriens [EMAIL PROTECTED]: Paul Vriens wrote: Paul Vriens wrote: Francois Gouget wrote: So if anyone has been wondering why I don't run the tests on Win98 anymore... I still do! The problem is that since 2008/05/08 something prevents winetest from submitting the results. The

Best place for HOWTO documents for your favourite application?

2008-05-25 Thread Reece Dunn
Hi, I have been trying our various Oberon Media games. The thing that is holding this up from working is the hyperlinks on the intro screen (I am going to enter a bug report later on). I have worked out how to run and register the games (given a valid registration key that you have purchased) so

Re: Crosstests - Too large of log files?

2008-05-22 Thread Reece Dunn
2008/5/21 Austin English [EMAIL PROTECTED]: In the past 2 days, when running the cross tests on my work XP box, I keep getting an error that the log file is too big (1.6 Mb 1.5 Mb max). Anyone else seeing this? It's submitting partial reports, which may or may not be useful. Can we get some

Re: Crosstests - Too large of log files?

2008-05-22 Thread Reece Dunn
2008/5/21 Austin English [EMAIL PROTECTED]: On Wed, May 21, 2008 at 12:39 PM, Paul Vriens [EMAIL PROTECTED] wrote: Austin English wrote: In the past 2 days, when running the cross tests on my work XP box, I keep getting an error that the log file is too big (1.6 Mb 1.5 Mb max). Anyone else

Re: Lots of regressions in games in last few versions

2008-05-11 Thread Reece Dunn
2008/5/11 Tom Wickline [EMAIL PROTECTED]: Well its not only Games, if you install office 2007 NOTHING works with RC-1! You have to revert back to 0.9.59 for it to work the best it ever did, then it's all down hill from each release forward ..As it looks Wine 1.0 will be a huge POS..

Re: Time-based releases idea

2008-05-05 Thread Reece Dunn
2008/5/5 Kai Blin [EMAIL PROTECTED]: On Monday 05 May 2008 05:13:16 Dan Kegel wrote: I just wrote up an idea related to release management for post-1.0 wine releases. It's online at http://wiki.winehq.org/TimeBasedReleases Essentially, the idea is to release in March and September,

Re: shlwapi: expose the IStream_Read and IStream_Write functions.

2008-05-01 Thread Reece Dunn
2008/5/1 Robert Shearman [EMAIL PROTECTED]: Reece Dunn wrote: @@ -926,6 +926,13 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR,DWORD,DWORD,BOOL,struct IStream*,s HRESULT WINAPI SHCreateStreamWrapper(LPBYTE,DWORD,DWORD,struct IStream**); +#undef IStream_Read +#undef IStream_Write

Re: cabinet: Revert cabinet: Fix for FDICopy with an empty cabinet file.

2008-04-26 Thread Reece Dunn
2008/4/26 James Hawkins [EMAIL PROTECTED]: Hi, The test was incorrect and failed on all platforms. Vitaly, please ask someone to test your patches on a real windows system in the future if you don't have access to one. Wouldn't it be better to actually fix the test case than revert it

<    1   2   3   4   5   >