Re: mono progress on mixed-mode assemblies...

2008-05-15 Thread Robert Shearman
Kornél Pál wrote: Also note that Mono's Class Library is licensed under MIT/X11 because inlining (done by the runtime) may be incompatible with GPL that would not allow non-GPL programs to be executed within Mono. Would it be possible to have a MIT/X11 licensed msvcrt? I'm not sure if you

Re: includes: Add vmr9 header

2008-05-13 Thread Robert Shearman
Maarten Lankhorst wrote: @@ -0,0 +1,525 @@ +/* + * Copyright 2008 Maarten Lankhorst + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + *

Re: [PATCH] Cache localised number chars

2008-05-13 Thread Robert Shearman
Michael Karcher wrote: UDATE *lpUdate) static void VARIANT_GetLocalisedNumberChars(VARIANT_NUMBER_CHARS *lpChars, LCID lcid, DWORD dwFlags) { static const VARIANT_NUMBER_CHARS defaultChars = { '-','+','.',',','$',0,'.',',' }; + static VARIANT_NUMBER_CHARS lastChars; + static LCID

Re: rpcrt4: Fix ndr_marshall test failures, try 2

2008-05-07 Thread Robert Shearman
Maarten Lankhorst wrote: -ok(RPC_S_OK == RpcServerUseProtseqEp(ncalrpc, 20, endpoint, NULL), RpcServerUseProtseqEp\n); -ok(RPC_S_OK == RpcServerRegisterIf(IFoo_v0_0_s_ifspec, NULL, NULL), RpcServerRegisterIf\n); -ok(RPC_S_OK == RpcServerListen(1, 20, TRUE), RpcServerListen\n);

Re: [PATCH] check for iface-ref to avoid crash

2008-05-07 Thread Robert Shearman
Marcus Meissner wrote: @@ -742,6 +742,9 @@ static void write_c_method_def(FILE *header, const type_t *iface) static void write_c_disp_method_def(FILE *header, const type_t *iface) { + if (!iface-ref) { +error_loc(write_c_disp_method_def: no reference on interface(%p)\n, iface);

Re: winex11.drv: Set the size of returned DEVMODE to least common one as XP does

2008-05-04 Thread Robert Shearman
David Adam wrote: Hello -devmode-dmSize = sizeof(DEVMODEW); -devmode-dmSpecVersion = MAKEWORD(1,4); -devmode-dmDriverVersion = MAKEWORD(1,4); +devmode-dmSize = FIELD_OFFSET(DEVMODEW, dmICMMethod); +devmode-dmSpecVersion = DM_SPECVERSION; +devmode-dmDriverVersion =

Re: credui: Danish translation

2008-05-04 Thread Robert Shearman
Jens Albretsen wrote: Changelog: Danish translation of credui +LANGUAGE LANG_DANISH, SUBLANG_DEFAULT + +IDD_CREDDIALOG DIALOG DISCARDABLE 0, 0, 213, 149 +STYLE DS_MODALFRAME | DS_NOIDLEMSG | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION IDS_TITLEFORMAT +FONT 8, MS Shell

Re: Fix building tools/widl (for bison 1.75, among others)

2008-05-02 Thread Robert Shearman
Gerald Pfeifer wrote: After the following change about a week ago Rob Shearman [EMAIL PROTECTED] widl: Make the rules for parsing fields in structures, encapsulated unions and non-encapsulated unions more strict. Move the rules in fields that handle empty union cases into separate

Re: widl: Add a framework for automated testing of IDL files that should succeed or fail to be parsed.

2008-05-02 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: The way I see it, we have a choice between having a framework that uses the makefile to run individual tests of the parser without checking the content or a framework that runs every test in one go, but is capable

Re: shlwapi: expose the IStream_Read and IStream_Write functions.

2008-05-01 Thread Robert Shearman
Reece Dunn wrote: @@ -926,6 +926,13 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR,DWORD,DWORD,BOOL,struct IStream*,s HRESULT WINAPI SHCreateStreamWrapper(LPBYTE,DWORD,DWORD,struct IStream**); +#undef IStream_Read +#undef IStream_Write + +HRESULT WINAPI IStream_Read(struct IStream

Re: RFC: detecting wine drivers in the audio tests

2008-04-30 Thread Robert Shearman
Francois Gouget wrote: My idea is that some platforms (e.g. Wine) could ask for stricter checks, by using strict_wine a bit like they use todo_wine to request looser checks. So for instance you would do: strict_wine ok(expected_cond || buggy(this_is_a_bug), ...); Then on Windows the

Re: [PATCH 1/4] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-29 Thread Robert Shearman
Alexandre Julliard wrote: --- include/d3d10.h.old 2008-04-29 13:38:38.0 +0200 +++ include/d3d10.h 2008-04-29 13:39:08.0 +0200 @@ -3455,12 +3455,12 @@ virtual void STDMETHODCALLTYPE VSSetConstantBuffers( UINT StartSlot, UINT NumBuffers, -

Re: widl: Add a framework for automated testing of IDL files that should succeed or fail to be parsed.

2008-04-29 Thread Robert Shearman
Dan Hipschman wrote: On Mon, Apr 28, 2008 at 08:37:26PM +0100, Robert Shearman wrote: This should aid in testing more-obscure parts of the parser that aren't necessarily valid when using RPC (and hence don't make sense being put in dlls/rpcrt4/tests/server.idl). Obviously

Re: widl: callback, code, comm_status and in_line are attribute names, not keywords.

2008-04-29 Thread Robert Shearman
Robert Shearman wrote: --- tools/widl/parser.l |8 1 files changed, 4 insertions(+), 4 deletions(-) Just to note, this patch depends on the patch series that I sent yesterday and that I'm about to resend now. -- Rob Shearman

Re: [PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.

2008-04-28 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: Use an attribute to store the const qualifier for the pointer and type. Allow multiple type-qualifiers to be applied to a type by adding a declaration-specifier rule that encompasses type-qualifiers and types

Re: [PATCH 6/7] widl: Accept integer constant suffixes in the lexer.

2008-04-27 Thread Robert Shearman
Dan Hipschman wrote: On Sat, Apr 26, 2008 at 09:51:58AM +0100, Robert Shearman wrote: +u_suffix(l|L) +l_suffix(u|U) I'm guessing you meant for these to be the other way around. Good spot, thanks! -- Rob Shearman

Re: [PATCH 09/17] widl: Split the expr rule up into multiple rules to fix operator precedence.

2008-04-21 Thread Robert Shearman
Alexandre Julliard wrote: You shouldn't need that, the %left/%right declarations should define the correct precedence already. Why doesn't this work for you? I was attempting to fix the attached case. The result of the expression evaluation can be seen in the generated _c.c file by searching

Re: Help with configure option

2008-04-16 Thread Robert Shearman
Alistair Leslie-Hughes wrote: I need to add an option, HAS_TEXTCONCAT_BUG to the configure script to check for a bug in libxml. What file(s) do I have to change? The file attached is an example to test for this issue. (returns -1 if the error exists) The trouble is that because msxml3

Re: fusion: Explicitly check for -1 for a missing table

2008-04-16 Thread Robert Shearman
James Hawkins wrote: It works just fine. -1 is 4294967295 in ULONG (32bit), which is exactly the same as offset on error (because we assigned it -1, but the representation in memory is the same). Then use ~0 so that the purpose is clearer. Adding a define for this value would probably

RFC: Fix for IWineMsiRemotePackage::FormatRecord

2008-04-15 Thread Robert Shearman
causes an error for this parameter. I'm proposing the attached patch to fix things, but I'm not able to test that this works correctly. Thanks, -- Rob Shearman From 6e1a75e76dbf402b05b9475eaf74b7b1341919ea Mon Sep 17 00:00:00 2001 From: Robert Shearman [EMAIL PROTECTED] Date: Tue, 15 Apr 2008

Re: browseui: Remove unused variables

2008-04-15 Thread Robert Shearman
Andrew Talbot wrote: @@ -299,7 +299,6 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface, { ProgressDialog *This = (ProgressDialog *)iface; struct create_params params; -HANDLE hThread; TRACE((%p, %p, %x, %p)\n, iface,

Re: comctl32: Remove unused variables

2008-04-15 Thread Robert Shearman
Andrew Talbot wrote: @@ -967,16 +967,14 @@ static HFONT SYSLINK_SetFont (SYSLINK_INFO *infoPtr, HFONT hFont, BOOL bRedraw) */ static LRESULT SYSLINK_SetText (SYSLINK_INFO *infoPtr, LPCWSTR Text) { -int textlen; - /* clear the document */ SYSLINK_ClearDoc(infoPtr); -

Re: dinput: Remove unused variables

2008-04-15 Thread Robert Shearman
Andrew Talbot wrote: @@ -142,13 +142,12 @@ static INT find_joystick_devices(void) { CHAR device_name[MAX_PATH], *str; INT len; -int fd; len = sprintf(device_name, %s%d, JOYDEV_NEW, i) + 1; -if ((fd = open(device_name, O_RDONLY)) 0) +

Re: error: `XICCallback' undeclared (Solaris build problem)

2008-04-14 Thread Robert Shearman
Kusanagi Kouichi wrote: Does this patch fix the problem? -XICCallback destroy = {(XPointer)data, X11DRV_DestroyIC}; +XIMCallback destroy = {(XPointer)data, (XIMProc)X11DRV_DestroyIC}; I think a configure check may be a more appropriate fix. -- Rob Shearman

Re: msdmo: Array parameter is passed to function as pointer so loses size information

2008-04-10 Thread Robert Shearman
Andrew Talbot wrote: Robert Shearman wrote: This is incorrect. count is the size in bytes of the buffer passed in (szName) and so should be sizeof(szName) not sizeof(szName)/sizeof(szName[0]) (i.e. 80). Are you sure? MSDN says szName: Array of 80 Unicode characters that receives

Re: shell32: Implement ParseDisplayName for EntireNetwork in the Network Places shell folder.

2008-04-10 Thread Robert Shearman
Juan Lang wrote: Hi Rob, +strcpy(pData-u.network.szNames, Entire Network); Is this not locale-dependent? I don't believe so. ParseDisplayName (which isn't implemented yet) will do the mapping between the PIDL and the name the user sees, which doesn't have to depend on

Re: msdmo: Array parameter is passed to function as pointer so loses size information

2008-04-09 Thread Robert Shearman
Andrew Talbot wrote: @@ -291,8 +291,9 @@ lend: * * Get DMP Name from the registry */ -HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[80]) +HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[]) { +#define NAME_SIZE 80 /* Size of szName[] */ WCHAR

Re: Wine 1.0 status: 70 days to release, 68 bugs to fix. 28 days to code freeze!

2008-04-05 Thread Robert Shearman
Dan Kegel wrote: New (by A.F. and Austin): 11420 advapi320 service control manager API problem: name of named objects might differ (client vs. service process) This should be fixed as a result of the services work that was done in the last couple of weeks and the last

Re: [PATCH 4/4] configure.ac: Add support for MSVC.

2008-04-04 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: MSVC needs a lot more in the way of rule changes and/or helper scripts for it to work properly, but this is a good start. I'm not sure I see the point. You can't really run configure or make on an MSVC setup anyway

Re: Crossbuild patch, appropriate for wine?

2008-04-04 Thread Robert Shearman
John Klehm wrote: diff --git a/include/excpt.h b/include/excpt.h index 3369f3b..081fb06 100644 --- a/include/excpt.h +++ b/include/excpt.h @@ -46,6 +46,10 @@ typedef enum _EXCEPTION_DISPOSITION unsigned long __cdecl _exception_code(void); void * __cdecl _exception_info(void); int

Re: Crossbuild patch, appropriate for wine?

2008-04-04 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: Actually, I think the best place to fix this is in include/wine/exception.h. I also think it would be better to use defined(__MINGW32__) !defined(USE_COMPILER_EXCEPTIONS). This is because that is the platform

Re: msi: Remove tentative definition of static array with no size specifier

2008-04-03 Thread Robert Shearman
Andrew Talbot wrote: James Hawkins wrote: It's ugly. What warning are you trying to fix? Although I imagine that gcc doesn't do anything particularly adverse as a result of the existing code, if the pedantic switch were applied it would cause a message of the following type to

Re: Hey all, introducing myself and my GSoC idea...

2008-04-01 Thread Robert Shearman
James Hawkins wrote: On Mon, Mar 31, 2008 at 8:11 PM, Juan Lang [EMAIL PROTECTED] wrote: Personally, I've thought that playing around with the native LPC API might be interesting. I'm sure there are other areas of the native API that are sparsely documented, and for which some test

Re: midl question

2008-03-31 Thread Robert Shearman
Alistair Leslie-Hughes wrote: Hi Rob, What work would need to be done to get widl to support __stdcall? The issue is that widl doesn't support functions in typedefs. Further issues are that widl doesn't support writing out the function typedef once parsed and widl doesn't store the calling

Re: amstream: IAMMultiMediaStream::EnumMediaStreams

2008-03-28 Thread Robert Shearman
Nikolay Sivov wrote: @@ -144,9 +144,18 @@ { IAMMultiMediaStreamImpl *This = (IAMMultiMediaStreamImpl *)iface; -FIXME((%p/%p)-(%ld,%p) stub!\n, This, iface, Index, ppMediaStream); +TRACE((%p/%p)-(%d,%p)\n, This, iface, Index, ppMediaStream); -return E_NOTIMPL; +

Re: [PATCH 3/7] services: Start a local RPC server.

2008-03-28 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: +handle_t __RPC_USER MACHINE_HANDLEW_bind(MACHINE_HANDLEW MachineName) +{ +WCHAR transport[] = SVCCTL_TRANSPORT; +WCHAR endpoint[] = SVCCTL_ENDPOINT; +LPWSTR server_copy = NULL; +RPC_WSTR binding_str

Re: amstream: IMediaStream::GetMultiMediaStream

2008-03-28 Thread Robert Shearman
Nikolay Sivov wrote: @@ -109,9 +109,14 @@ { IMediaStreamImpl *This = (IMediaStreamImpl *)iface; -FIXME((%p/%p)-(%p) stub!\n, This, iface, ppMultiMediaStream); +TRACE((%p/%p)-(%p)\n, This, iface, ppMultiMediaStream); -return S_FALSE; +if(!(*ppMultiMediaStream))

Re: midl question

2008-03-27 Thread Robert Shearman
Alistair Leslie-Hughes wrote: Hi, In an IDL file I need to define the following typedef HRESULT (__stdcall *FExecuteInAppDomainCallback) (void* cookie); How do i get midl to understand what __stdcall is defined to? midl or widl? AFAIK midl supports the __stdcall keyword. -- Rob

Re: widl: Use is_string_type for detecting strings in write_typeformatstring_var to make it consistent with write_remoting_arg.

2008-03-27 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: Fix the is_string_type function used for detecting strings by only examining aliases instead of both aliases and pointers. This is due to the requirement that pointers to strings be handled as pointers and so

Re: GSOC proposal - control panel

2008-03-27 Thread Robert Shearman
[EMAIL PROTECTED] wrote: No dice. CPls are DLLs that export a function - CPlApplet(). winegcc coughs on dllexport. - not implemented. __declspec(dllexport) is a MSVC-only feature. Hence, when compiling with gcc (even using winegcc) it won't actually export the function. As has been

Re: wininet: Implement chunked reads.

2008-03-26 Thread Robert Shearman
Hans Leidekker wrote: static DWORD HTTPREQ_ReadFile(WININETHANDLEHEADER *hdr, void *buffer, DWORD size, DWORD *read) { WININETHTTPREQW *req = (WININETHTTPREQW*)hdr; +static WCHAR encoding[20]; +DWORD buflen = sizeof(encoding); +static const WCHAR szChunked[] =

Re: Version of Windows

2008-03-19 Thread Robert Shearman
Chris Teague wrote: This is probably trivial, but I'm having a tough time figuring out the current version of Windows that Wine is mimicking. I have a situation where I need to behave differently if the version is NT (0x0500) versus when it is XP (0x0600). I see the WINVER #define, but that

Re: Alexandre Julliard : winex11: Fix bug report address

2008-03-19 Thread Robert Shearman
Groeschel, Volker wrote: The Patch points to wine-cvs. Shouldn't it point to wine-devel. Not in the version of the patch I'm looking at: if (! is_tablet_cursor(target-name, device_type)) { -WARN(Skipping device %d [name %s|type %s]; not apparently a

Re: user32: Test destroying the cursor of a parent process.

2008-03-18 Thread Robert Shearman
Saulius Krasuckas wrote: * On Tue, 8 Jan 2008, Eric Pouech wrote: * Andrew Riedi a écrit : dlls/user32/tests/cursoricon.c | 201 ... +static void do_child(void) +{ +WNDCLASS class; +MSG msg; +BOOL ret; + +

Re: services.exe/advapi32[3/7]: start a local RPC server

2008-03-17 Thread Robert Shearman
Mikołaj Zalewski wrote: @@ -231,6 +247,101 @@ static inline LPWSTR SERV_dupmulti(LPCSTR str) } /** + * RPC connection with servies.exe + */ + +static BOOL check_services_exe() +{ Put void in the

Re: services.exe/advapi32[5/7]: Move QueryServiceConfig to services.exe

2008-03-17 Thread Robert Shearman
by chance on the pointer occupying the lpLoadOrderGroup; it could just as well have been lpBinaryName, lpServiceStartName or lpDisplayName. + +/* Windows function 0x11 must be using a different prototype - not compatible */ +/* Robert Shearman thinks there should be a byte_count attribute

Re: services.exe/advapi32[7/7]: move GetServiceDisplayName to services.exe and implement GetServiceKeyName

2008-03-17 Thread Robert Shearman
Mikołaj Zalewski wrote: +/* Windows function 0x14 must be using a different prototype - not compatible */ +DWORD svcctl_GetServiceDisplayNameW( +SvcCtlRpcHandle rpc_handle, +[in] POLICY_HANDLE *hSCManager, +[in] LPCWSTR lpServiceName, +

Re: Running services in WINE?

2008-03-14 Thread Robert Shearman
Paul Vriens wrote: James Hawkins wrote: On Fri, Mar 14, 2008 at 8:03 AM, Paul Vriens [EMAIL PROTECTED] wrote: Christopher wrote: Maarten Lankhorst wrote: Hi Christopher, 2008/3/12, Christopher [EMAIL PROTECTED]: I've been trying to get MozyHome working on WINE, and

Re: Hans Leidekker : wininet: Make sure not to overwrite any caller supplied authorization header.

2008-03-12 Thread Robert Shearman
Alexandre Julliard wrote: Module: wine Branch: master Commit: b069ef4268e7056856ce6714714d929165f24fc8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b069ef4268e7056856ce6714714d929165f24fc8 Author: Hans Leidekker [EMAIL PROTECTED] Date: Fri Feb 1 14:40:15 2008 +0100

Re: compile fail on Linux Mint

2008-03-11 Thread Robert Shearman
Chad Harris wrote: Just tried to compile wine.. ( Yes, I know theres a package ) but sometimes I'm sadistic enough to want to compile somethin.. and it just keeps failing.. perhaps you can shed some light on what's goin' wrong? You need to install glibc and associated development

Re: a patch to fix the font in bottons and so on.

2008-03-10 Thread Robert Shearman
彭思 wrote: Hi everyone, I have a patch in ubuntu China forum, which fix the font in bottons and so on to display correctly using the right font. This patch changes only one source file: dlls/gdi32/freetype.c. The main function is: Default and ansi charset is translated to

Re: Make winecfg DPI interval to be the same as in Windows

2008-03-07 Thread Robert Shearman
L. Rahyen wrote: @@ -37,7 +37,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(winecfg); #define RES_MAXLEN 5 /* the maximum number of characters in a screen dimension. 5 digits should be plenty, what kind of crazy person runs their screen 10,000 pixels across? */ #define MINDPI 96 -#define MAXDPI 160

Re: [3/6] qmgr: Add a mutex to BackgroundCopyJob.

2008-03-07 Thread Robert Shearman
Dan Hipschman wrote: Pretty much the same as yesterday but I changed to using mutexes instead of critical sections since I need to wait on two at once (one for the job and the other for the file when updating progress). I'm not sure this is a correct reason for mutexes instead of critical

Re: msi: Fix cast-qual warnings

2008-03-03 Thread Robert Shearman
James Hawkins wrote: module = LoadLibraryExW( file-TargetPath, NULL, LOAD_LIBRARY_AS_DATAFILE ); if (module) { -LPCWSTR guid; -guid = MSI_RecordGetString(row,1); -CLSIDFromString((LPWSTR)guid, tl_struct.clsid); +LPWSTR guid; +guid =

Re: ntdll: Added support for Windows 2008

2008-03-03 Thread Robert Shearman
Alistair Leslie-Hughes wrote: sizeof(RTL_OSVERSIONINFOEXW), 6, 0, 0x1770, VER_PLATFORM_WIN32_NT, {' ',0}, 0, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 0 +}, +/* WIN2K8 */ +{ +sizeof(RTL_OSVERSIONINFOEXW), 6, 0, 0x1771,

Re: Building dlls/oleaut32/tests/olepicture.c under Cygwin?

2008-03-03 Thread Robert Shearman
Dan Kegel wrote: 7. Try compiling again. Now you fail with a handful of errors like /cygdrive/c/DOCUME~1/Liz/LOCALS~1/Temp/ccXL7SF3.o:olepicture.c:(.text+0x18e5): u ndefined reference to `_IPictureDisp_Invoke' Seems like a portability problem in tests/olepicture.c. From ocidl.h: #define

Re: [PATCH] shlwapi: Handle PathCanonicalize with too long paths

2008-02-29 Thread Robert Shearman
Marcus Meissner wrote: lpszPath) { WCHAR szPath[MAX_PATH]; WCHAR szBuff[MAX_PATH]; -MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); +DWORD le = GetLastError(); +int ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); + +if (!ret) { +

Re: dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.

2008-02-29 Thread Robert Shearman
Paul Vriens wrote: Robert Shearman wrote: --- dlls/dxdiagn/provider.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Is there a need to have it assigned, as the next line overwrites boolret again

Re: kernel32 winelib: Don't test string size in CompareStringW for null terminated strings

2008-02-29 Thread Robert Shearman
Adam Strzelecki wrote: During playing with installing Visual Studio 2005 with WINE I found out that WINE's MSI is spending lot of time inside lstrcmpW. With Mac OS X process sampler I checked that actually 60-70% of CompareStringW is wine_compare_string, rest is rest of function body, which

Re: kernel32 winex11: WaitForMultipleObjectsEx should ignore NULL handles

2008-02-29 Thread Robert Shearman
Adam Strzelecki wrote: Hi, In MSI dialog.c: msi_dialog_check_messages function it often happens that is sends: MsgWaitForMultipleObjects( 1, handle, 0, INFINITE, QS_ALLINPUT ); Where handle = NULL. I'm not sure if it is correct behavior. But tracing it down I found out that kernel32 and

Re: marshalled ITypeComp

2008-02-26 Thread Robert Shearman
Guillermo Winkler wrote: Hi, I'm having some problems regarding ITypeInfo/ITypeComp implementation. IDispatch* pdisp; ITypeInfo* ptinfo; HRESULT hr = pdisp-GetTypeInfo(0, LOCALE_SYSTEM_DEFAULT, typeinfo); hr = ptinfo-GetTypeComp(ptcomp); pdisp is created from hr =

Re: [3/4].Wbemprox.dll. Main modules for then library.

2008-02-25 Thread Robert Shearman
Ivan Sinitsin wrote: --- /dev/null 2007-03-10 18:36:24 +0300 +++ Makefile.in 2008-02-21 15:57:24 +0300 @@ -0,0 +1,23 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR= @srcdir@ +VPATH = @srcdir@ +MODULE= wbemprox.dll +IMPORTLIB = libwbemprox.$(IMPLIBEXT) +IMPORTS

Re: [2/4]try2.Wbemprox.dll. Idl file.

2008-02-25 Thread Robert Shearman
Ivan Sinitsin wrote: --- /dev/null 2007-03-10 18:36:24 +0300 +++ wbemprox.idl 2008-02-21 16:09:20 +0300 @@ -0,0 +1,260 @@ Then doesn't appear to be a wbemprox.idl file in any version of the Platform SDK that I have access to. The interfaces in your file are in wbemcli.idl instead.

Re: dmband: Indirection levels fix

2008-02-21 Thread Robert Shearman
Andrew Talbot wrote: diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c index 891fb5a..8b89573 100644 --- a/dlls/dmband/band.c +++ b/dlls/dmband/band.c @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD This-pDesc-ftDate =

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.

2008-02-19 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: If we do need it, we can include it in the .l file after config.h and with an appropriate include guard. You should instead put a %option in the files that need it. The point is that all of the files need it. Only

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.

2008-02-19 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: The point is that all of the files need it. Only tools/widl/parser.l needs to include unistd.h and it already does so manually. Then you should put the option in all the files. That sort of thing doesn't belong

Re: slc: Initial stub DLL (try 2)

2008-02-19 Thread Robert Shearman
Alistair Leslie-Hughes wrote: slc: Initial stub dll I'm not sure we want to go down the path of implementing the functions in this DLL. Furthermore, this file isn't present on an XP SP2 installation. Can you give some information as to why this is needed and how the application depends on

Re: iTunes

2008-02-18 Thread Robert Shearman
Maarten Lankhorst wrote: On a slightly related note: Do you know if the hardware drivers are installed somewhere? I would be interested in getting iTunes syncing to my ipod touch (similar to iphone). I didn't see anything in my wineprefix after installation. I don't know about the iPod Touch

Re: include: Add support for executing finally code for exceptions without using a separate function.

2008-02-18 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: The first goal is accomplished by changing the previous two-state variable of __first into a three-state variable where the third state is the state in which the finally code is executed in the normal case. The second

Re: [PATCH] Environment variable to specify X11 window for desktop

2008-02-15 Thread Robert Shearman
Timothy Lee wrote: The attached patch allows the WINE desktop to be embedded within an existing X11 window, and is similar to the windowed mode in WINE. I've tested this feature using MS PowerPoint Viewer 2007, so that a fullscreen slideshow can be fitted inside any X11 window. I'm

Re: [PATCH #1] wininet: Added beginning support for HTTP cache files.

2008-02-13 Thread Robert Shearman
Jacek Caban wrote: +/* FIXME: Better check, when we have to create the cache file */ +if(bSuccess (lpwhr-hdr.dwFlags INTERNET_FLAG_NEED_FILE)) { +WCHAR url[INTERNET_MAX_URL_LENGTH]; +WCHAR cacheFileName[MAX_PATH+1]; +BOOL b; + +b =

Re: systray[3/4]: Better validate icon owner

2008-02-07 Thread Robert Shearman
Kirill K. Smirnov wrote: I don't get why you need this change. PostMessage should correctly handle the case where icon-owner has been destroyed and adding a call to IsWindow just introduces a race condition. Just a testcase: 1) run any wine app (to be sure that explorer is running),

Re: systray[3/4]: Better validate icon owner

2008-02-07 Thread Robert Shearman
Reece Dunn wrote: On 06/02/2008, Robert Shearman [EMAIL PROTECTED] wrote: PostMessage should correctly handle the case where icon-owner has been destroyed and adding a call to IsWindow just introduces a race condition. Is there a test case in the PostMessage tests to verify

Re: systray[3/4]: Better validate icon owner

2008-02-06 Thread Robert Shearman
Kirill K. Smirnov wrote: @@ -131,15 +130,18 @@ static LRESULT WINAPI adaptor_wndproc(HW case WM_LBUTTONDBLCLK: case WM_RBUTTONDBLCLK: case WM_MBUTTONDBLCLK: -/* notify the owner hwnd of the message */ -WINE_TRACE(relaying 0x%x\n, msg); -

Re: systray[2/4]: correctly handle icon addition/deletion

2008-02-06 Thread Robert Shearman
Kirill K. Smirnov wrote: @@ -71,6 +71,12 @@ struct icon static struct tray tray; static BOOL hide_systray; +static BOOL add_icon(NOTIFYICONDATAW *nid); +static BOOL modify_icon(NOTIFYICONDATAW *nid); +static BOOL delete_icon(const NOTIFYICONDATAW *nid); +static BOOL

Re: help with typelib support

2008-01-23 Thread Robert Shearman
Alistair Leslie-Hughes wrote: Hi, This msxml bug requires the TYPELIB resource to be added. http://bugs.winehq.org/show_bug.cgi?id=11257 I modified the followng file as follows. Makefile.in IDL_TLB_SRCS = msxml3_v1.idl msxml3_v1.idl(new File, with a single line) #include msxml2.idl

Re: kernel32: Intialise 16-bit stack to zero.

2008-01-17 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: Otherwise dbghelp could sometimes get confused and think it should switch to 16-bit mode. This results in messages such as the following when warn or tracing for the heap channel is turned on: fixme:dbghelp:Failed

Re: gdi32: Do not allow to create too large device dependent bitmaps like Windows does

2008-01-15 Thread Robert Shearman
Dmitry Timoshkov wrote: +SetLastError(0xdeadbeef); +hbmp = CreateBitmap(0x7ff, 9, 1, 1, NULL); +ok(!hbmp, CreateBitmap should fail\n); +ok(GetLastError() == ERROR_NOT_ENOUGH_MEMORY, + expected ERROR_INVALID_PARAMETER, got %u\n, GetLastError()); The string here

Re: GDI32.dll.NamedEscape

2008-01-14 Thread Robert Shearman
Luis C. Busquets Pérez wrote: I am having problems with a bunch of three games that came together in the same pack. They all abort qhen asking for installation with the following line wine: Call from 0x73ba1895 to unimplemented function GDI32.dll.NamedEscape, aborting Does anybody know

Re: [hlink] Skip tests if hlink couldn't be created

2008-01-14 Thread Robert Shearman
Dan Kegel wrote: This makes the test slightly more robust to operator error. If we're striving to get zero test failures then converting a crash to some failures isn't really much of an improvement. -- Rob Shearman

Re: SVN usage for Wine

2008-01-13 Thread Robert Shearman
James McKenzie wrote: Because git is unstable on the Mac platform, I've been utilizing a little time investigating the use of either SVN or CVS to download .git updates. This appears to not be working per the Wiki pages for SVN. I've been using git releases on my Mac for the last year

Re: Advapi32: Service Control RPC

2008-01-10 Thread Robert Shearman
Rolf Kalbermatter wrote: Robert Shearman [mailto:[EMAIL PROTECTED] wrote: No. Everything (except multi-dimensional arrays, possibly) can already be done by the code we output already. Adding code to output -Oicf proc format strings in widl would be possible, but unnecessary. Ok

Re: Advapi32: Service Control RPC

2008-01-09 Thread Robert Shearman
Rolf Kalbermatter wrote: The current service control API directly accesses the registry for most things. In native those fucntions are simple wrappers around RPC calls to the actual service.exe application. Mikolaj Zalewski offered about 3 months ago a possible aproach to implement the

Re: dlls/kernel32/task.c -- minor improvement

2008-01-07 Thread Robert Shearman
Alexandre Julliard wrote: Gerald Pfeifer [EMAIL PROTECTED] writes: Index: dlls/kernel32/task.c === RCS file: /home/wine/wine/dlls/kernel32/task.c,v retrieving revision 1.2 diff -u -3 -p -r1.2 task.c ---

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2008-01-06 Thread Robert Shearman
Huang, Zhangrong wrote: Hi, Sorry for the delay. Here is a test, pls import the attached registry files, and copy native activeds.dll, adsldpc.dll, adsldp.dll to your windows system32 dir, and patch wine/dlls/ole32/tests/moniker.c Then run the test: $ ../../../wine ole32_test.exe.so

Re: comdlg32: Remove unneeded casts (Resend)

2008-01-02 Thread Robert Shearman
Andrew Talbot wrote: if (fodInfos-ofnInfos-Flags OFN_ALLOWMULTISELECT) size += 1; /* return needed size in first two bytes of lpstrFile */ - *(WORD *)fodInfos-ofnInfos-lpstrFile = size; + *fodInfos-ofnInfos-lpstrFile = size;

Re: [wintab32] Refine how we determine cursor types; use that to discard non tablet devices.

2007-12-27 Thread Robert Shearman
Jeremy White wrote: +/* FIXME: strcasestr is not available on all platforms; implement a simple version */ +static char * poormans_strcasestr(const char *haystack, const char *needle) This is something that can be put in include/wine/port.h. -- Rob Shearman

Re: winex11.drv: driver.c: GET_USER_FUNC

2007-12-21 Thread Robert Shearman
Adam Rimon wrote: Is there any reason for the /do { .. } while(0);/ in the GET_USER_FUNC macro? It's a standard way of making sure that the macro is safe if you put it after an if statement or similar without opening a new block. -- Rob Shearman

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer

2007-12-20 Thread Robert Shearman
Maarten Lankhorst wrote: @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U if ((pStubMsg-Buffer + size pStubMsg-Buffer) || /* integer overflow of pStubMsg-Buffer */ (pStubMsg-Buffer + size pStubMsg-BufferEnd))

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer

2007-12-20 Thread Robert Shearman
Maarten Lankhorst wrote: Hi Rob, Robert Shearman schreef: Maarten Lankhorst wrote: @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U if ((pStubMsg-Buffer + size pStubMsg-Buffer) || /* integer overflow of pStubMsg-Buffer

Re: kernel32: Remove unneeded casts

2007-12-20 Thread Robert Shearman
Andrew Talbot wrote: /* All local heap allocations are aligned on 4-byte boundaries */ #define LALIGN(word) (((word) + 3) ~3) -#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((char*)(ptr)+(arena))) +#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((ptr)+(arena))) Don't

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-20 Thread Robert Shearman
Huang, Zhangrong wrote: See dlls/ole32/compobj.c, static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, BOOL apartment_threaded, REFCLSID rclsid, REFIID riid, void **ppv) {

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Robert Shearman
Andrey Turkin wrote: Robert Shearman wrote: Andrey Turkin wrote: /** *BindIoCompletionCallback (KERNEL32.@) */ +extern NTSTATUS WINAPI RtlSetIoCompletionCallback(HANDLE

Re: gdi32: Add a GdiConvertToDevmodeW test, make it pass under Wine

2007-12-18 Thread Robert Shearman
Dmitry Timoshkov wrote: DEVMODEW *dmW; WORD dmW_size; -dmW_size = dmA-dmSize + CCHDEVICENAME; -if (dmA-dmSize = (const char *)dmA-dmFormName - (const char *)dmA + CCHFORMNAME) +dmW_size = dmA-dmSize; +if (dmW_size sizeof(DEVMODEA)) +dmW_size =

Re: Today's git won't hunt. Server crash, lots of other problems?

2007-12-18 Thread Robert Shearman
Dan Kegel wrote: On Dec 18, 2007 10:29 AM, Susan Cragin [EMAIL PROTECTED] wrote: My git won't install DNS9P any more, as of today's git. Any suggestions? [EMAIL PROTECTED]:~/DNS9$ wine setup fixme:advapi:LookupAccountNameW (null) Lsusan (nil) 0x34b944 (nil) 0x34b948 0x34b93c - stub

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-18 Thread Robert Shearman
Andrey Turkin wrote: /** * BindIoCompletionCallback (KERNEL32.@) */ +extern NTSTATUS WINAPI RtlSetIoCompletionCallback(HANDLE,LPOVERLAPPED_COMPLETION_ROUTINE,ULONG); This should go in

Re: New bugzilla components.

2007-12-16 Thread Robert Shearman
Dmitry Timoshkov wrote: Rename wine-ole - ole32 Add oleaut32, rpcrt4 Currently, all of the above are filed in wine-ole and I don't have a problem with that. Since a common question by our bugzilla advocates is does installing DCOM fix the bug? then this makes sense. Care needs to be

Re: Clear padding in the buffer due to alignment.

2007-12-16 Thread Robert Shearman
Dmitry Timoshkov wrote: Robert Shearman [EMAIL PROTECTED] wrote: This isn't done in MIDL, but I think it's desirable both for silencing Valgrind warnings and for security purposes (fixes potential for leaking information to remote computers or other processes). +print_file(file

Re: Clear padding in the buffer due to alignment.

2007-12-16 Thread Robert Shearman
Dmitry Timoshkov wrote: Robert Shearman [EMAIL PROTECTED] wrote: Is it possible to make it 64-bit and Wine/Windows compatible by using ULONG_PTR instead of long? At the moment, widl doesn't support generating 64-bit compatible client, server and proxy code so doing so would be useless

Re: Tracking down missing controls (drawn)

2007-12-14 Thread Robert Shearman
Alistair Leslie-Hughes wrote: Hi, I've manage to get MS Money 2008 loading there sample file, (with some help from Juan). Nice work. The next issue is trying to get the information to display correctly. The first image is the one currently running in WINE, and the second is within

  1   2   3   4   5   6   7   8   9   10   >