Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-12 Thread Alexandre Julliard
Nikolay Sivov bungleh...@gmail.com writes: Paul Vriens wrote: Not sure for the reason. But one thing I don't like is that this comctl32/msg.c (with no actual tests itself) is also shown on test.winehq.org. Could we get rid of .c file here and move messaging test helpers to header only? It's

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/10 Owen Rudge oru...@codeweavers.com: This is the first of a series of patches to implement the IImageList interface into comctl32, introduced in comctl32 v6. This first patch splits the routines for loading v6 of comctl32 (requiring a side-by-side manifest) out of the listview tests

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Nikolay Sivov
Henri Verbeet wrote: 2009/8/10 Owen Rudge oru...@codeweavers.com: This is the first of a series of patches to implement the IImageList interface into comctl32, introduced in comctl32 v6. This first patch splits the routines for loading v6 of comctl32 (requiring a side-by-side manifest) out

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/11 Nikolay Sivov bungleh...@gmail.com: Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compilation. He didn't move any tests but only

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Paul Vriens
Henri Verbeet wrote: 2009/8/11 Nikolay Sivov bungleh...@gmail.com: Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compilation. He didn't move

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Henri Verbeet
2009/8/11 Paul Vriens paul.vriens.w...@gmail.com: FWIW, these comctl32 tests also already rely on msg.c for all the message related tests. It's probably not much of an issue here then.

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Reece Dunn
2009/8/11 Paul Vriens paul.vriens.w...@gmail.com: Henri Verbeet wrote: 2009/8/11 Nikolay Sivov bungleh...@gmail.com: Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Paul Vriens
Reece Dunn wrote: 2009/8/11 Paul Vriens paul.vriens.w...@gmail.com: Henri Verbeet wrote: 2009/8/11 Nikolay Sivov bungleh...@gmail.com: Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Nikolay Sivov
Paul Vriens wrote: Reece Dunn wrote: 2009/8/11 Paul Vriens paul.vriens.w...@gmail.com: Henri Verbeet wrote: 2009/8/11 Nikolay Sivov bungleh...@gmail.com: Henri Verbeet wrote: I don't know if there's any reason these tests should be an exception, but the general rule is that tests are

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file

2009-08-11 Thread Owen Rudge
Not sure for the reason. But one thing I don't like is that this comctl32/msg.c (with no actual tests itself) is also shown on test.winehq.org. That is something that unfortunately does happen with v6util, too (v6util shows itself as another test in the test list). However, I thought it