Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 3]

2010-10-02 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5709 Your paranoid

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]

2010-10-01 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5679 Your paranoid

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]

2010-10-01 Thread Ricardo Filipe
2010/10/1 Reece Dunn mscl...@googlemail.com: Hi, try 1 -- throw TypeError if T in 'new T' is not an object. try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION instead of IDS_NO_PROPERTY but this

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]

2010-10-01 Thread Jacek Caban
On 10/1/10 9:59 AM, Reece Dunn wrote: Hi, try 1 -- throw TypeError if T in 'new T' is not an object. try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION instead of IDS_NO_PROPERTY but this requires

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

2010-09-30 Thread Jacek Caban
Hi Reece, On 9/30/10 12:20 AM, Reece Dunn wrote: This addresses a fixme in the jscript code that is currently triggered when running the Big Fish Games client, with a test. if(V_VT(constr) != VT_DISPATCH) { -FIXME(throw TypeError\n); +hres =

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

2010-09-30 Thread Reece Dunn
On 30 September 2010 11:25, Jacek Caban ja...@codeweavers.com wrote:  Hi Reece, On 9/30/10 12:20 AM, Reece Dunn wrote: This addresses a fixme in the jscript code that is currently triggered when running the Big Fish Games client, with a test.     if(V_VT(constr) != VT_DISPATCH) { -        

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.

2010-09-29 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5608 Your paranoid