Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Nicolas Le Cam
2012/1/25 Nicolas Le Cam niko.le...@gmail.com: 2012/1/25 Francois Gouget fgou...@free.fr: On Wed, 25 Jan 2012, Detlef Riekenberg wrote: On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote: -    if (usage ~handled) +

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Henri Verbeet
On 25 January 2012 01:25, Francois Gouget fgou...@free.fr wrote: I don't pretend to know what Henry meant but reported_once is not initialized. It's probably put into a zero-initialized section by the compiler but it looks worrying to me (I believe something like this has been debated on the

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Andrew Eikum
On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote: The code looks like it would do what was intended to me. The problem I have with it, and I'm pretty sure I've mentioned this before, is that reducing debug output shouldn't be a goal on its own. If you're a user, and the messages

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Stefan Dösinger
Am 25.01.2012 14:40 schrieb Andrew Eikum aei...@codeweavers.com: What about changing them to WARN so that they don't print to the console by default? Everyone knows there are workarounds, but is anyone really gaining anything by having these flood the console? I agree with this sentiment,

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-24 Thread Detlef Riekenberg
On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote: -if (usage ~handled) +static DWORD reported_once; + +if (usage ~(handled | reported_once)) +{ +reported_once |= (usage ~handled);

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-24 Thread Francois Gouget
On Wed, 25 Jan 2012, Detlef Riekenberg wrote: On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote: -if (usage ~handled) +static DWORD reported_once; + +if (usage ~(handled | reported_once)) +

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-24 Thread Nicolas Le Cam
2012/1/25 Francois Gouget fgou...@free.fr: On Wed, 25 Jan 2012, Detlef Riekenberg wrote: On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote: -    if (usage ~handled) +    static DWORD reported_once; + +    if

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-22 Thread Henri Verbeet
On 22 January 2012 19:44, Detlef Riekenberg wine@web.de wrote: -    if (usage ~handled) +    static DWORD reported_once; + +    if (usage ~(handled | reported_once)) +    { +        reported_once |= (usage ~handled);         FIXME(Unhandled usage flags %#x.\n, usage ~handled); +