Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-08 Thread Detlef Riekenberg
On Mi, 2006-10-04 at 23:22 +0300, Saulius Krasuckas wrote: For the normal case, SetLastError() is called only on failure. http://msdn.microsoft.com/library/en-us/debug/base/setlasterror.asp Do we trust MSDN when we can check things ourselves? No, we don't trust, right? :) We trust

Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-03 Thread Saulius Krasuckas
Hello, Dmitry, * On Wed, 27 Sep 2006, Dmitry Timoshkov wrote: * Saulius Krasuckas [EMAIL PROTECTED] wrote: memset(filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee);

Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-03 Thread Detlef Riekenberg
On Di, 2006-10-03 at 20:40 +0300, Saulius Krasuckas wrote: It makes sense to check last error value only if an API has failed, while you are adding last error checks everywhere. Unless you have an application that depends on it, that's wrong. Well, thanks. I'll change that, but is it

Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-09-27 Thread Dmitry Timoshkov
Saulius Krasuckas [EMAIL PROTECTED] wrote: memset(filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee); Please use a usual value we all agreed to use: 0xdeadbeef. It makes sense to