Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-12 Thread Jerry Jenkins
Dimitrie O. Paun wrote: Why do we need the static? Had I pasted more source code, you would have known why. LONG ALSA_WaveInit(void) { snd_pcm_t* h = NULL; snd_pcm_info_t *info; snd_pcm_hw_params_t * hw_params; WINE_WAVEOUT* wwo;

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-11 Thread Jerry Jenkins
Index: dlls/winmm/winealsa/audio.c === RCS file: /home/wine/wine/dlls/winmm/winealsa/audio.c,v retrieving revision 1.20 diff -u -r1.20 audio.c --- dlls/winmm/winealsa/audio.c22 Sep 2003 21:13:33 - 1.20 +++

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-11 Thread Sylvain Petreolle
Was something like this already applied to CVS ? This could explain why I got garbage into winealsa for the device names. +chardevice[] = hw; I think it should be static char device[] = hw; Why is that? In fact, I think it shouldn't, if it

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-11 Thread Jerry Jenkins
Dimitrie O. Paun wrote: On October 11, 2003 03:42 am, Jerry Jenkins wrote: +chardevice[] = hw; I think it should be static char device[] = hw; Why is that? In fact, I think it shouldn't, if it gets modified during the call, we'll end up passing

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-11 Thread Dimitrie O. Paun
On October 12, 2003 01:00 am, Jerry Jenkins wrote: If we keep device[], we need the static keyword to make winealsa work. Why do we need the static? -- Dimi.