Re: Anotated 'make test' log

2010-07-18 Thread Max TenEyck Woodbury
On 07/17/2010 10:27 AM, Detlef Riekenberg wrote: Hi Max Welcome to Wine. Your Patch [Add '_ONCE' variants of DPRINTF, FIXME, WARN.] ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE Thank you! Fixed and resubmitted.

Re: Anotated 'make test' log

2010-07-17 Thread Detlef Riekenberg
Hi Max Welcome to Wine. Your Patch [Add '_ONCE' variants of DPRINTF, FIXME, WARN.] ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE -- By by ... Detlef ___ Neu:

Re: Anotated 'make test' log

2010-06-17 Thread Max TenEyck Woodbury
On 06/16/2010 04:48 PM, Dan Kegel wrote: Max wrote: [Maybe we should modify FIXME itself to only print out once.] That's worth discussing, but changing FIXME itself might be going a bit too far during the current code freeze. You could try adding a FIXME_ONCE macro, though, and use it to

Re: Anotated 'make test' log

2010-06-16 Thread Max TenEyck Woodbury
Dan wrote: OK. I'd suggest starting by looking at http://bugs.winehq.org/show_bug.cgi?id=15435 Wine logs too verbose, quieter fixme's needed and sending in a patch to make one of the overly-verbose fixme's a bit quieter. Thanks. I'll look at it. Also, check your mail system; I can't

Re: Anotated 'make test' log

2010-06-16 Thread Max TenEyck Woodbury
Dan wrote: OK. I'd suggest starting by looking at http://bugs.winehq.org/show_bug.cgi?id=15435 Wine logs too verbose, quieter fixme's needed and sending in a patch to make one of the overly-verbose fixme's a bit quieter. Thanks. I'll look at it. Summary: Wine logs too verbose, quieter

Re: Anotated 'make test' log

2010-06-16 Thread Dan Kegel
Max wrote: [Maybe we should modify FIXME itself to only print out once.] That's worth discussing, but changing FIXME itself might be going a bit too far during the current code freeze. You could try adding a FIXME_ONCE macro, though, and use it to quiet some particular message that really gets

Re: Anotated 'make test' log

2010-06-16 Thread James McKenzie
Dan Kegel wrote: Max wrote: [Maybe we should modify FIXME itself to only print out once.] That's worth discussing, but changing FIXME itself might be going a bit too far during the current code freeze. You could try adding a FIXME_ONCE macro, though, and use it to quiet some

Re: Anotated 'make test' log

2010-06-15 Thread Dan Kegel
Max wrote: A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. OK. I'd suggest starting by looking at http://bugs.winehq.org/show_bug.cgi?id=15435 Wine logs too verbose, quieter fixme's needed and sending in

Anotated 'make test' log

2010-06-13 Thread Max TenEyck Woodbury
I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A

re: Anotated 'make test' log

2010-06-13 Thread Dan Kegel
What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive