RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-09 Thread Andreas Rosenberg
Thanks for the clarification about todo_wine, Paul Paul Vriens wrote: Well I don't think it will be accepted as is. We usually don't add functions that are not used anywhere especially when the comments say that there is a bug elsewhere that should be fixed first. Well, I was thinking about

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-08 Thread Andreas Rosenberg
Thanks for your hints, Paul. I added some tests for the Ansi variant of the function and fixed the problem you mentioned. I also think that your addition of _GetAccountNameFromTokenW is holding the committing of this patch back, especially because you don't seem to use that function. I also

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-08 Thread Paul Vriens
Andreas Rosenberg wrote: Thanks for your hints, Paul. I added some tests for the Ansi variant of the function and fixed the problem you mentioned. I also think that your addition of _GetAccountNameFromTokenW is holding the committing of this patch back, especially because you don't seem to

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-06 Thread Paul Vriens
Andreas Rosenberg wrote: Just had a look again on your resend: this doesn't seem correct: +if ( lpcchSize lpcchSize ) I also think that your addition of _GetAccountNameFromTokenW is holding the committing of