Re: RESEND [wininet]add implementation of few more options

2005-11-09 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: In your Last suggestion if i initialize the length variable in the tests, the native simply gives garbage, thats inorder to make the test pass. I too dont know much about how use the wininet apis, i just wrote a simple test prog to get test

Re: RESEND [wininet]add implementation of few more options

2005-11-09 Thread Vijay Kiran Kamuju
About uninitalizing the length variable, if the tests bomb in windows, dont ask me. well i will put them in anew patch once this gets accepted. i have still some more tests and implementation to go. This is just the beggining. Thanks, Vijay PS: - Why this always happens to me :( . On

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: as previous implementation had some bugs use this version +case INTERNET_OPTION_VERSION: { -if (*lpdwBufferLength sizeof(HTTP_VERSION_INFO)) -INTERNET_SetLastError(ERROR_INSUFFICIENT_BUFFER); +

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Andreas Mohr
Hi, On Wed, Nov 09, 2005 at 12:07:57AM +0800, Dmitry Timoshkov wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: + char useragent[] = {'W','i','n','i','n','e','t',' ','T','e','s','t',0 }; char useragent[] = Wininet Test; works just fine. Maybe it works, but not fine ;) static const

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Robert Shearman
Vijay Kiran Kamuju wrote: +case INTERNET_OPTION_ASYNC: +case INTERNET_OPTION_ASYNC_ID: +case INTERNET_OPTION_ASYNC_PRIORITY: +case INTERNET_OPTION_CALLBACK_FILTER: +case INTERNET_OPTION_CODEPAGE: +case INTERNET_OPTION_CONNECT_BACKOFF: +

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
Hi, I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for the same options. next time i will think of something valid. In your third suggestion, you asked me not to

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread James Hawkins
On 11/9/05, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: In your third suggestion, you asked me not to set to 0, if set to 0xdeadbeef, that means i have to check for 0xdeadbeef. :(. when does API set its error to 0, what might be the cases generally. You have to set the last error to a crazy

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
I tried in test program initilizing the length varaible like DWORD len=0; Then its giving me garbage, didnt try other possibilities. Thanks, Vijay On 11/9/05, James Hawkins [EMAIL PROTECTED] wrote: On 11/9/05, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: In your third suggestion, you asked me

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for the same options. next time i will think of something valid.

Re: RESEND [wininet]add implementation of few more options

2005-11-08 Thread Vijay Kiran Kamuju
On 11/9/05, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I have made changes, sending them soon. Dimitry: In your first suggestion, i think using a new variable is not a good idea. It has been done like that for all options and previously for