Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: 2013/2/5 J. Bruce Fields bfie...@fieldses.org: On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: 2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote:

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: Nothing prevents it. If somebody grabbed a share mode lock on a file before we call deny_lock_file, we simply

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:00:13PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote:

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-08 Thread J. Bruce Fields
On Thu, Feb 07, 2013 at 08:50:16PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: That would be a bug, I think. E.g. man 3posix open: No files shall be created or modified if the function returns -1. Looking at the code... See the

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/5 J. Bruce Fields bfie...@fieldses.org: On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: 2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: Nothing prevents it. If somebody grabbed a share mode lock on a file before we call deny_lock_file, we simply close this file and return -ETXTBSY. But leave the newly-created file

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 06:32:38PM +0400, Pavel Shilovsky wrote: 2013/2/7 J. Bruce Fields bfie...@fieldses.org: On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: Nothing prevents it. If somebody grabbed a share mode lock on a file

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-07 Thread Pavel Shilovsky
2013/2/7 J. Bruce Fields bfie...@fieldses.org: That would be a bug, I think. E.g. man 3posix open: No files shall be created or modified if the function returns -1. Looking at the code... See the references to FILE_CREATED in atomic_open--looks like that's trying to

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-05 Thread Pavel Shilovsky
2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are translated to flock's flags: !O_DENYREAD - LOCK_READ !O_DENYWRITE - LOCK_WRITE O_DENYMAND - LOCK_MAND and

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-02-05 Thread J. Bruce Fields
On Tue, Feb 05, 2013 at 03:45:31PM +0400, Pavel Shilovsky wrote: 2013/1/31 J. Bruce Fields bfie...@fieldses.org: On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are translated to flock's flags: !O_DENYREAD -

Re: [PATCH v2 3/8] vfs: Add O_DENYREAD/WRITE flags support for open syscall

2013-01-30 Thread J. Bruce Fields
On Thu, Jan 17, 2013 at 08:52:59PM +0400, Pavel Shilovsky wrote: If O_DENYMAND flag is specified, O_DENYREAD/WRITE/MAND flags are translated to flock's flags: !O_DENYREAD - LOCK_READ !O_DENYWRITE - LOCK_WRITE O_DENYMAND - LOCK_MAND and set through flock_lock_file on a file. This