Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-12 Thread Aric Stewart
It seems to be 'OK' for X11 to return that because everyone in the X11 universe seems to just accept that as how X works. Not fixing it wine would mean require all wine users to use something like xmodmap to modify their own xservers to get the correct behavior. That doesn't seem like an

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-12 Thread Dmitry Timoshkov
Aric Stewart a...@codeweavers.com wrote: It seems to be 'OK' for X11 to return that because everyone in the X11 universe seems to just accept that as how X works. Could you please provide an example of this? How other projetcs cope with that? Having an appropriate X11 keyboard layout

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-12 Thread Andrew Eikum
Dmitry Timoshkov wrote: Aric Stewart a...@codeweavers.com wrote: It seems to be 'OK' for X11 to return that because everyone in the X11 universe seems to just accept that as how X works. Could you please provide an example of this? How other projetcs cope with that? Having an appropriate

Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Andrew Eikum
A bug made itself present in VkKeyScan's handling of the less-than character on US (and other) keyboard layouts. VkKeyScan('') in Windows returns 0x1bc, which is VK_OEM_COMMA with the shift key flag set. In Wine, VkKeyScan('') returns 0xe2, which is VK_OEM_102, or the VK for the infamous

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Andrew Eikum
Andrew Eikum wrote: A bug made itself present in VkKeyScan's handling of the less-than character on US (and other) keyboard layouts. VkKeyScan('') in Windows returns 0x1bc, which is VK_OEM_COMMA with the shift key flag set. In Wine, VkKeyScan('') returns 0xe2, which is VK_OEM_102, or the VK

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-11 Thread Dmitry Timoshkov
Andrew Eikum aei...@codeweavers.com wrote: The root cause of this is X's XKeysymToKeycode returning the keycode for the phantom key instead of the keycode for the comma key when passed the keysym for '' (XK_less). This isn't incorrect on X's part, but inconvenient for Wine as most US