Re: advpack: Handle dwFlags for DelNode with tests

2005-12-03 Thread James Hawkins
On 12/1/05, James Hawkins [EMAIL PROTECTED] wrote: Hi, I changed the invalid CharPrev != \\ comparison to string[len] != '\\'. Changelog * Use DelNode itself for the directory recursion. * Handle the dwFlags parameter. * Factor out file creation and deletion. * Add test cases for DelNode

Re: advpack: Handle dwFlags for DelNode with tests

2005-12-01 Thread Alexandre Julliard
James Hawkins [EMAIL PROTECTED] writes: +/* Generate a path with wildcard suitable for iterating */ +if (CharPrevA(szFilename, szFilename + iLen) != \\) +{ I don't think this means what you think it means ;-) -- Alexandre Julliard [EMAIL PROTECTED]

Re: advpack: Handle dwFlags for DelNode with tests

2005-12-01 Thread James Hawkins
On 12/1/05, Alexandre Julliard [EMAIL PROTECTED] wrote: James Hawkins [EMAIL PROTECTED] writes: +/* Generate a path with wildcard suitable for iterating */ +if (CharPrevA(szFilename, szFilename + iLen) != \\) +{ I don't think this means what you think it means ;-)

Re: advpack: Handle dwFlags for DelNode with tests

2005-12-01 Thread Andreas Mohr
Hi, On Thu, Dec 01, 2005 at 02:45:37PM +, James Hawkins wrote: On 12/1/05, Alexandre Julliard [EMAIL PROTECTED] wrote: James Hawkins [EMAIL PROTECTED] writes: +/* Generate a path with wildcard suitable for iterating */ +if (CharPrevA(szFilename, szFilename + iLen)

Re: advpack: Handle dwFlags for DelNode with tests

2005-12-01 Thread Mike Hearn
On Thu, 01 Dec 2005 11:28:29 +0100, Alexandre Julliard wrote: +/* Generate a path with wildcard suitable for iterating */ +if (CharPrevA(szFilename, szFilename + iLen) != \\) +{ James, it should be if (CharPrevA(szFilename, szFilename + iLen) != '\\') { } Note the