On Tue, Sep 20, 2005 at 04:20:50PM -0500, Robert Shearman wrote:
> Since this was a behaviour in our file open dialog, did we even verify
> that this was a listview bug or is it that destroying the listview in
> the middle of a notification is something that you shouldn't do? If the \
A quick te
Hi all,
I've scanned wine-devel and wine-patches and have seen that more patches got
in to fix the file dialog crash, but that none was applied. Was there any
consensus on how this should be fixed?
Bye,
--
Michael Jung
[EMAIL PROTECTED]
On Tue, Sep 20, 2005 at 11:32:38PM -0400, Dimi Paun wrote:
> This is true only if we rely on the access violation exception
> (which is a possibility, I admit). But the test patch that I sent
> checked the hwnd after each notify message with IsWindow(), and
> if invalid it was throwing a custom exc
On Tue, 20 Sep 2005 16:20:50 -0500
Robert Shearman <[EMAIL PROTECTED]> wrote:
> Since this was a behaviour in our file open dialog, did we even verify
> that this was a listview bug or is it that destroying the listview in
> the middle of a notification is something that you shouldn't do?
The n
On Wed, 2005-09-21 at 00:11 +0200, Lionel Ulmer wrote:
> Correct me if I am wrong (I know absolutely nothing about how the
> listview code works) but a flaw of the 'exception based' solution
> would be if the application allocated memory that would re-use the
> just freed memory pointed by 'infoPtr
On Tue, Sep 20, 2005 at 11:51:00AM -0400, Dimi Paun wrote:
> I personally think an exception-based solution would be better.
> This is what exceptions where invented.
(...)
Correct me if I am wrong (I know absolutely nothing about how the listview
code works) but a flaw of the 'exception based' so
Michael Jung wrote:
Hello Alexandre, Dimi and Phil,
This is a patch for the infoPtr problem in comctl32's listview.c. I guess it
matches your suggestion on IRC? I've only changed the minimum necessary to
get rid of the file dialog crash. If that's the correct approach in your
opinion, I will
> Dimi, if you think this is ugly, or if you are working on a better
solution,
> please do protest.
Well, in part it's a matter of style, and IMO this will clutter the code.
Moreover, the patch as it is now works by accident. For example:
/* send NM_RELEASEDCAPTURE notification */
- notify(in
