RE: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-14 Thread Greg Geldorp
From: Reece Dunn mscl...@googlemail.com msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not registered. This does not fail on the test page, as the msxml3 tests are skipped when msxml3.dll is not present. It would probably be better to issue a win_skip in this instance, but it is

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread Nikolay Sivov
On 6/13/2010 22:55, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()

2010-06-13 Thread Reece Dunn
On 13 June 2010 20:46, Nikolay Sivov nsi...@codeweavers.com wrote: On 6/13/2010 22:55,  (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please