Re: sorry one more question: assert statements in tests

2010-07-10 Thread Reece Dunn
On 10 July 2010 03:40, Misha Koshelev misha...@gmail.com wrote: I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_ dimensions). * patch 2: separate into function that works with

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
On Sat, 2010-07-10 at 07:40 +0100, Reece Dunn wrote: On 10 July 2010 03:40, Misha Koshelev misha...@gmail.com wrote: I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Reece Dunn
On 10 July 2010 17:40, Misha Koshelev misha...@gmail.com wrote: On Sat, 2010-07-10 at 07:40 +0100, Reece Dunn wrote: On 10 July 2010 03:40, Misha Koshelev misha...@gmail.com wrote: Ok that makes sense. What about in the case of something like this: /*

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
Thank you for the explanation. maxUlps is in fact a constant. Although the asserts in my previous question re incremental patches were also only applicable due to programmer error. However, I think in that case a skip is much more appropriate if nothing else because it is immediately clear the

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
Just for thoroughness and clarity... I would like to put BOTH a skip that outputs that test was skipped and assert that then keeps any further damage being done. This is in the case of maxUlps. Any objections? Thanks Misha On Jul 10, 2010 12:11 PM, Reece Dunn mscl...@googlemail.com wrote:

sorry one more question: assert statements in tests

2010-07-09 Thread Misha Koshelev
I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_ dimensions). * patch 2: separate into function that works with arbitrary dimensions for the box, etc. I restrict to the dimensions