Re: [1/6] try 2: msvcrt: Implement strcpy_s

2007-11-16 Thread Stefan Dösinger
Am Freitag, 16. November 2007 00:45:47 schrieb Detlef Riekenberg: On Do, 2007-11-15 at 17:35 +0100, Stefan Dösinger wrote: +memset(dest, 'X', sizeof(dest)); +ret = pstrcpy_s(dest, sizeof(dest), small); +ok(ret == 0, Copying a string into a big enough destination returned %d,

Re: server: Add a call for retrieving the image file name of a process.

2007-11-16 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: --- dlls/ntdll/process.c| 20 +++- dlls/ntdll/tests/info.c | 36 server/process.c| 31 +++ server/protocol.def |9 + 4 files changed,

Re: ntdll: send_debug_event: don't send uninitialized bytes

2007-11-16 Thread Robert Shearman
Dan Kegel wrote: +/* Returns size of initialized part of a particular EXCEPTION_RECORD */ +static int exception_record_size( const EXCEPTION_RECORD *rec ) +{ +return sizeof(*rec) +- (EXCEPTION_MAXIMUM_PARAMETERS-rec-NumberParameters) * sizeof(ULONG_PTR); +} FIELD_OFFSET exists

winetest_interactive : how does it work?

2007-11-16 Thread Paul Vriens
Hi, I just ran winetest (by double clicking on the executable) on my WinXP box. I was missing some advpack popups that were there before. Francois sent in a patch to only do some particular tests when winetest_interactive is true. I would assume that clicking on a executable is interactive,

Re: ntdll: send_debug_event: don't send uninitialized bytes

2007-11-16 Thread Dan Kegel
On Nov 16, 2007 3:06 AM, Robert Shearman [EMAIL PROTECTED] wrote: +return sizeof(*rec) +- (EXCEPTION_MAXIMUM_PARAMETERS-rec-NumberParameters) * sizeof(ULONG_PTR); FIELD_OFFSET exists for this exact purpose. OK, I'll bite: is +return FIELD_OFFSET(EXCEPTION_RECORD,

Re: [PATCH] svchost: Added base implementation of svchost (1/12)

2007-11-16 Thread Alexandre Julliard
Roy Shea [EMAIL PROTECTED] writes: +/* Allocate and initializes an ANSI version of the Unicode string */ +static LPSTR UnicodeToAnsi(const WCHAR *unicode) +{ +int size; +LPSTR ansi; + +size = WideCharToMultiByte(CP_UTF8, 0, unicode, -1, NULL, 0, NULL, NULL); +ansi =

Re: winetest_interactive : how does it work?

2007-11-16 Thread Francois Gouget
On Fri, 16 Nov 2007, Paul Vriens wrote: Hi, I just ran winetest (by double clicking on the executable) on my WinXP box. I was missing some advpack popups that were there before. Francois sent in a patch to only do some particular tests when winetest_interactive is true. I would assume

Re: Start: Convert start to Unicode. [try5]

2007-11-16 Thread Alexandre Julliard
Anatoly Lyutin [EMAIL PROTECTED] writes: @@ -202,9 +246,9 @@ int main(int argc, char *argv[]) DWORD waitcode; waitcode = WaitForSingleObject(sei.hProcess, INFINITE); if (waitcode) - fatal_error(WaitForSingleObject,

Re: server: Add a call for retrieving the image file name of a process.

2007-11-16 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: get_dll_info doesn't appear to be suitable for this purpose. We don't know what the base address of the EXE is and the call doesn't return the required size for the filename. Well, you have to extend it a bit to support that, but it's better than

Re: server: Add a call for retrieving the image file name of a process.

2007-11-16 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: --- dlls/ntdll/process.c| 20 +++- dlls/ntdll/tests/info.c | 36 server/process.c| 31 +++ server/protocol.def |

Re: ntdll: send_debug_event: don't send uninitialized bytes

2007-11-16 Thread Robert Shearman
Dan Kegel wrote: On Nov 16, 2007 3:06 AM, Robert Shearman [EMAIL PROTECTED] wrote: +return sizeof(*rec) +- (EXCEPTION_MAXIMUM_PARAMETERS-rec-NumberParameters) * sizeof(ULONG_PTR); FIELD_OFFSET exists for this exact purpose. OK, I'll bite: is +return

Re: [1/6] try 2: msvcrt: Implement strcpy_s

2007-11-16 Thread Stefan Dösinger
Am Freitag, 16. November 2007 11:25:39 schrieb Stefan Dösinger: Did you test with invalid pointers (crash / handled graceful)? No, good idea, I'll try that now This crashes signature.asc Description: This is a digitally signed message part.

pglXMakeCurrent causes wine to crash on Mac os x

2007-11-16 Thread Tobias Platen
Hello if i run wine on Mac os x 10.4.10 with Apples X11 (opengl linked staticly) i get the following runtime errors; X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 129 (Apple-DRI) Minor opcode of failed request: 2 ()

Re: USER32: win16 applications should not see long filenames returned from dialog control (try 4)

2007-11-16 Thread Alex Villací­s Lasso
Alex Villacís Lasso escribió: I hope this version addresses the fact DlgDirSelect does not modify the last error code, and therefore cannot be used to distinguish between a valid and an invalid file. Changelog: * Applications should not see long filenames returned from dialog control

Re: [Bug 10464] Regression when installing Skype

2007-11-16 Thread James Hawkins
On 11/16/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: http://bugs.winehq.org/show_bug.cgi?id=10464 --- Comment #5 from Austin English [EMAIL PROTECTED] 2007-11-16 18:33:31 --- James, you can disable bugzilla from e-mailing you for CC's and/or disable all e-mail. Austin, it's not about

Re: svchost: Added base implementation of svchost (1/27)

2007-11-16 Thread Juan Lang
Hi Roy, +#define WIN32_LEAN_AND_MEAN That's not needed if you're not including windows.h (which you're not.) +if (unicode[i] 129) You have an off-by-two error here. 7-bit clean means if (unicode[i] 127). You can also use something like if (unicode[i] 0x80). Stylistic note, use or

Removing Windows and Solaris from the Downloads page

2007-11-16 Thread Scott Ritchie
It appears that the links for the Windows and Solaris versions on the winehq downloads page are very, very old. Since they're no longer maintained, we should just remove them, yes? Thanks, Scott Ritchie