a patch...
No, I think it's better to avoid this. Our test environment is useful
for testing not only Wine but also Mingw, we have already found a
number of bugs that way. We would lose that possibility if we started
adding workarounds that hide the Mingw bugs.
--
Alexandre Julliard
[EMAIL PROTECTED]
Lionel Ulmer [EMAIL PROTECTED] writes:
Is this a VERY verbose Changelog or the new way to see the patch in the
commit log :-) ?
No, it's just the dumb maintainer hitting the wrong key at the wrong
time...
--
Alexandre Julliard
[EMAIL PROTECTED]
the number you had previously in
the config file.
--
Alexandre Julliard
[EMAIL PROTECTED]
Raphael [EMAIL PROTECTED] writes:
Alexandre, instead using copy of the sames files can we use a static library
for sharing this code ?
I'm afraid not, we can't create a separate static library every time
we need to share some code between dlls, it doesn't scale.
--
Alexandre Julliard
[EMAIL
emmanuel maillard [EMAIL PROTECTED] writes:
Changelog
Add macro used to build the Wine configure script
You should make the existing WINE_GET_SONAME macro more general so
that you can use it too, instead of duplicating the whole thing.
--
Alexandre Julliard
[EMAIL PROTECTED]
on. Most likely you need
to fix wine_switch_to_stack or something like that.
--
Alexandre Julliard
[EMAIL PROTECTED]
emmanuel maillard [EMAIL PROTECTED] writes:
Changelog
Add darwin support in read_undef_symbols
That should be based on the __ASM_NAME etc. configure checks.
--
Alexandre Julliard
[EMAIL PROTECTED]
Dmitry Timoshkov [EMAIL PROTECTED] writes:
It would be better to remove a duplicate definition to avoid
such bad things happening in the future.
Yeah that's the plan, it's part of the remaining dll separation
cleanup work.
--
Alexandre Julliard
[EMAIL PROTECTED]
a more recent Wine.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
that Wine is configured for, which is
the wrong thing to do since the behavior of the Wine code in that case
does not depend on the version.
--
Alexandre Julliard
[EMAIL PROTECTED]
Dimitrie O. Paun [EMAIL PROTECTED] writes:
ChangeLog
Fix the _WCHAR_T_DEFINED/_WCHAR_T_DEFINED sentries for
compatibility with the MSVCRT ones.
Unfortunately _WCHAR_T_DEFINED is also used by gcc in stddef.h.
--
Alexandre Julliard
[EMAIL PROTECTED]
headers independent
from Wine.
--
Alexandre Julliard
[EMAIL PROTECTED]
have to explicitly pad the
structures that need it.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
(); }
}
If a given call crashes under Win9x then there's probably no point in
testing it that way at all, it's very unlikely that an app would
depend on that. It would be much better to test the function in a way
that doesn't crash on any platform.
--
Alexandre Julliard
[EMAIL PROTECTED]
Ulrich Czekalla [EMAIL PROTECTED] writes:
Hmmm. It didn't work for me when I tried under win2k. I'll investigate it
further.
I added a small test in dlls/user/tests/win.c if it helps.
--
Alexandre Julliard
[EMAIL PROTECTED]
how it would solve issues
like the above anyway.
--
Alexandre Julliard
[EMAIL PROTECTED]
Brett I. Holcomb [EMAIL PROTECTED] writes:
Yes. I just did again and it doesn't work. Same error. Something got
broken again I guess.
Path entries from the config file are no longer used. Check the
contents of your ~/.wine/dosdevices directory.
--
Alexandre Julliard
[EMAIL PROTECTED]
in the makefile.
--
Alexandre Julliard
[EMAIL PROTECTED]
special target, isn't that portable?
No, it's not, and frankly I don't see why you would need that. Could
you please explain a bit more what you are trying to do?
--
Alexandre Julliard
[EMAIL PROTECTED]
Francois Gouget [EMAIL PROTECTED] writes:
* dlls/ntdll/tests/rtlstr.c
Make deststring static const.
The string can't be const, it gets modified.
--
Alexandre Julliard
[EMAIL PROTECTED]
point of view; it may well be that this needs makefile changes, but if
so they need to be done cleanly, which isn't the case with your patch
I'm afraid.
--
Alexandre Julliard
[EMAIL PROTECTED]
not
a proper fix. The right way is to reserve the high memory area so that
things don't get mapped there.
--
Alexandre Julliard
[EMAIL PROTECTED]
that info. The
standard build shouldn't have to worry about these things.
--
Alexandre Julliard
[EMAIL PROTECTED]
in the normal init code.
--
Alexandre Julliard
[EMAIL PROTECTED]
Mike Hearn [EMAIL PROTECTED] writes:
I thought the kernel would be happy to mmap addresses 2gig for the
dynamic linker - no?
It doesn't matter, we don't need that space, we just need to prevent
dlls from getting mapped there.
--
Alexandre Julliard
[EMAIL PROTECTED]
with the remote name?
And BTW please send diff -u patches.
--
Alexandre Julliard
[EMAIL PROTECTED]
, and
WINPOS_ActivateOtherWindow will never be called.
--
Alexandre Julliard
[EMAIL PROTECTED]
something that needs to be tested too. As shown by the XRender
error, that test is exercising some interesting code paths, so I think
it's much better to keep it the way it is.
--
Alexandre Julliard
[EMAIL PROTECTED]
and wineprefixcreate, but it may be best to wait for
them to actually work...
--
Alexandre Julliard
[EMAIL PROTECTED]
to document it?
I think the runtime messages can be removed, the new scheme should
make any manual intervention unnecessary. The documentation about that
will have to be rewritten, so maybe for now we can just put a big
FIXME in there.
--
Alexandre Julliard
[EMAIL PROTECTED]
real app tries to do something with the
results it will fail just as badly as before.
--
Alexandre Julliard
[EMAIL PROTECTED]
of that is going to create a
big mess. It needs a *very* good reason to create a new library, and
if it's just for sharing a couple of structure dumping functions it's
not worth it.
--
Alexandre Julliard
[EMAIL PROTECTED]
coding style; braces don't
need semicolons, and the function body should be indented.
--
Alexandre Julliard
[EMAIL PROTECTED]
not correct.
--
Alexandre Julliard
[EMAIL PROTECTED]
to create the heap.
The process heap can be placed anywhere, this isn't the cause of the
problem. You are confusing it with the shared heap.
--
Alexandre Julliard
[EMAIL PROTECTED]
the read access was optimized out. Try doing the access
through a volatile pointer.
--
Alexandre Julliard
[EMAIL PROTECTED]
[EMAIL PROTECTED]
Please don't add changelog information in the code, that's what the
CVS log and the Changelog file are for.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
, that's a bug.
--
Alexandre Julliard
[EMAIL PROTECTED]
the problem occurs for me.
That's not a fix, that's just hiding the problem. You need to figure
out why the value was not initialized at this point, it's probably a
message order thing.
--
Alexandre Julliard
[EMAIL PROTECTED]
?
--
Alexandre Julliard
[EMAIL PROTECTED]
it from being corrupted, since we only replace the
previous one once the new one has been saved correctly. It would be
interesting to find out exactly how yours managed to get
corrupted. What sort of corruption do you see?
--
Alexandre Julliard
[EMAIL PROTECTED]
the patch.
--
Alexandre Julliard
[EMAIL PROTECTED]
like a filesystem issue, I prefer that g
If you feel like trying to reproduce it, maybe you could try to add an
fsync() in the saving code and see if this makes a difference.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
So, I decided to write a test for that. The test passes under Wine.
Not for me:
class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS
class.c:258: Test failed: GetLastError() should be set to ERROR_CLASS_HAS_WINDOWS
--
Alexandre Julliard
[EMAIL PROTECTED]
.
The message order is wrong because we rely on X expose events to
repaint the window. This is one of the reasons we need to go back to
not using X windows for every window; but until that is done, your fix
is going to cause every window to be repainted twice.
--
Alexandre Julliard
[EMAIL
to MS Windows paste operation.
You are bypassing the reallocation of the buffer when the limit is
exceeded, but still adding the data to the buffer. I don't think this
will work right.
--
Alexandre Julliard
[EMAIL PROTECTED]
possible that you need to grow the buffer even when
the limit is not exceeded. Also you only check the length of the
inserted string against the limit, you should check the total
resulting length instead.
--
Alexandre Julliard
[EMAIL PROTECTED]
for
every API being tested.
--
Alexandre Julliard
[EMAIL PROTECTED]
files, not in the code.
--
Alexandre Julliard
[EMAIL PROTECTED]
of duplication.
--
Alexandre Julliard
[EMAIL PROTECTED]
that things are going to
work right by using the wrong threading version; it may seem to solve
some issues but it will definitely create others.
--
Alexandre Julliard
[EMAIL PROTECTED]
threading version?
Yes, I'd expect it to use wine-kthread in that case.
3. Any way to force wine to start wine-kthread?
You don't want to do that, it won't work right.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
-items[iItem].lParam, 0, infoPtr-cbInfo);
That doesn't look right at all, lParam is not at the end of the
structure. And the variable-size info should really be a byte array or
something similar, not an LPARAM.
--
Alexandre Julliard
[EMAIL PROTECTED]
regression tests to
ensure that the definitions remain in sync.
--
Alexandre Julliard
[EMAIL PROTECTED]
?
Does it make a difference if you bypass the preloader and run
wine-kthread directly?
--
Alexandre Julliard
[EMAIL PROTECTED]
work right.
--
Alexandre Julliard
[EMAIL PROTECTED]
?
No, I don't think we should encourage this kind of version checks.
--
Alexandre Julliard
[EMAIL PROTECTED]
, but I guess either
we have a hack elsewhere, or for some reason the bug doesn't appear in
the builds we support?
There is a hack in Crossover for that, it adds a magic number to the
handle structure. I'll merge it in.
--
Alexandre Julliard
[EMAIL PROTECTED]
now to make sure it works, and to
make the transition easier since most symbols won't change before 1.0.
Backwards compatibility will only be guaranteed after 1.0 is released.
--
Alexandre Julliard
[EMAIL PROTECTED]
in.
--
Alexandre Julliard
[EMAIL PROTECTED]
see any evidence that this is true, and MSDN says If the
lpFileName parameter does not contain a full path and file name for
the file, WritePrivateProfileString searches the Windows directory for
the file. Do you have a test case showing that the current behavior
is wrong?
--
Alexandre Julliard
Filip Navara [EMAIL PROTECTED] writes:
+if (!(hRes = FindResourceW(shell32_hInstance, LSHELL_RUN_DLG,
(LPWSTR)RT_DIALOG)))
You cannot use wide char string constants in Wine.
--
Alexandre Julliard
[EMAIL PROTECTED]
LOCALE_NOUSEROVERRIDE in that case, I don't see how your patch would
make any difference (and win.ini definitely gets refreshed with the
current code). Could you please give more details on the problem you
are seeing?
--
Alexandre Julliard
[EMAIL PROTECTED]
a macro that looks like we do. The proper way is to add exception
handlers in functions where an app explicitly relies on the pointer
check, and not add checks otherwise; using the IsBad*Ptr functions is
always wrong since they are not thread-safe.
--
Alexandre Julliard
[EMAIL PROTECTED]
in all cases, this
should only be done where we are sure we have a dialog window. For
instance you don't want MapDialogRect to add dialog info to arbitrary
windows just because it got passed a wrong handle.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
-local hook, or does some other strange magic; NT refuses to set
a system-wide hook with a NULL module, so I'd expect your app to fail
on NT (except if it does a version check, in which case it should run
on Wine too if you set the Windows version to NT).
--
Alexandre Julliard
[EMAIL PROTECTED]
, not in
the makefile. Also I think it would be cleaner to use a different rc
file for the dist case instead of using #ifdefs.
--
Alexandre Julliard
[EMAIL PROTECTED]
the 3GB
space mark that fact in the PE header somewhere. Can we take
consideration of this marking and honor it?
Sure, this can be done. Do you have an app that needs this?
--
Alexandre Julliard
[EMAIL PROTECTED]
Shachar Shemesh [EMAIL PROTECTED] writes:
Alexandre Julliard wrote:
Sure, this can be done. Do you have an app that needs this?
Yes. Do you want a proof of concept?
If you have one that would be great.
--
Alexandre Julliard
[EMAIL PROTECTED]
Ferenc Wagner [EMAIL PROTECTED] writes:
Alexandre Julliard [EMAIL PROTECTED] writes:
Also I think it would be cleaner to use a different rc
file for the dist case instead of using #ifdefs.
I agree. The problem is the single-rc-file limitation,
which would require some code duplication
space, and why it would be interesting to
get a test case for that failure condition.
--
Alexandre Julliard
[EMAIL PROTECTED]
to be able to test it afterwards otherwise you just get leftovers from
a previous call.
--
Alexandre Julliard
[EMAIL PROTECTED]
. They are actually working on machines with
3GB of RAM, and they need it accessable. I will need to run some
tests, but I think that they mostly do memory allocation and filling,
not mmaps.
Memory allocations are based on mmap.
--
Alexandre Julliard
[EMAIL PROTECTED]
) bChangePos
!X11DRV_is_window_rect_mapped( oldWindowRect )
X11DRV_is_window_rect_mapped( newWindowRect ))
{
--
Alexandre Julliard
[EMAIL PROTECTED]
to ERROR_PATH_NOT_FOUND
The bug is in int21.c. I committed a fix.
--
Alexandre Julliard
[EMAIL PROTECTED]
, while they work
fine today. I think it's better to keep the current way and improve
the auto-detection if needed.
--
Alexandre Julliard
[EMAIL PROTECTED]
= idSaveResult;
It seems you are doing redundant work here, since DEFDLG_SetDefButton
will also send the same WM_GETDLGCODE. Wouldn't a simpler fix be to
have DEFDLG_SetDefButton not set idResult unless it really changed the
default button?
--
Alexandre Julliard
[EMAIL PROTECTED]
, of course you'd need to adapt the DM_SETDEFID handling to the
change. I think that's better than sending duplicate messages.
--
Alexandre Julliard
[EMAIL PROTECTED]
should
all use MSVCRT_.
-- there is a sh script that uses this simple rule
to generate the test file. Do we integrate the
script with the build system?
I think we can simply put the generated code in CVS.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
this).
wineinstall is not out of date, it still works fine, I don't see any
reason to remove it from the doc.
--
Alexandre Julliard
[EMAIL PROTECTED]
.
--
Alexandre Julliard
[EMAIL PROTECTED]
and get treated as if they didn't. I think having different
levels of hand holding for different users makes a lot of sense, and
wineinstall gives us that possibility.
--
Alexandre Julliard
[EMAIL PROTECTED]
don't have
clueless users asking you how to build Wine, but I get quite a bit of
them; and being able to tell them just run tools/wineinstall saves
me a lot of grief.
--
Alexandre Julliard
[EMAIL PROTECTED]
use configure;make and that
there's nothing magical about wineinstall that would require them to
use it. Patches welcome.
--
Alexandre Julliard
[EMAIL PROTECTED]
to also support
source builds.
--
Alexandre Julliard
[EMAIL PROTECTED]
to build the source, that's the best way to find
compilation problems on strange setups.
--
Alexandre Julliard
[EMAIL PROTECTED]
...
An initial set of symlinks will be created by wineprefixcreate; they
can then be modified with winecfg (or by changing the symlinks by hand
of course). The plan is also to have winecfg autodetect cdroms but
that's not done yet.
--
Alexandre Julliard
[EMAIL PROTECTED]
install. Try with current
CVS, there's a bug with SetEndOfFile in 20040615 that probably
explains the problem.
--
Alexandre Julliard
[EMAIL PROTECTED]
needed by old games like TombRaider 2).
There's probably no need to add a special case, we can simply add the
win95 behavior. The question is what that behavior is supposed to be;
in the current design a NULL instance is meaningless.
--
Alexandre Julliard
[EMAIL PROTECTED]
code can't really be made optional.
--
Alexandre Julliard
[EMAIL PROTECTED]
don't think anybody else is
working on that at the moment.
--
Alexandre Julliard
[EMAIL PROTECTED]
little benefit. It's much easier to do it at the syscall level.
--
Alexandre Julliard
[EMAIL PROTECTED]
are really trying to
do is to revert the change in rev 1.94, but this causes other problems
(cf. bug 1435). I think you'll have to write a regression test for
that one.
--
Alexandre Julliard
[EMAIL PROTECTED]
that will allow at some point in the future to run all
possible apps. We shouldn't compromise on a design that guarantees
that some apps will *never* run just because it runs more apps today.
Besides, a completely broken Wine is the best way to ensure that
someone starts worrying about the issue g
--
Alexandre
1 - 100 of 5393 matches
Mail list logo
