Re: [try2] gdiplus/tests: Dynamically load gdiplus.dll.

2009-02-23 Thread Detlef Riekenberg
On Mo, 2009-02-23 at 13:38 +0100, Paul Vriens wrote: Is .NET installed (any version)? My w2k test box has the popup about the missing gdiplus and dotnet is installed. From the dllinfo: gdiplus load error 1359

Re: msi: Add reinstall tests.

2009-02-27 Thread Detlef Riekenberg
On Do, 2009-02-26 at 10:50 +0100, Hans Leidekker wrote: +state = 0xdeadbee; +action = 0xdeadbee; +r = MsiGetFeatureState(hpkg, one, state, action); +ok( r == ERROR_UNKNOWN_FEATURE, Expected ERROR_UNKNOWN_FEATURE, got %d\n, r ); +ok( state == 0xdeadbee, Expected 0xdeadbee,

Re: [imaadp32 2/3] fixed adpcm_FormatSuggest

2009-02-28 Thread Detlef Riekenberg
On Fr, 2009-02-27 at 20:07 +0100, Stefano Guidoni wrote: case WAVE_FORMAT_IMA_ADPCM: -adfs-pwfxDst-nBlockAlign = 1024; + init_wfx_ima_adpcm((IMAADPCMWAVEFORMAT*)adfs-pwfxDst); /* FIXME: not handling header overhead */ TRACE(setting spb=%u\n,

Re: Vacations

2009-03-15 Thread Detlef Riekenberg
On Fr, 2009-03-13 at 20:05 +0100, Alexandre Julliard wrote: Folks, There won't be any commits next week, as I'll be skiing... Have fun and take care -- By by ... Detlef

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Detlef Riekenberg
On Sa, 2009-03-28 at 11:48 +0100, Christian Costa wrote: Thanks for working on this part of Wine. +/** + * MCIAVI_drvClose [internal] + */ +static DWORD MCIQTZ_drvClose(DWORD dwDevID)

Re: mciqtz32: Add basic play capability

2009-03-29 Thread Detlef Riekenberg
On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote: +hr = CoCreateInstance(CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER, IID_IGraphBuilder, (LPVOID*)wma-pgraph); +if (FAILED(hr)) { +TRACE(Cannot create filtergraph (hr = %x)\n, hr); + return MCIERR_INTERNAL; +}

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Detlef Riekenberg
On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: There are some discrepancies in the indentation and I don't mind removing tabs but what's wrong with them, they are commonly use in wine depending on one's taste. Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPACE,

Re: mciqtz32: Implement driver messages

2009-03-30 Thread Detlef Riekenberg
On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. Changing only the

Re: Implement [Un]RegisterHotKey with test

2009-03-31 Thread Detlef Riekenberg
On Mo, 2009-03-30 at 18:17 +0500, Vladimir Pankratov wrote: +return DefWindowProcW (hWnd, msg, wParam, lParam); +WCHAR className[] = {'T','e','s','t','H','o','t','K','e','y',0}; +WCHAR winName[] = {'H','o','t','K','e','y','T','e','s','t',0}; +ATOM classatom; +

Re: gdi32: don't compile printdtv16 on 64-bit

2009-04-01 Thread Detlef Riekenberg
On Di, 2009-03-24 at 22:19 -0500, Austin English wrote: +@ stdcall -i386 WriteSpool16(long ptr long) You disable Printing in Wine with that. -- By by ... Detlef

Re: urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-04 Thread Detlef Riekenberg
On Fr, 2009-04-03 at 20:49 +0200, Paul Vriens wrote: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=1, expected 2 So the question is, does somebody now what URLZONEREG_DEFAULT defaults to? HKCR or HKLM and is this always

Re: SoC: DirectShow/Gstreamer

2009-04-09 Thread Detlef Riekenberg
On Di, 2009-03-17 at 15:56 +0100, Maarten Lankhorst wrote: You will probably find graphedt.exe from the microsoft sdk useful, A GPL alternative exists, but does not work in Wine yet: http://blog.monogram.sk/janos/tools/monogram-graphstudio/ -- By by ... Detlef

Re: FYI -- Dragon Naturally Speaking running a bit better today.

2009-04-14 Thread Detlef Riekenberg
On Do, 2009-04-09 at 16:05 -0400, Susan Cragin wrote: Dragon Naturally Speaking ... the amount of time one can use it before it crashes crept up about 2 minutes, ... Today I dictated for about 14 minutes until it crashed. That's progress. Susan, thanks a lot for your sedulous testing of

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL

2009-04-16 Thread Detlef Riekenberg
On Mi, 2009-04-15 at 13:37 +0200, Paul Vriens wrote: The lstrcpyW and lstrcatW additions to init() in the tests don't work on Win95. I guess that's where the new failures come from: I removed a broken(hres == VARCMP_GT), and that's what VarCmp on your w95 machine returned. My second Patch

Re: Winprinfo tool

2009-04-16 Thread Detlef Riekenberg
On Mi, 2009-04-15 at 10:13 +0300, Saulius Krasuckas wrote: I just have struck one tool related to Windows printer drivers [*]: [*] http://unixwiz.net/tools/winprinfo.html Thanks for your Post. I know that tool, but i wrote my own API test tool before I found winprinfo. My tool allows me to

Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).

2009-04-17 Thread Detlef Riekenberg
On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: +Dacl = HeapAlloc(GetProcessHeap(), 0, Size); +ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, Size); +ok(ret, GetTokenInformation(TokenDefaultDacl) failed with error %u\n, GetLastError()); +

Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 10:01 +0200, Henri Verbeet wrote: More specifically, you need to protect this with an #ifdef. #ifdef __GNUC__ #define __WINE_ATTR_UNUSED __attribute__((unused)) #else #define __WINE_ATTR_UNUSED #endif Support for compiler specific features should be tested during

Re: dsound: Allow a special cbSize case in CreateSoundBuffer (updated)

2009-04-21 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 21:51 -0700, Jesse Allen wrote: In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for the cbSize and we have to allow it, but only when the SubFormat is KSDATAFORMAT_SUBTYPE_PCM. This updated patch is simpler... at the expense of being less clear ;)

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Detlef Riekenberg
On Di, 2009-04-21 at 21:06 +0100, Reece Dunn wrote: LANG=es_ES.UTF-8 ./wine winecfg works for me. The language code is es_ES and not just es. That works. I have started a page on the wiki (http://wiki.winehq.org/TestingLanguages) to document how to launch Wine in the different languages.

Re: Need help writing test

2009-04-25 Thread Detlef Riekenberg
Hi Igor I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, Thanks for your work on comctl32 TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin

Re: Reparse point unit tests patches

2009-04-26 Thread Detlef Riekenberg
On So, 2009-04-26 at 13:18 +1000, Paul TBBle Hampson wrote: [PATCH 2/2] Add unit tests for junction points using reparse point interface http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html I didn't test the patches, but from the quick lock: The test must compile with the

Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA

2009-04-27 Thread Detlef Riekenberg
On Mo, 2009-04-27 at 20:48 +1000, Jeff Latimer wrote: -ok( len == sizeof( expect4 ), Got size %d\n, len); +ok( len == sizeof( expect4 ), Expected size to be %d, got %d\n, sizeof( expect4 ), len); Do not use sizeof() in a test. +/*check to see it IPv6 is available */ +v6 =

Entry point not found for GetDiskInfoA (wininet_crosstest.exe)

2009-05-20 Thread Detlef Riekenberg
In dlls/wininet/tests/urlcache.c, GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using

Re: Entry point not found for GetDiskInfoA (wininet_crosstest.exe)

2009-05-22 Thread Detlef Riekenberg
On Do, 2009-05-21 at 12:05 +0200, Alexandre Julliard wrote: Using that executable on Windows or Wine is not possible (Entry point not found for GetDiskInfoA) The wininet_test.exe on winehq has an ordinal Import of 102 in that place. How can we fix that? You have to use the Wine

Re: PowerPC MacOSX work...

2009-05-26 Thread Detlef Riekenberg
On Mo, 2009-05-25 at 22:06 +0200, Stefan Dösinger wrote: they won't work because WinPPC uses little endian while MacOS uses big endian. I am wondering how that would be possible though, can PPCs switch modes? Yes, a PowerPC can switch endian. -- By by ... Detlef

Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL

2009-06-02 Thread Detlef Riekenberg
This one introduces failures on NT4 and below and on some boxes with a non-English locale. Argh .. Could you have a look? Yes. Thanks for the fast report. -- By by ... Detlef

Re: opengl32: get rid of glext.h

2009-06-11 Thread Detlef Riekenberg
On Mi, 2009-06-10 at 21:56 +0200, Roderick Colenbrander wrote: -#ifdef HAVE_GL_GLEXT_H -# include GL/glext.h -#endif The same code is used in winex11.drv/opengl.c Can this also be removed? When that's the case, then GL/glext.h can be removed from AC_CHECK_HEADERS in configure.ac -- By by

Re: PATCH - enhance the help message in expand

2009-06-12 Thread Detlef Riekenberg
On Do, 2009-06-11 at 11:16 -0400, Steven Edwards wrote: +expand [-r] source destination\n +expand -r source [destination]\n +expand -D source.cab [-F:Files]\n +expand source.cab -F:files destination\n +\n + -rRename expanded files.\n +

Re: shell32: update file type associations when requested

2009-06-12 Thread Detlef Riekenberg
On Do, 2009-06-11 at 20:52 +0200, Damjan Jovanovic wrote: + +if (wEventId SHCNE_ASSOCCHANGED) +{ +TRACE(refreshing file type associations); +RefreshFileTypeAssociations(); +} \n is missing in the TRACE. The helper function looks like an API call. Please use

Re: advpack: Implement ExtractFilesW [try 2]

2009-06-19 Thread Detlef Riekenberg
On Do, 2009-06-11 at 15:04 -0700, James Hawkins wrote: 2009/6/11 Vladimir Pankratov script...@mail.ru: Hello all. Implemented ExtractFilesW Changed files: advpack/files.c You're converting A - W - A. This happens because cabinet.Extract is (as far as we know) ansi-only. In this

Re: Wine translation statistics sources

2009-06-21 Thread Detlef Riekenberg
On Sa, 2009-06-20 at 19:19 +0200, Alexandre Julliard wrote: Mikołaj Zalewski miko...@zalewski.pl writes: It's online again. Having it on WineHQ would probably give a better uptime It's now online at http://source.winehq.org/transl/ and will be updated every time there's a git push.

Re: W-related helper functions for our tests

2009-06-21 Thread Detlef Riekenberg
On Fr, 2009-06-19 at 12:44 +0200, Paul Vriens wrote: I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the

Re: Wine translation statistics sources

2009-06-21 Thread Detlef Riekenberg
On Mo, 2009-06-08 at 23:24 +0200, Michael Stefaniuc wrote: And we of course need something to cope with the change to the clock resource files as mentioned by Michael Stefaniuc. Or we should change our clock resources to fit in the rest of wine? You mean reverting Alexandre's patch?

Crash in the mlang test

2009-06-21 Thread Detlef Riekenberg
Hi Ge The mlang tests where reordered and now it crashed on on your Win98 machine with mlang.dll 4.72.3110.0. http://test.winehq.org/data/675e6e93b1d2b4555d05e311764510abf763d21d/98_gvg-w98/mlang:mlang.html Please send me the results for the test with: set WINETEST_REPORT_SUCCESS=1 Thanks

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree

2009-06-29 Thread Detlef Riekenberg
On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: With this patch, they are treated like other programs, e.g., winhlp32, and installed, so one can use: $ wine view and get the same effect. That parts of configure.ac are created by tools/make_makefiles tools/make_makefiles-50-# Programs

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte

2009-07-02 Thread Detlef Riekenberg
On Mo, 2009-06-29 at 16:49 +0900, Dmitry Timoshkov wrote: Christoph von Wittich christ...@apiviewer.de wrote: + if (*pcbProvName INT_MAX) + *pcbProvName = INT_MAX; In which way WideCharToMultiByte is broken? It always helps to provide an explanation and if possible a test case. While

Re: XInput [1/4]: Implement XInputGetState

2009-07-15 Thread Detlef Riekenberg
On Do, 2009-07-09 at 12:50 +0200, Michael Gruber wrote: On Thu, Jul 9, 2009 at 09:50, Stefan Dösingerstefandoesin...@gmx.at wrote: Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic

Re: New winetricks 20090716: new verbs droid, wenquanyi, dinput8

2009-07-17 Thread Detlef Riekenberg
On Fr, 2009-07-17 at 02:01 +0200, Matijn Woudt wrote: (to the list this time) On Fri, Jul 17, 2009 at 1:54 AM, Ben Kleinshackl...@gmail.com wrote: 2009/7/16 Hin-Tak Leung hintak_le...@yahoo.co.uk: I have decided against responding to the chinese thread (so much mis-information,

Wine icon refresh

2009-08-15 Thread Detlef Riekenberg
On Sa, 2009-08-08 at 20:42 +0100, Joel Holdsworth wrote: If you want, I can draw a Tango-style icon for it, as part of my work in progress wine icon refresh: http://www.airwebreathe.org.uk/wine-icon/ They look nice, but I have some comments: idb_std_large.bmp and idb_std_small.bmp: The print

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-15 Thread Detlef Riekenberg
On Mi, 2009-08-12 at 23:31 +0100, Owen Rudge wrote: You can't do that. HIMAGELIST should be the same thing as IImageList. Hmm. Looking at the HIMAGELIST/IImageList internals in a debugger on Windows, the layout appears to be ... :-( Disassembling Windows Code is not allowed for Wine. You

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 17:58 +0200, Alexandre Julliard wrote: Juan Lang juan.l...@gmail.com writes: @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, TRACE(socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n, s, level, optname, optval, *optlen); +

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 18:22 +0200, Alexandre Julliard wrote: Juan Lang juan.l...@gmail.com writes: There can be several other ways to handle this, it needs test cases to determine which way Windows is using. Sorry for my lack of imagination: could you suggest at least one other way so

Re: [(try 3) 3/3] opengl32/tests: Improve test for wglMakeCurrent.

2009-09-19 Thread Detlef Riekenberg
On Sa, 2009-09-19 at 13:15 +0200, Rico Schüller wrote: +ret = wglMakeCurrent( NULL, NULL ); +ok( !ret, wglMakeCurrent failed\n ); shouldn't that message read wglMakeCurrent succeeded ? Yes, probably something like wglMakeCurrent succeeded, but should fail! is really a better

Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote: * sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE Using the name sti_tests is bad. The short sti is enough. You forgot the license notice We usually cast the result of GetProcAddress() as (void *).

Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: +todo_wine ok(SUCCEEDED(hres), get_hash failed: 0x%08x\n, hres); +if(SUCCEEDED(hres)){ +if(str_pass) +ok(strcmp_wa_null(str, exp) == 0, expected retrieved hash to be L\%s\, was: %s\n, exp,

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Detlef Riekenberg
On Di, 2009-09-29 at 13:27 +0200, Markus Stockhausen wrote: The test will fail in Windows and Wine to get the results in both cases. The result will show like this: dsurface.c:1264: Test failed: backbuffer surface has dwBackBufferCount==2 This is 0 here with ATI Radeon R100 on Win98se, w2k

Re: wininet: Handle finding ftp files in subdirectories and using wildcards.

2009-09-29 Thread Detlef Riekenberg
On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: +if (lpszSearchPath) +HeapFree(GetProcessHeap(), 0, lpszSearchPath); + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-04 Thread Detlef Riekenberg
On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote: +/*** + * wrap_getxattr + * Retrieve extended attribute of posix file into given buffer. + * Use fd if given, else use fname; caller only sets one or the other. +

Re: Another virus-in-wine story

2009-10-31 Thread Detlef Riekenberg
On Sa, 2009-10-24 at 22:07 -0700, Dan Kegel wrote: This is about the fifth article of this sort, so it's not really news anymore, but it's still fun to read about. http://linux.slashdot.org/story/09/10/24/1759213/Now-Linux-Can-Get-Viruses-Via-Wine The blogger mention the bad website, but the

Re: avifile bugfixes

2009-11-10 Thread Detlef Riekenberg
On Di, 2009-11-10 at 00:43 +0100, Julius Schwartzenberg wrote: I will add tests to show this and submit the patches then. I created a test for avifil32 in June 2008, but it was not comitted. ( http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html ) The bug 14085 was created to

Re: d3d8/tests: Avoid a crash, when CreateTexture failed

2009-11-11 Thread Detlef Riekenberg
On Mi, 2009-11-11 at 15:16 +0100, Henri Verbeet wrote: I.e., does the attached patch work for you? yes, with 0 failures :-) d3d9 has the same code (but i cant test d3d9 on my machine). Thanks. Do you want to send the patches yourself? -- By by ... Detlef

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.

2009-11-19 Thread Detlef Riekenberg
On Do, 2009-11-19 at 13:18 +, Huw Davies wrote: --- dlls/winspool.drv/info.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to

Re: Very long printernames and test failures

2009-12-07 Thread Detlef Riekenberg
On So, 2009-12-06 at 19:28 +0100, Paul Vriens wrote: Some test failures are shown on boxes with long printernames, for example: http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_test-on-vista/winspool.drv:info.html

Re: [PATCH 3/4] jscript: Added Function constructor tests.

2009-12-10 Thread Detlef Riekenberg
On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: +func = new Function(); +tmp = func(); +ok(tmp === undefined, func(1,3,2) = + tmp) Greetings from Copy Paste -- By by ... Detlef

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2

2009-12-10 Thread Detlef Riekenberg
On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: +{ +/* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches -- By by ... Detlef

Re: Bugs in Wine research

2008-06-14 Thread Detlef Riekenberg
On Di, 2008-05-27 at 15:11 +0200, [EMAIL PROTECTED] wrote: the complete results are available at http://www.cs.aau.dk/~dechouxb/results/complete/, The requested URL /~dechouxb/results/complete/ was not found on this server. Thanks for helping Wine -- By by ... Detlef

Re: 'Interactive' tests on Windows 2003

2008-06-22 Thread Detlef Riekenberg
On Fr, 2008-06-13 at 13:04 -0500, James Hawkins wrote: Do you think we should add a check for winetest_interactive Possible, but that skip the test before the calls that bring up the permission dialog? If anyone else knows of a better way, let us know. Add a CBT-Hook and force the

Re: Website down

2008-06-22 Thread Detlef Riekenberg
On Mi, 2008-06-18 at 09:51 -0600, Brian Vincent wrote: Sure: http://www.winehq.org/webalizer -Brian On Tue, Jun 17, 2008 at 8:27 PM, Hin-Tak Leung [EMAIL PROTECTED] wrote: Just for geek value, is it possible to have a graph of how the slashdot effect look like? I

how to run wine under a different language

2008-06-23 Thread Detlef Riekenberg
On Mo, 2008-06-23 at 02:41 -0400, Filipe Ferreira wrote: (Anyone care to share how to run wine under a different language?) - Install the language - Select the language from locale -a LC_ALL=de_DE.utf8 wine winecfg LC_ALL=en_US.utf8 wine winecfg LC_ALL=it_IT.utf8 wine winecfg -- By by

Revert winspool.drv: Make sure the printer driver registry entry exists.

2008-06-24 Thread Detlef Riekenberg
On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote: Today I started getting a heap corruption and crash in localspl: ... Anyone know what's up with that? That was introduced by Huw (added a circular dependance). Changelog: Revert winspool.drv: Make sure the printer driver registry entry

Re: [6/7] gdiplus: Implemented GdipGetPathData with test

2008-06-26 Thread Detlef Riekenberg
Hi Nikolay: +pathData-Points = GdipAlloc(sizeof(PointF) * pathData-Count); +if(!pathData-Points) +return OutOfMemory; + +pathData-Types = GdipAlloc(pathData-Count); +if(!pathData-Points) Greetings from Copy Paste pathData-Points = pathData-Types +

Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests

2008-06-26 Thread Detlef Riekenberg
On Mi, 2008-06-25 at 21:34 -0700, Maarten Lankhorst wrote: Because of the magnitude of the change I cannot split this patc hup, my apologies for this. Without any view at your code, the sentense above is wrong by design. A Test is always independant from the implementation, and what permit a

Re: ok lets try this yet again

2008-06-26 Thread Detlef Riekenberg
On Do, 2008-06-26 at 14:38 -0400, [EMAIL PROTECTED] wrote: I have no Idea about the touched code, but still some more hints: You must use your real name +WineD3D_PixelFormat *cfgs = This-adapter-cfgs; +BOOL exactDepthMatch = FALSE; /*Changed june 23,08 */ +

Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests

2008-06-28 Thread Detlef Riekenberg
On Do, 2008-06-26 at 22:58 -0700, Maarten Lankhorst wrote: there are still some things I need to figure out with avi. Is avifil32.dll usable for that? Does Windows reuse avifil32.dll or did MS again lots of code duplication? The current Problem in Wine is the correct importlib: avicap32 +

Re: programs: add rudimentary dxdiag

2008-07-01 Thread Detlef Riekenberg
On Mo, 2008-06-30 at 10:15 -0500, Austin English wrote: Instead of simple stub, this patch also adds the (simplified) d3d test like seen in native dxdiag, so users can test if their d3d is setup correctly. Screenshot can be seen here: http://bugs.winehq.org/attachment.cgi?id=14342

Re: [UPDATE] shell32: Check registry entry for cpl files (in standard control panel)

2008-07-03 Thread Detlef Riekenberg
On Do, 2008-07-03 at 08:45 -0700, Juan Lang wrote: Well, technically, they would be registered in the [mmcpl] section of control.ini, which is then mapped in the registry (snip) I could add a check for CPL entries in control.ini if desired using the GetPrivateProfileSection function, and

Re: programs: add rudimentary dxdiag

2008-07-06 Thread Detlef Riekenberg
On Mi, 2008-07-02 at 23:02 +, Louis Lenders wrote: so for now i'd have to guess : 1. no need for a dxdiag in wine 2. my patches are too crappy to respond to. In both cases it's useless to leave thebug i opened for missing dxdiag open, so i'll abandon it (bug 14118) Louis, please do

Re: richedit: do not read actual scrollbar state for scrollbar update, use internal state instead (RESEND)

2008-07-06 Thread Detlef Riekenberg
On Fr, 2008-07-04 at 16:32 -0500, Alex Villací­s Lasso wrote: Resending. Please comment on this patch.  dlls/riched20/editor.c | 21 ++ dlls/riched20/editstr.h |3 + dlls/riched20/paint.c| 36 ++- dlls/riched20/tests/editor.c | 794

Re: Alternate shell?

2008-07-06 Thread Detlef Riekenberg
On Do, 2008-05-22 at 15:16 -0700, Dan Kegel wrote: For a maximal dogfood experience, I was looking around for a way to use a replacement Windows shell with Wine as my desktop environment instead of gnome or kde. Wow. So far, all the ones I've found are either broken, hard to use, or just

Re: taskmgr: Add full translation [1/2]

2008-07-20 Thread Detlef Riekenberg
On So, 2008-07-20 at 22:58 +0500, Vladimir Pankratov wrote: First of all, your Idea is great, but your Patch is far to large. Please move only some strings (usual is from one source file) to the resources at once. Then you must keep the resources in sync. That means, when you move one string to

Re: [1/11] ole32 : basic inprocess handler implentation

2008-08-09 Thread Detlef Riekenberg
On Do, 2008-08-07 at 15:45 +0200, [EMAIL PROTECTED] wrote: This patch modifies the Makefile.in file to include some new file to be compile - You must use your real name - Wine must compile after every Patch. You need to add the changes for Makefile.in, when you add a file - Why do you need

Re: debugging applications Re: Networking problems with IDU Verwaltung software

2008-08-09 Thread Detlef Riekenberg
On Fr, 2008-08-08 at 16:51 +0200, Werner LEMBERG wrote: Investigate the RelayInclude and RelayExclude string values in [HKCU\Software\Wine\Debug] if you're being overwhelmed by certain functions. [...] I suppose this is a registry entry, right? Yes. HKCU (or HCU) is:

Re: DIB engine status

2008-08-09 Thread Detlef Riekenberg
On Fr, 2008-08-01 at 12:56 +0100, Huw Davies wrote: Hi folks, Here's an update on the DIB engine that I've been working on for the last few months. This work has been made possible by the generosity of Google - so thanks go to them and of course to Dan. You can find the code at

Re: rpcrt4: [1/2] Improve stub for I_RpcBindingInqTransportType, with test

2008-08-10 Thread Detlef Riekenberg
On So, 2008-08-10 at 12:21 +0900, Dmitry Timoshkov wrote: + /* NT: RPC_S_NO_CONTEXT_AVAILABLE, 9x: RPC_S_NO_CALL_ACTIVE */ + if (!Binding) return RPC_S_NO_CONTEXT_AVAILABLE; According to your test this should be if (!Binding || !Type) return RPC_S_NO_CONTEXT_AVAILABLE; No, your

Re: ntdll/file: Add sub-second resolution to NtQueryInformationFile

2008-08-18 Thread Detlef Riekenberg
On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote: --- configure | 303 +++ You should never include autogenerated code in a Patch. This will reduce the risk, that your Patch does not apply after a different Patch was commited.

Re: winetricks: add ie6 verb

2008-08-23 Thread Detlef Riekenberg
On Mo, 2008-08-18 at 13:11 -0400, Steven Edwards wrote: +load_ie6() { Nice Idea. +# Installing Core Fonts +load_corefonts Which Font is required (please fill bug reports) Which Font is optional? +# Installing Richedit 2.0 Library +load_riched20 What is needed in the builtin

Re: [crypt32/tests] Use CryptAcquireContextA instead of CryptAcquireContextW

2008-08-26 Thread Detlef Riekenberg
On Mo, 2008-08-25 at 22:16 +0200, Paul Vriens wrote: static BOOL (WINAPI * pCryptAcquireContextA) (HCRYPTPROV *, LPCSTR, LPCSTR, DWORD, DWORD); -static BOOL (WINAPI * pCryptAcquireContextW) -(HCRYPTPROV *, LPCWSTR, LPCWSTR, DWORD, DWORD);

Re: [10/10] WineX11: add a run-total fps counter to the fps debug channel

2008-08-26 Thread Detlef Riekenberg
On Mo, 2008-08-25 at 09:32 -0500, Stefan Dösinger wrote: @@ -3486,15 +3486,19 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE *physDev) /* FPS support */ if (TRACE_ON(fps)) { - static long prev_time, frames; + static long prev_time, start_time; + static unsigned long

Re: Patchwatcher online

2008-09-09 Thread Detlef Riekenberg
On Fr, 2008-09-05 at 10:24 -0700, Dan Kegel wrote: The results page http://kegel.com/wine/patchwatcher/results/ looks nice and green; Opps, all developer send there Patches in September with 09 as minute, and in August with 08 ... :-) And it would be very nice, when you hide the

splint (Re: Adding Flawfinder to Patchwatcher)

2008-09-09 Thread Detlef Riekenberg
On So, 2008-09-07 at 18:10 +, Jason Spiro wrote: Other people may be able to suggest more good tools. AFAIK splint is one of the most popular OSS static analysis tools, but I've never really used it. Has anyone here used it? On the flawfinder homepage, it says that splint does

Re: d3dx9_36: Fix the tests for native Windows.

2008-09-10 Thread Detlef Riekenberg
On Mi, 2008-09-10 at 18:16 +0200, Tony wrote: Hi, At least for all Windows versions below Vista, the d3dx9 importlib does exist (and d3dx9_36 does not), I installed a recent dx9-runtime on my w2k test system, but a d3dx9.dll is not present (d3dx9_36.dll exist). I get always a blocking popup,

Re: PrintDlgEx [2/7]: Add basic dialog.

2008-09-19 Thread Detlef Riekenberg
On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote: there is no point in adding new resources in English to the other languages rc files. If a resource doesn't exist Win32 will automatically fail over to use the en_US version. According to julliard a while ago, this is not the case.

Re: shdocvw: [Patch 1/2] Implement URLSubRegQueryA [Resend]

2008-10-15 Thread Detlef Riekenberg
On Mi, 2008-10-15 at 16:53 +0200, Alexandre Julliard wrote: Detlef Riekenberg [EMAIL PROTECTED] writes: +len = sizeof(buffer); +res = SHRegGetUSValueA(regpath, name, NULL, buffer, len, FALSE, NULL, 0); +if (!res) { +lstrcpynA(out, buffer, outlen

Re: mscms: quiet a noisy fixme (1/3)

2008-10-17 Thread Detlef Riekenberg
On Do, 2008-10-16 at 19:44 -0500, Austin English wrote: +if (quietfixme == 0) +{ +FIXME(unhandled bitmap format\n); Such a FIXME has no useful information. You should also dump the unhandled bitmap format in the FIXME +quietfixme = 1; +

Re: gdi32: Add job name field into CreateSpoolFile

2008-10-17 Thread Detlef Riekenberg
On Mo, 2008-10-13 at 12:29 +0400, Konstantin Kondratyuk wrote: -sprintf(psCmd,|lpr -P'%s',pszOutput+4); +sprintf(psCmd,|lpr -T %s -P'%s',pszTitle,pszOutput+4); This is broken, when there is a space in the Title. -- By by ... Detlef

Re: does anyone else's windows 98 machine not survive the user32 msg test?

2008-10-29 Thread Detlef Riekenberg
On So, 2008-10-26 at 22:31 -0500, Vincent Povirk wrote: After I run user32_crosstest msg on my windows 98 virtual machine in qemu, it no longer responds to any mouse input (the cursor moves and changes, but clicking has no effect) Does this happen to anyone else, especially on a windows 98

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-03 Thread Detlef Riekenberg
On So, 2008-11-02 at 10:58 -0800, Dan Kegel wrote: This approach won't help users of the Wine conformance tests running on Windows, Sure it would; just make the test server setup script run on cygwin properly. require an installed cygwin is broken by design. winetest.exe is a standalone

Re: [ddraw/tests] Fix a test on W2K3

2008-11-05 Thread Detlef Riekenberg
On Di, 2008-11-04 at 10:25 -0800, chris ahrendt wrote: Actually as of 6.5 of VMWARE direct draw 9c is 100% supported. So why couldn't we use vmware 6.5 as a valid platform for testing direct draw api's? When our tests use valid data but received an E_NOTIMPL, then DirectX 9c in VMWare

Make Wine and the tests dpi aware

2008-11-12 Thread Detlef Riekenberg
Wine use some fixed values for calculating gui elements, and hopefully the current values are verified with tests. The tests works in Windows, but only with the default settings: 96 dpi (Small Fonts / Kleine Schriften) and the default theme. It would be a good idea to run the tests also for

Re: OLEAUT32: implement OleLoadPictureFile(Ex) and add tests

2008-11-14 Thread Detlef Riekenberg
On Mi, 2008-11-12 at 23:40 -0800, Jeremy Drake wrote: I have no Idea about that area, but the unicode API is not implemented on win9x (GetTempFileNameW, CreateFileW, DeleteFileW) if(!pOleLoadPictureFile || !pOleLoadPictureFileEx) Are there systems in the Wild that have OleLoadPictureFile, but

Re: OLEAUT32: implement OleLoadPictureFile(Ex) and add tests

2008-11-14 Thread Detlef Riekenberg
On Fr, 2008-11-14 at 21:17 +0100, Detlef Riekenberg wrote: On Mi, 2008-11-12 at 23:40 -0800, Jeremy Drake wrote: if(!pOleLoadPictureFile || !pOleLoadPictureFileEx) Are there systems in the Wild that have OleLoadPictureFile, but are missing OleLoadPictureFile? In that case, you should use 2

Re: Regarding ./configure file

2008-11-22 Thread Detlef Riekenberg
On Fr, 2008-11-21 at 10:57 -0800, Juan Lang wrote: I thought that if you want to add anything to wine you: 1 - simply add it to git 2 - ./tools/make_makefiles 3 - autoconf 4 - ./configure 5 - make depend make Is this wrong? Yes. On occasion we need to add or improve checks

Re: Did anyone have any trouble compiling wine today? Or was it just me ....

2008-11-30 Thread Detlef Riekenberg
On Sa, 2008-11-29 at 18:53 -0600, Austin English wrote: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o serial.o serial.c

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Detlef Riekenberg
On Di, 2008-12-23 at 14:24 +0100, Stefan Dösinger wrote: I'm only afraid of this hypothetical scenario: 1) We remove a test because it breaks on $NONSTANDARDWINDRV We disable the test with: if (0) { /* that crash on $NONSTANDARDWINDRV */ full test here } 3) Some

Re: Implementing dxdiag as student project?

2008-12-28 Thread Detlef Riekenberg
On Sa, 2008-12-27 at 23:20 -0800, Dan Kegel wrote: Hi folks, it seems odd to me that Wine doesn't have a tool like dxdiag yet. We often have people complain that graphics aren't working, and we have to ask them to do things like run glxgears as diagnostics. Would it make sense to implement

Re: Henri Verbeet : secur32: Handle SECPKG_ATTR_STREAM_SIZES in schan_QueryContextAttributesW().

2008-12-29 Thread Detlef Riekenberg
On Mo, 2008-12-29 at 19:21 +0100, Christian Costa wrote: Compilation failed here (FC8), I got this error : gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2

Re: Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn

2009-01-06 Thread Detlef Riekenberg
On Mo, 2009-01-05 at 22:10 -0500, Markus wrote: can anyone tell me where to find information about the b3DAccelerationExists and b3DAccelerationEnabled properties in the display container returned by I suggest to use dxdiag and regmon on Windows. In dxdiag, you can disable DirectDraw /

Re: Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn

2009-01-07 Thread Detlef Riekenberg
On Di, 2009-01-06 at 22:47 -0500, Markus wrote: can anyone tell me where to find information about the b3DAccelerationExists and b3DAccelerationEnabled properties in the display container returned by I suggest to use dxdiag and regmon on Windows. In dxdiag, you can disable

Re: richedit: Added tests to show that options are stored internally.

2009-01-11 Thread Detlef Riekenberg
On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote: Hi Dylan. First of all, thanks for working on riched* +/* EM_SETOPTIONS changes the window style, but changing the + * window style does not change the options. */ +dwStyle = GetWindowLongW(hwndRichEdit, GWL_STYLE); Almost all

Re: richedit: Added tests for autoscrolling options based on WS_V/HSCROLL.

2009-01-11 Thread Detlef Riekenberg
On So, 2009-01-11 at 02:58 -0500, Dylan Smith wrote: It seems as if the autoscrolling options can be set based on whether WS_VSCROLL or WS_HSCROLL styles are used to create the window, but this is done differently between version 1.0 and 3.0 of the richedit control. I noticed this indirectly

  1   2   3   4   5   6   >