Re: Does wine handle virtual midi ports correct on OSX?

2009-05-07 Thread Ken Thomases
On May 6, 2009, at 11:20 PM, Dewdman42 wrote: Does anyone know if Darwine can be fixed to handle virtual midi ports correctly? They work very sporadically right now. It seems to be related to getting the ports flushed or initialized or something. When there is a virtual midi port present

Re: Time to remove obsolete platforms HP, SGI, and DEC?

2009-05-29 Thread Ken Thomases
On May 29, 2009, at 12:18 PM, Austin English wrote: On Fri, May 29, 2009 at 12:14 PM, Dmitry Timoshkov dmi...@codeweavers.com wrote: Austin English austinengl...@gmail.com wrote: Why do we have versions on Mac OS X? How about we combine them all? It can make a big difference in the bug.

Re: Is there any way to debug driver?

2009-06-18 Thread Ken Thomases
On Jun 17, 2009, at 10:49 AM, Wang, Robin wrote: We also have tried using winedbg, but it cannot break into our driver either. The only way we can break into our driver before is using gdb wine- pthread, but now it is not available. Do you have some suggestion on winedbg configuration to

Re: suggestions about MacOS DYLD_FALLBACK_LIBRARY_PATH patch

2009-07-19 Thread Ken Thomases
On Jul 17, 2009, at 10:02 PM, Steven Edwards wrote: I tried looking in to generating of AppleScript app bundles however there seems to be no documented way to do it other than to use the Apple Script tool so no automatted method. Are you familiar with the osacompile command? -Ken

Re: ntdll: For Darwin/Mac OS X, use legacy getdirentries if 64-bit inodes enabled.

2009-07-31 Thread Ken Thomases
On Jul 31, 2009, at 5:15 PM, Austin English wrote: On Fri, Jul 31, 2009 at 4:25 PM, Ken Thomasesk...@codeweavers.com wrote: Fixes building on Snow Leopard. --- dlls/ntdll/directory.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) FWIW, NetBSD has

Re: Alexandre Julliard : libwine: Ignore libraries that are of the wrong 32/ 64 class.

2009-08-14 Thread Ken Thomases
Hi Alexandre, It seems this would fail to ignore a fat Mach-O library that doesn't include the right 32/64 class. For example, a fat i386/ppc library when running 64-bit. A fat library starts with the struct fat_header defined in /usr/ include/mach-o/fat.h, followed by a number of struct

Re: [RFC] Adding an OpenAL DLL thunk

2009-08-27 Thread Ken Thomases
Hi, On Aug 25, 2009, at 8:15 AM, Chris Robinson wrote: This patch set does not support OSX's OpenAL, but it should be simple enough to add for anyone familiar with handling frameworks in configure.ac. I'm attaching a patch to do so. It's a bit hacky since we don't really have a way to

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Ken Thomases
Hi Dan, On Oct 7, 2009, at 9:24 AM, Dan Kegel wrote: Yeah, the patch handles OS X [...] Tangentially related to this xattr issue, are you aware of BSD's chflags system call and the st_flags field of struct stat? On Mac OS X (and any other BSD which defines UF_HIDDEN),

Re: Multiple wineservers?

2009-10-07 Thread Ken Thomases
On Oct 7, 2009, at 11:43 AM, Nicholas LaRoche wrote: Is it possible to run more than 1 version of wineserver concurrently? If each is referencing a different WINEPREFIX, yes. Cheers, Ken

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-07 Thread Ken Thomases
On Oct 7, 2009, at 11:46 AM, Dan Kegel wrote: On Wed, Oct 7, 2009 at 9:21 AM, Ken Thomases k...@codeweavers.com wrote: It would also be good to check for UF_IMMUTABLE|SF_IMMUTABLE to determine FILE_ATTRIBUTE_READONLY, and set UF_IMMUTABLE when setting FILE_ATTRIBUTE_READONLY, although

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Ken Thomases
On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */ - waveOutOpen returns: %x\n, ret); -if (ret == MMSYSERR_NOERROR) +if (ret

Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

2009-10-16 Thread Ken Thomases
On Oct 16, 2009, at 3:46 AM, Alexandre Julliard wrote: Ken Thomases k...@codeweavers.com writes: On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote: On 10/16/2009 02:19 AM, Ken Thomases wrote: -todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME

Re: winecoreaudio: Quiet a noisy FIXME.

2009-10-17 Thread Ken Thomases
On Oct 16, 2009, at 10:26 PM, Peter Dons Tychsen wrote: On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote: +static int once; + +if (!once++) FIXME(independent left/right volume not implemented (%f, %f)\n, left, right); I know it is a detail, but is it not a bit misleading

Re: SCSITaskDevice vs our own driver

2009-10-17 Thread Ken Thomases
On Oct 16, 2009, at 6:01 PM, Charles Davis wrote: Eventually, I want to implement IOCTL_SCSI_PASS_THOROUGH on Mac OS. The way I see it, there are two ways to do this: 1. Use the SCSITaskDevice interface. This is a CFPlugIn object provided by the driver (it's like a COM object). We have to

Please test on Windows: waveOutGet/SetVolume

2009-10-21 Thread Ken Thomases
Hi, Can I ask folks with Windows available to them to run a test for me? I'm attaching a patch for the winmm wave.c test to test the behavior of waveOutSetVolume and waveOutGetVolume, in particular the difference between setting/getting the volume with a device identifier versus a

Re: Order of setting audio Play/Pause state and device opening

2009-10-30 Thread Ken Thomases
On Oct 29, 2009, at 9:18 AM, joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com wrote: In audio.c/wodPause: /* The order of the following operations is important since we can't hold * the mutex while we make an Audio Unit call. Stop the Audio Unit before *

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-23 Thread Ken Thomases
The call to setenv() has 0 (false) as its third parameter, so that LANG is not overwritten. -Ken On Nov 23, 2009, at 9:12 AM, Charles Davis wrote: --- dlls/kernel32/locale.c | 53 +-- 1 files changed, 28 insertions(+), 25 deletions(-)

Re: Whitespace cleanups

2009-11-25 Thread Ken Thomases
On Nov 25, 2009, at 9:13 AM, Nate Gallaher wrote: I understand the preserve existing format rule, particularly in cases of braces, inter-paren spacing, variable names, function names, and alignment, but I don't see the benefit of keeping 80-cols insanity around. One important reason to

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-25 Thread Ken Thomases
On Nov 24, 2009, at 7:52 AM, Charles Davis wrote: I just realized something. The reason Wine doesn't respect LANG is that it overrides the LC_MESSAGES setting if it is set to the default. It will be set to the default if there is no LC_MESSAGES in the environment. So we don't want to override

Re: Whitespace cleanups

2009-11-25 Thread Ken Thomases
On Nov 25, 2009, at 11:13 AM, Nate Gallaher wrote: Ken Thomases wrote: One important reason to avoid whitespace-only changes is it makes git-blame essentially useless for finding the real source of functional changes. But is that really important? git-bisect would put you on the other

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-26 Thread Ken Thomases
On Nov 26, 2009, at 12:31 AM, Vitaliy Margolen wrote: Ken Thomases wrote: Setting LC_ALL would achieve that, plus override the various other locale categories. Set LANG is the wrong approach, in my opinion. However this is not the way Wine works on all other platforms. Sure it is, if you

Re: Whitespace cleanups

2009-11-26 Thread Ken Thomases
On Nov 26, 2009, at 10:15 AM, Francois Gouget wrote: On Wed, 25 Nov 2009, Ken Thomases wrote: [...] One important reason to avoid whitespace-only changes is it makes git-blame essentially useless for finding the real source of functional changes. Such changes don't make git-blame useless

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-30 Thread Ken Thomases
to change the language of displayed messages, one should set LC_MESSAGES. Ken Thomases writes: I see no upside at all to changing LANG into an override where that's not how it functions in any other context. I see no override involved here. On my Mac OSX 10.5.8 which is pretty much a base

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-30 Thread Ken Thomases
is most likely oblivious to this fact. Ken Thomases wrote: Mac OS X's Language Text (formerly known as International) settings in System Preferences don't quite map exactly to Unix LANG or LC_* environment variables, which are a poor intermediary for mapping to Windows settings. I agree

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-11-30 Thread Ken Thomases
On Nov 30, 2009, at 9:34 PM, James McKenzie wrote: This algorithm is used in all programs that rely on GNU gettext and works perfectly fine: - By default, no LANG or LC_* environment variable is set, hence the programs obey the user settings. - For users of Terminal.app, who set these

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Ken Thomases
that.) On Tue, Dec 1, 2009 at 06:12, Ken Thomases k...@codeweavers.com wrote: [...] Wine should just use the settings from System Preferences directly (via CFLocale, CFNumberFormatter, and CFDateFormatter), with an optional way to override them for those rare users who want Wine's behavior

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-02 Thread Ken Thomases
On Dec 2, 2009, at 1:22 PM, Gert van den Berg wrote: I'm using Terminal.app using default settings (AFAIK, except for colors). Set locale variables at startup is enabled. I don't see settings for en_ZA* in /usr/share/locale (af_ZA does exist, but if my applications turn Afrikaans I'll go

Re: RFC: dsound: Add support for enumerating capture devices through openal, try 4

2009-12-02 Thread Ken Thomases
On Dec 2, 2009, at 12:11 PM, Maarten Lankhorst wrote: This patch doesn't apply, just a rfc email to see if this approach is correct :) +static void *openal_handle = RTLD_DEFAULT; +#ifdef SONAME_LIBOPENAL +char error[128]; +openal_handle = wine_dlopen(SONAME_LIBOPENAL, RTLD_NOW,

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-03 Thread Ken Thomases
On Dec 2, 2009, at 11:25 PM, Gert van den Berg wrote: What I meant is that LC_* (not LC_ALL) don't have a setting that says the locale is say en_ZA it only has we have number (LC_NUMERIC) from en_ZA, times (LC_TIME) from en_UK, sort things (LC_COLLATE) according to en_AU, determine whether

Re: Wine sound discussion summary

2009-12-07 Thread Ken Thomases
On Dec 6, 2009, at 10:08 AM, Stefan Dösinger wrote: Am 06.12.2009 um 15:32 schrieb Roderick Colenbrander: This audio engine is quite similar to pulseaudio and it offers functionality like per stream volume which normal APIs like oss/alsa/openal don't offer, so these APIs would map better to

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 8, 2009, at 6:39 AM, joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com wrote: Ken Thomases wrote: This results in the order I previously described: LC_ALL LC_* from the original environment Mac OS X settings LANG In other words, LANG is completely ignored, since

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 3, 2009, at 11:27 AM, Ken Thomases wrote: I propose the following (in pseudocode): mac_formats_locale = CFLocaleGetIdentifier( CFLocaleCopyCurrent() ); mac_language = CFArrayGetValueAtIndex ( CFBundleCopyLocalizationsForPreferences ( CFLocaleCopyAvailableLocaleIdentifiers(), NULL

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.

2009-12-09 Thread Ken Thomases
On Dec 9, 2009, at 1:34 PM, Ken Thomases wrote: So, I'm making a new proposal: the Mac formats region will be used to set LANG unconditionally. (Passing 1 for the third argument to setenv() rather than 0.) The current code for overwriting lcid_LC_MESSAGES will be tweaked. Instead

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Ken Thomases
On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: Dan Kegel [EMAIL PROTECTED] writes: On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard [EMAIL PROTECTED] wrote: patchwatcher should watch for replies on wine-devel, and link the reply to the patch Yes. The other similar

Re: Proposal: switch Wine source tree to utf-8

2008-09-02 Thread Ken Thomases
On Aug 29, 2008, at 11:10 PM, Dan Kegel wrote: Just how silly would it be for us to bite the bullet and set all source files to utf-8? We'd need to recode a bunch of files once, but after that, there'd be less confusion about how to view and edit various resource files. One area that I know

Re: atl: Remove WINAPI on static functions where not needed.

2008-11-24 Thread Ken Thomases
Thanks for taking care of this, Francois. On Nov 23, 2008, at 5:15 PM, Francois Gouget wrote: Astute readers will notice that this leaves one loophole: nasty macro use like in dlls/winmm/message16.c: #define A(_x,_y) MMDRV_InstallMap(_x, \ MMDRV_##_y##_Map16To32W, MMDRV_##_y##_UnMap16To32W,

Re: Unused vtables and debug channels

2008-12-15 Thread Ken Thomases
On Dec 15, 2008, at 3:41 PM, Andrew Talbot wrote: It appears that the following vtables and Wine debug channels are not being used, so I am considering removing them. Please let me know, therefore, if you have plans for any of them and want them kept. Wine debug channels in: [...]

Re: kernel32: Allow the prefered language to be different from the prefered locale on Mac OS X by correctly setting LC_MESSAGES.

2006-12-11 Thread Ken Thomases
On Dec 11, 2006, at 1:46 PM, Pierre d'Herbemont wrote: This patch allows Mac OS X Users that set in System Preferences.app a language (say English) and that don't use the default number and text formatting currently associated with this language (for instance if they use French number and

Re: kernel32: Allow the prefered language to be different from the prefered locale on Mac OS X by correctly setting LC_MESSAGES.

2006-12-11 Thread Ken Thomases
On Dec 11, 2006, at 5:49 PM, Pierre d'Herbemont wrote: On 12 déc. 06, at 00:20, Pierre d'Herbemont wrote: +} +closedir(dir); I think the above code to scan /usr/share/locale is unnecessary. Doesn't CFLocaleCopyAvailableLocaleIdentifiers provide the equivalent? You're quite

Re: kernel32: Allow the prefered language to be different from the prefered locale on Mac OS X. [take3]

2006-12-13 Thread Ken Thomases
Wait, wait... On Dec 12, 2006, at 6:55 AM, Pierre d'Herbemont wrote: This time with Alexandre suggestion to use directly parse_locale_name. We still leave the possibility not to use the System preferences language if LC_MESSAGES env variable LC_MESSAGES was set to a value different than

Re: kernel32: Allow the prefered language to be different from the prefered locale on Mac OS X. [take3]

2006-12-13 Thread Ken Thomases
On Dec 13, 2006, at 12:02 PM, Pierre d'Herbemont wrote: On Dec 13, 2006, at 4:46 PM, Ken Thomases wrote: Wait, wait... On Dec 12, 2006, at 6:55 AM, Pierre d'Herbemont wrote: +all_locales = CFLocaleCopyAvailableLocaleIdentifiers(); +preferred_locales

Re: Some thoughts about the ominous DIB Engine

2007-02-09 Thread Ken Thomases
On Feb 9, 2007, at 5:18 AM, Michael Stefaniuc wrote: Rolf Kalbermatter wrote: I have been following this discussion for quite some time and finally decided to look into it a little bit. While the Wiki mentions that a difficult part of this would be to get any design accepted by Alexandre it

Re: Current wine and HL2 family - well done!

2007-03-05 Thread Ken Thomases
On Mar 5, 2007, at 12:00 PM, Stefan Dösinger wrote: Hi! I've made also the glsl test. The same problem is here - there is too much shine all over the game. Not only barrels and weapons, but also faces, dresses, walls.. It looks like covered by the oil film. There are also some strange

Re: Alexandre Julliard : ntdll: Add a wrapper to call the thread entry point for broken apps.

2007-03-14 Thread Ken Thomases
On Mar 14, 2007, at 7:25 AM, Alexandre Julliard wrote: Module: wine Branch: master Commit: 773febb04213cf014b007a83744a66544d6c URL:http://source.winehq.org/git/wine.git/? a=commit;h=773febb04213cf014b007a83744a66544d6c Author: Alexandre Julliard [EMAIL PROTECTED] Date: Wed Mar

Re: Mem usage in Mac OSX

2006-10-03 Thread Ken Thomases
On Oct 2, 2006, at 12:49 PM, Robert Shearman wrote: Nick Burns wrote: All the following have this VM ~=4GB on startup -- its not a leaking problem... (afaict) OGL/D3D -- WinRAR, GTAVC, Tribes2, (FlatOutDemo -- even thou it dies on startup now -- still gets to ~4GB), SHOGO NON-GL -- cmd

Re: [PATCH 3/3] configure: Use 0 instead of NULL because NULL isn't defined.

2007-10-19 Thread Ken Thomases
On Oct 19, 2007, at 5:24 PM, Stefan Dösinger wrote: Am Freitag, 19. Oktober 2007 23:18:51 schrieb Ken Thomases: This makes the test test the proper thing on Mac OS X. It still fails, but for a good reason. --- configure.ac |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

Re: wine 0.9.5 IO completion port questions

2007-12-06 Thread Ken Thomases
On Dec 3, 2007, at 4:05 PM, Andrey Turkin wrote: Marius Slyzius wrote: 2) possible bug: the server sends 1500 bytes with WsaSend ( with 2 WSABUFFER ) and the client receive only 1452 bytes and calls WsaRecv again. Also on the server, the completion port receive event that transferred 1452

Re: [PATCH 1/1] winecoreaudio: Make sure Port_SendToMessageThread is non-NULL in CoreAudio_WaveRelease.

2008-01-29 Thread Ken Thomases
On Jan 28, 2008, at 8:06 AM, Misha Koshelev wrote: I have started playing with wine on MacOS in VMWare. wineprefixcreate page faults on my MacOS system and I tracked it to Port_SendToMessageThread staying NULL because of: err:wave:CoreAudio_WaveInit AudioHardwareGetProperty:

Re: [PATCH 1/4] avifil32: Fix copy/paste error.

2008-03-12 Thread Ken Thomases
On Mar 11, 2008, at 7:00 AM, Stefan Dösinger wrote: I think the patches suffer from mail client line wrapping Huh. I specifically switched to Thunderbird to send them because I thought it wouldn't do that. Anyway, I've resent them using the --attach option for git-format- patch. Thanks

Re: Maarten Lankhorst : winmm: Fix midi deadlock by not holding lock on release .

2008-03-19 Thread Ken Thomases
This has a whiff of the double-checked locking anti-pattern. I can't see a way where it would really bite us in this case, but that anti- pattern has several subtleties. So, I just wanted to prompt people to double-check it (pun acknowledged). Cheers, Ken On Mar 18, 2008, at 7:44 AM,

Re: winex11.drv: Indirection level fix

2008-03-21 Thread Ken Thomases
On Mar 21, 2008, at 10:30 AM, Andrew Talbot wrote: It seems that either packet should not be a WTPACKET **, or the first parameter to the memcpy() should be *packet. Unable to find this function being used anywhere, I guessed the former. It's used in dlls/wintab32/wintab32.c via

Re: Alexandre Julliard : winex11: Fix handling of property sizes for 64-bit platforms.

2008-04-07 Thread Ken Thomases
On Apr 7, 2008, at 6:50 AM, Alexandre Julliard wrote: Module: wine Branch: master Commit: 3bfa90eedafc9bd2faf9bc421caa172547e8ddd6 URL:http://source.winehq.org/git/wine.git/? a=commit;h=3bfa90eedafc9bd2faf9bc421caa172547e8ddd6 Author: Alexandre Julliard [EMAIL PROTECTED] Date: Mon

Re: relay log problem

2010-01-28 Thread Ken Thomases
On Jan 28, 2010, at 5:21 PM, Michael Stefaniuc wrote: On 01/28/2010 10:59 PM, Henri Verbeet wrote: On 28 January 2010 22:39, Stefan Leichterstefan.leich...@camline.com wrote: Is this a know problem? Is a work around available? Yeah, that's a known problem. As a workaround you can use

Re: mountmgr.sys not running on OpenBSD - depends on dbus/hal, or a timing issue?

2010-03-03 Thread Ken Thomases
On Mar 3, 2010, at 12:12 PM, Austin English wrote: The main question I have though, is that I can't get winetest to run there. When I run ./wine winetest or ./wine winetest-latest.exe, winetest begins to load, then bails out, saying mountmgr.sys isn't running, likely because my wineprefix is

Re: wineaudiofile.acm: Initial commit

2010-03-13 Thread Ken Thomases
On Mar 12, 2010, at 12:12 PM, Aric Stewart wrote: Henri Verbeet wrote: +ERR(Feed Error %c%c%c%c\n, (char) (ret 24), + (char) (ret 16), + (char) (ret 8), + (char) ret);

Re: New SCSI Driver for Mac OS X

2010-04-28 Thread Ken Thomases
Hi Charles, Are the DKIOCPREVENT and DKIOCALLOW ioctls necessary? DiskArbitration already has a facility for clients to refuse mount/unmount/eject requests. http://developer.apple.com/mac/library/documentation/Darwin/Reference/DiscArbitrationFramework/DiskArbitration_h/ Among other things, if

Re: New SCSI Driver for Mac OS X

2010-04-28 Thread Ken Thomases
On Apr 28, 2010, at 6:18 PM, Charles Davis wrote: Besides, to use it, we'd have to call DADiskMount() directly instead of going through diskutil. Huh? Who goes through diskutil? Who would have to call DADiskMount()? And why do you think DADiskMount() is necessary to register approval

Re: New SCSI Driver for Mac OS X

2010-04-28 Thread Ken Thomases
On Apr 28, 2010, at 8:28 PM, Charles Davis wrote: On 4/28/10 5:48 PM, Ken Thomases wrote: On Apr 28, 2010, at 6:18 PM, Charles Davis wrote: Besides, to use it, we'd have to call DADiskMount() directly instead of going through diskutil. Huh? Who goes through diskutil? NTDLL, when

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Ken Thomases
On May 12, 2010, at 2:30 PM, Charles Davis wrote: In Mac OS X 10.5, mmap() was changed to conform to UNIX '03. Among other things, this means that mmap() no longer supports unaligned file offsets (like Linux). What problems does this cause? However, by reading Darwin source, I learned that

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Ken Thomases
On May 12, 2010, at 6:53 PM, Charles Davis wrote: On 5/12/10 5:37 PM, Ken Thomases wrote: What problems does this cause? It makes Wine use more memory than it needs to. http://wiki.winehq.org/UnalignedMmap Can't we achieve that just by avoiding the mapping of the mmap identifier

Re: Release plans

2010-05-24 Thread Ken Thomases
On May 24, 2010, at 9:56 AM, Damjan Jovanovic wrote: ICNS seems like by far the easiest image file format in existence: http://en.wikipedia.org/wiki/Apple_Icon_Image It's apparently slightly more complicated than that page suggests, given a simple run-length compression scheme for image data:

Please review: Patch for non-Linux serial set_baud_rate()

2010-06-30 Thread Ken Thomases
Hi, I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from

Re: Please review: Patch for non-Linux serial set_baud_rate()

2010-06-30 Thread Ken Thomases
On Jun 30, 2010, at 11:47 AM, Ken Thomases wrote: I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems

Re: DIB clarification

2010-08-30 Thread Ken Thomases
On Aug 29, 2010, at 8:49 PM, Jeff Cook wrote: To clarify, it's not about having secret DIB engine code, it's about saying I guess we just won't find time to provide useful feedback until some company sponsors it..., as I saw several times during the old threads. What Jeremy neglected to say

Re: Wine Introduction Page

2010-09-07 Thread Ken Thomases
On Sep 4, 2010, at 2:20 PM, James McKenzie wrote: I know it is in git. I don't want to give out bogus information, that's why the question. I don't have an Intel system here with MacOSX 10.4 installed anymore, all of mine are at 10.6.4 Same thing with XCode. I know that the 2.x is at

Re: loader: On Mac, reserve the process's original thread for the frameworks.

2010-10-27 Thread Ken Thomases
On Oct 27, 2010, at 5:36 PM, Ken Thomases wrote: The frameworks expect the original thread to run its run loop, so input sources (like distributed notifications) get processed. For example, Core Audio on Snow Leopard doesn't track changes in the default ouput device, such as when

Re: AUTHORS list and the C locale on Mac OS X

2010-11-10 Thread Ken Thomases
On Nov 9, 2010, at 4:29 PM, Reece Dunn wrote: You could use autoconf to detect: 1/ broken handling of UTF-8 characters by sed; 2/ name of LC_ALL flag that handles UTF-8 In theory, you only need to set LC_CTYPE, not any other aspect of the locale. And for that, you don't need the

Re: AUTHORS list and the C locale on Mac OS X

2010-11-10 Thread Ken Thomases
On Nov 10, 2010, at 2:27 PM, Hin-Tak Leung wrote: --- On Wed, 10/11/10, Ken Thomases k...@codeweavers.com wrote: Are you sure about that? Checking on a couple of Linux systems here, the locale command reports: $ locale LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 ... mine (fedora x86_64

Re: AUTHORS list and the C locale on Mac OS X

2010-11-10 Thread Ken Thomases
On Nov 10, 2010, at 5:00 PM, Reece Dunn wrote: I'm getting the same behaviour (Ubuntu 10.10) -- LC_ALL accepts either utf8 or UTF-8 for en_GB, en_IE, etc. The caveat here is that the primary locale needs to exist (and presumably needs to have a UTF-8 valiant present). That is, as I don't

Re: loader: On Mac, reserve the process's original thread for the frameworks. (try 2)

2010-11-12 Thread Ken Thomases
On Nov 12, 2010, at 5:14 AM, Alexandre Julliard wrote: Ken Thomases k...@codeweavers.com writes: +/* This is a hack. We want to wait until the main thread has + * really exited in response to our signal. However, Mac OS X + * doesn't let us join the main thread

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-11-30 Thread Ken Thomases
On Nov 30, 2010, at 6:52 AM, Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: --- configure |8 +- configure.ac |5 + dlls/wineqtdecoder/Makefile.in| 11 + dlls/wineqtdecoder/main.c | 135

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-30 Thread Ken Thomases
Hi Loïc, On Dec 30, 2010, at 4:20 AM, maury loïc wrote: it's my first patch, and it implement the CDROM_Verify() to work on Mac Os. I think most people are going to need more explanation for why this is a legitimate way to implement this function on Mac OS X. :) Cheers, Ken

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-31 Thread Ken Thomases
On Dec 30, 2010, at 9:36 AM, James McKenzie wrote: This has been critically examined by several people and if the solution were this simple it would have been put in place a long time ago. Charles Davis has spend over a year looking at how to implement CDROM functionality for MacOSX.

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

2010-12-31 Thread Ken Thomases
On Dec 31, 2010, at 1:38 PM, Ken Thomases wrote: Why does that matter? The question is, under what circumstances does it end up in CDROM_Verify()? What is the right behavior of CDROM_Verify() and how would that be implemented on Mac OS X? I should add that this patch seem correct to me

windowscodecs: Use Mac OS X native ICNS support, not libicns.

2011-01-05 Thread Ken Thomases
Hi Damjan, I was intrigued to see the ICNS support you added to windowscodecs some months ago. Neat work! However, I'm confused about why you used the third-party libicns library. As near as I can tell, the ICNS support is only used on Mac OS X and it's not likely to ever be used elsewhere.

Re: windowscodecs: Use Mac OS X native ICNS support, not libicns.

2011-01-05 Thread Ken Thomases
On Jan 5, 2011, at 5:25 AM, Damjan Jovanovic wrote: It doesn't seem like a good idea to introduce a platform-specific dependency for ICNS support, but you might want to get feedback from other Wine developers. Hmm. I guess I don't see how ICNS is anything other than platform-specific. Is

Re: windowscodecs: Use Mac OS X native ICNS support, not libicns.

2011-01-05 Thread Ken Thomases
On Jan 5, 2011, at 5:45 AM, Damjan Jovanovic wrote: On Wed, Jan 5, 2011 at 1:31 PM, Ken Thomases k...@codeweavers.com wrote: OK. Do you think my patch should be held up until you find an approach that works for both? The patch seems fine (doesn't seem to regress anything), but aren't

Re: [PATCH 1/3] winemenubuilder: Icon heights/widths of 0 mean 256, for Vista icons.

2011-01-11 Thread Ken Thomases
On Jan 11, 2011, at 2:41 AM, Damjan Jovanovic wrote: The 256x256 pixel icons are designed to be viewed in that size. They can, and often do, contain a different picture to the smaller icons. When you scale them down to a smaller size, they look bad. On MacOS that may not matter since multiple

Re: [PATCH 1/3] winemenubuilder: Icon heights/widths of 0 mean 256, for Vista icons.

2011-01-12 Thread Ken Thomases
On Jan 12, 2011, at 3:22 AM, Damjan Jovanovic wrote: On Wed, Jan 12, 2011 at 7:36 AM, Ken Thomases k...@codeweavers.com wrote: Also, is it common for Windows icons to contain 64x64 variants? My impression is that it's not, but I have no hard data about that. In that case, it's typically

Re: windowscodecs: Disable ICNS support when building for Mac OS X 10.4 Tiger.

2011-01-21 Thread Ken Thomases
On Jan 21, 2011, at 2:36 AM, Damjan Jovanovic wrote: Should we reconsider libicns? Apple's APIs obviously can't be relied upon. On Jan 21, 2011, at 5:04 AM, Alexandre Julliard wrote: Several other things are already broken on Mac OS X 10.4. Basic functionality is there, but it's not worth

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 2)

2011-01-22 Thread Ken Thomases
On Jan 22, 2011, at 8:35 AM, Loïc Maury wrote: I have add comment in the code for the patch. @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) return STATUS_SUCCESS; else return STATUS_NO_MEDIA_IN_DEVICE; +/* At this point, we know that we have

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

2011-01-24 Thread Ken Thomases
Loïc, Your mailer seems to have mangled your patch with line wrapping. There are some suggestions on Wine's SubmittingPatches wiki page for avoiding this. Primarily, you should attach the patch to your email. If you already did that, then you may need to use a different mailer. For

Re: gameux: Always return NULL when category not available (valgrind) (try 2)

2011-01-26 Thread Ken Thomases
On Jan 26, 2011, at 11:34 AM, André Hentschel wrote: Am 26.01.2011 18:03, schrieb Vincent Povirk: I maintain that This-stats.categories[categoryIndex].sName cannot be NULL. It is an array, not a pointer. But an Arrayname points to the first field IMHO. Not quite. In C, arrays degrade to

Re: RFC: Adding Mac support to secur32/schannel.c

2011-01-31 Thread Ken Thomases
Hi Juan, On Jan 28, 2011, at 10:36 AM, Juan Lang wrote: I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-02 Thread Ken Thomases
On Feb 1, 2011, at 10:19 AM, Juan Lang wrote: I may be flogging a dead horse here, but I personally am loath to see another implementation creep in, side by side with the existing one, that has no guarantee of working any better. Well, it won't work any better, just as well as. I don't see

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-02 Thread Ken Thomases
On Feb 2, 2011, at 11:38 AM, Juan Lang wrote: That's fine. You asked for feedback on your general approach, and described it as a proof of concept. I gave you feedback on it as such. I appreciate your feedback. Although, in truth, I was asking more about how to do it (wether to separate

Re: CD handling on MacOS - the big picture?

2011-02-11 Thread Ken Thomases
On Feb 11, 2011, at 10:23 AM, joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com wrote: Mixed CDs occur in some games, but some audio CDs contain bonus content as well. On MacOS, mixed CDs are mounted as two volumes - the audio part, - the data/binary section not unlike

Re: Failing kernel32:change and ntdll:change tests on Mac OS

2011-03-10 Thread Ken Thomases
On Mar 10, 2011, at 2:47 PM, Charles Davis wrote: The Change Notification tests all fail miserably on my machine (a 2009 Mac Pro with Mac OS X 10.6), because that feature hasn't been implemented on Mac yet. I could implement it for 10.5 up, but the problem is that the public API for Change

Re: Failing kernel32:change and ntdll:change tests on Mac OS

2011-03-10 Thread Ken Thomases
On Mar 10, 2011, at 4:20 PM, Ken Thomases wrote: I doubt Alexandre would accept reworking wineserver around CFRunLoop, but I can think of several alternatives: 1) Have the wineserver spin off a secondary thread to run the CFRunLoop and then communicate to the main thread via a file

Re: Failing kernel32:change and ntdll:change tests on Mac OS

2011-03-21 Thread Ken Thomases
On Mar 21, 2011, at 8:52 AM, Charles Davis wrote: On 3/10/11 3:27 PM, Ken Thomases wrote: On Mar 10, 2011, at 4:20 PM, Ken Thomases wrote: I doubt Alexandre would accept reworking wineserver around CFRunLoop, I know. Then again, I've often wondered if doing this might be beneficial. I

Re: Fix to bug 25504 for gnutls based schannel

2011-04-18 Thread Ken Thomases
On Apr 18, 2011, at 3:46 AM, Hans Leidekker wrote: On Mon, 2011-04-18 at 10:36 +0200, Marcus Meissner wrote: On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote: On Sun, 2011-04-17 at 09:42 -0400, jbalent...@tuffmail.com wrote: #ifdef SONAME_LIBGNUTLS #include gnutls/gnutls.h

Re: [PATCH 4/5] winecoreaudio.drv: Implement IAudioSessionControl::GetState

2011-05-01 Thread Ken Thomases
Hi, On Apr 29, 2011, at 3:50 PM, Andrew Eikum wrote: +LIST_FOR_EACH_ENTRY(client, This-session-clients, ACImpl, entry){ +OSSpinLockLock(client-lock); +if(client-playing == StatePlaying){ +*state = AudioSessionStateActive; I think the session should be

Re: Trailing white space and other pedantry.

2011-05-16 Thread Ken Thomases
On May 16, 2011, at 7:42 PM, max wrote: On 05/16/2011 01:00 PM, André Hentschel wrote: Am 16.05.2011 18:34, schrieb m...@mtew.isa-geek.net: From: Max TenEyck Woodburym...@mtew.isa-geek.net I have been working on the documentation extraction problem and code analysis problem. I have made

Re: performance regression or not?

2011-05-24 Thread Ken Thomases
On May 23, 2011, at 12:13 PM, joerg-cyril.hoe...@t-systems.com joerg-cyril.hoe...@t-systems.com wrote: - I'm now wondering whether thread affinity may play a role. Alas, I don't know how to disable one core with Mac OS X 10.5.8 Double-click on

Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND)

2011-06-04 Thread Ken Thomases
On Jun 4, 2011, at 8:02 AM, Gerald Pfeifer wrote: Resending: This really looks like a straightforward bug fix and the current code definitely wrong??? No. As others have pointed out, your logic is wrong. The existing code is correct. The difference between two pointers (of the same type)

Re: [4/6] winex11.drv: Grab registered hotkeys in the X server.

2011-06-13 Thread Ken Thomases
On Jun 13, 2011, at 2:07 PM, Vincent Povirk wrote: 0005-winex11.drv-Grab-registered-hotkeys-in-the-X-server.txt Is it necessary to test QS_HOTKEY in dlls/winex11.drv/event.c:filter_event, where QS_KEY is currently tested? If somebody calls MsgWaitForMultipleObjectsEx with QS_HOTKEY but not

Re: [4/6] winex11.drv: Grab registered hotkeys in the X server.

2011-06-14 Thread Ken Thomases
On Jun 14, 2011, at 12:40 AM, Vincent Povirk wrote: Is it necessary to test QS_HOTKEY in dlls/winex11.drv/event.c:filter_event, where QS_KEY is currently tested? If somebody calls MsgWaitForMultipleObjectsEx with QS_HOTKEY but not QS_KEY, shouldn't KeyPress events be accepted? I

Re: app freezes during WM_KILLFOCUS

2011-06-16 Thread Ken Thomases
On Jun 16, 2011, at 9:09 AM, Eric Frias wrote: I've been chasing a bug for a few days, and finally have a good idea of what is going on. When a program brings up a modal dialog box in response to a WM_KILLFOCUS message, the program will freeze. Excellent analysis. Please file a bug report

Re: Tests failing on OSX

2011-09-21 Thread Ken Thomases
On Sep 21, 2011, at 2:58 AM, Francois Gouget wrote: Note also that the firewall will also ask whether to allow incoming network access for some of the tests. I would really like information on how to best deal with that. That sounds like Mac OS X's application firewall which is Apple's

Re: Tests failing on OSX

2011-09-21 Thread Ken Thomases
On Sep 21, 2011, at 5:59 AM, Francois Gouget wrote: On Wed, 21 Sep 2011, Ken Thomases wrote: Anyway, the application firewall is based on code-signing. The user's permission to allow a program to accept incoming connections is tied to the program's signature. [...] Since regularly

  1   2   3   >