Paul Vriens wrote:
And the subject of the mail should be a bit more than just
advapi32/tests.
Oops, sry. Read the second mail after resending in the patch
containing your first suggestions.
But I'm a bit confused about the meaning of todo_wine.
todo_wine discards output from failed tests, if I
Thanks for the clarification about todo_wine, Paul
Paul Vriens wrote:
Well I don't think it will be accepted as is. We usually don't add
functions that are not used anywhere especially when the comments say
that there is a bug elsewhere that should be fixed first.
Well, I was thinking about
Thanks for your hints, Paul.
I added some tests for the Ansi variant of the function
and fixed the problem you mentioned.
I also think that your addition of _GetAccountNameFromTokenW is holding the
committing of this patch back, especially because you don't seem to use
that
function.
I also
Hi!
I sent a patch regarding GetUserProfileDirectory last Monday.
I didn't receive any comments/critics as on my previous attempts.
The patch doesn't appear in wine-cvs, so I suppose something is
still not correct. Can anybody give me a clue, please?
Regards
Andreas
From acb4bf2dc4ecbd56fa54dfcbd8be2b270929d865 Mon Sep 17 00:00:00 2001
From: Andreas.Rosenberg andreas.rosenb...@apis.de
Date: Mon, 30 Mar 2009 10:19:50 +0200
Subject: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A
---
dlls/userenv/Makefile.in |2 +-
dlls/userenv/tests/userenv.c |
Vitaliy Margolen wrote:
+res = RegOpenKeyExW( HKEY_LOCAL_MACHINE, profile_pathname, 0L,
KEY_QUERY_VALUE, keyProfileDir );
+res = RegGetValueW( keyProfileDir, profile_subkey,
profile_keyname, RRF_RT_ANY,
+ NULL, buffer, sizePath ); /* RegGetValue
While I did some experimenting with the proposals from Vitaliy Margolen
to get an accepted patch for GetUserProfileDirectoryW, I found this
behavior:
OpenProcessToken(hProcess,TOKEN_QUERY,hToken);
...
GetTokenInformation( hToken, TokenUser, ptiUser, cbti, cbti )
...
LookupAccountSidW( NULL,
Vitaliy Margolen wrote:
The error codes returned by a function are not part of the Windows API
But they are. MS just made their obligation to document all of their craft
that much easer and that much more undefined. According to this logic
Error! is the only message you need for anything
On Friday 06 March 2009 14:12:11 you wrote:
Paul Vriens wrote:
Andreas Rosenberg wrote:
Hi,
Error during compilation:
userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from
incompatible
I don't consider it helpful writing a conformance test, for something
that is not specified. One could simply omit the error codes, but if
this call should fail an app may log/present a more meaningfull error
message than without it. If the error codes should be different from
Windows, this
Nikolay Sivov wrote:
Andreas Rosenberg wrote:
+ if ( !lpcchSize ) {
+ SetLastError(ERROR_INVALID_PARAMETER);
+ return FALSE;
+ SetLastError(ERROR_MORE_DATA);
+ }
+ }
+ }
+ else
+ SetLastError
From d59c1fe3e26e0cb41a3affe4034abc6dc9bd0556 Mon Sep 17 00:00:00 2001
From: Andreas.Rosenberg andreas.rosenb...@apis.de
Date: Thu, 5 Mar 2009 18:41:37 +0100
Subject: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A
---
dlls/userenv/Makefile.in |2 +-
dlls/userenv/tests/userenv.c |
Nikolay Sivov wrote:
Andreas Rosenberg wrote:
+if ( !lpcchSize ) {
+SetLastError(ERROR_INVALID_PARAMETER);
+return FALSE;
+SetLastError(ERROR_MORE_DATA);
+}
+}
+}
+else
+SetLastError
On Monday 02 March 2009 17:26:47 Nikolay Sivov wrote:
Andreas Rosenberg wrote:
+TRACE(%p %s %p\n, hToken, debugstr_w(lpProfileDir), lpcchSize );
+/* profile specific tokens not supported, so hToken ignored */
+
+SetLastError(0);
+res =
RegOpenKeyExW(HKEY_LOCAL_MACHINE
Hi!
From time to time I'm testing our application (IQ-FMEA) with Wine.
Our GUI framework is checking the return codes of most API calls,
so several incompatibilities between Windows and Wine are detected
while many other programs simply ignore them.
So I found several things that differ between
Hello Wine developers,
perhaps some guys will remember me. I'm working for a small
software company making a tool for FMEA and risk management.
Late last year I managed to make our application work with Wine
by submitting some patches.
Our company held it's anual user meeting this week in
Hello guys,
after a long pause I'm back testing our application
(http://appdb.winehq.org/appview.php?appId=1536) with WINE.
In the meantime I've been working to prepare our application
for the east european/asian market (UTF16, wide char API).
This seems to work so far, but as soon as you
Hi guys!
I'd like to run a TAPI based application in Wine (updated from CVS today).
I extracted the vendor specific TAPI driver and the registry keys
and included both into a Wine setup.
Then I tried to do setup the TAPI driver using the
telephon.cpl (taken from Win98):
wine rundll32.exe
Hi folks,
I sent a patch for bug 1848 already twice. 1st time in the first
half of december. 2nd time last week. Other stuff seems to be
commited into the CVS.
I was wondering, why my patch is not accepted.
Can't you keep the pace commiting the patch into the CVS as they
are sent to you?
Is
From my notes (I dont have Linux to hand just now):
Trap occurs ar 0x43d4e2
At this point in time the path/exe is in 0x552150 On windows:
This was copied from 0x12fe20 (Was already filled in at a breakpoint at
0x43d4ba)
which in turn came from 0x141ee0 when the pgm is very first loaded
Hello guys,
I'm watching this thread since yesterday.
Perhaps I can give you a clue.
I'm trying to investigate that GetCommandLine thing.
The one thing I couldnt answer is how the game 'gets' the command line.
int WinMain(
HINSTANCE hInstance,
HINSTANCE hPrevInstance,
Perhaps. I'd be willing to bet that virtually all (gui) win32 apps are
tested by running it from explorer or the shell, which seems to use full
paths though.
I'd also bet 5 EUROs ;-)
So the fact that we usually run without a full path seems to
be problematic. I guess there's a slight
I was thinking about fixing the bug 1848.
Here are parts of the involved functions.
See my comments/questions with multiple *** inside:
---
BOOL WINAPI TrackPopupMenu( HMENU hMenu, UINT wFlags, INT x, INT y,
INT nReserved, HWND hWnd, const
Hi!
I'm new to this list. The company I'm working for, is developing
software for Windows and as a personal Linux fan I was testing
our software with Wine from time to time. The last tries (several
month ago) were still pretting bad, but with the Wine from Suse 9.0
(snapshot from August 2003)
24 matches
Mail list logo