Re: ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath

2007-06-07 Thread Ulrich Czekalla
Silly me that's what I get for copying and pasting what was already there. Attached is a revised patch. Thanks, /Ulrich On Fri, Jun 08, 2007 at 01:11:03AM +0900, Dmitry Timoshkov wrote: Ulrich Czekalla [EMAIL PROTECTED] wrote: -WCHAR word[MAX_PATH]; -int i=0,j,tabIndex=0

Re: opengl32: Correctly size and position opengl child windows

2006-10-06 Thread Ulrich Czekalla
On Fri, Oct 06, 2006 at 01:30:43PM +0200, Roderick Colenbrander wrote: Hi, The plan is to get all the X-specific opengl code into winex11.drv and to get rid of things like ExtEscape. I also want to avoid using WineGLContext in opengl32.dll as I plan to change this too. A call like

Re: Shell integration

2006-06-16 Thread Ulrich Czekalla
On Thu, Jun 15, 2006 at 11:26:02AM +0100, Robert Shearman wrote: I don't think it is. I think it would be better to start off with by just doing the shell integration in shell32. If a framework like this is needed, then it will become obvious later on. That's why I like the idea of using

Re: Shell integration idea

2006-06-02 Thread Ulrich Czekalla
I think the general approach is good. The way you handle the built in implementation seems odd to me. I think setting the registry key to make the freedesktop.org version as the default would be good enough. I'm not convinced we need IWineShellIntegration. I think it would be cleaner to directly

Re: thanks for wine

2006-05-19 Thread Ulrich Czekalla
The attached patch should help. It's a bit of a hack and it's mostly untested but copy and paste in MSVC6 seems to work fine. /Ulrich On Wed, May 17, 2006 at 07:21:55AM +0800, qingdoa daoo wrote: --- Ulrich Czekalla [EMAIL PROTECTED] wrote: I still don't understand why it would set

Re: thanks for wine

2006-05-17 Thread Ulrich Czekalla
-Mesa-devel-6.8.2-100 xorg-x11-Mesa-6.8.2-100 xorg-x11-Xnest-6.8.2-100 xorg-x11-fonts-scalable-6.8.2-100 xorg-x11-6.8.2-100.2 Many thanks Roland - Ursprüngliche Mail Von: Ulrich Czekalla [EMAIL PROTECTED] An: Roland Kaeser [EMAIL PROTECTED] Gesendet

Re: thanks for wine

2006-05-16 Thread Ulrich Czekalla
Yes good idea. Things are a bit hectic around here but I'll try to do that in the next couple of days. /Ulrich On Fri, May 12, 2006 at 09:22:49AM -0400, Dimi Paun wrote: Wine's clipboard implementation is a bit of a mistery to a lot of people :) Ulrich, it would be really great if you can

Re: thanks for wine

2006-05-15 Thread Ulrich Czekalla
; } --- Ulrich Czekalla [EMAIL PROTECTED]: On Fri, May 12, 2006 at 04:16:28PM +0800, qingdoa daoo wrote: Now that you brought it up, clipboard in wine does have some limitations. e.g. when a process calls OpenClipboard(hwnd), Windows doesn't seem to care if the hwnd is owned

Re: thanks for wine

2006-05-12 Thread Ulrich Czekalla
On Fri, May 12, 2006 at 06:20:13AM +, Roland Kaeser wrote: The only major issues that I'm aware of are coping and pasting OLE embedded objects. That should be taken care of when Rob is finished his COM work. IMO 633, 2382 and 5061 are not really copy and paste bugs. They are caused by

Re: thanks for wine

2006-05-11 Thread Ulrich Czekalla
On Wed, May 10, 2006 at 10:55:46PM +0300, Marius Andreiana wrote: Thank you wine developers for allowing me to play the Da Vinci Quest with Firefox and required Flash 8 plugin, not available for Linux. Cool. Copy-paste didn't work between wine and Gnome, but everything else was without a

Re: thanks for wine

2006-05-11 Thread Ulrich Czekalla
There may be an odd bug here and there but copy and paste should be working just fine between most applications. At least the X11 driver code should be working correctly. The only major issues that I'm aware of are coping and pasting OLE embedded objects. That should be taken care of when Rob is

Re: How hard would it be to support Java?

2006-03-19 Thread Ulrich Czekalla
On Fri, Mar 17, 2006 at 06:21:43PM -0800, Dan Kegel wrote: Quite a few apps use embedded JVM's. Case in point: SPSS, one of the apps requested by Munich. So I played around a bit with Sun's latest 1.5 JRE. It can run trivial apps, so I closed http://bugs.winehq.org/show_bug.cgi?id=2953

Re: Patch for Bug 4159

2005-12-27 Thread Ulrich Czekalla
I don't think this should fail if size equals 0. This function is also used by StgStreamImpl_Read and it shouldn't fail if it reads 0 bytes. I think a better place to fix it is in the SmallBlocksToBigBlocks() loop. /Ulrich On Mon, Dec 26, 2005 at 09:26:58AM -0500, Howard Selover III wrote:

Re: listview: infoPtr might be invalid after WM_NOTIFY

2005-10-18 Thread Ulrich Czekalla
On Tue, Sep 20, 2005 at 04:20:50PM -0500, Robert Shearman wrote: Since this was a behaviour in our file open dialog, did we even verify that this was a listview bug or is it that destroying the listview in the middle of a notification is something that you shouldn't do? If the \ A quick test

Re: riched20.dll asserts

2005-09-28 Thread Ulrich Czekalla
Hi Aric, Could you try the attached patch. I must admit I don't fully understand the underlying data structures but I think this patch fixes the problem. /Ulrich On Tue, Sep 27, 2005 at 11:36:58AM -0500, Aric Stewart wrote: Hello, So looking into an issue with IE6 i found the following

Re: dlls/x11drv/mouse.c

2005-09-09 Thread Ulrich Czekalla
On Fri, Sep 09, 2005 at 11:22:26AM +0200, Alexandre Julliard wrote: This sounds like it's just masking the problem. Do you know precisely why the mouse position is incorrect? No :-/ I can't explain it. The XQueryPointer call in X11DRV_GetCursorPos is returning an incorrect value. I don't see

Re: dll/winmm/playsound.c

2005-09-08 Thread Ulrich Czekalla
fccType is type FOURCC which is a DWORD. /Ulrich On Thu, Sep 08, 2005 at 11:28:56AM -0500, Robert Shearman wrote: I think these formats should be %04x as fccType is 2 bytes, not 4 bytes.

Re: dlls/gdi/dib.c GetDIBits

2005-06-01 Thread Ulrich Czekalla
Uwe, Here you go. I hope it helps. /Ulrich On Wed, Jun 01, 2005 at 10:05:08AM +0200, Uwe Bonnes wrote: Ulrich == Ulrich Czekalla [EMAIL PROTECTED] writes: Ulrich This patch fixes a regression that happened quite sometime Ulrich ago. We don't always fill in the BITMAPINFO struct

Re: Text Alignment, how is it handled ?

2005-02-10 Thread Ulrich Czekalla
makes no attempt to rewrite any of it ;-) /Ulrich On Tue, Feb 08, 2005 at 12:53:56PM -0500, Ulrich Czekalla wrote: Actually I just started to look at this as well. I expect to have a patch in the next day or so. If you already have something let me know and I'll stop working on it. Thanks

Re: Text Alignment, how is it handled ?

2005-02-10 Thread Ulrich Czekalla
patch makes no attempt to rewrite any of it ;-) /Ulrich On Tue, Feb 08, 2005 at 12:53:56PM -0500, Ulrich Czekalla wrote: Actually I just started to look at this as well. I expect to have a patch in the next day or so. If you already have something let me know and I'll stop working

Re: Oracle - unixODBC - wine - Win32 ODBC Apple [Virus checked]

2005-01-25 Thread Ulrich Czekalla
On Tue, Jan 25, 2005 at 03:14:56PM -0800, Bill Medland wrote: On January 25, 2005 08:03 am, Martin HEIN wrote: Bill, I just upgraded to the most recent version of CrossOver Office 4.1 Professional, a nightly build as of January 25th, 2005, and wine reports version 20050111. (upgraded

Re: WINEDBG: add support to interrogate gdi objects

2005-01-21 Thread Ulrich Czekalla
Eric DMI AEI CAEN wrote: Message du 21/01/05 04:10 ChangeLog: Ulrich Czekalla * add support to interrogate gdi objects several comments: * the changes in db_disasm.c are not declared in the changelog. Morever, I don't see the need of passing an extra parameter in db_task_printsym

Re: Contributing to WINE

2004-09-22 Thread Ulrich Czekalla
On Wed, Sep 22, 2004 at 04:55:17PM +0100, Mike Hearn wrote: To be fair, this seems to be Mutt/Pine sucking. The email source is a very standard multipart/mixed HTML+text mail which is the de-facto standard outside of geek mailing lists :) There's nothing magic about it, if somebodies

Re: edit control

2004-09-15 Thread Ulrich Czekalla
On Wed, Sep 15, 2004 at 06:27:11PM +0100, Robert Shearman wrote: Ulrich Czekalla wrote: Running some tests under WinXP I noticed that if the edit control doesn't have WS_EX_CLIENTEDGE it looses the WS_BORDER style and it handles painting the border. This also has the side effect that it's

Re: edit control

2004-09-09 Thread Ulrich Czekalla
Yeah, not all of it does. This cleans it up. Thanks, /Ulrich On Thu, Sep 09, 2004 at 02:39:13PM +0100, Robert Shearman wrote: That read-only check looks completely bogus to me as the code below already checks for ES_READONLY. Index: dlls/user/edit.c

Re: listview

2004-09-03 Thread Ulrich Czekalla
Ok, I'll do some more research and see if I can come up with a better solution. Thanks, /Ulrich On Fri, Sep 03, 2004 at 12:44:01PM +0200, Rein Klazes wrote: On Thu, 2 Sep 2004 17:28:31 -0400, you wrote: ChangeLog: Ulrich Czekalla [EMAIL PROTECTED] Handle WM_BUTTONDOWN

[ulrich@codeweavers.com: Re: Clipboard functionality across processes]

2004-05-15 Thread Ulrich Czekalla
this functionality. /Ulrich On Fri, May 14, 2004 at 01:25:18PM -0400, Ulrich Czekalla wrote: The clipboard code is in dlls/x11/clipboard.c. dlls/x11drv/wineclipsrv.c contains the code for the separate process that is suppose to be launched to host the clipboard data once the application exits. I haven't

Re: Clipboard functionality across processes

2004-05-14 Thread Ulrich Czekalla
, 2004 at 03:23:34PM +0530, Santosh Siddheshwar wrote: Hi, Any pointers to where to look for the relevant code which may need to be looked at? Regards Santosh Siddheshwar -Original Message- From: Ulrich Czekalla [SMTP:[EMAIL PROTECTED] Sent: Wednesday, May 12, 2004 7

Re: Clipboard functionality across processes

2004-05-12 Thread Ulrich Czekalla
The short answer is no. We did have this functionality before and much of the code is still in cvs but it was broken for some time and I've disabled it. With a little bit of work it could be added back. There are other ways to do this such as using klipper. /Ulrich On Wed, May 12, 2004 at

Re: SetFocus

2004-04-27 Thread Ulrich Czekalla
Hmmm. It didn't work for me when I tried under win2k. I'll investigate it further. /Ulrich On Tue, Apr 27, 2004 at 08:52:35PM -0700, Alexandre Julliard wrote: Ulrich Czekalla [EMAIL PROTECTED] writes: ChangeLog: Ulrich Czekalla [EMAIL PROTECTED] Trying to set focus

Re: Wine menu woes

2004-04-11 Thread Ulrich Czekalla
I do have a patch that needs to be cleaned up that moves menu management to the server. It's a rather large patch because all the menu painting and event handling had to be rewritten. My plan is to finish it up once we release our next version of Crossover. /Ulrich On Sat, Apr 10, 2004 at

Re: [Fwd: [unixODBC-DEV] - UnixODBC, Wine, Crystal Report -- would appreciate insight]]

2004-01-07 Thread Ulrich Czekalla
On Wed, Jan 07, 2004 at 07:11:54AM -0800, Bill Medland wrote: On January 6, 2004 07:35 pm, Dan Kegel wrote: Can somebody have a look at this? Thanks, Dan I'll do what I can; everyone else feel free to jump in. Original Message Subject: [unixODBC-DEV] - UnixODBC,

Re: option to ignore primary selection

2003-12-18 Thread Ulrich Czekalla
Makes sense to me. I modified the patch to turn it on by default. /Ulrich On Thu, Dec 18, 2003 at 02:06:29PM +, Mike Hearn wrote: On Thu, 2003-12-18 at 05:00, Ulrich Czekalla wrote: This patch adds an option (turned off by default) to restrict Wine to only use the clipboard selection