Re: KERNEL: check for NULL in LoadModule16

Andreas Mohr wrote: Hi, On Mon, Aug 29, 2005 at 01:43:04PM -0500, Alex Villací­s Lasso wrote: I could not find any MSDN reference on any documented behavior for LoadLibrary16 or LoadModule16 when libname == NULL. I've checked it now (Watcom, Win98 SE): (forgot to zero LOADPARAMS,

Re: KERNEL: check for NULL in LoadModule16

Andreas Mohr wrote: What about a directory dlls/kernel/tests/win16/ ? (and adding a README mentioning OpenWatcom) Or should it be dlls/kernel/tests16/ instead? Why not a binary win16 checked into CVS to be run by winetest? We only want to test win16 loading, right? regards, Jakob

Re: KERNEL: check for NULL in LoadModule16

Hi, On Mon, Aug 29, 2005 at 01:43:04PM -0500, Alex Villací­s Lasso wrote: I could not find any MSDN reference on any documented behavior for LoadLibrary16 or LoadModule16 when libname == NULL. I've checked it now (Watcom, Win98 SE): (forgot to zero LOADPARAMS, sorry! But it hopefully didn't

Re: KERNEL: check for NULL in LoadModule16

Hi, On Mon, Aug 29, 2005 at 12:37:31PM -0500, Alex Villací­s Lasso wrote: An old copy of Print Shop Deluxe Companion manages to supply a NULL as a name to be loaded by LoadLibrary16 -- LoadModule16 -- SIGSEGV. This patch adds a check to return ERROR_READ_FAULT instead of crashing. Alex

Re: KERNEL: check for NULL in LoadModule16

Andreas Mohr wrote: Hi, On Mon, Aug 29, 2005 at 12:37:31PM -0500, Alex Villací­s Lasso wrote: An old copy of Print Shop Deluxe Companion manages to supply a NULL as a name to be loaded by LoadLibrary16 -- LoadModule16 -- SIGSEGV. This patch adds a check to return ERROR_READ_FAULT instead

Re: KERNEL: check for NULL in LoadModule16

Hi, On Mon, Aug 29, 2005 at 01:43:04PM -0500, Alex Villací­s Lasso wrote: I could not find any MSDN reference on any documented behavior for LoadLibrary16 or LoadModule16 when libname == NULL. Even if Windows does not check for NULL in this function, I do not think that the bug-for-bug