Re: mciqtz32: Implement driver messages

2009-03-31 Thread Christian Costa
You're right. Not good for git blame. I will ask to Alexandre. Thanks. By, Christian Detlef Riekenberg a écrit : On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid

Re: mciqtz32: Implement driver messages

2009-03-30 Thread Detlef Riekenberg
On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. Changing only the

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Detlef Riekenberg
On Sa, 2009-03-28 at 11:48 +0100, Christian Costa wrote: Thanks for working on this part of Wine. +/** + * MCIAVI_drvClose [internal] + */ +static DWORD MCIQTZ_drvClose(DWORD dwDevID)

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Christian Costa
There are some discrepancies in the indentation and I don't mind removing tabs but what's wrong with them, they are commonly use in wine depending on one's taste. Christian Detlef Riekenberg a écrit : On Sa, 2009-03-28 at 11:48 +0100, Christian Costa wrote: Thanks for working on this part of

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Detlef Riekenberg
On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: There are some discrepancies in the indentation and I don't mind removing tabs but what's wrong with them, they are commonly use in wine depending on one's taste. Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPACE,

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Christian Costa
I din't know wine has a indentation style. This is good news. That said, I don't understand then why we don't just convert wine's code (in several steps off course) and avoid troubles particularity switch from one style to another depending on the dll we are working on. I recently implemented