Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now available

2006-10-22 Thread Jaap Keuter
Hi, Sorry dude, since it's not yet picked up and we want no 'big' changes now I vote against it. The reason why it was not picked up? I don't know, but I would have to rework the code considerable before committing it, as I would want to get rid of the 10 level deep conditionals, the use of

Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now available

2006-10-22 Thread Tobias Erichsen
Hi again, no problem. I have already started to move a good amount of the literals into the h-file and I will try to move all I can into value_string arrays. But this won't be possible for everything, as MIDI itself has some specialities already within the coding and RTP-MIDI takes this even

Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now available

2006-10-22 Thread Ulf Lamping
Tobias Erichsen wrote: Hi again, no problem. I have already started to move a good amount of the literals into the h-file and I will try to move all I can into value_string arrays. But this won't be possible for everything, as MIDI itself has some specialities already within the coding

Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now available

2006-10-22 Thread Jaap Keuter
Hi, Good to see the dissector is improving. A couple of _add_text() calls is oke, but the more they can be avoided the better. Problem is twofold, one being unable to filter on them, the other that the presentation of the overall look and feel is implemented by the core itself. Changes in that

[Wireshark-dev] Radius Statistics Patch

2006-10-22 Thread Alejandro Vaquero
Hi All, find attached a patch for the Radius dissector to add statistics in the Service Response Time menu and the tshark stats. Regards Alejandro Index: config.nmake === --- config.nmake(revision 19652) +++

[Wireshark-dev] News.txt of the 0.99.4pre NSIS installer showing outdated 0.99.3 information!

2006-10-22 Thread Ulf Lamping
Hi List! Is this intentional? ;-) Regards, ULFL ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] [Patch] Few small fixes to packet-wlccp.c

2006-10-22 Thread Stephen Fisher
Here is a patch to make a few small fixes to packet-wlccp.c: * Null terminate one of the value strings that was missing it * Change a comment from LCC to LLC * Change the version variable from guint to guint8 to match the packet [it is already using tvb_get_guint8()] Thanks, Steve

[Wireshark-dev] How to test a newly added plugin????

2006-10-22 Thread taraniteja.vishwanatha
Hi , I have added a plugin for a protocol which runs on top of SUA layer. But we do not have the environment to test the plugin. The client may provide us with a capture file but we cannot test all the scenarios ( all the messages and packet formats) with that. Please let me know the

Re: [Wireshark-dev] [Patch] Few small fixes to packet-wlccp.c

2006-10-22 Thread Jaap Keuter
Hi, Checked in. Thanx, Jaap On Sun, 22 Oct 2006, Stephen Fisher wrote: Here is a patch to make a few small fixes to packet-wlccp.c: * Null terminate one of the value strings that was missing it * Change a comment from LCC to LLC * Change the version variable from guint to guint8 to