Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread Speck Michael EHWG AVL/GAE
Hi Brian, just had a look on your latest preview. There is one more thing you can do to reduce the code size even further: as Jakub has already suggested earlier, it is a good idea to use value_string struct to map values with strings. In your case it is especially true for the GPS status. There

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC

2010-02-04 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/1066 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build

Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread Gerasimos Dimitriadis
Hi Brian, there is no need to add a text string as blurb, if it is the same as the title of the field, so for example the ipv4 one would become: { hf_helen_ipv4, { IPv4, helen.ipv4address, FT_IPv4, BASE_NONE, NULL, 0x0, NULL, HFILL}},

Re: [Wireshark-dev] RTP-MIDI not working in 1.3.3 (but does perfectly in 1.2.6)

2010-02-04 Thread Bill Meier
Tobias Erichsen wrote: Hi everyone, Last night I spent some time to adapt my RTP-MIDI dissector. When trying it out with version 1.3.3 it failed. Wireshark 1.3.3 crashes when I call proto_register_field_array in my proto_register_rtp_midi. Could anyone give me a pointer what the

[Wireshark-dev] 1.3.3 - proto_register_field_array crashes with type FT_BYTES

2010-02-04 Thread Tobias Erichsen
Hi everyone, I have noticed that my dissector crashes Wireshark 1.3.3 when trying to register my array (proto_register_field_array) which contains the following record: { hf_rtp_midi_unknown_data, { Unknown Data,

Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread Maynard, Chris
Some other observations/feedback: You should look again at the doc/README.developer skeleton code and follow the common structure there. For example, you need to add a GPL statement, you should move the handoff and register routines to the bottom, etc. Run tools/check*.pl on your dissector.

Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread philippe alarcon
Hello, Related to the question Chris has raised here below regarding the new protocol, I have a more general question : - what are the criteria (or the requirements) to add a new dissector in main Wireshark distribution ? (independantly of the compliance of the code to the development rules)

Re: [Wireshark-dev] 1.3.3 - proto_register_field_array crashes with type FT_BYTES

2010-02-04 Thread Tobias Erichsen
Hi Bill, thanks for the feedback. Actually it has been the 0x7f that caused me the real harm ;-). It is now fixed... Best regards, Tobias Original-Nachricht Datum: Thu, 04 Feb 2010 10:40:07 -0500 Von: Bill Meier wme...@newsguy.com An: Developer support list for Wireshark

Re: [Wireshark-dev] 1.3.3 - proto_register_field_array crashes with type FT_BYTES

2010-02-04 Thread Bill Meier
Tobias Erichsen wrote: Hi everyone, I have noticed that my dissector crashes Wireshark 1.3.3 when trying to register my array (proto_register_field_array) which contains the following record: { hf_rtp_midi_unknown_data, {

Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread Maynard, Chris
I am not a core developer, just a contributor like you, but since I'm on this thread, I'll add my 2 cents ... I don't think there really are any hard requirements per se. But, once a dissector is accepted, the core development team is now somewhat responsible for maintaining it (patches

[Wireshark-dev] Getting data out of 'address' struct

2010-02-04 Thread Beth
If I populate an address with the following syntax: SET_ADDRESS(pinfo-dl_dst, AT_EUI64, sizeof(guint64), jn_dst64); and then later I need to get that address back out as a uint64, what is the proper way to do it? I don't see any predefined macro for this operation, at least not in address.h.

Re: [Wireshark-dev] Getting data out of 'address' struct

2010-02-04 Thread Beth
Never mind, I forgot about memcpy. That works fine. ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] preliminary code submission

2010-02-04 Thread Jaap Keuter
Hi Chris, You describe it very nicely, it's al subjective indeed. Still the guidelines in README.Developer and other documentation give a pretty good idea what's required. Thanks, Jaap Send from my iPhone On 4 feb 2010, at 17:42, Maynard, Chris christopher.mayn...@gtech.com wrote: I am

Re: [Wireshark-dev] 1.3.3 - proto_register_field_array crashes with type FT_BYTES

2010-02-04 Thread Jaap Keuter
Hi, Well, go ahead and create such a page under /Development Thanks, Jaap Send from my iPhone On 4 feb 2010, at 18:01, Beth beth.trid...@gmail.com wrote: It seems I'm not the only one who got bitten by this change (several times - I'm a slow learner). Just wondering, is there a

Re: [Wireshark-dev] Some random patches I use...

2010-02-04 Thread ronnie sahlberg
metze great patches, as usual. applied, thanks. On Sat, Jan 30, 2010 at 1:10 AM, Stefan (metze) Metzmacher me...@samba.org wrote: Hi, I'm using a few patches in my private git branch of wireshark. It would be nice if they could go upstream. metze

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2010-02-04 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/1373 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason:

[Wireshark-dev] buildbot failure in Wireshark (development) on Ubuntu-9.10-x64

2010-02-04 Thread buildbot-no-reply
The Buildbot has detected a new failure of Ubuntu-9.10-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Ubuntu-9.10-x64/builds/127 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: ubuntu-9.10-x64 Build

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC

2010-02-04 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/1076 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build