Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread Chris Maynard
Richard Sharpe realrichardsha...@... writes: If there are any suggestions for other changes, let me know. Hi Richard. It looks like there are other bit-oriented fields besides hf_scsi_control that could benefit from this as well: hf_scsi_inquiry_flags, hf_scsi_modesel_flags, ... There also

Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread Anders Broman
Chris Maynard skrev 2010-12-04 15:29: Richard Sharperealrichardsha...@... writes: If there are any suggestions for other changes, let me know. Hi Richard. It looks like there are other bit-oriented fields besides hf_scsi_control that could benefit from this as well: hf_scsi_inquiry_flags,

Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread Richard Sharpe
On Sat, Dec 4, 2010 at 6:29 AM, Chris Maynard chris.mayn...@gtech.com wrote: Richard Sharpe realrichardsha...@... writes: If there are any suggestions for other changes, let me know. Hi Richard.  It looks like there are other bit-oriented fields besides hf_scsi_control that could benefit

Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread ronnie sahlberg
Yeah The scsi dissector does need some tlc to clean up and to harmonize the dissection according to the latest versions of the standard. For handling flags, you may want to look at some examples such as ... static const int *aca_fields[] = { hf_scsi_inq_aerc, /* obsolete in spc3

Re: [Wireshark-dev] Thinking of some changes to packet-scsi.c ...

2010-12-04 Thread Richard Sharpe
On Sat, Dec 4, 2010 at 3:46 PM, ronnie sahlberg ronniesahlb...@gmail.com wrote: Yeah The scsi dissector does need some tlc to clean up and to harmonize the dissection according to the latest versions of the standard. For handling flags, you may want to look at some examples such as ...