[Wireshark-dev] [PATCH] add support for tipc dissector at transport level.

2012-07-27 Thread Karin Nilsson
Signed-off-by: Karin Nilsson karin.nils...@ericsson.com --- epan/dissectors/packet-tipc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/epan/dissectors/packet-tipc.c b/epan/dissectors/packet-tipc.c index 949cdf3..864d789 100644 --- a/epan/dissectors/packet-tipc.c +++

Re: [Wireshark-dev] [PATCH] add support for tipc dissector at transport level.

2012-07-27 Thread Jaap Keuter
Hi, Why not request for a proper portnumber at IANA? Thanks, Jaap On 2012-07-27 13:32, Karin Nilsson wrote: Signed-off-by: Karin Nilsson karin.nils...@ericsson.com --- epan/dissectors/packet-tipc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [Wireshark-dev] [PATCH] add support for tipc dissector at transport level.

2012-07-27 Thread Erik Hugne
Good question. I'll bring this up with the TIPC working group. //E On 2012-07-27 14:01, Jaap Keuter wrote: Hi, Why not request for a proper portnumber at IANA? Thanks, Jaap On 2012-07-27 13:32, Karin Nilsson wrote: Signed-off-by: Karin Nilsson karin.nils...@ericsson.com ---

[Wireshark-dev] UDP sub-dissector for TIPC?

2012-07-27 Thread Erik Hugne
Hi. I'm developing a UDP based bearer for the TIPC protocol. Wireshark currently have support for TIPC, but can only identify these packets when transported directly on top of Ethernet. It shouldnt be an all too complex task to fix so that the TIPC dissector can be applied on specific UDP

[Wireshark-dev] How to save the stream data for a special protocol

2012-07-27 Thread qiang.huang
Dear all: It's no problem for us to write a dissector Plugin to dissect one or more packets for a special protocol. But we find that it's nearly impossible to use it to save its stream data for its serials of packets without repeating. As long as a user refreshes or clicks the wireshark's

Re: [Wireshark-dev] [PATCH] add support for tipc dissector at transport level.

2012-07-27 Thread Jeff Morriss
IANA is definitely the better way to go, but another option is to make the port number configurable (as a dissector preference, maybe using a range preference in case multiple ports are needed), possibly defaulting to 0 (meaning users must configure it to get it to work). Making the dissector

Re: [Wireshark-dev] How to save the stream data for a special protocol

2012-07-27 Thread Stephen Fisher
On Fri, 27 Jul 2012 02:51:02 -0600 qiang.huangqiang.hu...@symbio.com wrote It's no problem for us to write a dissector Plugin to dissect one or more packets for a special protocol. But we find that it's nearly impossible to use it to save its stream data for its

Re: [Wireshark-dev] 答复: [Wireshark-users] Wireshark 1.6.9 is now available

2012-07-27 Thread Gerald Combs
We switched to the OpenSUSE GTK+ bundle in 1.6.9. According to Dependency Walker it requires libxml via Cairo. I checked in a fix in r44077. Damker, can you try wireshark-win32-1.6.10pre1-44077 or later from

[Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Pascal Quantin
Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used. According to the nice comment Guy put in revision above the variable assignment, I have the feeling that it is actually useful

Re: [Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Evan Huus
On Fri, Jul 27, 2012 at 6:14 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used. According to the nice comment Guy put in

Re: [Wireshark-dev] Possible bug in dissect_pipe_dcerpc() (packet-smb-pipe.c)

2012-07-27 Thread Pascal Quantin
2012/7/28 Evan Huus eapa...@gmail.com On Fri, Jul 27, 2012 at 6:14 PM, Pascal Quantin pascal.quan...@gmail.com wrote: Hi all, while working on fixing a few Clang warnings in packet-smb-pipe.c, I discovered that the hash_key variable in dissect_pipe_dcerpc() function is never used.