[Wireshark-dev] Problems with regenerating lppe dissector

2012-09-10 Thread Jakub Zawadzki
Hi, I'm trying to regenerate packet-lppe.c from asn1/lppe using command: ../../tools/asn2wrs.py -p lppe -c ./lppe.cnf -s ./packet-lppe-template -D . -O ../../epan/dissectors LPPe.asn Regenerated version doesn't compiles: ../../asn1/lppe/packet-lppe-fn.c:868:77: error: use of undeclared

Re: [Wireshark-dev] Problems with regenerating lppe dissector

2012-09-10 Thread Pascal Quantin
2012/9/10 Jakub Zawadzki darkjames...@darkjames.pl Hi, I'm trying to regenerate packet-lppe.c from asn1/lppe using command: ../../tools/asn2wrs.py -p lppe -c ./lppe.cnf -s ./packet-lppe-template -D . -O ../../epan/dissectors LPPe.asn Regenerated version doesn't compiles:

Re: [Wireshark-dev] Problems with regenerating lppe dissector

2012-09-10 Thread Pascal Quantin
2012/9/10 Pascal Quantin pascal.quan...@gmail.com 2012/9/10 Jakub Zawadzki darkjames...@darkjames.pl Hi, I'm trying to regenerate packet-lppe.c from asn1/lppe using command: ../../tools/asn2wrs.py -p lppe -c ./lppe.cnf -s ./packet-lppe-template -D . -O ../../epan/dissectors LPPe.asn

Re: [Wireshark-dev] Adding data parameter to dissector handler

2012-09-10 Thread Jakub Zawadzki
On Tue, Sep 04, 2012 at 11:19:09AM +0200, Jakub Zawadzki wrote: On Mon, Sep 03, 2012 at 06:00:06PM -0700, Guy Harris wrote: On Sep 3, 2012, at 4:35 PM, Jakub Zawadzki wrote: I plan to replace: typedef void (*dissector_t)(tvbuff_t *, packet_info *, proto_tree *); typedef int

[Wireshark-dev] When to use tree != NULL check?

2012-09-10 Thread mmann78
In working on bug 3534, one of the review comments was that a tree != NULL check placed near the start of the dissector should be removed as it prevented some of the COL_INFO/expert info data from being populated if tree was NULL. While I agree the tree != NULL check should probably be

Re: [Wireshark-dev] When to use tree != NULL check?

2012-09-10 Thread Guy Harris
On Sep 10, 2012, at 7:37 PM, mman...@netscape.net wrote: I guess I've always used the rule that simple [1] dissectors (no matter how large) should all have the tree != NULL check before any dissection really takes place. Simple would also have to include no subdissectors so that you don't