Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread zeugs
You don't have Kerberos enabled (HAVE_KERBEROS). By the way using an explicit --with-kerberos should throw a configure error if Kerberos isn't found, so I don't know what is going on there. There's a warning I haven't realized when running configure: --- $./configure --with-kerberos

Re: [Wireshark-dev] Does it make any sense to supply Radiotap + 802.11 headers for packets captured on wireless adapter for managed mode?

2016-04-19 Thread Yang Luo
Hi Guy, Thanks for your answer! It seems that the header switch based on operation mode switch is quite reasonable. I think I will make Npcap follow it. And I still have some additional questions. First there's a little background here: Npcap uses a build-time configuration to choose whether

Re: [Wireshark-dev] checkapi

2016-04-19 Thread Jeff Morriss
On 04/19/2016 05:17 AM, Graham Bloice wrote: On 18 April 2016 at 22:48, Guy Harris > wrote: On Apr 18, 2016, at 2:16 PM, Graham Bloice > wrote: > What should we do

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 20:53, João Valverde wrote: On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my build system has failed in compiling the current master. The error is: CC packet-dcerpc-rep_proc.lo packet-dcerpc-netlogon.c: In function

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread Guy Harris
Or #ifdef HAVE_KERBEROS #define _U_IF_NO_KERBEROS_ #else #define _U_IF_NO_KERBEROS_ _U_ #endif ... static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass _U_IF_NO_KERBEROS_ ) or maybe

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 21:02, Alexis La Goutte wrote: On Tue, Apr 19, 2016 at 9:53 PM, João Valverde > wrote: On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my build system has

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread Alexis La Goutte
On Tue, Apr 19, 2016 at 9:53 PM, João Valverde < joao.valve...@tecnico.ulisboa.pt> wrote: > > > On 19-04-2016 20:38, Uli Heilmeier wrote: > >> Hi list, >> >> since commit 3c1f71e my build system has failed in compiling the current >> master. >> >> The error is: >> >> >>CC

Re: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]"

2016-04-19 Thread João Valverde
On 19-04-2016 20:38, Uli Heilmeier wrote: Hi list, since commit 3c1f71e my build system has failed in compiling the current master. The error is: CC packet-dcerpc-rep_proc.lo packet-dcerpc-netlogon.c: In function 'get_keytab_as_list': packet-dcerpc-netlogon.c:6561:71: error:

Re: [Wireshark-dev] Does it make any sense to supply Radiotap + 802.11 headers for packets captured on wireless adapter for managed mode?

2016-04-19 Thread Guy Harris
On Apr 19, 2016, at 7:07 AM, Yang Luo wrote: > I want to know does this 3) option make any sense to anyone? How does Linux > handle this? I want to keep the same behavior with Linux. What Linux does for mac80211 drivers (which I think the majority of drivers are) is

Re: [Wireshark-dev] Does it make any sense to supply Radiotap + 802.11 headers for packets captured on wireless adapter for managed mode?

2016-04-19 Thread Guy Harris
On Apr 19, 2016, at 7:09 AM, Yang Luo wrote: > Someone told me that: > • could you please automatically provide Ethernet pseudo-headers rather > than Radiotap etc. when the WLAN NIC is switched to "managed" (STA) mode? The > point is that Wireshark doesn't dissect

[Wireshark-dev] Build failing on SUSE 11.3

2016-04-19 Thread Anders Broman
Hi, The build fails for me on SUSE 11.3 /usr/lib64/gcc/x86_64-suse-linux/4.3/../../../../x86_64-suse-linux/bin/ld: skipping incompatible /usr/lib/libc.a when searching for -lc ui/gtk/libgtkui.a(gui_utils.o): In function `window_icon_realize_cb':

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
On Tue, Apr 19, 2016 at 8:35 PM, Dario Lombardo wrote: > > > On Tue, Apr 19, 2016 at 1:44 PM, Yang Luo wrote: > >> >> I found I can push using https, but the reminds me it lacks change-id. >> >> I'm not sure I got your point, but you can get rid

Re: [Wireshark-dev] Does it make any sense to supply Radiotap + 802.11 headers for packets captured on wireless adapter for managed mode?

2016-04-19 Thread Yang Luo
Someone told me that: - could you please automatically provide Ethernet pseudo-headers rather than Radiotap etc. when the WLAN NIC is switched to "managed" (STA) mode? The point is that Wireshark doesn't dissect frames whose 802.11 header indicates some Data subtypes (probably

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
On Tue, Apr 19, 2016 at 1:44 PM, Yang Luo wrote: > > I found I can push using https, but the reminds me it lacks change-id. > > I'm not sure I got your point, but you can get rid of all change-id issues using the tools/pre-commit hook. Read here

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
I used git-review too, it is provide by Python on Windows. All I need to do is to commit via SmartGit and then type in "git-review". On Tue, Apr 19, 2016 at 7:52 PM, Graham Bloice wrote: > I find using the git-review ( >

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Graham Bloice
I find using the git-review ( https://www.mediawiki.org/wiki/Gerrit/git-review) tool simplifies a lot of Gerrit\git interactions. On 19 April 2016 at 12:44, Yang Luo wrote: > Hi all, > > I found I can push using https, but the reminds me it lacks change-id. > I fnished

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
Hi all, I found I can push using https, but the reminds me it lacks change-id. I fnished cloning via https and got this done:) My patch is: https://code.wireshark.org/review/#/c/15003/ Thanks for your help! Cheers, Yang On Tue, Apr 19, 2016 at 7:26 PM, Dario Lombardo

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
To push using ssh (that is one of the two methods supported) you have to upload your public key to gerrit using the web interface. Next to the http section, you can find the ssh one. Use it to upload the key. You can push using http and its password. Simply replace the ssh url with the https one.

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
Hi Dario, I got this error. J:\github_repos\wireshark>git push ssh:// yang...@code.wireshark.org:29418/wireshark HEAD:refs/for/master/dot11-support-on-windows Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
Hi Alexis, Cloning using https seems to be faster than ssh, nearly 90KB/s. I have generated the HTTP password. Let' see if it can finish.. On Tue, Apr 19, 2016 at 4:57 PM, Alexis La Goutte wrote: > Hi Yang, > > Do you have try to clone via https ? (using Gerrit) :

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Dario Lombardo
Hi Yang You can clone from github, then add whatever git remote you want. But you don't need to do that, since the command to push a change to gerrit can be issued to point directly to wireshark repo. As stated here https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html you can push

Re: [Wireshark-dev] checkapi

2016-04-19 Thread Graham Bloice
On 18 April 2016 at 22:48, Guy Harris wrote: > On Apr 18, 2016, at 2:16 PM, Graham Bloice > wrote: > > > What should we do about the lex files? Guy's last comment on this issue > was > > > > Some "generated" code is "generated" by copying it from

Re: [Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Alexis La Goutte
Hi Yang, Do you have try to clone via https ? (using Gerrit) : git clone https://yang...@code.wireshark.org/review/wireshark (may be you need to generated a HTTP password on Gerrit Option) On Tue, Apr 19, 2016 at 10:45 AM, Yang Luo wrote: > Hi list, > > I want to submit a

[Wireshark-dev] Connection slow and got interrupted when cloning the Wireshark repo

2016-04-19 Thread Yang Luo
Hi list, I want to submit a patch to Wireshark. I'm using SmartGit on Win10. My location is Beijing. I followed the guide here: https://wiki.wireshark.org/Development/SubmittingPatches And I always fails this step: git clone ssh://yang...@code.wireshark.org:29418/wireshark Because the speed is

Re: [Wireshark-dev] Fixed position mode (packet list view).

2016-04-19 Thread Alexis La Goutte
Hi Jakub, We are always interesting by code contribution to get review of core/dev, the better is to push your code on Gerrit, you can add WIP (work in progress) flag on commit message if the code is "experimental". Cheers On Tue, Apr 12, 2016 at 10:44 PM, Jakub Mazur

Re: [Wireshark-dev] cut-off for v2.2

2016-04-19 Thread Alexis La Goutte
Hi Alan, Often the code is freeze to end of May for next major release. it will be a announce in -dev mailing when the planning will be finish. Cheers On Fri, Apr 15, 2016 at 3:22 PM, Alan Partis wrote: > I noted the comments yesterday that v2.2 will likely be