Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Guy Harris
On Aug 5, 2016, at 2:31 PM, Guy Harris wrote: > 'test/run_and_catch_crashes' has non-whitelisted license 'UNKNOWN' > 'macosx-support-lib-patches/qt-fix-pc-files' has non-whitelisted > license 'UNKNOWN' > 'macosx-support-lib-patches/qt-fix-pc-file' has

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Guy Harris
On Aug 5, 2016, at 12:17 PM, João Valverde wrote: > The Debian licensecheck.pl version prior to the Smedegaard take over was > standalone. I think we should import that to tools. We might still want to look over the list of files currently being complained

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:53 AM, João Valverde wrote: On 08/05/2016 11:50 AM, Guy Harris wrote: On Aug 5, 2016, at 3:36 AM, João Valverde wrote: On 08/05/2016 11:21 AM, Guy Harris wrote: Should we just grab some version that works and include it in the tools

Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs

2016-08-05 Thread John Dill
>Message: 1 >Date: Fri, 5 Aug 2016 14:47:59 +0100 >From: Graham Bloice >To: Developer support list for Wireshark >Subject: Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs > >>On 5 August 2016 at 14:08, John Dill

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 17:13, Graham Bloice wrote: > On 5 August 2016 at 17:01, Dario Lombardo > wrote: > >> I updated qt to 5.6.1. After cmake, I get >> >> -- The following OPTIONAL packages have not been found: >> * CAP

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 17:01, Dario Lombardo wrote: > I updated qt to 5.6.1. After cmake, I get > > -- The following OPTIONAL packages have not been found: > * CAP > * Gettext > * M > * PkgConfig > * Qt5Core >

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
I updated qt to 5.6.1. After cmake, I get -- The following OPTIONAL packages have not been found: * CAP * Gettext * M * PkgConfig * Qt5Core * Qt5LinguistTools * Qt5Multimedia * Qt5PrintSupport *

Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs

2016-08-05 Thread Michael Mann
This may be related/similar to bug 6392 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6392). I believe the capture in this bug has only a few "leftover" bytes (and I thought the issue may be related to amount of fixed data needed by dissector). However 38 bytes seems much larger than

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
> > What Qt version? I think I've seen that one before. >> > > 5.3.2. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 14:08, John Dill wrote: > I have a TCP protocol that sends multiple PDUs. So far, my dissector > seems to handle the cases where one PDU is split across multiple frames, > and when multiple PDUs are dissected in one frame. Unfortunately, I'm >

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 14:22, Dario Lombardo wrote: > Actually I was missing one package. Then I cleaned repo up with git clean > -dfx. Now I still don't go to the end but with > > Build FAILED. >"c:\Development\wsbuild64\Wireshark.sln" (default target) (1) -> >

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
Actually I was missing one package. Then I cleaned repo up with git clean -dfx. Now I still don't go to the end but with Build FAILED. "c:\Development\wsbuild64\Wireshark.sln" (default target) (1) -> "c:\Development\wsbuild64\copy_qt_dlls.vcxproj.metaproj" (default target) (14) ->

Re: [Wireshark-dev] Cannot open include file: ‘moduleinfo.h’: No such file or directory

2016-08-05 Thread Jaap Keuter
This is were we write documentation for, in this case doc/README.plugins. You should have a look. > On 05 Aug 2016, at 14:08, Paul Offord wrote: > > Hi Pascal, > > Ha – I feel a bit stupid for not noticing that. > > Thanks and regards…Paul > > From:

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Pascal Quantin
Le 5 août 2016 14:34, "Graham Bloice" a écrit : > > On 5 August 2016 at 13:29, Dario Lombardo wrote: >> >> I'm trying to compile wireshark on windows, but it fails. I have low skills on windows, so maybe I'm missing something very basic.

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 13:29, Dario Lombardo wrote: > I'm trying to compile wireshark on windows, but it fails. I have low > skills on windows, so maybe I'm missing something very basic. > > Any hint? Thank you. > > >"c:\Development\wsbuild64\Wireshark.sln"

[Wireshark-dev] Windows compilation fails

2016-08-05 Thread Dario Lombardo
I'm trying to compile wireshark on windows, but it fails. I have low skills on windows, so maybe I'm missing something very basic. Any hint? Thank you. "c:\Development\wsbuild64\Wireshark.sln" (default target) (1) ->

Re: [Wireshark-dev] Cannot open include file: ‘moduleinfo.h’: No such file or directory

2016-08-05 Thread Paul Offord
Hi Pascal, Ha – I feel a bit stupid for not noticing that. Thanks and regards…Paul From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Pascal Quantin Sent: 05 August 2016 13:06 To: Developer support list for Wireshark

Re: [Wireshark-dev] Cannot open include file: ‘moduleinfo.h’: No such file or directory

2016-08-05 Thread Pascal Quantin
Hi Paul, 2016-08-05 14:02 GMT+02:00 Paul Offord : > Hi All, > > > > I’m writing a new plugin dissector (nothing to do with my previous post). > I just have the basic functions at the moment of initialiser, handoff and > dissection – copied from the WS wiki. The build

[Wireshark-dev] Cannot open include file: ‘moduleinfo.h’: No such file or directory

2016-08-05 Thread Paul Offord
Hi All, I’m writing a new plugin dissector (nothing to do with my previous post). I just have the basic functions at the moment of initialiser, handoff and dissection – copied from the WS wiki. The build in VS fails with: Error C1083: Cannot open include file: ‘moduleinfo.h’: No such file

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Paul Offord
That sounds really interesting. Eliminating the Qt code is very attractive. I’ll look into it. Thanks and regards…Paul From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Roland Knall Sent: 05 August 2016 11:57 To: Developer support list for

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
This is exactly what I do here with my plugin. Although without the TCP part. The method to do it without using Qt in the dissector is to implement a tap interface in the dissector, and register the plugin on that interface. The plugin than can start the TCP server and monitors the tap interface

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:50 AM, Guy Harris wrote: On Aug 5, 2016, at 3:36 AM, João Valverde wrote: On 08/05/2016 11:21 AM, Guy Harris wrote: Should we just grab some version that works and include it in the tools directory, so that we don't get mysterious

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Guy Harris
On Aug 5, 2016, at 3:36 AM, João Valverde wrote: > On 08/05/2016 11:21 AM, Guy Harris wrote: > >> Should we just grab some version that works and include it in the tools >> directory, so that we don't get mysterious failures when updating the >> version of

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Paul Offord
Hi Roland, No, not really an RPC interface. Some very simple commands and events flow back and forth, like this: Command|GoToFrame|55 Response|MovedToFrame|55 Event|MovedToFrame|67 We needed it to be a dissector to enable us to detect when the user moves within a trace so that we can

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 11:21 AM, Guy Harris wrote: On Aug 5, 2016, at 2:52 AM, Graham Bloice wrote: I did look a bit for licensecheck and it appears to be a Perl script available as a Debian (and RPM) package devscripts as suggested by João, a package for Debian

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 11:21, Guy Harris wrote: > On Aug 5, 2016, at 2:52 AM, Graham Bloice > wrote: > > > I did look a bit for licensecheck and it appears to be a Perl script > available as a Debian (and RPM) package devscripts as suggested by João,

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Guy Harris
On Aug 5, 2016, at 2:52 AM, Graham Bloice wrote: > I did look a bit for licensecheck and it appears to be a Perl script > available as a Debian (and RPM) package devscripts as suggested by João, a > package for Debian package maintainers. As such, it isn't

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 10:45 AM, Guy Harris wrote: On Aug 5, 2016, at 2:00 AM, João Valverde wrote: On 08/05/2016 08:56 AM, Alexis La Goutte wrote: I confirm ;-) (too slow...) But it is strange don't get the same warning between Ubuntu 14.04 and 16.04 I

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 10:52, Graham Bloice wrote: > > > On 5 August 2016 at 10:45, Guy Harris wrote: > >> On Aug 5, 2016, at 2:00 AM, João Valverde > .pt> wrote: >> >> > On 08/05/2016 08:56 AM, Alexis La Goutte wrote:

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
So, if I understand it correctly, it is a RPC interface? I still think, implementing this as a dissector is a major overkill, and will also lead to issues further down the line, if dissectory API changes or similar issues. I'd implement such an interface via a simple plugin architecture, which

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 10:45, Guy Harris wrote: > On Aug 5, 2016, at 2:00 AM, João Valverde ulisboa.pt> wrote: > > > On 08/05/2016 08:56 AM, Alexis La Goutte wrote: > >> I confirm ;-) (too slow...) > >> > >> But it is strange don't get the same warning

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Guy Harris
On Aug 5, 2016, at 2:00 AM, João Valverde wrote: > On 08/05/2016 08:56 AM, Alexis La Goutte wrote: >> I confirm ;-) (too slow...) >> >> But it is strange don't get the same warning between Ubuntu 14.04 and >> 16.04 > > I assume the licensecheck regexes

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Paul Offord
Hi Roland, The dissector is called Syncro and it allows a remote process to access the WS plugin_if extensions through a TCP connection. We wanted to be able to achieve this without building a custom version of WS and so built it as a dissector. We don’t use any of the GUI stuff from Qt,

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Anders Broman
Hi, As Graham I’m suspicious about GUI code in plugins. Code “enhancing” the GUI should probably be placed in the respective GUI folder(Qt or GTK) and hook into the menus. I suppose that currently require you to build a custom Wireshark version. Can’t your GUI code be made part of the standard

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Paul Offord
Thanks Graham. From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Graham Bloice Sent: 05 August 2016 10:21 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Adding Qt5 libs via VS Additional

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Roland Knall
Paul, could you give an example, why you chose Qt libraries over Gtk? Was it not possible, or is it a personal choice? I do have plugins for WS, which use Qt, but not for dissectors, so I am just curious, what was missing. regards Roland On Fri, Aug 5, 2016 at 11:20 AM, Graham Bloice

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 07:54, Paul Offord wrote: > Hi, > > > > I have written a plugin dissector that uses some Qt5 functions. To build > with Visual Studio 2013 I have to manually add some Qt5 libs via Project -> > Properties -> Linker -> Input -> Additional

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 08:56 AM, Alexis La Goutte wrote: I confirm ;-) (too slow...) But it is strange don't get the same warning between Ubuntu 14.04 and 16.04 I assume the licensecheck regexes changed. Michael may need to be running 16.04 to test this with any accuracy. While on the subject

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Alexis La Goutte
I confirm ;-) (too slow...) But it is strange don't get the same warning between Ubuntu 14.04 and 16.04 Cheers Le vendredi 5 août 2016, João Valverde a écrit : > > > On 08/05/2016 04:03 AM, Michael Mann wrote: > >> I thought I'd try to cut down on some of

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread João Valverde
On 08/05/2016 04:03 AM, Michael Mann wrote: I thought I'd try to cut down on some of the "noise" created by checklicenses.py and creating exceptions for files that obviously don't need a license header (COPYING/AUTHORS files in plugins for example). I thought it would simply be a matter of

[Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Paul Offord
Hi, I have written a plugin dissector that uses some Qt5 functions. To build with Visual Studio 2013 I have to manually add some Qt5 libs via Project -> Properties -> Linker -> Input -> Additional Dependencies. This works OK but whenever I run: cmake -D ENABLE_CHM_GUIDES=on -G "Visual