Re: [Wireshark-dev] proto_item_get_display_repr ignoring time zone

2020-07-23 Thread Thomas Wiens
Am 23.07.2020 um 20:58 schrieb Jaap Keuter: > That smells like a bug to me. I'll submit a patch for this. proto_item_get_display_repr() is only used in two other dissectors. The function itself has no comments and is not mentioned in the readme. I'd expect to get the same string back as its

Re: [Wireshark-dev] proto_item_get_display_repr ignoring time zone

2020-07-23 Thread Jaap Keuter
That smells like a bug to me. > On 23 Jul 2020, at 18:33, Thomas Wiens wrote: > > Hi, > > I've noticed that when I add a timestamp in UTC time zone > (ABSOLUTE_TIME_UTC) to the tree with proto_tree_add_time() it's displayd > in UTC as expected. But when I get the string from this proto_item

[Wireshark-dev] proto_item_get_display_repr ignoring time zone

2020-07-23 Thread Thomas Wiens
Hi, I've noticed that when I add a timestamp in UTC time zone (ABSOLUTE_TIME_UTC) to the tree with proto_tree_add_time() it's displayd in UTC as expected. But when I get the string from this proto_item with proto_item_get_display_repr() then I get local time instead. I've digged a little bit

Re: [Wireshark-dev] Dissect data on a bit-by-bit basis

2020-07-23 Thread Tomasz Moń
On Thu, Jul 23, 2020 at 8:18 AM Guy Harris wrote: > On Jul 21, 2020, at 6:04 PM, Filipe Laíns wrote: > > I am working on the USB HID dissector and I need to dissect data on a > > bit by bit basis, instead of byte. The data structure is completely > > dynamic (described by the HID descriptor) and

Re: [Wireshark-dev] Dissect data on a bit-by-bit basis

2020-07-23 Thread Guy Harris
On Jul 21, 2020, at 6:04 PM, Filipe Laíns wrote: > I am working on the USB HID dissector and I need to dissect data on a > bit by bit basis, instead of byte. The data structure is completely > dynamic (described by the HID descriptor) and the basic data block is > the bit. Any bit or sequence of