Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread ronnie sahlberg
since this uses a ephemeral port number which changes between runs you should not register the dissector to the port itself much better is to once you have detected that port A on host B uses that protocol you create a conversation for host B port A and register the dissector for that particular

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread Stephen Fisher
On Wed, Oct 04, 2006 at 01:54:41AM +1000, ronnie sahlberg wrote: since this uses a ephemeral port number which changes between runs you should not register the dissector to the port itself much better is to once you have detected that port A on host B uses that protocol you create a

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-03 Thread LEGO
Is it ok to have the preference and register a port (once). What can cause problems is to register a port instead of creating a conversation, think in what would happen if it starts to use ports used by other protocols. On 10/3/06, Stephen Fisher [EMAIL PROTECTED] wrote: On Wed, Oct 04, 2006 at

[Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-02 Thread Stephen Fisher
Attached is a patch that changes packet-newmail.c to always register itself on the port from the preferences (defaults to 0) upon launch. This allows the user to right-click and use decode as. Currently, the dissector only registers itself when the default port number changes from 0 or by

Re: [Wireshark-dev] [Patch] update to packet-newmail.c

2006-10-02 Thread Anders Broman
Checked in. Best regards Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Stephen Fisher Skickat: den 3 oktober 2006 01:24 Till: wireshark-dev@wireshark.org Ämne: [Wireshark-dev] [Patch] update to packet-newmail.c Attached is a patch that changes